[Mesa-dev] [PATCH] mesa: fix 10.2 build after commits 548fd6cd, af50ae73

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83679 Cc: 10.2 mesa-sta...@lists.freedesktop.org Two patches which were meant for the 10.3 branch created errors in the 10.2 branch: 548fd6cd2564fe1c4e72ca6b2752fd2584afc7e2 af50ae73f01bebc312555c49e49e33cbfbaf56e3 In both cases, a

Re: [Mesa-dev] [PATCH] i965: Make Gen4-5 push constants call _mesa_load_state_parameters too.

, and probably Gen4 as well. Reported-by: Mark Janes mark.a.ja...@intel.com Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_curbe.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_curbe.c b/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH] program: use extern C where appropriate in sampler.cpp

`make check` fails to link test_vec4_copy_propagation after 6dac455e. --- src/mesa/program/sampler.cpp | 5 ++--- src/mesa/program/sampler.h | 7 +++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/sampler.cpp b/src/mesa/program/sampler.cpp index

Re: [Mesa-dev] [PATCH] program: use extern C where appropriate in sampler.cpp

Brian Paul bri...@vmware.com writes: I don't think this is right. The functions in question are C++ functions and they're only called from .cpp files. I don't see why C-style linkage is desired. See https://bugs.freedesktop.org/show_bug.cgi?id=87371 for another approach. Please test

[Mesa-dev] [PATCH v2] i965: remove includes of sampler.h from extern C blocks

C linkage was removed from functions in program/sampler.cpp. However, some cpp files include program/sampler.h within extern C blocks, causing link errors for test_vec4_copy_propagation. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs.h | 2

Re: [Mesa-dev] [PATCH 1/3] i965/fs: Implement the WaCMPInstFlagDepClearedEarly work-around.

This test breaks !OpenGL 1_1.infinite-spot-light on broadwell. Probe color at (0,0) Expected: 0.50 0.00 0.00 1.00 Observed: 0.00 0.00 0.00 1.00 -Mark Matt Turner matts...@gmail.com writes: Prevents piglit regressions from the next patch. ---

Re: [Mesa-dev] [PATCH] i965/vec4: Calculate register allocation q values manually.

the FS back-end does. Reported-by: Mark Janes mark.a.ja...@intel.com --- src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp b/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH] i965/fs: Don't use backend_visitor::exec_list after creating the CFG.

Hi Matt, The tests which originated this bug still crash: glslparsertest: ../../../../../../src/mesa/drivers/dri/i965/brw_fs.cpp:2930: void fs_visitor::insert_gen4_post_send_dependency_workarounds(bblock_t*, fs_inst*): Assertion `!needs_dep[i]' failed. You don't need a g965 to reproduce it, as

Re: [Mesa-dev] [PATCH] i965: fix `make check` target

Brian Paul bri...@vmware.com writes: On 03/18/2015 11:38 AM, Mark Janes wrote: 4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for i965 gtests. This commit links the tests with libglapi, which contains the missing symbols. --- src/mesa/drivers/dri/i965/Makefile.am | 10

[Mesa-dev] [PATCH] i965: fix `make check` target

4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for i965 gtests. This commit links the tests with libglapi, which contains the missing symbols. --- src/mesa/drivers/dri/i965/Makefile.am | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] i965: fix `make check` target

Matt Turner matts...@gmail.com writes: On Wed, Mar 18, 2015 at 10:38 AM, Mark Janes mark.a.ja...@intel.com wrote: 4bdbb588a9d385509f9168e38bfdb76952ba469c introduced link errors for i965 gtests. This commit links the tests with libglapi, which contains the missing symbols. I'm not really

Re: [Mesa-dev] [PATCH] dri: add _glapi_set_nop_handler(), _glapi_new_nop_table() to dri_test.c

Reviewed-by: Mark Janes mark.a.ja...@intel.com Brian Paul bri...@vmware.com writes: I wasn't aware of these _glapi_ stub functions when I committed 4bdbb588a9d385509f9168e38bfdb76952ba469c. Fixes make check Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89662 --- src/mesa/drivers

Re: [Mesa-dev] [PATCH] nir/worklist: Don't change the start index when computing the tail index

Reviewed-by: Mark Janes mark.a.ja...@intel.com Jason Ekstrand ja...@jlekstrand.net writes: --- src/glsl/nir/nir_worklist.c | 10 +- src/glsl/nir/nir_worklist.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/glsl/nir/nir_worklist.c b/src/glsl/nir

Re: [Mesa-dev] [PATCH] Fix invalid extern C around header inclusion.

Matt Turner matts...@gmail.com writes: On Thu, Mar 5, 2015 at 4:54 AM, Jose Fonseca jfons...@vmware.com wrote: Thanks for doing this. It looks great. Reviewed-by: Jose Fonseca jfons...@vmware.com Feel free to push my patch or I'll push it after you push this one. Thanks José. I've just

Re: [Mesa-dev] [PATCH] include: Add helper header to help trap includes inside extern C.

Unfortunately, my build configuration does not build gallium. This caused me to miss some files which still have extern C includes. Due to this oversight, master encounters build errors. I'll send a patch asap. -Mark Mark Janes mark.a.ja...@intel.com writes: Assuming my patch to fix 'extern

[Mesa-dev] [PATCH] nouveau: Fix build, invalid extern C around header inclusion.

The previous patch to fix header inclusion within extern C neglected to fix the occurences of this pattern in nouveau files. When the helper to detect this issue was pushed to master, it broke the build for the nouveau driver. This patch fixes the nouveau build. Bugzilla:

[Mesa-dev] [PATCH, v2 2/2] r300g: Fix build, invalid extern C around header inclusion.

A previous patch to fix header inclusion within extern C neglected to fix the occurences of this pattern in r300 files. When the helper to detect this issue was pushed to master, it broke the build for the r300 driver. This patch fixes the r300 build. Bugzilla:

[Mesa-dev] [PATCH, v2 1/2] nouveau: Fix build, invalid extern C around header inclusion.

A previous patch to fix header inclusion within extern C neglected to fix the occurences of this pattern in nouveau files. When the helper to detect this issue was pushed to master, it broke the build for the nouveau driver. This patch fixes the nouveau build. Bugzilla:

Re: [Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

This was never pushed, so Reviewed-by: Mark Janes mark.a.ja...@intel.com Vinson Lee v...@freedesktop.org writes: egl_dri2.c: In function ‘dri2_bind_tex_image’: egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this function [-Wmaybe-uninitialized] (*dri2_dpy-tex_buffer

Re: [Mesa-dev] [PATCH 07/11] i965: Make sure we always mark array surfaces as such

Reviewed-by: Mark Janes mark.a.ja...@intel.com Eduardo Lima Mitev el...@igalia.com writes: From: Iago Toral Quiroga ito...@igalia.com Even if they only have one slice, otherwise textureSize() won't produce correct results for the depth value. Fixes 10 dEQP tests in this category: dEQP

Re: [Mesa-dev] [PATCH V2 1/3] glsl: move array validation into its own function

The series is Reviewed-by: Mark Janes mark.a.ja...@intel.com Timothy Arceri t_arc...@yahoo.com.au writes: V2: return true when var-type is unsized by max access is within valid range --- src/glsl/linker.cpp | 89 ++--- src/glsl/linker.h

Re: [Mesa-dev] [PATCH] gallivm: init MM = NULL to silence warning

Hi Brian, Did you try to `make check` in mesa with these patches? I get errors compiling glx-test: src/glx/glxclient.h:59:25: fatal error: util/macros.h: No such file or directory -Mark Brian Paul bri...@vmware.com writes: --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +- 1 file

Re: [Mesa-dev] [PATCH] include: Add helper header to help trap includes inside extern C.

Jose Fonseca jfons...@vmware.com writes: From: José Fonseca jfons...@vmware.com This is just to help repro and fixing these issues with any C++ compiler -- commiting this will of course wait until all issues are addressed. Hi Jose, I have a patch which trivially fixes extern C in the 14

Re: [Mesa-dev] [PATCH] include: Add helper header to help trap includes inside extern C.

Assuming my patch to fix 'extern C' issues is pushed before this one, Reviewed-by: Mark Janes mark.a.ja...@intel.com Jose Fonseca jfons...@vmware.com writes: From: José Fonseca jfons...@vmware.com This is just to help repro and fixing these issues with any C++ compiler -- commiting

[Mesa-dev] [PATCH] Fix invalid extern C around header inclusion.

System headers may contain C++ declarations, which cannot be given C linkage. For this reason, include statements should never occur inside extern C. This patch moves the C linkage statements to enclose only the declarations within a single header. --- src/gallium/auxiliary/util/u_math.h

[Mesa-dev] [PATCH] fix m32 build: missing stdio inclusions

Several patches added include statements where required by the m64 build. Some files are only compiled for m32, and require similar changes. --- src/mesa/tnl/t_vertex_sse.c | 2 ++ src/mesa/x86/rtasm/x86sse.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/tnl/t_vertex_sse.c

Re: [Mesa-dev] [PATCH 3/4] glsl: use common intrastage array validation

Timothy Arceri t_arc...@yahoo.com.au writes: Use common intrastage array validation for interface blocks. This change also allows us to support interface blocks that are arrays of arrays. Please wrap this message to fit within 80 columns. --- src/glsl/link_interface_blocks.cpp | 76

Re: [Mesa-dev] [PATCH] glsl: mark uniform and input interface blocks as read only

Reviewed-by: Mark Janes mark.a.ja...@intel.com Timothy Arceri t_arc...@yahoo.com.au writes: --- Piglit tests: http://lists.freedesktop.org/archives/piglit/2015-March/015369.html src/glsl/ast_to_hir.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp

Re: [Mesa-dev] [PATCH 2/9] i965/nir: Make our environment variable checking smarter

Reviewed-by: Mark Janes mark.a.ja...@intel.com Jason Ekstrand ja...@jlekstrand.net writes: Before, we enabled NIR if you set INTEL_USE_NIR to anything which mean that INTEL_USE_NIR=false would actually turn on NIR. In preparation for turning NIR on by default, this commit makes it smarter

Re: [Mesa-dev] [PATCH] i965/generator: Get rid of the ! in the unreachable statement

Reviewed-by: Mark Janes mark.a.ja...@intel.com Jason Ekstrand ja...@jlekstrand.net writes: --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH] glsl: mark special built-in inputs referenced by vertex stage

Tested-by: Mark Janes mark.a.ja...@intel.com Tapani Pälli tapani.pa...@intel.com writes: Refactoring done on active attribute queries did not take in to account special built-in inputs for the vertex stage. This commit sets them referenced by vertex stage so that they get enumerated properly

Re: [Mesa-dev] [PATCH 11/21] i965/fs: Define scalarizing VEC4 pseudo-IR.

Francisco Jerez curroje...@riseup.net writes: This is not a real IR in the sense of a long-lived representation of the program. An SVEC4 instruction, defined as an opcode operating on 4-vectors of FS registers, is broken up into its scalar components (each an fs_inst) as soon as it's

Re: [Mesa-dev] [PATCH] i965/fs: set execution size to 8 with simd8 ddy instruction

Tested-by: Mark Janes mark.a.ja...@intel.com Tapani Pälli tapani.pa...@intel.com writes: Commit dd5c825 changed the way how execution size for instructions get set. Previously it was based on destination register width, now it is set explicitly when emitting instructions. Signed-off

Re: [Mesa-dev] [PATCH 5/6] egl/main: expose only core EGL functions statically

Hi Emil, This patch prevents piglit from linking: [ 98%] CMakeFiles/ext_image_dma_buf_import-sample_rgb.dir/sample_common.c.o: In function `sample_and_destroy_img': piglit/tests/spec/ext_image_dma_buf_import/sample_common.c:107: undefined reference to `eglDestroyImageKHR' Is

Re: [Mesa-dev] [PATCH] nir/lower_tex_projector: Don't use designated initializers

Reviewed-by: Mark Janes mark.a.ja...@intel.com Jason Ekstrand ja...@jlekstrand.net writes: These don't work in MSVC or in older versions of GCC Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89899 Cc: Eric Anholt e...@anholt.net --- src/glsl/nir/nir_lower_tex_projector.c | 3

Re: [Mesa-dev] [PATCH 1/5] mesa: remove unused macros from colormac.h

Series Reviewed-by: Mark Janes mark.a.ja...@intel.com Brian Paul bri...@vmware.com writes: --- src/mesa/main/colormac.h | 45 - 1 file changed, 45 deletions(-) diff --git a/src/mesa/main/colormac.h b/src/mesa/main/colormac.h index bc69f46

[Mesa-dev] [PATCH 3/4] radeon/r200: remove unneeded #include of colormac.h

--- src/mesa/drivers/dri/r200/r200_context.h | 1 - src/mesa/drivers/dri/r200/r200_maos_arrays.c | 1 - src/mesa/drivers/dri/r200/r200_state.c| 1 - src/mesa/drivers/dri/r200/r200_state_init.c | 1 - src/mesa/drivers/dri/r200/r200_swtcl.c| 1 -

[Mesa-dev] [PATCH 4/4] mesa: remove unneeded #include of colormac.h

--- src/mesa/main/pack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index f723608..c444890 100644 --- a/src/mesa/main/pack.c +++ b/src/mesa/main/pack.c @@ -43,7 +43,6 @@ #include glheader.h -#include colormac.h #include enums.h #include

[Mesa-dev] (no subject)

With the removal of unused colormac.h macros 2ad8af1a0c319c83e4a8e00db3a9b9cb0ae029eb, several unused includes were eliminated. This patch set removes the remaining places where colormac.h is included but not used. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 1/4] i915: remove unneeded #include of colormac.h

--- src/mesa/drivers/dri/i915/i915_vtbl.c | 1 - src/mesa/drivers/dri/i915/intel_state.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i915_vtbl.c b/src/mesa/drivers/dri/i915/i915_vtbl.c index 706e0c3..8e5e393 100644 --- a/src/mesa/drivers/dri/i915/i915_vtbl.c

[Mesa-dev] [PATCH 2/4] i965: remove unneeded #include of colormac.h

--- src/mesa/drivers/dri/i965/intel_blit.c | 1 - src/mesa/drivers/dri/i965/intel_state.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c index 9500bd7..be67111 100644 ---

Re: [Mesa-dev] [PATCH 0/4] remove unneeded #include of colormac.h

Please pardon the git-send-email mistake. I meant to set a proper subject for the thread. -Mark Mark Janes mark.a.ja...@intel.com writes: With the removal of unused colormac.h macros 2ad8af1a0c319c83e4a8e00db3a9b9cb0ae029eb, several unused includes were eliminated. This patch set removes

Re: [Mesa-dev] [PATCH 4/4] i965/bxt: Add known PCI IDs

I would capitalize the hex strings, to match the rest of the file. with that, Reviewed-by: Mark Janes mark.a.ja...@intel.com Ben Widawsky benjamin.widaw...@intel.com writes: These match the ones defined in the kernel. The only one tested by us is 0x0a84. Signed-off-by: Ben Widawsky b

Re: [Mesa-dev] [PATCH] i965/gen8: Use HALIGN_16 for single sample mcs buffers

Tested-by: Mark Janes mark.a.ja...@intel.com Ben Widawsky benjamin.widaw...@intel.com writes: The original code meant to do this, but was only checking num_samples == 1 to figure out if a surface was fast clear capable. However, we can allocate single sample miptrees with num_samples == 0

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

This patch allows us to enable our Braswell in our continuous integration pool. Without it, gpu hangs prevent piglit from completing. Getting Braswell enabled in the pool will help us prevent future regressions on the platform. Tested-by: Mark Janes mark.a.ja...@intel.com Ben Widawsky

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

This patch fixes `make check` for me, but v2 has been pushed, so... Who gets to make a patch to fix master? Tested-by: Mark Janes mark.a.ja...@intel.com Ian Romanick i...@freedesktop.org writes: From: Brian Paul bri...@vmware.com Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vs: Fix matNxM vertex attributes where M != 4.

This fixes 1256 tests on BDW. Tested-by: Mark Janes mark.a.ja...@intel.com Kenneth Graunke kenn...@whitecape.org writes: Matrix vertex attributes have their columns padded out to vec4s, which I was failing to account for. Scalar NIR expects them to be packed, however. Cc: mesa-sta

Re: [Mesa-dev] [PATCH 3/3 v2] i965/bdw: Fix 3DSTATE_VF_INSTANCING when the edge flag is used

These three patches are Tested-by: Mark Janes mark.a.ja...@intel.com Neil Roberts n...@linux.intel.com writes: When the edge flag element is enabled then the elements are slightly reordered so that the edge flag is always the last one. This was confusing the code to upload

Re: [Mesa-dev] [PATCH v3 1/2] mesa: Fix order of format + type and internal format checks for glTexImage ops

This patch regresses the following tests: piglit.spec.oes_compressed_paletted_texture.basic api piglit.spec.oes_compressed_paletted_texture.basic api piglit.spec.oes_compressed_etc1_rgb8_texture.basic When you submit v4, please verify that there are no piglit or dEQP regressions. Also, please

Re: [Mesa-dev] [PATCH v2] glsl: avoid compiler's segfault when processing operators with void arguments

Should this patch be cc'd to stable branches? Without it, the compiler crashes on invalid inputs, instead of generating an error. This patch applies cleanly to 10.5 and 10.6. -Mark Renaud Gaubert ren...@lse.epita.fr writes: This is done by returning an rvalue of type void in the

Re: [Mesa-dev] [PATCH] mesa: Use the effective internal format instead for validation

This test regresses a large number of tests in piglit and dEQP, for example: piglit.spec.oes_texture_float.oes_texture_float.snbgt2m64 (from piglit) Standard Output /tmp/build_root/m64/lib/piglit/bin/oes_texture_float -auto -fbo oes-texture-float: error 0x502 at

Re: [Mesa-dev] [PATCH] mesa/teximage: Fix ASTC-caused S3TC regression

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Tested-by: Mark Janes <mark.a.ja...@intel.com> Nanley Chery <nanleych...@gmail.com> writes: > From: Nanley Chery <nanley.g.ch...@intel.com> > > The ASTC spec forbids other compressed formats from

Re: [Mesa-dev] [PATCH 00/10] i965: always mark used surfaces in the visitors

Francisco Jerez writes: > Iago Toral writes: > >> On Tue, 2015-11-03 at 15:28 +0200, Francisco Jerez wrote: >>> Iago Toral writes: >>> >>> > On Fri, 2015-10-30 at 16:19 +0200, Francisco Jerez wrote: >>> >> Iago Toral Quiroga

Re: [Mesa-dev] [Mesa-stable] New stable-branch 11.0 candidate pushed

Hi Emil, I get this regression testing the new branch: piglit.spec.oes_compressed_paletted_texture.basic api /tmp/build_root/m64/lib/piglit/bin/oes_compressed_paletted_texture-api -auto -fbo Trying glTexImage2D... Trying glCompressedTexImage2D... Unexpected GL error: GL_INVALID_ENUM 0x500

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Brian Paul <bri...@vmware.com> writes: > On 10/05/2015 05:18 PM, Mark Janes wrote: >> I tested this patch and found: >> >> regressions: >>spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW >> only) >&

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

No regressions were indicated by this patch. However, the initial regression did not trigger any test failures, either. It is unacceptable for such an obvious regression to pass Mesa's automated test suites. I re-opened the bug, pending the creation of suitable tests. -Mark Emil Velikov

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Tested-by: Mark Janes <mark.a.ja...@intel.com> Brian Paul <bri...@vmware.com> writes: > Callers of create_texture() will either pass target=0 or a validated > GL texture target enum so no need to do another error check inside > the loop. > --- > src/mesa/main/texobj.c

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Brian Paul <bri...@vmware.com> writes: > On 10/07/2015 04:47 PM, Mark Janes wrote: >> Brian Paul <bri...@vmware.com> writes: >> >>> On 10/05/2015 05:18 PM, Mark Janes wrote: >>>> I tested this patch and found: >>>> >>>> r

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Brian Paul <bri...@vmware.com> writes: > You tested with all 3 patches and everything's OK now? Sorry, I should have been more clear: Series is Tested-by: Mark Janes <mark.a.ja...@intel.com> > > I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move > g

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

yes, the assertions are still accurate. I haven't been able to get a stack trace yet. If I don't get to it perhaps Tapani can take a look this evening. Ian Romanick <i...@freedesktop.org> writes: > On 10/06/2015 09:31 AM, Mark Janes wrote: >> Mark Janes <mark.a.ja...

Re: [Mesa-dev] [PATCH] glapi: Remove _x86_64_get_get_dispatch symbol from x86-64 assembly.

Digging through old, un-reviewed patches... Mesa builds and runs just fine without this. Reviewed-by: Mark Janes mark.a.ja...@intel.com Matt Turner matts...@gmail.com writes: Never used. --- src/mapi/glapi/gen/gl_x86-64_asm.py | 6 -- 1 file changed, 6 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

Kenneth Graunke writes: > On Wednesday, September 02, 2015 12:03:12 AM Matt Turner wrote: >> The lowered code reads from the destination, which isn't possible from >> message registers. >> >> Fixes the dEQP functional.shaders.precision.int.highp_mul_fragment test >> on

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

I verified that this fixed the following tests on snb: dEQP-GLES3.functional.shaders.precision.int.highp_mul_fragment dEQP-GLES3.functional.shaders.precision.int.mediump_mul_fragment dEQP-GLES3.functional.shaders.precision.int.lowp_mul_fragment However, my testing showed the

Re: [Mesa-dev] [PATCH v4 0/3] A couple of fixes for Tex(Sub)Image error checks

Mark Janes <mark.a.ja...@intel.com> writes: > By my count, this series fixes 59 separate dEQP tests on various I incorrectly attributed 54 of those test fixes to this patch series. I had applied this patch on top of Iago's 96ea1663082c4a17eaf59873190f1e9677623d91, which also impr

Re: [Mesa-dev] Indirect fixes for Samplers v3

I tested this series, and found some issues: The following tests assert on g33: piglit.shaders.glsl-fwidth piglit.shaders.glsl-fs-sampler-numbering piglit.shaders.glsl-lod-bias piglit.shaders.glsl-kwin-blur-1 piglit.shaders.glsl-bug-22603 piglit.shaders.glsl-fs-texturecube

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

When I tested this, I saw an intermittent BSW gpu hang. I haven't been able to confirm that it is due to the host-mem-barrier test. -Mark Francisco Jerez writes: > The hardware documentation relating to the UAV HW-assisted coherency > mechanism and UAV access enable

Re: [Mesa-dev] [PATCH] i965/fs: Fix hang on IVB and VLV with image format mismatch.

This fixes a GPU hang on IVB, which is triggered with piglit.spec.arb_shader_image_load_store.invalid Tested-by: Mark Janes <mark.a.ja...@intel.com> Francisco Jerez <curroje...@riseup.net> writes: > IVB and VLV hang sporadically when an untyped surface read or write > message

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

Mark Janes <mark.a.ja...@intel.com> writes: > I verified that this fixed the following tests on snb: > > dEQP-GLES3.functional.shaders.precision.int.highp_mul_fragment > dEQP-GLES3.functional.shaders.precision.int.mediump_mul_fragmen

Re: [Mesa-dev] [PATCH] glsl: Handle attribute aliasing in attribute storage limit check.

Tested-by: Mark Janes <mark.a.ja...@intel.com> Kenneth Graunke <kenn...@whitecape.org> writes: > In various versions of OpenGL and GLSL, it's possible to declare > multiple VS input variables with aliasing attribute locations. > > So, when computing the storage requiremen

Re: [Mesa-dev] [PATCH v4 0/3] A couple of fixes for Tex(Sub)Image error checks

By my count, this series fixes 59 separate dEQP tests on various platforms. I found no regressions. Tested-by: Mark Janes <mark.a.ja...@intel.com> Eduardo Lima Mitev <el...@igalia.com> writes: > This is a new version of the mini-series that fixes the regression descri

Re: [Mesa-dev] [Mesa-stable] New stable-branch 10.6 candidate pushed

Please add Matt Turner's patch: [PATCH 10.6] i965/fs: Handle MRF destinations in lower_integer_multiplication(). This fixes a sandy bridge regression in dEQP. dEQP regressions on stable will prevent ChromeOS from using 10.6.6 as the basis for their Mesa build. thanks, Mark Emil Velikov

Re: [Mesa-dev] [PATCH] i965/gen8+: Skip depth stalls on state change

Ben Widawsky writes: > On Fri, Sep 04, 2015 at 02:58:30PM -0700, Ben Widawsky wrote: >> On Wed, Sep 02, 2015 at 01:03:43PM +0100, Chris Wilson wrote: >> > On Wed, Aug 26, 2015 at 10:52:58AM -0700, Ben Widawsky wrote: >> > > Docs suggest this is no longer required starting with

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

Mark Janes <mark.a.ja...@intel.com> writes: > Francisco Jerez <curroje...@riseup.net> writes: > >> Mark Janes <mark.a.ja...@intel.com> writes: >> >>> When I tested this, I saw an intermittent BSW gpu hang. I haven't been >>> able

Re: [Mesa-dev] [PATCH v5 00/70] ARB_shader_storage_buffer_object (mesa, i965)

I tested this series, and found a few issues: - `make check` fails the dispatch sanity tests in Mesa - The branch doesn't rebase cleanly on top of master (this isn't wrong, it just surprised me, since you sent out the series so recently) -

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

Tested-by: Mark Janes <mark.a.ja...@intel.com> Eduardo Lima Mitev <el...@igalia.com> writes: > This is a new version of the series that attempt to fix the regression > reported at: > > https://bugs.freedesktop.org/show_bug.cgi?id=91582 > > The review by Ja

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

Francisco Jerez <curroje...@riseup.net> writes: > Mark Janes <mark.a.ja...@intel.com> writes: > >> When I tested this, I saw an intermittent BSW gpu hang. I haven't been >> able to confirm that it is due to the host-mem-barrier test. >> > It would probab

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) expected[1] = 1.00. Read value: 0.00 spec.arb_copy_image.arb_copy_image-srgb-copy (assertion) arb_copy_image-srgb-copy: src/mesa/main/texobj.c:1739:

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

Emil Velikov <emil.l.veli...@gmail.com> writes: > Hi all, > > On 10 September 2015 at 00:30, Mark Janes <mark.a.ja...@intel.com> wrote: >> Mark Janes <mark.a.ja...@intel.com> writes: >> >>> Francisco Jerez <curroje...@riseup.net> write

Re: [Mesa-dev] [Mesa-stable] New stable-branch 11.0 candidate pushed

Can you please add this commit to the branch for 11.0.1? commit 2ea16966ae66d4dd5c5dcb996d7996d9c734bbee Author: Kristian Høgsberg Kristensen Date: Wed Sep 23 16:57:47 2015 -0700 i965: Respect stride and subreg_offset for ATTR registers It fixes a Braswell dEQP

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

This patch series fixes a few dEQP tests on braswell. The rest of the platform are unaffected, according to my tests. deqp-gles2.functional.negative_api.texture.teximage2d_invalid_type deqp-gles2.functional.negative_api.texture.teximage2d_invalid_internalformat

Re: [Mesa-dev] [PATCH 0/5] Enable up to 24 MRF registers in gen6

This series hits an assertion on ILK and G45: src/mesa/drivers/dri/i965/brw_eu_emit.c:150: brw_set_dest: Assertion `dest.nr < (devinfo->gen == 6 ? 24 : 16)' failed. It triggers about 8k piglit assertions on those platforms. I'm turning off testing for G45 and ILK until it is resolved.

Re: [Mesa-dev] [PATCH 0/5] Enable up to 24 MRF registers in gen6

Hi Iago, According to my tests, this patch series fixes the gles2/gles3 "functional.uniform_api.random.23" tests in dEQP, on sandybridge. Do you see the same results? Should this patch series be applied to the stable branch? thanks, Mark Iago Toral Quiroga writes: >

Re: [Mesa-dev] [PATCH 1/2] mesa: Use the effective internal format instead for validation

Hi Eduardo, I can't get this patch to apply to any recent version of glformats.c Can you double check it? thanks, Mark Eduardo Lima Mitev writes: > When validating format+type+internalFormat for texture pixel operations > on GLES3, the effective internal format should be

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Mark Janes <mark.a.ja...@intel.com> writes: > I tested this patch and found: > > regressions: > spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) > expected[1] = 1.00. Read value: 0.00 In subsequent testing I found this BDW failure

[Mesa-dev] [PATCH] Add missing platform information for KBL

With this commit, KBL passes piglit at parity with SKL. Signed-off-by: Mark Janes <mark.a.ja...@intel.com> --- src/mesa/drivers/dri/i965/brw_device_info.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c b/src/mesa/drivers/dri/i965/brw_device_

Re: [Mesa-dev] [PATCH] Add missing platform information for KBL

Sarah Sharp <sarah.a.sh...@intel.com> writes: > On Fri, Jan 08, 2016 at 04:30:20PM -0800, Mark Janes wrote: >> In testing KBL, I found: >> >> - urb size was not set for slices gt1.5, gt2, and gt3. The value I >>used for these slices (384) was tak

Re: [Mesa-dev] [PATCH] i915: correctly parse/set the context flags

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Tested-by: Mark Janes <mark.a.ja...@intel.com> Emil Velikov <emil.l.veli...@gmail.com> writes: > With an earlier commit we've spit the flags parsing to a separate > function, but forgot to update all the dri modules to

Re: [Mesa-dev] [Mesa-announce] Mesa 11.1.0 release candidate 1

Hi Emil, I noticed that this branchpoint is after the KHR_DEBUG patches which broke GL conformance. Is the plan to resolve this bug before release? https://bugs.freedesktop.org/show_bug.cgi?id=93048 -Mark Emil Velikov writes: > On 23 November 2015 at 09:18, Thierry

Re: [Mesa-dev] [PATCH 1/2] anv: let anv_entrypoints_gen.py generate proper Wayland/Xcb guards

Tested-by: Mark Janes <mark.a.ja...@intel.com> Emil Velikov <emil.l.veli...@gmail.com> writes: > From: Emil Velikov <emil.veli...@collabora.com> > > Similar to the vulkan headers, our code should include everything > properly guarded by the WSI VK_USE_PLATFORM_*_

Re: [Mesa-dev] [PATCH 29/29] vbo: Use a bitmask to track the active arrays in vbo_save*.

mathias.froehl...@gmx.net writes: > From: Mathias Fröhlich > > The use of a bitmask makes functions iterating only active > attributes less visible in profiles. > > Signed-off-by: Mathias Fröhlich > --- > src/mesa/vbo/vbo_save.h | 2 ++

Re: [Mesa-dev] [PATCH 29/29] vbo: Use a bitmask to track the active arrays in vbo_save*.

Mathias Fröhlich <mathias.froehl...@gmx.net> writes: > On Monday, June 20, 2016 10:33:42 Mark Janes wrote: >> mathias.froehl...@gmx.net writes: >> >> > From: Mathias Fröhlich <mathias.froehl...@web.de> >> > >> > The use of a bitmask make

Re: [Mesa-dev] [PATCH v2] Add missing platform information for KBL

Thanks Sarah. I'll turn on KBL testing in the CI. Sarah Sharp <sarah.a.sh...@linux.intel.com> writes: > From: Mark Janes <mark.a.ja...@intel.com> > > In testing KBL, I found: > > - urb size was not set for slices gt1.5, gt2, and gt3. The value I >used for the

Re: [Mesa-dev] [PATCH] i965: Skip update_texture_surface when the plane doesn't exist

On snb and ilk, this patch breaks piglit.spec.ext_image_dma_buf_import.ext_image_dma_buf_import-sample_nv1 https://bugs.freedesktop.org/show_bug.cgi?id=96674 Jordan Justen writes: > Reported-by: Grazvydas Ignotas > Bugzilla:

Re: [Mesa-dev] vulkan: Move XML and generator into src/intel/genxml

Steven Newbury writes: > On Sun, 2016-02-21 at 12:01 +, Steven Newbury wrote: >> On Sun, 2016-02-21 at 11:28 +, Steven Newbury wrote: >> > On Sun, 2016-02-21 at 10:56 +, Steven Newbury wrote: >> > > On Sun, 2016-02-21 at 10:16 +, Steven Newbury

Re: [Mesa-dev] [PATCH] i965/bxt: Fix conservative wm thread counts.

Tested-by: Mark Janes <mark.a.ja...@intel.com> Ben Widawsky <benjamin.widaw...@intel.com> writes: > When setting the conservative thread counts, I halved everything. That isn't > correct for the wm, which has nothing to do with actual thread counts. I suck. > &

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

in a single layout(...), this > change triggers the rules for multiple layouts. > > Cc: Mark Janes <mark.a.ja...@intel.com> > --- > src/glsl/ast_type.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp > index cf494d9..e0e33

Re: [Mesa-dev] [PATCH] [v2] i965/bxt: Production thread counts

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Ben Widawsky <benjamin.widaw...@intel.com> writes: > v2: Forgot to squash in the comment removal > > Signed-off-by: Ben Widawsky <benjamin.widaw...@intel.com> > --- > src/mesa/drivers/dri/i965/brw_device_info.c |

Re: [Mesa-dev] [PATCH] Revert "i965: Restore vbo after color resolve during brw_try_draw_prims()"

Ben Widawsky writes: > On Mon, Feb 15, 2016 at 11:34:03AM +0200, Topi Pohjolainen wrote: >> This got pushed accidentally in the first place but wasn't reverted >> as it didn't regress piglit but instead fixed one newly introduced >> test exercising a corner in case

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

Iago Toral writes: > On Wed, 2016-03-09 at 09:54 +0200, Pohjolainen, Topi wrote: >> On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez wrote: >> > Hello, >> > >> > There is only one patch from this series that has been reviewed (patch >> > 1). >> > >> > Our

[Mesa-dev] [PATCH] util: Fix race condition on libgcrypt initialization

Fixes intermittent Vulkan CTS failures within the test groups: dEQP-VK.api.object_management.multithreaded_per_thread_device dEQP-VK.api.object_management.multithreaded_per_thread_resources dEQP-VK.api.object_management.multithreaded_shared_resources Signed-off-by: Mark Janes <mark.a

  1   2   3   >