[Mesa-dev] [RFC PATCH 08/17] clover: Fill in the program byte-size in pipe_compute_state

2017-05-03 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/core/kernel.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index 4716705323..328323b6b0

[Mesa-dev] [RFC PATCH 14/17] clover: Accept SPIR-V binaries in clCreateProgramWithBinary

2017-05-03 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/program.cpp | 35 --- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/gallium/state_trackers/clov

[Mesa-dev] [RFC PATCH 09/17] clover: Add additional functions to query supported IRs

2017-05-03 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/core/device.cpp | 11 +++ src/gallium/state_trackers/clover/core/device.hpp | 3 +++ 2 files changed, 14 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/g

[Mesa-dev] [RFC PATCH 16/17] clover: Add a pointer property to return ILs

2017-05-03 Thread Pierre Moreau
OpenCL 2.1 gives the ability to query for a program’s IL, which is returned as a pointer. Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- .../state_trackers/clover/core/property.hpp| 39 ++ 1 file changed, 39 insertions(+) diff --git a/src/g

[Mesa-dev] [RFC PATCH 13/17] clover: Handle the case when linking SPIR-V binaries together

2017-05-03 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/core/program.cpp | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/program.cpp b/src/gallium/state_trackers/clove

[Mesa-dev] [RFC PATCH 12/17] clover: Refuse to compile source code to SPIR-V

2017-05-03 Thread Pierre Moreau
Creating a program using clCreateProgramWithSource to SPIR-V requires a non-upstreamed version of LLVM and clang, therefore it is currently not supported. Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/core/program.cpp | 4 1 file chan

[Mesa-dev] [RFC PATCH 17/17] clover: Handle CL_PROGRAM_IL in clGetProgramInfo

2017-05-03 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/program.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/gallium/state_trackers/clover/api/program.cpp index 57b8

[Mesa-dev] [RFC PATCH 15/17] clover: Implement clCreateProgramWithIL from OpenCL 2.1

2017-05-03 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/program.cpp | 29 ++- src/gallium/state_trackers/clover/core/program.cpp | 57 -- src/gallium/state_trackers/clover/core/program.hpp | 14 ++ 3 files chang

[Mesa-dev] [shader-db] [PATCH 2/3] nv-report: Match fields regardless of their order

2017-10-08 Thread Pierre Moreau
If a field was not present, its value will default to 0. This lets the code run on outputs that did not include the amount of shared memory used, for example. Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- nv-report.py | 38 -- 1 file chang

[Mesa-dev] [shader-db] [PATCH 3/3] nv-report: Add "shared" as a possible reported field

2017-10-08 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- nv-report.py | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/nv-report.py b/nv-report.py index bb6b42d..7bd3356 100644 --- a/nv-report.py +++ b/nv-report.py @@ -3,8 +3,8 @@ ""&

[Mesa-dev] [shader-db] [PATCH 1/3] nv-report: Avoid division-by-zero in diff() function

2017-10-08 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- nv-report.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/nv-report.py b/nv-report.py index abd6110..724c662 100644 --- a/nv-report.py +++ b/nv-report.py @@ -62,7 +62,12 @@ def analyze(fname): return

[Mesa-dev] [PATCH 2/3] nv50, nvc0/ir: Copy shared memory per block to the program info structure and back

2017-10-02 Thread Pierre Moreau
In OpenCL/CUDA kernels, shared memory usage can be defined within the kernel code. Those usage will only be picked up while parsing the SPIR-V, during the translation phase of the program. Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/drivers/nouveau/nv50/nv50_pro

[Mesa-dev] [PATCH 3/3] nv50, nvc0/ir: Display shared memory usage in pipe_debug_message

2017-10-02 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/drivers/nouveau/nv50/nv50_program.c | 7 --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_program.c

[Mesa-dev] [PATCH 1/3] nv50/ir: Store shared memory per block in nv50_ir_prog_info

2017-10-02 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h b/src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h index 76f0

Re: [Mesa-dev] [PATCH 3/3] nv50, nvc0/ir: Display shared memory usage in pipe_debug_message

2017-10-03 Thread Pierre Moreau
he end. Either way. I placed it there to group it with other memory storage information such as local, and gpr in some way. I’ll send a patch to update nv-report (to which ML should I send it?). > On Mon, Oct 2, 2017 at 2:57 PM, Pierre Moreau <pierre.mor...@free.fr> wrote: >

[Mesa-dev] [PATCH 1/2] nvir/nvc0: Properly lower 64-bit shifts when the shift value is >32

2017-12-03 Thread Pierre Moreau
int shl 36 uniform int shr 36 uniform int64_t iexpected_shl 0x09ac9010 uniform int64_t iexpected_shr -0x7dfcff0 # bit pattern: 0xf8203010 uniform uint64_t uexpected_shl 0x50102030 uniform uint64_t uexpected_shr 0x0140 draw rect ortho 12 0 4 4 Signed-off-by: Pie

[Mesa-dev] [PATCH 2/2] nvir/nvc0: Properly lower 64-bit SHL/SHR when the shift is an imm

2017-12-03 Thread Pierre Moreau
The existing lowering code assumed the shift would not be an immediate but did not guard against it. However, in the constant folding pass, a multiplication by a power-of-2 immediate would get optimised into a shift-left instruction, with the shift value being an immediate. Signed-off-by: Pierre

Re: [Mesa-dev] [PATCH 2/2] nvir/nvc0: Properly lower 64-bit SHL/SHR when the shift is an imm

2017-12-03 Thread Pierre Moreau
On 2017-12-03 — 15:36, Ilia Mirkin wrote: > On Sun, Dec 3, 2017 at 3:28 PM, Pierre Moreau <pierre.mor...@free.fr> wrote: > > The existing lowering code assumed the shift would not be an immediate > > but did not guard against it. However, in the constant folding pass,

[Mesa-dev] [PATCH] nvir: Always split 64-bit IMAD/IMUL operations

2017-12-04 Thread Pierre Moreau
Those operations do not map to actual hardware instructions, therefore those should always be lowered to 32-bit instructions. Fixes: 009c54aa7af "nv50/ir: Split 64-bit integer MAD/MUL operations" Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/drivers

Re: [Mesa-dev] [PATCH v3] mesa/spirv: move and rename nir_spirv_supported_capabilities

2017-12-07 Thread Pierre Moreau
Thank you for the changes! Reviewed-by: Pierre Moreau <pierre.mor...@free.fr> On 2017-12-07 — 17:12, Alejandro Piñeiro wrote: > To avoid any vulkan driver to include the GL mtypes.h. Renamed as > eventually this could be used by drivers not using nir. > > v2: remove compiler/

Re: [Mesa-dev] [PATCH] mesa: define nir_spirv_supported_capabilities

2017-12-06 Thread Pierre Moreau
Hello Alejandro, As far as I understand, nir_spirv_supported_capabilities is being filled in by the driver and then fetched by the API entrypoint to check the capabilities required by the SPIR-V binary given as input. And this is done regardless of the input IR used by the driver, be it NIR, LLVM

[Mesa-dev] [PATCH v7 16/21] clover/spirv: Add functions for validating SPIR-V binaries

2018-05-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Changes in: - v7: Update the dependency name (meson) and the libs variable (Makefile) due to the replacement of llvm-spirv to the new official SPIRV-LLVM-Translator src/gallium/state_trackers/clover/Makefile.am

Re: [Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

2018-05-23 Thread Pierre Moreau
clover: Implement clCreateProgramWithILKHR; * and the three patches I just resent as v7. Thank you. Pierre On 2018-03-25 — 20:02, Pierre Moreau wrote: > Hello, > > This has only minor changes compared to the previous version, but as it > introduces a new patch, I preferred to resen

Re: [Mesa-dev] [PATCH 1/2] util/u_math: Implement a logbase2 function for unsigned long

2018-05-23 Thread Pierre Moreau
On 2018-05-23 — 12:12, Eric Engestrom wrote: > On Tuesday, 2018-05-22 23:06:16 +0200, Karol Herbst wrote: > > From: Pierre Moreau <pierre.mor...@free.fr> > > > > Signed-off-by: Karol Herbst <kher...@redhat.com> > > --- > &

[Mesa-dev] [PATCH v7 14/21] clover/llvm: Allow translating from SPIR-V to LLVM IR

2018-05-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Changes in: - v7: Update the LLVM API call due to the replacement of llvm-spirv to the new official SPIRV-LLVM-Translator src/gallium/state_trackers/clover/Makefile.am | 6 +++- .../state_trackers/clover/llvm/invocation.cp

[Mesa-dev] [PATCH v7 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-05-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Changes in: - v7: Replace the llvm-spirv repository by the new official SPIRV-LLVM-Translator configure.ac | 18 ++ meson.build | 8 2 files changed, 26 insertions(+) diff --git a/configur

Re: [Mesa-dev] [PATCH v7 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-05-26 Thread Pierre Moreau
On 2018-05-23 — 15:51, Dylan Baker wrote: > Quoting Pierre Moreau (2018-05-23 14:43:10) > > Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> > > --- > > Changes in: > > - v7: Replace the llvm-spirv repository by the new official > > SPIRV-LLVM

[Mesa-dev] [PATCH v8 16/21] clover/spirv: Add functions for validating SPIR-V binaries

2018-06-05 Thread Pierre Moreau
Signed-off-by: Pierre Moreau --- Notes: Changes in: * v8: Add DEFINES to libclspirv and libclover, in autotools, as they would otherwise never know whether CLOVER_ALLOW_SPIRV has been defined (Dave Airlie) * v7: Update the dependency name (meson) and the libs variable

[Mesa-dev] [PATCH v8 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-06-05 Thread Pierre Moreau
Reviewed-by: Karol Herbst Reviewed-by: Dylan Baker Signed-off-by: Pierre Moreau --- Notes: Changes in: * v8: * Properly align LLVMSPIRVLib comment (Dylan Baker) * Only define CLOVER_ALLOW_SPIRV when **both** dependencies are found: autotools was only requiring one

Re: [Mesa-dev] [RFC 3/3] clover+gallium+freedreno: caps to reduce kernel recompiles

2018-04-26 Thread Pierre Moreau
The cap would need to be added to the documentation as well, in “src/gallium/docs/source/screen.rst”. I might be wrong, but I think you are going to break all existing drivers in clover, that do not yet support the new cap: for unsupported caps, drivers return a value of 0, which means they would

Re: [Mesa-dev] [PATCH v2 0/3] nouveau compiler warning cleanups

2017-12-29 Thread Pierre Moreau
Series is Reviewed-by: Pierre Moreau <pierre.mor...@free.fr> On 2017-12-16 — 23:00, Rhys Kidd wrote: > Couple of little compiler warning cleanups so that nouveau builds without any > warnings for meson's debug and release builds with gcc 7.2.0 > > v2: Add preventative co

Re: [Mesa-dev] [PATCH v2 03/31] nvir: move common converter code in base class

2018-01-04 Thread Pierre Moreau
With the comments below addressed, this patch is Reviewed-by: Pierre Moreau <pierre.mor...@free.fr> On 2018-01-04 — 16:01, Karol Herbst wrote: > v2: remove TGSI related bits > > Signed-off-by: Karol Herbst <kher...@redhat.com> > --- > src/gallium/drivers/nouveau/M

[Mesa-dev] [PATCH v2 17/22] clover: Handle CL_PROGRAM_IL_KHR in clGetProgramInfo

2018-01-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/program.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/gallium/state_trackers/clover/api/program.cpp index ed3b679c7c..754a

[Mesa-dev] [PATCH v2 22/22] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

2018-01-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp

[Mesa-dev] [PATCH v2 21/22] clover: Implement clCreateProgramWithIL from OpenCL 2.1

2018-01-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/dispatch.

[Mesa-dev] [PATCH v2 18/22] clover/api: Implement CL_DEVICE_IL_VERSION_KHR

2018-01-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/device.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp index 4e274c5005..6bed

[Mesa-dev] [PATCH v2 16/22] clover: Implement clCreateProgramWithILKHR

2018-01-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/dispatch.hpp | 4 ++ src/gallium/state_trackers/clover/api/program.cpp | 29 - src/gallium/state_trackers/clover/core/program.cpp | 68 +- src/gallium/state_trackers/

[Mesa-dev] [PATCH v2 19/22] clover: Advertise cl_khr_il_program

2018-01-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/platform.cpp | 2 ++ src/gallium/state_trackers/clover/core/device.cpp | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/platform.cpp

[Mesa-dev] [PATCH v2 20/22] include/CL: Export OpenCL 2.1 functions

2018-01-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- include/CL/cl.h | 8 include/CL/cl_platform.h | 1 + 2 files changed, 9 insertions(+) diff --git a/include/CL/cl.h b/include/CL/cl.h index 316565d6e4..2130c19c5e 100644 --- a/include/CL/cl.h +++ b/include/C

[Mesa-dev] [PATCH v2 11/22] clover/spirv: Add functions for parsing arguments, linking programs, etc.

2018-01-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Resending to the ML, as gabe ran out of memory. src/gallium/state_trackers/clover/Makefile.am | 15 +- src/gallium/state_trackers/clover/Makefile.sources | 4 + src/gallium/state_trackers/clover/api/program.cpp | 1

[Mesa-dev] [PATCH v2 12/22] clover: Refuse to compile source code to SPIR-V

2018-01-23 Thread Pierre Moreau
Creating a program using clCreateProgramWithSource to SPIR-V requires a non-upstreamed version of LLVM and clang, therefore it is currently not supported. Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Resending to the ML, as gabe ran out of memory. src/gallium/state_trackers/

[Mesa-dev] [PATCH v2 13/22] clover: Handle the case when linking SPIR-V binaries together

2018-01-23 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Resending to the ML, as gabe ran out of memory. src/gallium/state_trackers/clover/core/program.cpp | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clove

Re: [Mesa-dev] [PATCH v2 03/22] clover/api: Fail if trying to build a non-executable binary

2018-01-27 Thread Pierre Moreau
On 2018-01-23 — 15:09, Francisco Jerez wrote: > Pierre Moreau <pierre.mor...@free.fr> writes: > > > On 2018-01-23 — 14:03, Francisco Jerez wrote: > >> Pierre Moreau <pierre.mor...@free.fr> writes: > >> > >> > From the OpenCL

Re: [Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

2018-01-27 Thread Pierre Moreau
On 2018-01-24 — 09:19, Tomeu Vizoso wrote: > On 01/24/2018 12:03 AM, Karol Herbst wrote: > > On Tue, Jan 23, 2018 at 11:46 PM, Francisco Jerez <curroje...@riseup.net> > > wrote: > > > Pierre Moreau <pierre.mor...@free.fr> writes: > > > > &g

Re: [Mesa-dev] [PATCH v2 18/22] clover/api: Implement CL_DEVICE_IL_VERSION_KHR

2018-01-28 Thread Pierre Moreau
On 2018-01-23 — 14:12, Francisco Jerez wrote: > Pierre Moreau <pierre.mor...@free.fr> writes: > > > Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> > > --- > > src/gallium/state_trackers/clover/api/device.cpp | 5 + > > 1 file changed, 5 inse

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-02 Thread Pierre Moreau
On 2018-02-02 — 18:07, Timothy Arceri wrote: > > > On 02/02/18 17:21, Timothy Arceri wrote: > > On 02/02/18 16:38, Jan Vesely wrote: > > > On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: > > > > When PIPE_SHADER_IR_LLVM existed this query made sense but now it > > > > always returns

[Mesa-dev] Adding a SPIR-V target to libclc

2018-02-08 Thread Pierre Moreau
(Moving the conversation to its own thread.) > target agnostic libclc is rather difficult to do. CLC includes 3 levels > of precision on float (fp32) operands; full, half, native. The > implementation of each depends on capabilites of specific device (e.g. > vega(VI+?) can do 1 ULP log2/exp2 in

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-08 Thread Pierre Moreau
On 2018-02-08 — 12:47, Francisco Jerez wrote: > Pierre Moreau <pierre.mor...@free.fr> writes: > > > On 2018-02-07 — 12:36, Francisco Jerez wrote: > >> Pierre Moreau <pierre.mor...@free.fr> writes: > >> > >> > On 2018-02-06 — 20:50, Jan

Re: [Mesa-dev] [PATCH] r600/radeonsi/clover: use PIPE_SHADER_CAP_SUPPORTED_IRS with clover

2018-02-08 Thread Pierre Moreau
Reviewed-by: Pierre Moreau <pierre.mor...@free.fr> On 2018-02-08 — 10:57, Timothy Arceri wrote: > PIPE_SHADER_CAP_PREFERRED_IR was conlicting with PIPE_SHADER_IR_NIR > for compute shaders, so we let clover pick the one it wants to use. > > This change indirectly enables NIR s

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-08 Thread Pierre Moreau
On 2018-02-07 — 12:36, Francisco Jerez wrote: > Pierre Moreau <pierre.mor...@free.fr> writes: > > > On 2018-02-06 — 20:50, Jan Vesely wrote: > > [snip] > >> > > Happy to here suggestions for solving the current conflict in uses of > >> > > P

Re: [Mesa-dev] [PATCH 1/4] r600: add PIPE_SHADER_IR_NATIVE to supported shaders for cs

2018-02-09 Thread Pierre Moreau
IR_TGSI; > } > - case PIPE_SHADER_CAP_SUPPORTED_IRS: > + return PIPE_SHADER_IR_TGSI; This line is dead code and can be safely removed, as both the if-block and the else-block return a value already; it should be part of patch 03 instead. With that addressed, this patch is

Re: [Mesa-dev] [PATCH 2/4] clover: use PIPE_SHADER_CAP_SUPPORTED_IRS to discover IR

2018-02-09 Thread Pierre Moreau
On 2018-02-09 — 12:06, Timothy Arceri wrote: > PIPE_SHADER_CAP_PREFERRED_IR was conflicting with PIPE_SHADER_IR_NIR > for compute shaders, so we let clover pick the one it wants to use. > --- > src/gallium/state_trackers/clover/core/device.cpp | 11 +-- > 1 file changed, 9 insertions(+),

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

2018-02-09 Thread Pierre Moreau
ce_clc_version for cl version detection instead of device_version > Added device_clc_version in device.cpp/hpp > > Anyway, happy reviewing. > > Cc: Jan Vesely <jan.ves...@rutgers.edu> > Cc: Pierre Moreau <pierre.mor...@free.fr> > signature.asc Description: PGP signatur

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

2018-02-09 Thread Pierre Moreau
On 2018-02-09 — 11:50, Aaron Watry wrote: > No worries. I've been rebasing this series every time I've pulled > mesa for the last few months, and this week is the first time I've had > any real conflicts that need addressing. I'll see if I can find some > time to address your comments and

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-07 Thread Pierre Moreau
On 2018-02-06 — 20:50, Jan Vesely wrote: [snip] > > > Happy to here suggestions for solving the current conflict in uses of > > > PIPE_SHADER_CAP_PREFERRED_IR. > > > > One option could be to: > > * look at the preferred IR > > |-> if clover supports it, use it > > |-> else, check if any IR

Re: [Mesa-dev] [PATCH v5 06/34] nvir/nir: add support for NIR on nvc0

2018-02-20 Thread Pierre Moreau
Acked-by: Pierre Moreau <pierre.mor...@free.fr> On 2018-02-20 — 22:02, Karol Herbst wrote: > not all those nir options are actually required, it just made the work a > little easier. > > v2: fix asserts > parse compute shaders > don't lower bitfield_insert &g

Re: [Mesa-dev] [PATCH v5 07/34] nvc0/debug: add env var to make nir default

2018-02-20 Thread Pierre Moreau
Acked-by: Pierre Moreau <pierre.mor...@free.fr> On 2018-02-20 — 22:02, Karol Herbst wrote: > v2: allow for non debug builds as well > v3: move reading out env var more global > disable tg4 with multiple offsets with nir > disable caps for 64 bit types > > Sig

[Mesa-dev] [PATCH v3 16/21] clover: Implement clCreateProgramWithILKHR

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Notes: v3: * Remove the const on the length argument to CreateProgramWithILKHR (Francisco Jerez); * Capitalize comment (Francisco Jerez); * Store the IL as a std::vector instead of a pointer + size (Francisco

[Mesa-dev] [PATCH v3 19/21] clover: Advertise cl_khr_il_program

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Notes: v3: Advertise cl_khr_il_program if if the device support NATIVE as IR src/gallium/state_trackers/clover/api/platform.cpp | 2 ++ src/gallium/state_trackers/clover/core/device.cpp | 4 +++- 2 files changed, 5 insertions

[Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Notes: v3: * Bump the required version of SPIRV-Tools to the latest release; * Add a dependency on llvm-spirv. configure.ac | 10 ++ meson.build | 4 2 files changed, 14 insertions(+) diff --git a/config

[Mesa-dev] [PATCH v3 17/21] clover: Handle CL_PROGRAM_IL_KHR in clGetProgramInfo

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Notes: v3: Switch from using a pointer attribute to a vector (Francisco Jerez) src/gallium/state_trackers/clover/api/program.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/state_trackers/clov

[Mesa-dev] [PATCH v3 21/21] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/device.cpp | 3 +-- src/gallium/state_trackers/clover/api/program.cpp | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp

[Mesa-dev] [PATCH v3 20/21] clover: Implement clCreateProgramWithIL from OpenCL 2.1

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Notes: v3: Remove the const from the length argument of clCreateProgramWithIL src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 8 2 files changed, 9 inse

[Mesa-dev] [PATCH v3 02/21] clover: update ICD table to support everything up to 2.2

2018-02-21 Thread Pierre Moreau
From: Karol Herbst <kher...@redhat.com> v2: add more prototypes Signed-off-by: Karol Herbst <kher...@redhat.com> Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/dispatch.cpp | 29 +++- src/gallium/state_trackers/clover/api/

[Mesa-dev] [PATCH v3 00/21] Introducing SPIR-V support to clover

2018-02-21 Thread Pierre Moreau
/platform.cpp” * 15: “include/CL: Add cl_khr_il_program” * 21: “clover: Use OpenCL 2.1 defines in place of cl_khr_il_program” Karol Herbst (1): clover: update ICD table to support everything up to 2.2 Pierre Moreau (20): include/CL: Update to the latest OpenCL 2.2 headers clover/api: Fix

[Mesa-dev] [PATCH v3 08/21] clover: Disallow creating libraries from other libraries

2018-02-21 Thread Pierre Moreau
If creating a library, do not allow non-compiled object in it, as executables are not allowed, and libraries would make it really hard to enforce the "-enable-link-options" flag. Reviewed-by: Francisco Jerez <curroje...@riseup.net> Signed-off-by: Pierre Moreau <pierre.mor...@

[Mesa-dev] [PATCH v3 09/21] clover: Track flags per module section

2018-02-21 Thread Pierre Moreau
One flag that needs to be tracked is whether a library is allowed to received mathematics optimisations or not, as the authorisation is given when creating the library while the optimisations are specified when creating the executable. Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --

[Mesa-dev] [PATCH v3 06/21] clover/api: Rework the validation of devices for building

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/program.cpp | 39 +- src/gallium/state_trackers/clover/core/program.cpp | 3 +- 2 files changed, 25 insertions(+), 17 deletions(-) diff --git a/src/gallium/state_trackers/

[Mesa-dev] [PATCH v3 05/21] clover/device: Replace usage of "1 << PIPE_SHADER_IR_*" with supports_ir

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/core/device.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp

[Mesa-dev] [PATCH v3 12/21] clover: Remove the TGSI backend as unused

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/Makefile.am | 11 +- src/gallium/state_trackers/clover/Makefile.sources | 4 - src/gallium/state_trackers/clover/core/program.cpp | 15 +-- src/gallium/state_trackers/clover/meson.build

[Mesa-dev] [PATCH v3 03/21] clover/api: Fix tab indentation to spaces

2018-02-21 Thread Pierre Moreau
Acked-by: Francisco Jerez <curroje...@riseup.net> Reviewed-by: Karol Herbst <kher...@redhat.com> Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gall

[Mesa-dev] [PATCH v3 18/21] clover/api: Implement CL_DEVICE_IL_VERSION_KHR

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Notes: v3: Throw an exception if the cl_khr_il_program extension is not supported (Francisco Jerez) src/gallium/state_trackers/clover/api/device.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/g

[Mesa-dev] [PATCH v3 11/21] clover: Move platform extensions definitions to clover/platform.cpp

2018-02-21 Thread Pierre Moreau
Reviewed-by: Francisco Jerez <curroje...@riseup.net> Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- src/gallium/state_trackers/clover/core/platform.cpp | 5 + src/gallium/state_trackers/clover/core/platform.h

[Mesa-dev] [PATCH v3 15/21] include/CL: Add cl_khr_il_program

2018-02-21 Thread Pierre Moreau
Reviewed-by: Karol Herbst <kher...@redhat.com> Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- include/CL/cl_ext.h | 37 + 1 file changed, 37 insertions(+) diff --git a/include/CL/cl_ext.h b/include/CL/cl_ext.h index 5078e8f45f..5ea49

[Mesa-dev] [PATCH v3 14/21] clover/llvm: Allow translating from SPIR-V to LLVM IR

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- .../state_trackers/clover/llvm/invocation.cpp | 26 ++ .../state_trackers/clover/llvm/invocation.hpp | 4 src/gallium/state_trackers/clover/meson.build | 2 +- 3 files changed, 31 insertions

[Mesa-dev] [PATCH v3 04/21] clover: Add an helper for checking if an IR is supported

2018-02-21 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- Notes: v3: * Dropped supported_irs() (Francisco Jerez) * Changed supports_ir() argument type to `enum pipe_shader_ir` (Francisco Jerez) src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_tr

[Mesa-dev] [PATCH v3 10/21] clover: Move device extensions definitions to core/device.cpp

2018-02-21 Thread Pierre Moreau
Reviewed-by: Francisco Jerez <curroje...@riseup.net> Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 14 ++ src/gallium/state_trackers

[Mesa-dev] [PATCH v3 07/21] clover/api: Fail if trying to build a non-executable binary

2018-02-21 Thread Pierre Moreau
From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram): > If program is created with clCreateProgramWithBinary, then the > program binary must be an executable binary (not a compiled binary or > library). Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> -

Re: [Mesa-dev] [PATCH v3 21/21] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

2018-02-22 Thread Pierre Moreau
> I think this can be merged into patches 17 and 18, no? You are right, will do. > On Wed, Feb 21, 2018 at 11:50 PM, Pierre Moreau <pierre.mor...@free.fr> wrote: > > Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> > > --- > > src/gallium/state

Re: [Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-02-22 Thread Pierre Moreau
d llvm-spirv needs to be “rebased” as some commits went missing during the update process, but that is not going to impact the API used; we can absolutely wait for that to finish before merging the series. Pierre > On Wed, Feb 21, 2018 at 11:50 PM, Pierre Moreau <pierre.mor...@free.fr> wr

Re: [Mesa-dev] [PATCH v3 09/21] clover: Track flags per module section

2018-02-22 Thread Pierre Moreau
On 2018-02-21 — 20:04, Aaron Watry wrote: > On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau <pierre.mor...@free.fr> wrote: > > One flag that needs to be tracked is whether a library is allowed to > > received mathematics optimisations or not, as the authorisation is gi

Re: [Mesa-dev] [PATCH v5 05/34] nvir: add lowering helper

2018-02-20 Thread Pierre Moreau
With the variables “dt”, “st” and “std” renamed to match existing code, this patch is Reviewed-by: Pierre Moreau <pierre.mor...@free.fr> On 2018-02-20 — 22:02, Karol Herbst wrote: > this is mostly usefull for lazy IR converters not wanting to deal with 64 bit > lowering and other i

Re: [Mesa-dev] [PATCH v5 03/34] nvir: print the shader type when dumping headers

2018-02-20 Thread Pierre Moreau
Acked-by: Pierre Moreau <pierre.mor...@free.fr> On 2018-02-20 — 22:02, Karol Herbst wrote: > this makes debugging the shader header a little easier > > Signed-off-by: Karol Herbst <kher...@redhat.com> > --- > src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 1 + >

Re: [Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-02-23 Thread Pierre Moreau
On 2018-02-22 — 11:04, Francisco Jerez wrote: > Pierre Moreau <pierre.mor...@free.fr> writes: > > >> do we already have an upstream version of both dependencies we could > >> just use? Or do we still need special branches? > > > > For both we can use

Re: [Mesa-dev] [PATCH v3 06/21] clover/api: Rework the validation of devices for building

2018-02-23 Thread Pierre Moreau
On 2018-02-22 — 10:41, Francisco Jerez wrote: > Pierre Moreau <pierre.mor...@free.fr> writes: > > > Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> > > --- > > src/gallium/state_trackers/clover/api/program.cpp | 39 > > +- &

Re: [Mesa-dev] [PATCH v3 14/21] clover/llvm: Allow translating from SPIR-V to LLVM IR

2018-02-23 Thread Pierre Moreau
On 2018-02-22 — 11:00, Francisco Jerez wrote: > Pierre Moreau <pierre.mor...@free.fr> writes: > > > Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> > > --- > > .../state_trackers/clover/llvm/invocation.cpp | 26 > >

Re: [Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

2018-07-15 Thread Pierre Moreau
/pierremoreau/mesa/commits/clover_spirv_series_v8 Thank you in advance, Pierre On 2018-05-23 — 23:58, Pierre Moreau wrote: > Hello everyone, > > I updated a few patches of the series to have it use the new official > SPIR-V <-> LLVM translator, that can be found at &g

Re: [Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

2018-07-17 Thread Pierre Moreau
view: "clover: update ICD table to > support everything up to 2.2" > > On Sun, Jul 15, 2018 at 9:26 PM, Pierre Moreau wrote: > > Hello, > > > > I would appreciate if the following patches could be reviewed: > > * Patch 07 (latest: v6): clover

Re: [Mesa-dev] [PATCH v2 13/22] clover: Handle the case when linking SPIR-V binaries together

2018-01-23 Thread Pierre Moreau
On 2018-01-23 — 08:32, Karol Herbst wrote: > On Tue, Jan 23, 2018 at 1:33 AM, Pierre Moreau <pierre.mor...@free.fr> wrote: > > Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> > > --- > > src/gallium/state_trackers/clover/core/program.cpp | 22 > > +++

[Mesa-dev] [PATCH v2 14/22] clover: Add a pointer property to return ILs

2018-01-22 Thread Pierre Moreau
OpenCL 2.1, and cl_khr_il_program, gives the ability to query for a program’s IL, which is returned as a pointer. Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- .../state_trackers/clover/core/property.hpp| 39 ++ 1 file changed, 39 insertions(+) diff

[Mesa-dev] [PATCH v2 15/22] include/CL: Add cl_khr_il_program

2018-01-22 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- include/CL/cl_ext.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/include/CL/cl_ext.h b/include/CL/cl_ext.h index 710bea8837..2e4845d27d 100644 --- a/include/CL/cl_ext.h +++ b/include/CL/cl

[Mesa-dev] [PATCH v2 09/22] configure.ac, meson: Check for SPIRV-Tools

2018-01-22 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- configure.ac | 5 + meson.build | 2 ++ 2 files changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index 7c1fbe0ed1..8c50ea6792 100644 --- a/configure.ac +++ b/configure.ac @@ -2373,6 +2373,11 @@ AM_CONDI

[Mesa-dev] [PATCH v2 10/22] clover/spirv: Import spirv.hpp11 version 1.0 (rev 12)

2018-01-22 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- .../state_trackers/clover/spirv/spirv.hpp11| 997 + 1 file changed, 997 insertions(+) create mode 100644 src/gallium/state_trackers/clover/spirv/spirv.hpp11 diff --git a/src/gallium/state_trackers/clover

[Mesa-dev] [PATCH v2 08/22] include/pipe: Define SPIRV as an IR

2018-01-22 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index b34e7a8570..082d4c4d87 100644 --- a/src/gallium/includ

[Mesa-dev] [PATCH v2 06/22] clover: Move device extensions definitions to core/device.cpp

2018-01-22 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 14 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files changed, 16 insertions(

[Mesa-dev] [PATCH v2 07/22] clover: Move platform extensions definitions to clover/platform.cpp

2018-01-22 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- src/gallium/state_trackers/clover/core/platform.cpp | 5 + src/gallium/state_trackers/clover/core/platform.hpp | 2 ++ 3 files changed, 9 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH v2 01/22] clover/api: Fix tab indentation to spaces

2018-01-22 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp index 3572

[Mesa-dev] [PATCH v2 02/22] clover: Add additional functions to query supported IRs

2018-01-22 Thread Pierre Moreau
Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --- src/gallium/state_trackers/clover/core/device.cpp | 11 +++ src/gallium/state_trackers/clover/core/device.hpp | 3 +++ 2 files changed, 14 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/g

[Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

2018-01-22 Thread Pierre Moreau
yet. Thank you in advance for reviewing/commenting, Pierre [1]: https://github.com/KhronosGroup/SPIRV-Tools/ Pierre Moreau (22): clover/api: Fix tab indentation to spaces clover: Add additional functions to query supported IRs clover/api: Fail if trying to build a non-executable binary

[Mesa-dev] [PATCH v2 05/22] clover: Track flags per module section

2018-01-22 Thread Pierre Moreau
One flag that needs to be tracked is whether a library is allowed to received mathematics optimisations or not, as the authorisation is given when creating the library while the optimisations are specified when creating the executable. Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> --

<    1   2   3   4   >