[Mesa-dev] [PATCH v4 00/20] Introducing SPIR-V support to clover

lover: Implement clCreateProgramWithIL from OpenCL 2.1” Karol Herbst (1): clover: update ICD table to support everything up to 2.2 Pierre Moreau (19): include/CL: Update to the latest OpenCL 2.2 headers clover/api: Fix tab indentation to spaces clover: Remove the TGSI backend as unused clover: A

[Mesa-dev] [PATCH v4 03/20] clover/api: Fix tab indentation to spaces

Acked-by: Francisco Jerez Reviewed-by: Karol Herbst Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium

[Mesa-dev] [PATCH v4 04/20] clover: Remove the TGSI backend as unused

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/Makefile.am | 11 +- src/gallium/state_trackers/clover/Makefile.sources | 4 - src/gallium/state_trackers/clover/core/program.cpp | 13 +-- src/gallium/state_trackers/clover/meson.build | 9 +- .../state_trackers

[Mesa-dev] [PATCH v4 05/20] clover: Add an helper for checking if an IR is supported

Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- Notes: v3: * Dropped supported_irs() (Francisco Jerez) * Changed supports_ir() argument type to `enum pipe_shader_ir` (Francisco Jerez) src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium

[Mesa-dev] [PATCH v4 09/20] clover: Disallow creating libraries from other libraries

If creating a library, do not allow non-compiled object in it, as executables are not allowed, and libraries would make it really hard to enforce the "-enable-link-options" flag. Reviewed-by: Francisco Jerez Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- Notes: v3: Re

[Mesa-dev] [PATCH v4 08/20] clover/api: Fail if trying to build a non-executable binary

From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram): > If program is created with clCreateProgramWithBinary, then the > program binary must be an executable binary (not a compiled binary or > library). Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- sr

[Mesa-dev] [PATCH v4 10/20] clover: Track flags per module section

One flag that needs to be tracked is whether a library is allowed to received mathematics optimisations or not, as the authorisation is given when creating the library while the optimisations are specified when creating the executable. Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau

[Mesa-dev] [PATCH v4 07/20] clover/api: Rework the validation of devices for building

Signed-off-by: Pierre Moreau --- Notes: Changes in v4: * validate_build_common no longer returns a list of devices (Francisco Jerez); * Dropped duplicate checks (Francisco Jerez). src/gallium/state_trackers/clover/api/program.cpp | 23 +- src/gallium

[Mesa-dev] [PATCH v4 06/20] clover/device: Replace usage of "1 << PIPE_SHADER_IR_*" with supports_ir

Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/core/device.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp index

[Mesa-dev] [PATCH v4 11/20] clover: Move device extensions definitions to core/device.cpp

Reviewed-by: Francisco Jerez Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 14 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files

[Mesa-dev] [PATCH v4 13/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

Signed-off-by: Pierre Moreau --- Notes: Changes in v4: * make SPIRV-Tools and llvm-spirv optional (Francisco Jerez); * bump requirement for llvm-spirv to version 0.2 v3: * Bump the required version of SPIRV-Tools to the latest release; * Add a dependency on llvm-spirv

[Mesa-dev] [PATCH v4 14/20] clover/llvm: Allow translating from SPIR-V to LLVM IR

Signed-off-by: Pierre Moreau --- Notes: Changes in v4: * guard the SPIR-V code; * use an istringstream instead of a bidirectional stringstream, and initialise it directly (Francisco Jerez). .../state_trackers/clover/llvm/invocation.cpp | 29

[Mesa-dev] [PATCH v4 12/20] clover: Move platform extensions definitions to clover/platform.cpp

Reviewed-by: Francisco Jerez Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- src/gallium/state_trackers/clover/core/platform.cpp | 5 + src/gallium/state_trackers/clover/core/platform.hpp | 2 ++ 3 files changed, 9

[Mesa-dev] [PATCH v4 15/20] include/CL: Add cl_khr_il_program

Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- include/CL/cl_ext.h | 37 + 1 file changed, 37 insertions(+) diff --git a/include/CL/cl_ext.h b/include/CL/cl_ext.h index 5078e8f45f..5ea4968042 100644 --- a/include/CL/cl_ext.h +++ b/include/CL

[Mesa-dev] [PATCH v4 16/20] clover: Implement clCreateProgramWithILKHR

Signed-off-by: Pierre Moreau --- Notes: Changes in v4: guard parts of the code behind SPIR-V support v3: * Remove the const on the length argument to CreateProgramWithILKHR (Francisco Jerez); * Capitalize comment (Francisco Jerez); * Store the IL as a std::vector

[Mesa-dev] [PATCH v4 17/20] clover: Handle CL_PROGRAM_IL in clGetProgramInfo

Signed-off-by: Pierre Moreau --- Notes: Changes in v4: Use the core define instead of the extension one (Karol Herbst) v3: Switch from using a pointer attribute to a vector (Francisco Jerez) src/gallium/state_trackers/clover/api/program.cpp | 7 +++ 1 file changed, 7 insertions

[Mesa-dev] [PATCH v4 18/20] clover/api: Implement CL_DEVICE_IL_VERSION

Signed-off-by: Pierre Moreau --- Notes: Changes in v4: Use the core define instead of the extension one (Karol Herbst) v3: Throw an exception if the cl_khr_il_program extension is not supported (Francisco Jerez) src/gallium/state_trackers/clover/api/device.cpp | 7 +++ 1

[Mesa-dev] [PATCH v4 19/20] clover: Advertise cl_khr_il_program

Signed-off-by: Pierre Moreau --- Notes: Changes in v4: do not advertise SPIR-V support if CLOVER_ALLOW_SPIRV is not defined v3: Advertise cl_khr_il_program if if the device support NATIVE as IR src/gallium/state_trackers/clover/api/platform.cpp | 2 ++ src/gallium/state_trackers

[Mesa-dev] [PATCH v4 20/20] clover: Implement clCreateProgramWithIL from OpenCL 2.1

Signed-off-by: Pierre Moreau --- Notes: v3: Remove the const from the length argument of clCreateProgramWithIL src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH v5 08/34] nvir/nir: run some passes to make the conversion easier

On 2018-02-20 — 22:02, Karol Herbst wrote: > v2: add constant_folding > > Signed-off-by: Karol Herbst > --- > .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 40 > ++ > 1 file changed, 40 insertions(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_n

Re: [Mesa-dev] [PATCH v5 10/34] nvir/nir: add nir type helper functions

On 2018-02-20 — 22:02, Karol Herbst wrote: > v4: treat imul as unsigned > v5: remove pointless !! > > Signed-off-by: Karol Herbst > --- > .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 117 > + > 1 file changed, 117 insertions(+) > > diff --git a/src/gallium/drivers/n

Re: [Mesa-dev] [PATCH 4/5 v6] clover/llvm: Add get_[cl|language]_version, validation and some helpers

Sorry, partially forgot about it. I’ll look at it over the weekend, as I don’t have time before. :-/ Pierre signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo

Re: [Mesa-dev] [PATCH 4/5 v6] clover/llvm: Add get_[cl|language]_version, validation and some helpers

1+ use the version specified > 2) If not, use the highest 1.x version that the device supports > > Curiously, there is no valid value for -cl-std=CL1.0 > > Validates requested cl-std against device_clc_version > > Signed-off-by: Aaron Watry > Cc: Pierre Moreau >

[Mesa-dev] [PATCH v2 01/22] clover/api: Fix tab indentation to spaces

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp index 3572bb0c92..576555a9af 100644 --- a/src

[Mesa-dev] [PATCH v2 02/22] clover: Add additional functions to query supported IRs

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/core/device.cpp | 11 +++ src/gallium/state_trackers/clover/core/device.hpp | 3 +++ 2 files changed, 14 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover

[Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

yet. Thank you in advance for reviewing/commenting, Pierre [1]: https://github.com/KhronosGroup/SPIRV-Tools/ Pierre Moreau (22): clover/api: Fix tab indentation to spaces clover: Add additional functions to query supported IRs clover/api: Fail if trying to build a non-executable binary

[Mesa-dev] [PATCH v2 03/22] clover/api: Fail if trying to build a non-executable binary

From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram: > If program is created with clCreateProgramWithBinary, then the > program binary must be an executable binary (not a compiled binary or > library). Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/c

[Mesa-dev] [PATCH v2 05/22] clover: Track flags per module section

One flag that needs to be tracked is whether a library is allowed to received mathematics optimisations or not, as the authorisation is given when creating the library while the optimisations are specified when creating the executable. Signed-off-by: Pierre Moreau --- src/gallium/state_trackers

[Mesa-dev] [PATCH v2 04/22] clover: Disallow creating libraries from other libraries

If creating a library, do not allow non-compiled object in it, as executables are not allowed, and libraries would make it really hard to enforce the "-enable-link-options" flag. Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/program.cpp | 19 -

[Mesa-dev] [PATCH v2 14/22] clover: Add a pointer property to return ILs

OpenCL 2.1, and cl_khr_il_program, gives the ability to query for a program’s IL, which is returned as a pointer. Signed-off-by: Pierre Moreau --- .../state_trackers/clover/core/property.hpp| 39 ++ 1 file changed, 39 insertions(+) diff --git a/src/gallium

[Mesa-dev] [PATCH v2 15/22] include/CL: Add cl_khr_il_program

Signed-off-by: Pierre Moreau --- include/CL/cl_ext.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/include/CL/cl_ext.h b/include/CL/cl_ext.h index 710bea8837..2e4845d27d 100644 --- a/include/CL/cl_ext.h +++ b/include/CL/cl_ext.h @@ -308,6 +308,40

[Mesa-dev] [PATCH v2 08/22] include/pipe: Define SPIRV as an IR

Signed-off-by: Pierre Moreau --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index b34e7a8570..082d4c4d87 100644 --- a/src/gallium/include/pipe/p_defines.h +++ b/src/gallium

[Mesa-dev] [PATCH v2 09/22] configure.ac, meson: Check for SPIRV-Tools

Signed-off-by: Pierre Moreau --- configure.ac | 5 + meson.build | 2 ++ 2 files changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index 7c1fbe0ed1..8c50ea6792 100644 --- a/configure.ac +++ b/configure.ac @@ -2373,6 +2373,11 @@ AM_CONDITIONAL(HAVE_CLOVER_ICD, test &q

[Mesa-dev] [PATCH v2 10/22] clover/spirv: Import spirv.hpp11 version 1.0 (rev 12)

Signed-off-by: Pierre Moreau --- .../state_trackers/clover/spirv/spirv.hpp11| 997 + 1 file changed, 997 insertions(+) create mode 100644 src/gallium/state_trackers/clover/spirv/spirv.hpp11 diff --git a/src/gallium/state_trackers/clover/spirv/spirv.hpp11 b/src

[Mesa-dev] [PATCH v2 06/22] clover: Move device extensions definitions to core/device.cpp

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 14 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a

[Mesa-dev] [PATCH v2 07/22] clover: Move platform extensions definitions to clover/platform.cpp

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- src/gallium/state_trackers/clover/core/platform.cpp | 5 + src/gallium/state_trackers/clover/core/platform.hpp | 2 ++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH v2 18/22] clover/api: Implement CL_DEVICE_IL_VERSION_KHR

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp index 4e274c5005..6bede21ca4 100644 --- a/src/gallium

[Mesa-dev] [PATCH v2 16/22] clover: Implement clCreateProgramWithILKHR

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/dispatch.hpp | 4 ++ src/gallium/state_trackers/clover/api/program.cpp | 29 - src/gallium/state_trackers/clover/core/program.cpp | 68 +- src/gallium/state_trackers/clover/core/program.hpp | 14

[Mesa-dev] [PATCH v2 17/22] clover: Handle CL_PROGRAM_IL_KHR in clGetProgramInfo

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/program.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/gallium/state_trackers/clover/api/program.cpp index ed3b679c7c..754a5f2b00 100644 --- a/src

[Mesa-dev] [PATCH v2 20/22] include/CL: Export OpenCL 2.1 functions

Signed-off-by: Pierre Moreau --- include/CL/cl.h | 8 include/CL/cl_platform.h | 1 + 2 files changed, 9 insertions(+) diff --git a/include/CL/cl.h b/include/CL/cl.h index 316565d6e4..2130c19c5e 100644 --- a/include/CL/cl.h +++ b/include/CL/cl.h @@ -280,6 +280,7 @@ typedef

[Mesa-dev] [PATCH v2 19/22] clover: Advertise cl_khr_il_program

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 2 ++ src/gallium/state_trackers/clover/core/device.cpp | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/platform.cpp b/src/gallium/state_trackers

[Mesa-dev] [PATCH v2 22/22] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers

[Mesa-dev] [PATCH v2 21/22] clover: Implement clCreateProgramWithIL from OpenCL 2.1

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/dispatch.cpp b/src/gallium

[Mesa-dev] [PATCH v2 11/22] clover/spirv: Add functions for parsing arguments, linking programs, etc.

Signed-off-by: Pierre Moreau --- Resending to the ML, as gabe ran out of memory. src/gallium/state_trackers/clover/Makefile.am | 15 +- src/gallium/state_trackers/clover/Makefile.sources | 4 + src/gallium/state_trackers/clover/api/program.cpp | 1 - src/gallium/state_trackers

[Mesa-dev] [PATCH v2 12/22] clover: Refuse to compile source code to SPIR-V

Creating a program using clCreateProgramWithSource to SPIR-V requires a non-upstreamed version of LLVM and clang, therefore it is currently not supported. Signed-off-by: Pierre Moreau --- Resending to the ML, as gabe ran out of memory. src/gallium/state_trackers/clover/core/program.cpp | 4

[Mesa-dev] [PATCH v2 13/22] clover: Handle the case when linking SPIR-V binaries together

Signed-off-by: Pierre Moreau --- Resending to the ML, as gabe ran out of memory. src/gallium/state_trackers/clover/core/program.cpp | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/program.cpp b/src/gallium

Re: [Mesa-dev] [PATCH v2 13/22] clover: Handle the case when linking SPIR-V binaries together

On 2018-01-23 — 08:32, Karol Herbst wrote: > On Tue, Jan 23, 2018 at 1:33 AM, Pierre Moreau wrote: > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/state_trackers/clover/core/program.cpp | 22 > > +- > > 1 file changed, 17 insertion

Re: [Mesa-dev] [PATCH v2 08/22] include/pipe: Define SPIRV as an IR

On 2018-01-23 — 14:07, Jan Vesely wrote: > On Tue, 2018-01-23 at 01:33 +0100, Pierre Moreau wrote: > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/include/pipe/p_defines.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/gall

Re: [Mesa-dev] [PATCH v2 09/22] configure.ac, meson: Check for SPIRV-Tools

On 2018-01-23 — 14:20, Jan Vesely wrote: > On Tue, 2018-01-23 at 01:33 +0100, Pierre Moreau wrote: > > Signed-off-by: Pierre Moreau > > do these tools handle the original SPIR format as well? can this be > used to support cl_khr_spir? > > Jan They do not I’m afraid. I

Re: [Mesa-dev] [PATCH v2 08/22] include/pipe: Define SPIRV as an IR

On 2018-01-23 — 13:33, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-01-23 — 14:07, Jan Vesely wrote: > >> On Tue, 2018-01-23 at 01:33 +0100, Pierre Moreau wrote: > >> > Signed-off-by: Pierre Moreau > >> > --- > >> >

Re: [Mesa-dev] [PATCH v2 10/22] clover/spirv: Import spirv.hpp11 version 1.0 (rev 12)

On 2018-01-23 — 14:06, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > --- > > .../state_trackers/clover/spirv/spirv.hpp11| 997 > > + > > 1 file changed, 997 insertions(+) > > cre

Re: [Mesa-dev] [PATCH v2 15/22] include/CL: Add cl_khr_il_program

On 2018-01-23 — 14:08, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > Same comment as Karol, let's update the header instead. I will do that. Though that won’t impact this patch, as cl_khr_il_program is not part of the official

Re: [Mesa-dev] [PATCH v2 13/22] clover: Handle the case when linking SPIR-V binaries together

On 2018-01-23 — 14:08, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/state_trackers/clover/core/program.cpp | 22 > > +- > > 1 file changed, 17 insertions(+), 5 deletions

Re: [Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

On 2018-01-23 — 14:02, Francisco Jerez wrote: > Karol Herbst writes: > > > there seem to be some patches missing? > > > > On Tue, Jan 23, 2018 at 1:33 AM, Pierre Moreau > > wrote: > >> Hello, > >> > >> Here is the second versio

Re: [Mesa-dev] [PATCH v2 04/22] clover: Disallow creating libraries from other libraries

On 2018-01-23 — 14:04, Francisco Jerez wrote: > Pierre Moreau writes: > > > If creating a library, do not allow non-compiled object in it, as > > executables are not allowed, and libraries would make it really hard to > > enforce the "-enable-link-options" f

Re: [Mesa-dev] [PATCH v2 03/22] clover/api: Fail if trying to build a non-executable binary

On 2018-01-23 — 14:03, Francisco Jerez wrote: > Pierre Moreau writes: > > > From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram: > > > >> If program is created with clCreateProgramWithBinary, then the > >> program binary must be an executa

Re: [Mesa-dev] [PATCH v2 02/22] clover: Add additional functions to query supported IRs

On 2018-01-23 — 14:03, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/state_trackers/clover/core/device.cpp | 11 +++ > > src/gallium/state_trackers/clover/core/device.hpp | 3 +++ >

Re: [Mesa-dev] [PATCH v2 04/22] clover: Disallow creating libraries from other libraries

On 2018-01-23 — 15:16, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-01-23 — 14:04, Francisco Jerez wrote: > >> Pierre Moreau writes: > >> > >> > If creating a library, do not allow non-compiled object in it, as > >> > ex

Re: [Mesa-dev] [PATCH v2 03/22] clover/api: Fail if trying to build a non-executable binary

On 2018-01-23 — 15:09, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-01-23 — 14:03, Francisco Jerez wrote: > >> Pierre Moreau writes: > >> > >> > From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram:

Re: [Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

On 2018-01-24 — 09:19, Tomeu Vizoso wrote: > On 01/24/2018 12:03 AM, Karol Herbst wrote: > > On Tue, Jan 23, 2018 at 11:46 PM, Francisco Jerez > > wrote: > > > Pierre Moreau writes: > > > > > > > On 2018-01-23 — 14:02, Francisc

Re: [Mesa-dev] [PATCH v2 18/22] clover/api: Implement CL_DEVICE_IL_VERSION_KHR

On 2018-01-23 — 14:12, Francisco Jerez wrote: > Pierre Moreau writes: > > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/state_trackers/clover/api/device.cpp | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/src/gallium/state

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

On 2018-02-02 — 18:07, Timothy Arceri wrote: > > > On 02/02/18 17:21, Timothy Arceri wrote: > > On 02/02/18 16:38, Jan Vesely wrote: > > > On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: > > > > When PIPE_SHADER_IR_LLVM existed this query made sense but now it > > > > always returns PIPE

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

On 2018-02-06 — 20:50, Jan Vesely wrote: [snip] > > > Happy to here suggestions for solving the current conflict in uses of > > > PIPE_SHADER_CAP_PREFERRED_IR. > > > > One option could be to: > > * look at the preferred IR > > |-> if clover supports it, use it > > |-> else, check if any IR sup

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

On 2018-02-07 — 12:36, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-02-06 — 20:50, Jan Vesely wrote: > > [snip] > >> > > Happy to here suggestions for solving the current conflict in uses of > >> > > PIPE_SHADER_CAP_PRE

Re: [Mesa-dev] [PATCH] r600/radeonsi/clover: use PIPE_SHADER_CAP_SUPPORTED_IRS with clover

Reviewed-by: Pierre Moreau On 2018-02-08 — 10:57, Timothy Arceri wrote: > PIPE_SHADER_CAP_PREFERRED_IR was conlicting with PIPE_SHADER_IR_NIR > for compute shaders, so we let clover pick the one it wants to use. > > This change indirectly enables NIR support for compute shaders &

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

On 2018-02-08 — 12:47, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-02-07 — 12:36, Francisco Jerez wrote: > >> Pierre Moreau writes: > >> > >> > On 2018-02-06 — 20:50, Jan Vesely wrote: > >> > [snip] > >> >> &

[Mesa-dev] Adding a SPIR-V target to libclc

(Moving the conversation to its own thread.) > target agnostic libclc is rather difficult to do. CLC includes 3 levels > of precision on float (fp32) operands; full, half, native. The > implementation of each depends on capabilites of specific device (e.g. > vega(VI+?) can do 1 ULP log2/exp2 in hw

Re: [Mesa-dev] [PATCH 1/4] r600: add PIPE_SHADER_IR_NATIVE to supported shaders for cs

IR_TGSI; > } > - case PIPE_SHADER_CAP_SUPPORTED_IRS: > + return PIPE_SHADER_IR_TGSI; This line is dead code and can be safely removed, as both the if-block and the else-block return a value already; it should be part of patch 03 instead. With that addressed, this

Re: [Mesa-dev] [PATCH 2/4] clover: use PIPE_SHADER_CAP_SUPPORTED_IRS to discover IR

On 2018-02-09 — 12:06, Timothy Arceri wrote: > PIPE_SHADER_CAP_PREFERRED_IR was conflicting with PIPE_SHADER_IR_NIR > for compute shaders, so we let clover pick the one it wants to use. > --- > src/gallium/state_trackers/clover/core/device.cpp | 11 +-- > 1 file changed, 9 insertions(+), 2

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

ce-based arguments. > Use device_clc_version for cl version detection instead of device_version > Added device_clc_version in device.cpp/hpp > > Anyway, happy reviewing. > > Cc: Jan Vesely > Cc: Pierre Moreau > signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

On 2018-02-09 — 11:50, Aaron Watry wrote: > No worries. I've been rebasing this series every time I've pulled > mesa for the last few months, and this week is the first time I've had > any real conflicts that need addressing. I'll see if I can find some > time to address your comments and re-orga

Re: [Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

/pierremoreau/mesa/commits/clover_spirv_series_v8 Thank you in advance, Pierre On 2018-05-23 — 23:58, Pierre Moreau wrote: > Hello everyone, > > I updated a few patches of the series to have it use the new official > SPIR-V <-> LLVM translator, that can be found at &g

Re: [Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

view: "clover: update ICD table to > support everything up to 2.2" > > On Sun, Jul 15, 2018 at 9:26 PM, Pierre Moreau wrote: > > Hello, > > > > I would appreciate if the following patches could be reviewed: > > * Patch 07 (latest: v6): clover

Re: [Mesa-dev] Trying to build a opencl dev env

Hello Luke, If you set `PKG_CONFIG_PATH=$PATH_TO_LIBCLC_INSTALL/share/pkgconfig` when running meson, it should pick that version instead of the system one. I run it as `PKG_CONFIG_PATH=[…] meson setup […]`; it might also be possible to pass it as an argument instead, I do not know. Best, Pierre

Re: [Mesa-dev] Installing Mesa OpenCL for Nvidia?

Hello Murray, OpenCL is currently not exposed by the nv50 driver — the one used by your 9400 GT as well as the 9800 GT when using Nouveau. It is a work-in-progress though and I could give you some instructions on how to get it going, but bear in mind that you will need to build a custom version of

Re: [Mesa-dev] [RFC 1/3] tgsi: Add WORK_DIM System Value

On 05:43 PM - Apr 27 2016, Samuel Pitoiset wrote: > > > On 04/27/2016 05:24 PM, Ilia Mirkin wrote: > >On Wed, Apr 27, 2016 at 11:19 AM, Hans de Goede wrote: > >>Hi, > >> > >>On 27-04-16 16:49, Ilia Mirkin wrote: > >>> > >>>Please add this semantic to src/gallium/docs and explain what it > >>>mea

Re: [Mesa-dev] [PATCH 1/2] nvc0: clear out surfaces bufctx before rebinding everything

On 09:28 PM - May 18 2016, Ilia Mirkin wrote: > Otherwise we can end up in a situation where that bin just grows and > grows. > > Signed-off-by: Ilia Mirkin > --- > src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/gallium/drivers/nouv

[Mesa-dev] [PATCH] nv50/ir: Add missing handling of U64/S64 in inlines

Signed-off-by: Pierre Moreau --- U64/S64 support is missing in other places of codegen (like in nv50_ir_peephole.cpp for example), however its absence will result in code not being as optimised as it could have. Adding that support is not as straight forward as this patch, and will need a

Re: [Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

Oops, sorry. Reviewed-by: Pierre Moreau Thanks again for the series! Pierre On 2018-03-20 — 20:23, Aaron Watry wrote: > ping. > > This is the last of the series that still needs review. > > --Aaron > > On Thu, Mar 1, 2018 at 1:39 PM, Aaron Watry wrote: > >

[Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

: * Patch 07: “clover/api: Rework the validation of devices for building”; * Patch 14: “clover/llvm: Allow translating from SPIR-V to LLVM IR”; * Patch 18: “clover: Handle CL_PROGRAM_IL in clGetProgramInfo” Karol Herbst (1): clover: update ICD table to support everything up to 2.2 Pierre Moreau

[Mesa-dev] [PATCH v5 08/21] clover/api: Fail if trying to build a non-executable binary

From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram): > If program is created with clCreateProgramWithBinary, then the > program binary must be an executable binary (not a compiled binary or > library). Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- sr

[Mesa-dev] [PATCH v5 05/21] clover: Add an helper for checking if an IR is supported

Reviewed-by: Aaron Watry Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 2 files changed, 7 insertions(+) diff --git a/src/gallium/state_trackers/clover/core

[Mesa-dev] [PATCH v5 03/21] clover/api: Fix tab indentation to spaces

Acked-by: Francisco Jerez Reviewed-by: Karol Herbst Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium

[Mesa-dev] [PATCH v5 02/21] clover: update ICD table to support everything up to 2.2

From: Karol Herbst Reviewed-by: Pierre Moreau Signed-off-by: Karol Herbst --- v5: Fix return type of clCreateCommandQueueWithProperties v2: add more prototypes src/gallium/state_trackers/clover/api/dispatch.cpp | 29 +++- src/gallium/state_trackers/clover/api/dispatch.hpp | 190

[Mesa-dev] [PATCH v5 04/21] clover: Remove the TGSI backend as unused

Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/Makefile.am | 11 +- src/gallium/state_trackers/clover/Makefile.sources | 4 - src/gallium/state_trackers/clover/core/program.cpp | 13 +-- src/gallium/state_trackers/clover/meson.build

[Mesa-dev] [PATCH v5 10/21] clover: Track flags per module section

One flag that needs to be tracked is whether a library is allowed to received mathematics optimisations or not, as the authorisation is given when creating the library while the optimisations are specified when creating the executable. Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau

[Mesa-dev] [PATCH v5 09/21] clover: Disallow creating libraries from other libraries

If creating a library, do not allow non-compiled object in it, as executables are not allowed, and libraries would make it really hard to enforce the "-enable-link-options" flag. Reviewed-by: Francisco Jerez Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/stat

[Mesa-dev] [PATCH v5 06/21] clover/device: Replace usage of "1 << PIPE_SHADER_IR_*" with supports_ir

Reviewed-by: Aaron Watry Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/core/device.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover

[Mesa-dev] [PATCH v5 07/21] clover/api: Rework the validation of devices for building

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/program.cpp | 23 +- src/gallium/state_trackers/clover/core/program.cpp | 3 ++- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src

[Mesa-dev] [PATCH v5 11/21] clover: Move device extensions definitions to core/device.cpp

Reviewed-by: Francisco Jerez Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 14 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files

[Mesa-dev] [PATCH v5 14/21] clover/llvm: Allow translating from SPIR-V to LLVM IR

Signed-off-by: Pierre Moreau --- .../state_trackers/clover/llvm/invocation.cpp | 29 ++ .../state_trackers/clover/llvm/invocation.hpp | 6 + src/gallium/state_trackers/clover/meson.build | 2 +- 3 files changed, 36 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v5 12/21] clover: Move platform extensions definitions to clover/platform.cpp

Reviewed-by: Francisco Jerez Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- src/gallium/state_trackers/clover/core/platform.cpp | 5 + src/gallium/state_trackers/clover/core/platform.hpp | 2 ++ 3 files changed, 9

[Mesa-dev] [PATCH v5 15/21] include/CL: Add cl_khr_il_program

Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- include/CL/cl_ext.h | 37 + 1 file changed, 37 insertions(+) diff --git a/include/CL/cl_ext.h b/include/CL/cl_ext.h index 5078e8f45f..5ea4968042 100644 --- a/include/CL/cl_ext.h +++ b/include/CL

[Mesa-dev] [PATCH v5 21/21] clover: Implement clCreateProgramWithIL from OpenCL 2.1

Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/dispatch.cpp

[Mesa-dev] [PATCH v5 18/21] clover: Handle CL_PROGRAM_IL in clGetProgramInfo

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/program.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/gallium/state_trackers/clover/api/program.cpp index 3c7e56efb9..851a212b99 100644 --- a/src

[Mesa-dev] [PATCH v5 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- Changes in v5: * Add a comment saying where to find llvm-spirv (Karol Herbst). configure.ac | 18 ++ meson.build | 8 2 files changed, 26 insertions(+) diff --git a/configure.ac b/configure.ac index

[Mesa-dev] [PATCH v5 19/21] clover/api: Implement CL_DEVICE_IL_VERSION

Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp index 4e274c5005

[Mesa-dev] [PATCH v5 17/21] clover: Implement clCreateProgramWithILKHR

Signed-off-by: Pierre Moreau --- Changes in v5: * Use is_binary_spirv and is_valid_spirv from the SPIR-V backend; * Drop the SPIRV-Tools and llvm-spirv dependencies on clover. src/gallium/state_trackers/clover/api/dispatch.hpp | 4 ++ src/gallium/state_trackers/clover/api/program.cpp | 60

[Mesa-dev] [PATCH v5 20/21] clover: Advertise cl_khr_il_program

Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 2 ++ src/gallium/state_trackers/clover/core/device.cpp | 8 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/platform.cpp

[Mesa-dev] [PATCH v5 16/21] clover/spirv: Add functions for validating SPIR-V binaries

Signed-off-by: Pierre Moreau --- New in v5 src/gallium/state_trackers/clover/Makefile.am | 15 ++- src/gallium/state_trackers/clover/Makefile.sources | 4 + src/gallium/state_trackers/clover/meson.build | 10 +- .../state_trackers/clover/spirv/invocation.cpp | 138

<    1   2   3   4   >