Hi All,
I've been stalking this list for a while now and I thought I'd finally make an
attempt to contribute something. I've decided the KHR_debug extension is a good
place to start as the ARB_debug_output provideds a great starting point.
However I've hit my first road block.
I'm ready to
Hi Brian,
Where can I get a copy of you unfinished work on the GL_KHR_debug extension?
Thanks,
Tim
- Original Message -
From: Jose Fonseca jfons...@vmware.com
To: Timothy Arceri t_arc...@yahoo.com.au
Cc: mesa-dev@lists.freedesktop.org; Brian Paul bri...@vmware.com
Sent: Tuesday, 23
---
docs/devinfo.html| 2 +-
docs/sourcetree.html | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/docs/devinfo.html b/docs/devinfo.html
index bf77259..4c1099c 100644
--- a/docs/devinfo.html
+++ b/docs/devinfo.html
@@ -36,7 +36,7 @@ To add a new GL extension to Mesa you
enums were being converted twice resulting in incorrect values.
The extra conversion has been remove and the redundant assert is
removed also.
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/errors.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions
enum conversion is
removed.
As this is a bug that stops glDebugMessageControlARB() from working properly I
would also say this is probably a good candidate for the stable branches.
Thanks for your time,
Tim
- Original Message -
From: Timothy Arceri t_arc...@yahoo.com.au
To: mesa-dev
returned by the arb_debug_output functions need to be filtered
to return types/severitys that the caller expects (rather than new type
introduced byt khr_debug). To work around this just the types are just
remap them to types arb_debug_output understands.
Timothy Arceri (15):
mesa: Add some constants
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/config.h |7 ++-
src/mesa/main/errors.c |4
src/mesa/main/mtypes.h | 15 ++-
3 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/config.h b/src/mesa/main/config.h
index
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/errors.c | 308 +---
src/mesa/main/errors.h | 15 +++
2 files changed, 226 insertions(+), 97 deletions(-)
diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c
index
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/hash.c | 26 ++
src/mesa/main/hash.h |3 +++
2 files changed, 29 insertions(+)
diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c
index 6591af9..8dde8b1 100644
--- a/src/mesa/main/hash.c
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/errors.c | 275
src/mesa/main/errors.h |5 +
src/mesa/main/mtypes.h |5 +-
3 files changed, 214 insertions(+), 71 deletions(-)
diff --git a/src/mesa/main/errors.c b
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/arrayobj.c | 10 +-
src/mesa/main/arrayobj.h |3 +++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c
index 9226050..006a2ea 100644
--- a/src/mesa
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/dlist.c | 12 ++--
src/mesa/main/dlist.h |2 ++
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index af2b468..a82436c 100644
--- a/src/mesa/main
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/mtypes.h | 12
1 file changed, 12 insertions(+)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index bd3560a..2277b95 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -1128,6
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/arrayobj.c |1 +
src/mesa/main/bufferobj.c|1 +
src/mesa/main/dlist.c|1 +
src/mesa/main/framebuffer.c |1 +
src/mesa/main
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/syncobj.c |2 +-
src/mesa/main/syncobj.h |3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/syncobj.c b/src/mesa/main/syncobj.c
index e426474..92c7cb0 100644
--- a/src/mesa/main
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/objectlabel.c | 277 +++
src/mesa/main/objectlabel.h | 61 ++
2 files changed, 338 insertions(+)
create mode 100644 src/mesa/main/objectlabel.c
create mode 100644 src/mesa
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/Makefile.sources |1 +
src/mesa/SConscript |1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/Makefile.sources b/src/mesa/Makefile.sources
index a5c1f5d..122ea8e 100644
--- a/src/mesa/Makefile.sources
+++ b
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/drivers/dri/i965/brw_context.c |2 ++
src/mesa/main/enable.c |9 +
src/mesa/main/errors.c |3 +++
src/mesa/main/mtypes.h |1 +
src/mesa/state_tracker
Remap any type or severity exclusive to KHR_debug to
something suitable for ARB_debug_output
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/errors.c | 65 ++--
src/mesa/main/mtypes.h |1 +
2 files changed, 58 insertions
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/extensions.c |3 +++
src/mesa/main/get_hash_params.py | 14 +-
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index 1a040ee
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mapi/glapi/gen/gl_API.xml| 149 +-
src/mapi/glapi/gen/gl_genexec.py |1 +
2 files changed, 149 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen
On 27/08/13 00:51, Brian Paul wrote:
On 08/26/2013 04:43 AM, Timothy Arceri wrote:
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/hash.c | 26 ++
src/mesa/main/hash.h |3 +++
2 files changed, 29 insertions(+)
diff --git a/src/mesa/main
V2: fixed spelling typo in comment
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/errors.c | 275 -
src/mesa/main/errors.h | 5 +
src/mesa/main/mtypes.h | 5 +-
3 files changed, 214 insertions(+), 71 deletions(-)
diff
V2: fixed indentation of comment
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/objectlabel.c | 277
src/mesa/main/objectlabel.h | 61 ++
2 files changed, 338 insertions(+)
create mode 100644 src/mesa/main
V3: removed C++ style comment
V2: fixed spelling typo in comment
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/errors.c | 275 -
src/mesa/main/errors.h | 5 +
src/mesa/main/mtypes.h | 5 +-
3 files changed, 214
On 28/08/13 08:25, Fredrik Höglund wrote:
On Tuesday 27 August 2013, Timothy Arceri wrote:
V2: fixed indentation of comment
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/objectlabel.c | 277
src/mesa/main/objectlabel.h
V2: const qualify table parameter
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/hash.c | 28
src/mesa/main/hash.h |3 +++
2 files changed, 31 insertions(+)
diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c
index 6591af9..b31fd48
-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/objectlabel.c | 282 +++
src/mesa/main/objectlabel.h | 61 ++
2 files changed, 343 insertions(+)
create mode 100644 src/mesa/main/objectlabel.c
create mode 100644 src/mesa/main/objectlabel.h
+ }
+
+ if (label) {
+ /* set new label string */
+
+ if (length = 0) {
+ /* explicit length */
+ *labelPtr = (char *) malloc(length);
+ if (*labelPtr) {
+memcpy(*labelPtr, label, length);
+ }
The length given by the client is not
- Original Message -
From: Brian Paul bri...@vmware.com
On 08/27/2013 08:39 PM, Timothy Arceri wrote:
V2: const qualify table parameter
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/hash.c | 28
src/mesa/main/hash.h | 3
Since you obviously didn't run 'make check', I will be reverting this
entire series later today.
YOU MUST RUN 'make check'.
Ok, well what can I say I didnt know (or I guess didnt check) that Mesa had a
Testsuite I will submit a patch to add a section to devinfo.html about
submitting patches
Hi Ian,
Thanks for the review. An let me say I'm here to learn so sorry if my
questions/comments are something that should be obvious.
Remap any type or severity exclusive to KHR_debug to
something suitable for ARB_debug_output
There is no need for any of this remapping. The only way the
+/**
+ * Helper for _mesa_ObjectLabel() and _mesa_ObjectPtrLabel().
+ */
+static void
+set_label(struct gl_context *ctx, char **labelPtr, const char *label,
+ int length, const char *caller)
+{
+ if (*labelPtr) {
+ /* free old label string */
+ free(*labelPtr);
+
+ /* explicit length */
+ *labelPtr = (char *) malloc(length);
+ if (*labelPtr) {
+ memcpy(*labelPtr, label, length);
+ }
+ }
+ else {
+ /* null-terminated string */
+ int len = strlen(label);
+ if (len =
On Wed, 2013-09-04 at 20:09 -0700, Ian Romanick wrote:
On 09/04/2013 05:43 PM, Timothy Arceri wrote:
+/**
+ * Helper for _mesa_ObjectLabel() and _mesa_ObjectPtrLabel().
+ */
+static void
+set_label(struct gl_context *ctx, char **labelPtr, const char *label,
+ int length
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
docs/devinfo.html | 23 +++
1 file changed, 23 insertions(+)
diff --git a/docs/devinfo.html b/docs/devinfo.html
index 4c1099c..d921e0d 100644
--- a/docs/devinfo.html
+++ b/docs/devinfo.html
@@ -155,6 +155,29
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/objectlabel.c | 124 +--
1 file changed, 62 insertions(+), 62 deletions(-)
diff --git a/src/mesa/main/objectlabel.c b/src/mesa/main/objectlabel.c
index 90d9e09..7e39c92 100644
Add this comment because other places in OpenGL include the NULL terminator in
the length.
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/objectlabel.c |5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/objectlabel.c b/src/mesa/main/objectlabel.c
Date: Wed, 11 Sep 2013 18:27:43 -0700
From: Vinson Lee v...@freedesktop.org
To: mesa-dev@lists.freedesktop.org
Subject: [Mesa-dev] [PATCH] mesa: Return nonzero length only if memcpy
occurs.
Message-ID: 1378949263-18169-1-git-send-email-v...@freedesktop.org
Fixes Dereference after null check
Hi Brian,
Maybe its just another oversight in the spec but I thought I'd point out that
the spec doesnt actually say to test for this in the get label functions. I
assumed this was because label can be NULL in which case a bufSize of 0 would
be valid. I haven't checked what the Catalyst
I tested on Catalyst and it allows both negative and 0 buf size without
a GL_INVALID_VALUE error.
I'm not sure if I'm allowed to review patches but for whats its worth
for the other two patches.
Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au
On 16/09/13 15:37, Timothy Arceri wrote:
Hi
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
docs/GL3.txt |2 +-
docs/relnotes/9.3.html |1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 630fd99..6e5a868 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -145,7
---
src/glsl/ast_to_hir.cpp | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index dfa32d9..f96ed53 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -637,8 +637,8 @@
Hi Federico,
Just FYI you should send the piglit test to the piglit mailing list:
http://lists.freedesktop.org/mailman/listinfo/piglit
Also to allow easy review you should use git send-email rather than
attaching it to the email.
Timothy Arceri
On Mon, 2013-10-21 at 17:37 -0500, Federico Mena
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_array_index.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp
index b457ec8..107c29e 100644
--- a/src/glsl/ast_array_index.cpp
+++ b/src/glsl
The main purpose of this patch is to increase readability of
the array code. A redundent is_array() check is also removed.
The introduction of is_unsized_array() should also make the
ARB_arrays_of_arrays code simpler and more readable when it arrives.
Signed-off-by: Timothy Arceri t_arc
the
ARB_arrays_of_arrays code simpler and more readable when it arrives.
V2: Also replace code that checks for unsized arrays directly with the
length variable
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_array_index.cpp | 2 +-
src/glsl/ast_function.cpp| 11 +--
src/glsl
On Fri, 2013-10-25 at 14:51 -0700, Paul Berry wrote:
+ _mesa_glsl_error(loc, state,
+ is_initializer ? initializer : value
+ of type %s cannot be assigned to
+ variable of type %s,
+
On Tue, 2013-10-29 at 13:13 -0700, Eric Anholt wrote:
Josh Klint joshkl...@leadwerks.com writes:
Hi,
As I understand it, Mesa is in charge of providing OpenGL drivers for
Intel graphics hardware running on Linux. I'm in the process of
porting our game engine over to Linux, and have
V2: Return after error to avoid cascading error messages and
removed redundant to from error message
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl
Left over from bug #34376.
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 7 ---
1 file changed, 7 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 76b256c..adf10a0 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl
Just to clarify unsized arrays cannot be assigned so var-max_array_access
will always be 0 as redecorations are already handled before this point by
get_variable_being_redeclared()
On Wed, 2013-11-20 at 22:41 +1100, Timothy Arceri wrote:
Left over from bug #34376.
Signed-off-by: Timothy
I've only had a very quick scan over your patches but I think you need
to redo your patches that edit case statements as you are not just
changing the value of the intended case statement but also all of the
cases above it as they do not break or return they just fall through for
example:
---
Hi Thomas,
Looks like Siavash Eliasi beat you to it.
But here is some quick feedback. You seem to have made the same mistake
with your case statements [1]
Also you shouldn't attach the patch to your email but should use
git-send-email there is a link to more info on the Newbie page ;)
As for
Hi guys,
I received the following submitted as an Issue on my github account.
Maybe someone here has a project they can suggest.
Thanks,
Tim
On Thu, 2013-11-28 at 10:19 -0800, LeonardoItalia wrote:
Hello, I am an undergraduate Computer Science student from the
University of Bari, in southern
On Fri, 2013-11-29 at 09:36 +0200, Petri Latvala wrote:
On 11/28/2013 11:15 PM, Timothy Arceri wrote:
Hi guys,
I received the following submitted as an Issue on my github account.
Maybe someone here has a project they can suggest.
Is NewbieProjects too newbie for this?
http
regression.
Tim
On Wed, 2013-11-20 at 22:41 +1100, Timothy Arceri wrote:
Left over from bug #34376.
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 7 ---
1 file changed, 7 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
On Wed, 2013-12-04 at 14:32 -0800, Ian Romanick wrote:
On 11/20/2013 03:41 AM, Timothy Arceri wrote:
Left over from bug #34376.
I think this shader hits this error message:
#version 120
int x[];
void foo() { x[3] = 2; }
int x[] = int[2](1,2);
do_assignment
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 45 -
1 file changed, 24 insertions(+), 21 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 3bc181e..a7aa4c7 100644
--- a/src/glsl
Hi Guys,
I've been chasing my tail most of the afternoon using exec_list
basically I was just trying to copy all but the first element from one
list to another using the code bellow.
exec_list *copy_dims =
type-array_specifier-array_dimensions;
int i = 0;
);
}
I originally thought the pointer was being freed by an access to the
copied list somewhere but since foreach_list_safe makes things work
there must be something else happening.
On Sun, 2014-01-12 at 19:08 +1100, Timothy Arceri wrote:
Hi Guys,
I've been chasing my tail most of the afternoon
Ok please ignore I understand how exec_list works now. What I was trying
to do was silly I'll need to figure out a different solution sorry about
the noise.
On Sun, 2014-01-12 at 19:39 +1100, Timothy Arceri wrote:
I just tried the below code which is much cleaner but it to causes the
original
Hi all,
Its still a work in progress currently just passing the compile tests
that I submitted to the piglit list [1].
Its also a bit of a mess (some patches need squashing, a number of
patches are just temp updates to support single dimension arrays for the
time being) but I thought I would
. However if everything works how I'm
picturing it in my mind after changing this there isn't much more left
to do for implementing the extension (I'm sure there probably is more to
it though).
On Tue, 2014-01-14 at 22:53 +1100, Timothy Arceri wrote:
Hi all,
Its still a work in progress currently
First of all sorry for my first post being a reply to Ians 10.1 release
plan.
Secondly I've rebased my work on current master and reimplemented my
work using the approach I mention in my last email. The changes are half
the size and now some basic execution tests are passing. The new branch
is
, Jan 16, 2014 at 1:14 AM, Timothy Arceri t_arc...@yahoo.com.au wrote:
First of all sorry for my first post being a reply to Ians 10.1 release
plan.
Secondly I've rebased my work on current master and reimplemented my
work using the approach I mention in my last email. The changes are half
with these patches applied.
Timothy Arceri (9):
Mesa: Add ARB_arrays_of_arrays
glsl: add dimension_count to glsl_types
glsl: Add arrays_of_arrays to yacc definition
glsl: Add array specifier to ast code
glsl: only call mark_max_array if we are assigning an array
glsl: Implement
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/glsl_types.cpp | 15 +++
src/glsl/glsl_types.h | 17 -
2 files changed, 27 insertions(+), 5 deletions(-)
diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp
index 12d4ac0..1c9add7 100644
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/mtypes.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index 2e0ccc3..95eb7ca 100644
--- a/src/mesa/main/extensions.c
+++ b
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/glsl_parser.yy | 153 +---
1 file changed, 66 insertions(+), 87 deletions(-)
diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy
index 1c56d6f..6d63668 100644
--- a/src/glsl
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_function.cpp | 54 ---
1 file changed, 46 insertions(+), 8 deletions(-)
diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp
index 2d05d07..57aa45f 100644
--- a/src/glsl
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index c0e3443..359a0b8 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 3054b9c..a83ef9c 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -3196,6 +3196,10
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
docs/GL3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 0672ec7..9f756e9 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -142,7 +142,7 @@ GL 4.2:
GL 4.3:
GLSL 4.3
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast.h | 45 +++
src/glsl/ast_array_index.cpp| 13 +++
src/glsl/ast_to_hir.cpp | 173 +++-
src/glsl/ast_type.cpp | 8 +-
src/glsl
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast.h | 19 +++-
src/glsl/ast_function.cpp | 15 +++--
src/glsl/ast_to_hir.cpp | 31 +++---
src/glsl/glsl_parser.yy | 36 -
src/glsl
V2 dont create a second process_array_type function
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast.h | 19 +++-
src/glsl/ast_function.cpp | 14 +++--
src/glsl/ast_to_hir.cpp | 29 -
src/glsl/glsl_parser.yy
diff --git a/src/glsl/glsl_parser_extras.cpp
b/src/glsl/glsl_parser_extras.cpp
index 21dc3ab..92076b5 100644
--- a/src/glsl/glsl_parser_extras.cpp
+++ b/src/glsl/glsl_parser_extras.cpp
@@ -484,6 +484,7 @@ struct _mesa_glsl_extension {
static const _mesa_glsl_extension
On Thu, 2014-01-16 at 16:29 -0800, Matt Turner wrote:
On Wed, Jan 15, 2014 at 10:27 PM, Timothy Arceri t_arc...@yahoo.com.au
wrote:
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/glsl_types.cpp | 15 +++
src/glsl/glsl_types.h | 17 -
2
V2: Fix up whitespaces
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_function.cpp | 43 ---
1 file changed, 40 insertions(+), 3 deletions(-)
diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp
index 2d05d07..0d2cac0
On Sat, 2014-01-18 at 14:57 +1100, Timothy Arceri wrote:
diff --git a/src/glsl/glsl_parser_extras.cpp
b/src/glsl/glsl_parser_extras.cpp
index 21dc3ab..92076b5 100644
--- a/src/glsl/glsl_parser_extras.cpp
+++ b/src/glsl/glsl_parser_extras.cpp
@@ -484,6 +484,7 @@ struct
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast.h | 44 +++
src/glsl/ast_array_index.cpp| 13
src/glsl/ast_to_hir.cpp | 160 +++-
src/glsl/ast_type.cpp | 8 +-
src/glsl
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 226d128..62b7ec2 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -3176,6 +3176,10
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 326aa58..d02c9ff 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
This is a first pass at implementing the ARB_arrays_of_arrays extension in Mesa.
This series allows the Mesa front-end to parse and compile shaders that don't
require linking of
arrays of arrays e.g. multi dimensional uniforms. I'm sending this extension in
parts because my
time working on this
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/mtypes.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index 2e0ccc3..95eb7ca 100644
--- a/src/mesa/main/extensions.c
+++ b
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/glsl_parser.yy | 153 +---
1 file changed, 66 insertions(+), 87 deletions(-)
diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy
index 1c56d6f..6d63668 100644
--- a/src/glsl
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
docs/GL3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 0672ec7..9f756e9 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -142,7 +142,7 @@ GL 4.2:
GL 4.3:
GLSL 4.3
We need to insert outermost dimensions in the correct spot otherwise
the dimension order will be backwards
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/glsl_types.cpp | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/glsl/glsl_types.cpp b
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast.h | 19 +++-
src/glsl/ast_function.cpp | 14 +++--
src/glsl/ast_to_hir.cpp | 29 +-
src/glsl/glsl_parser.yy | 36 +-
src/glsl
Hi Paul
Thanks for the thorough review and taking the time to explain how to make
improvements. I can already see a number of improvements that can be made to
patch 5 based on the suggestions you have already made so you could hold off
reviewing that one if you havent started already and I've
This change does not help fix or prevent any bugs
it just seems reasonable to do
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast_to_hir.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index
This is a first pass at implementing the ARB_arrays_of_arrays extension in Mesa.
This series allows the glsl front-end to parse and compile shaders that don't
require linking of
arrays of arrays e.g. multi dimensional uniforms. I'm sending this extension in
parts because my
time working on this
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/glsl_parser.yy | 128 +---
1 file changed, 56 insertions(+), 72 deletions(-)
diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy
index 5451b76..2786e92 100644
--- a/src/glsl
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
Reviewed-by: Paul Berry stereotype441 at gmail.com
---
src/glsl/glcpp/glcpp-parse.y | 3 +++
src/mesa/main/extensions.c | 1 +
src/mesa/main/mtypes.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/src/glsl/glcpp/glcpp-parse.y b
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
Reviewed-by: Paul Berry stereotype441 at gmail.com
---
docs/GL3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 0672ec7..9f756e9 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -142,7
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
Reviewed-by: Paul Berry stereotype441 at gmail.com
---
src/glsl/ast_to_hir.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index be12f97..f13ac51 100644
--- a/src
Previously the reason we needed is_array was because we used array_size == NULL
to
represent both non-arrays and unsized arrays. Now that we use a non-NULL
array_specifier to represent an unsized array, is_array is redundant.
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl
We need to insert outermost dimensions in the correct spot otherwise
the dimension order will be backwards
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
Reviewed-by: Paul Berry stereotype441 at gmail.com
---
src/glsl/glsl_types.cpp | 16 ++--
1 file changed, 14 insertions
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au
---
src/glsl/ast.h | 66 +++
src/glsl/ast_array_index.cpp| 13 +++
src/glsl/ast_to_hir.cpp | 172
src/glsl/ast_type.cpp | 8 +-
src/glsl
1 - 100 of 6672 matches
Mail list logo