Re: [Mesa-dev] Moving libglvnd to FreeDesktop Gitlab

On 9/25/19 11:05 AM, dani...@collabora.com wrote: Sorry for mangled phone formatting, but go to https://gitlab.freedesktop.org, follow the + menu to create a new project, select 'import' and then GitHub. On 25 Sep 2019 5:56 pm, Kyle Brenneman wrote: On 9/24/19 11:40 PM, Matt Turner

Re: [Mesa-dev] Moving libglvnd to FreeDesktop Gitlab

On 9/24/19 11:40 PM, Matt Turner wrote: On Wed, Sep 11, 2019 at 9:14 PM Kyle Brenneman wrote: On 9/9/19 12:07 PM, Adam Jackson wrote: On Wed, 2019-09-04 at 14:27 -0600, Kyle Brenneman wrote: On 9/4/19 8:44 AM, Daniel Stone wrote: Hi, On Wed, 4 Sep 2019 at 15:12, Chuck Atkins wrote: Can

Re: [Mesa-dev] Moving libglvnd to FreeDesktop Gitlab

On 9/9/19 12:07 PM, Adam Jackson wrote: On Wed, 2019-09-04 at 14:27 -0600, Kyle Brenneman wrote: On 9/4/19 8:44 AM, Daniel Stone wrote: Hi, On Wed, 4 Sep 2019 at 15:12, Chuck Atkins wrote: Can we use Gitlab's GitHub import feature? https://gitlab.freedesktop.org/help/user/project/import

Re: [Mesa-dev] Moving libglvnd to FreeDesktop Gitlab

On 9/4/19 8:44 AM, Daniel Stone wrote: Hi, On Wed, 4 Sep 2019 at 15:12, Chuck Atkins wrote: Can we use Gitlab's GitHub import feature? https://gitlab.freedesktop.org/help/user/project/import/github.md I haven't used it before but it looks like it will migrate everything, i.e. repo, issues,

Re: [Mesa-dev] Moving libglvnd to FreeDesktop Gitlab

On 9/1/19 2:46 PM, Eric Engestrom wrote: On 2019-09-01 at 20:56, Daniel Stone wrote: Hi, On Sat, 31 Aug 2019 at 20:34, Matt Turner wrote: Getting patches into libglvnd has proven quite difficult (see [0] for example). There was some talk of moving it to FreeDesktop Gitlab on IRC recently.

Re: [Mesa-dev] RFC - libglvnd and GLXVND vendor enumeration to facilitate GLX multi-vendor PRIME GPU offload

On 2/13/19 2:32 PM, Andy Ritger wrote: On Wed, Feb 13, 2019 at 12:15:02PM -0700, Kyle Brenneman wrote: On 02/12/2019 01:58 AM, Michel Dänzer wrote: On 2019-02-11 5:18 p.m., Andy Ritger wrote: On Mon, Feb 11, 2019 at 12:09:26PM +0100, Michel Dänzer wrote: On 2019-02-08 11:43 p.m., Kyle

Re: [Mesa-dev] RFC - libglvnd and GLXVND vendor enumeration to facilitate GLX multi-vendor PRIME GPU offload

On 02/12/2019 01:58 AM, Michel Dänzer wrote: On 2019-02-11 5:18 p.m., Andy Ritger wrote: On Mon, Feb 11, 2019 at 12:09:26PM +0100, Michel Dänzer wrote: On 2019-02-08 11:43 p.m., Kyle Brenneman wrote: Also, is Mesa the only client-side vendor library that works with the Xorg GLX module? I

Re: [Mesa-dev] RFC - libglvnd and GLXVND vendor enumeration to facilitate GLX multi-vendor PRIME GPU offload

On 02/11/2019 02:51 PM, Andy Ritger wrote: On Fri, Feb 08, 2019 at 03:43:25PM -0700, Kyle Brenneman wrote: On 2/8/19 2:33 PM, Andy Ritger wrote: On Fri, Feb 08, 2019 at 03:01:33PM -0500, Adam Jackson wrote: On Fri, 2019-02-08 at 10:19 -0800, Andy Ritger wrote: (1) If configured for PRIME

Re: [Mesa-dev] RFC - libglvnd and GLXVND vendor enumeration to facilitate GLX multi-vendor PRIME GPU offload

On 02/08/2019 11:19 AM, Andy Ritger wrote: (I'll omit EGL and Vulkan for the moment, for the sake of focus, and those APIs have programmatic ways to enumerate and select GPUs. Though, some of what we decide here for GLX we may want to leverage for other APIs.) Today, GLX implementations

Re: [Mesa-dev] RFC - libglvnd and GLXVND vendor enumeration to facilitate GLX multi-vendor PRIME GPU offload

On 2/8/19 2:33 PM, Andy Ritger wrote: On Fri, Feb 08, 2019 at 03:01:33PM -0500, Adam Jackson wrote: On Fri, 2019-02-08 at 10:19 -0800, Andy Ritger wrote: (1) If configured for PRIME GPU offloading (environment variable or application profile), client-side libglvnd could load the possible

Re: [Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

On 12/14/2018 07:04 AM, Emil Velikov wrote: There is no need for the noop functions, the public_stubs and public_entries table or table size defines. Remove those. Pretty much all of this is applicable to GLVND, although it requires preparatory work. v2: - python style fixes (Dylan) - use

Re: [Mesa-dev] [PATCH 04/18] mapi/new: import mapi scripts from glvnd

EVENT SHALL +# IBM AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +# FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS +# IN THE SOFTWARE. +# +# Authors: +#Kyle Brenneman + +import s

Re: [Mesa-dev] [PATCH mesa] egl: add missing glvnd entrypoint for EGL_ANDROID_blob_cache

On 11/14/2018 05:55 AM, Eric Engestrom wrote: Fixes dEQP-EGL.functional.get_proc_address.extension.egl_android_blob_cache on builds with glvnd enabled. Fixes: 6f5b57093b3462a54e9c7 "egl: add support for EGL_ANDROID_blob_cache" Signed-off-by: Eric Engestrom Reviewed-by: Tapani Pälli ---

Re: [Mesa-dev] [PATCH mesa 3/3] egl: remove dead code in glvnd dispatch generation code

On 11/07/2018 06:20 AM, Eric Engestrom wrote: g_egldispatchstubs.[ch] are completely identical before and after this patch. Signed-off-by: Eric Engestrom --- src/egl/generate/eglFunctionList.py | 203 +++ src/egl/generate/gen_egl_dispatch.py | 61 ++-- 2 files

Re: [Mesa-dev] [PATCH mesa 2/3] egl: fix python lib deprecation warning

On 11/07/2018 06:20 AM, Eric Engestrom wrote: DeprecationWarning: the imp module is deprecated in favour of importlib importlib is available since python 2.7 and 3.1, and we already require 2.7 and 3.4 so we can simply use the new lib. Signed-off-by: Eric Engestrom ---

Re: [Mesa-dev] [PATCH v2] egl/glvnd: correctly report errors when vendor cannot be found

ement the libglvnd interface for EGL (v3)") Cc: Kyle Brenneman Cc: Eric Engestrom Signed-off-by: Emil Velikov --- src/egl/main/egldispatchstubs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/egl/main/egldispatchstubs.c b/src/egl/main/egldispatchstubs.c index bfc3195c779..9

Re: [Mesa-dev] [PATCH 2/2] egl/glvnd: correctly report errors when vendor cannot be found

On 11/5/18 9:13 AM, Emil Velikov wrote: On Fri, 2 Nov 2018 at 22:09, Kyle Brenneman wrote: +if (vendor == NULL) { +// XXX: How can we end here with EGL_SUCCESS? +if (errorCode != EGL_SUCCESS) { +// Since we have no vendor, the follow-up eglGetError() call

Re: [Mesa-dev] [PATCH 2/2] egl/glvnd: correctly report errors when vendor cannot be found

, GLVND remembers the last vendor and calls back into it's eglGetError, although there's no guarantee to ever have had one. Piglit: tests/egl/spec/egl_ext_device_query Fixes: ce562f9e3fa ("EGL: Implement the libglvnd interface for EGL (v3)") Cc: Kyle Brenneman Cc: Eric Engestrom Signed-of

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

On 06/15/2018 11:41 AM, Dylan Baker wrote: Quoting Kyle Brenneman (2018-06-15 10:23:24) On 06/15/2018 10:46 AM, Dylan Baker wrote: Quoting Kyle Brenneman (2018-05-30 06:18:27) On 05/29/2018 12:04 PM, Adam Jackson wrote: On Tue, 2018-05-29 at 09:54 -0700, Dylan Baker wrote: Quoting Adam

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

On 06/15/2018 10:46 AM, Dylan Baker wrote: Quoting Kyle Brenneman (2018-05-30 06:18:27) On 05/29/2018 12:04 PM, Adam Jackson wrote: On Tue, 2018-05-29 at 09:54 -0700, Dylan Baker wrote: Quoting Adam Jackson (2018-05-29 06:50:46) GL_LIB expands to GLX_mesa, but applications should not link

[Mesa-dev] [PATCH] egl/glvnd: Fix a segfault in eglGetProcAddress.

If FindProcIndex in egldispatchstubs.c is called with a name that's less than the first entry in the array, it would end up trying to store an index of -1 in an unsigned integer, wrap around to 2^32, and then crash when it tries to look that up. Change FindProcIndex so that it uses bsearch(3)

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

On 05/29/2018 12:04 PM, Adam Jackson wrote: On Tue, 2018-05-29 at 09:54 -0700, Dylan Baker wrote: Quoting Adam Jackson (2018-05-29 06:50:46) GL_LIB expands to GLX_mesa, but applications should not link against that. -lGL is never wrong, just hardcode it. Actually There is this really

Re: [Mesa-dev] [PATCH 3/3] glx: Implement GLX_EXT_no_config_context (v4)

On 12/05/2017 02:22 PM, Adam Jackson wrote: This more or less ports EGL_KHR_no_config_context to GLX. v2: Enable the extension only for those backends that support it. v3: Fix glvnd path and dri2_convert_glx_attribs() v4: Screeching signedness correctness, and disable a now inappropriate

Re: [Mesa-dev] [PATCH 1/4] egl: simplify _eglDebugReport* API

On 09/15/2017 07:42 AM, Emil Velikov wrote: Hi Kyle, On 8 September 2017 at 13:09, Emil Velikov <emil.l.veli...@gmail.com> wrote: On 7 September 2017 at 19:21, Kyle Brenneman <kbrenne...@nvidia.com> wrote: On 09/07/2017 11:56 AM, Emil Velikov wrote: On 7 September 2017 at

Re: [Mesa-dev] [PATCH 1/4] egl: simplify _eglDebugReport* API

On 09/07/2017 11:56 AM, Emil Velikov wrote: On 7 September 2017 at 18:36, Kyle Brenneman <kbrenne...@nvidia.com> wrote: On 09/07/2017 10:03 AM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> Instead of having three, almost identical but not quite, _eg

Re: [Mesa-dev] [PATCH 1/4] egl: simplify _eglDebugReport* API

Former is identical to funcName, while the latter is already stored (yet unused) in _EGLThreadInfo::CurrentObjectLabel. Cc: Kyle Brenneman <kbrenne...@nvidia.com> Cc: Adam Jackson <a...@redhat.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/egl/main/eglapi.c

Re: [Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

On 05/17/2017 12:50 PM, Emil Velikov wrote: On 17 May 2017 at 17:05, Kyle Brenneman <kyle.brenne...@gmail.com> wrote: The patch assumes that glXGetDriverConfig will only ever be implemented by Mesa. As long as that's a safe assumption, the change looks right to me. Can you elaborate

Re: [Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

ent then any other dispatch function. This patch gets the job done, but I'm not really happy with how this patch turned out, suggestions for a better fix are welcome. Cc: Kyle Brenneman <kbrenne...@nvidia.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/glx/g_glxglv

Re: [Mesa-dev] Mesa (master): EGL: Implement the libglvnd interface for EGL (v3)

-3Dce562f9e3fab769d64b0e5453ec2b4f8710a31ce=DwIGaQ=uilaK90D4TOVoH58JNXRgQ=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA=Ds3k6rGGKUw1azY-6PwRSbT8_barIkKrpFEb5MgLHjM=4kQ3DN9Ehflpps_falc-HyFLfFgctDCTsD87JMnF4K8= Author: Kyle Brenneman <kbrenne...@nvidia.com> Date: Wed Jan 4 11:31:58 2017 -0700 EGL: Implement the li

[Mesa-dev] [PATCH] GLX: Generate the libglvnd dispatch stub functions.

This patch adds a script to generate the dispatch stubs for libglvnd, instead of using a manually-edited list of functions. This should avoid problems in the future with the stub lists getting out of sync or out of order. I put the scripts into a new src/generate/ directory, because there's some

Re: [Mesa-dev] [PATCH] glx/glvnd: Fix GLXdispatchIndex sorting

only that it never came. As you can imagine not cool... Sorry, but for me this was sort of a drive by patch and I don't really have time to work on a test for this. But it looks like ajax owes you a test-case for this, ajax ? Also Kyle Brenneman (added to the CC) who helped me pinpoint the issue

Re: [Mesa-dev] [PATCH] fixup! EGL: Implement the libglvnd interface for EGL (v2)

On 01/16/2017 02:32 PM, Adam Jackson wrote: On Thu, 2017-01-05 at 14:29 -0700, Kyle Brenneman wrote: --- src/egl/generate/eglFunctionList.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Adam Jackson <a...@redhat.com> Is this too invasive for 13.1?

Re: [Mesa-dev] [PATCH] fixup! EGL: Implement the libglvnd interface for EGL (v2)

I can if that's preferable. On 01/11/2017 04:24 PM, Timo Aaltonen wrote: On 05.01.2017 23:29, Kyle Brenneman wrote: --- src/egl/generate/eglFunctionList.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/egl/generate/eglFunctionList.py b/src/egl/generate

[Mesa-dev] [PATCH] fixup! EGL: Implement the libglvnd interface for EGL (v2)

--- src/egl/generate/eglFunctionList.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/egl/generate/eglFunctionList.py b/src/egl/generate/eglFunctionList.py index b19b5f7..80cb834 100644 --- a/src/egl/generate/eglFunctionList.py +++

Re: [Mesa-dev] [PATCH] EGL: Implement the libglvnd interface for EGL.

minimal. Other responses inline. On 09/12/2016 03:32 PM, Dylan Baker wrote: Quoting Kyle Brenneman (2016-09-12 11:59:32) Added separate --enable-libglvnd-glx and --enable-libglvnd-egl configure options to enable libglvnd for GLX and EGL. The existing --enable-libglvnd option will now enable both

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v3)

This looks right to me. -Kyle On 09/14/2016 07:59 AM, Adam Jackson wrote: From: Kyle Brenneman <kbrenne...@nvidia.com> This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

Note that the primary object can still be meaningful even on a function that's defined to never throw an error. Those functions could still send a WARN or INFO level message if they had reason to, just not a CRITICAL or ERROR level. Until any of those are added to Mesa, though, it's an

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v2)

On 09/13/2016 02:42 PM, Adam Jackson wrote: On Tue, 2016-09-13 at 14:14 -0600, Kyle Brenneman wrote: On 09/13/2016 11:57 AM, Adam Jackson wrote: @@ -37,7 +39,7 @@ /* This should be kept in sync with _eglInitThreadInfo() */ #define _EGL_THREAD_INFO_INITIALIZER \ - { EGL_SUCCESS

Re: [Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls (v2)

On 09/13/2016 11:57 AM, Adam Jackson wrote: From: Kyle Brenneman <kbrenne...@nvidia.com> This decorates every EGL entrypoint with _EGL_FUNC_START, which records the function name and primary dispatch object label in the current thread state. It also adds debug report functions and call

Re: [Mesa-dev] [PATCH 14/14] egl: Implement EGL_KHR_debug

wrote: From: Kyle Brenneman <kbrenne...@nvidia.com> Wire up the debug entrypoints to EGL dispatch, and add the extension string to the client extension list. --- src/egl/main/eglapi.c | 140 ++ src/egl/main/eglglobals.c | 3 +- 2 files

Re: [Mesa-dev] [PATCH 08/14] egl: Factor out _eglCreateImageCommon

On 09/12/2016 04:19 PM, Adam Jackson wrote: From: Kyle Brenneman <kbrenne...@nvidia.com> --- src/egl/main/eglapi.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index a74e5e4..658d0d7 100644 --- a/s

[Mesa-dev] [PATCH] fixup! EGL: Implement the libglvnd interface for EGL.

Remove a couple of leftover hacks in the previous libglvnd patch. --- src/egl/main/egldispatchstubs.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/egl/main/egldispatchstubs.c b/src/egl/main/egldispatchstubs.c index 212a1fd..e02abd7 100644 ---

Re: [Mesa-dev] [PATCH 2/7] EGL: Implement eglLabelObjectKHR

On 09/09/2016 04:27 AM, Emil Velikov wrote: On 8 September 2016 at 18:46, Adam Jackson <a...@redhat.com> wrote: From: Kyle Brenneman <kbrenne...@nvidia.com> Added a label to the _EGLThreadInfo, _EGLDisplay, and EGLResource structs. Implemented the function eglLabelObjectKHR.

Re: [Mesa-dev] [PATCH 1/7] EGL: Update eglext.h

wrote: From: Kyle Brenneman <kbrenne...@nvidia.com> Updated eglext.h to revision 32074 from the Khronos repository. Added two #includes to egltypedefs.h. Both were in the previous version of eglext.h but not in the new one. -#include -#include - AFAICT neither of these was in the upstr

[Mesa-dev] [PATCH] EGL: Fix some errors in eglDebugMessageControlKHR.

Check if the attribute list is valid even if the callback is NULL. Set the callback pointer whether or not the attribute list is NULL. --- src/egl/main/eglapi.c | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 3/7] EGL: Implement remaining functions from EGL_KHR_debug

fix that and send out an updated patch if you like, or if it's easier, I can add a commit to the end of this list. -Kyle On 09/08/2016 11:46 AM, Adam Jackson wrote: From: Kyle Brenneman <kbrenne...@nvidia.com> Implemented eglDebugMessageControlKHR and eglQueryDebugKHR. Added e

Re: [Mesa-dev] [PATCH 4/6] EGL: Call the EGL_KHR_debug callback on errors.

The patch also changes _eglDebugReport so that it calls _eglInternalError at the end instead of _eglError. -Kyle On 09/06/2016 01:53 PM, Adam Jackson wrote: On Wed, 2016-07-06 at 10:33 -0600, Kyle Brenneman wrote: @@ -292,6 +292,24 @@ _eglError(EGLint errCode, const char *msg) return

Re: [Mesa-dev] [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3)

On 09/06/2016 05:29 AM, Emil Velikov wrote: * Interaction of ^^ with EGL device extension(s) - update existing extensions/introduce new ones ** Should EGL_EXT_device_enumeration expose one/multiple SW devices - no: we need alternative glvnd EGL interface for such cases - yes: implementing

[Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts.

Only keep track of a single current context, instead of separate contexts for GL and GLES. In EGL 1.4 (and 1.5), EGL_OPENGL_API and EGL_OPENGL_ES_API are supposed to be interchangeable for all purposes except for eglCreateContext. The _EGLThreadInfo::CurrentContexts array is now a single pointer

[Mesa-dev] [PATCH 5/6] EGL: Record the debug object label in _EGLThreadInfo.

Added a field to _EGLThreadInfo to hold the object label for the current EGL function call. Changed the _EGL_FUNC_START macro and _eglSetFuncName function to take an object type enum and an _EGLResource pointer, which it uses to fill in the object label. Removed the command name and object label

[Mesa-dev] [PATCH 2/6] EGL: Implement eglLableObjectKHR.

Added a label to the _EGLThreadInfo, _EGLDisplay, and EGLResource structs. Implemented the function eglLabelObjectKHR. --- src/egl/main/eglapi.c | 64 +++ src/egl/main/eglcurrent.c | 10 src/egl/main/eglcurrent.h | 5

[Mesa-dev] [PATCH 3/6] EGL: Implement remaining functions from EGL_KHR_debug.

Implemented eglDebugMessageControlKHR and eglQueryDebugKHR. Added entries in _egl_global to hold the debug callback and the set of enabled message types. Added a _eglDebugReport function to report a debug message, plus some macros for each of the message types. Still to do is to relace existing

[Mesa-dev] [PATCH 1/6] EGL: Update eglext.h.

Updated eglext.h to revision 32074 from the Khronos repository. Added two #includes to egltypedefs.h. Both were in the previous version of eglext.h but not in the new one. --- include/EGL/eglext.h | 36 ++-- src/egl/main/egltypedefs.h | 2 ++ 2 files

[Mesa-dev] [PATCH 4/6] EGL: Call the EGL_KHR_debug callback on errors.

Added a member to _EGLThreadInfo to hold the name of the current EGL function. Each EGL entrypoint will now set that at the beginning. _eglError will now call the debug callback function, using the function name stored in the current _EGLThreadInfo struct. This should allow the EGL_KHR_debug

[Mesa-dev] EGL: Implement EGL_KHR_debug

This is a set of patches to implement the EGL_KHR_debug extension. In addition to hopefully being useful in its own right, the current draft of the libglvnd interface for EGL requires each vendor library to support EGL_KHR_debug. The same functions should work for both a normal and libglvnd-based

[Mesa-dev] [PATCH 6/6] EGL: Fix some command names for EGL_KHR_debug.

Change a few EGL entrypoints to call a common internal function instead of forwarding to another entrypoint. If one EGL entrypoint calls another, then the second entrypoint would overwrite the current function name in the _EGLThreadInfo struct. That would cause it to pass the wrong function name

Re: [Mesa-dev] [PATCH 2/3] glx/glvnd: Use strcmp() based binary search in FindGLXFunction()

That binary search needs to set middle inside the while loop, not just once at the top. Also, I think that should be "last = middle - 1", not "last = middle". -Kyle On 05/11/2016 12:01 PM, Adam Jackson wrote: From: Emil Velikov It will allows us to find the

Re: [Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

On 05/12/2016 12:58 PM, Emil Velikov wrote: Hi all, On 11 May 2016 at 19:53, Kyle Brenneman <kbrenne...@nvidia.com> wrote: In the GLX dispatch functions, it should be safe to ignore a failed call to AddDrawableMapping. If it can't update the drawable-to-vendor hashtable at that

Re: [Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

, if AddFBConfigsMapping fails, should it use free or XFree to free the memory? -Kyle On 05/11/2016 12:01 PM, Adam Jackson wrote: From: Kyle Brenneman <kbrenne...@nvidia.com> With reference to the libglvnd branch: https://cgit.freedesktop.org/mesa/mesa/log/?h=libglvnd This is a squashed commit containi

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

On 03/14/2016 11:43 AM, Martin Peres wrote: On 14/03/16 19:16, Kyle Brenneman wrote: On 03/11/2016 05:25 PM, Martin Peres wrote: On 10/03/16 20:07, Adam Jackson wrote: On Thu, 2016-03-10 at 10:53 -0700, Kyle Brenneman wrote: On 03/10/2016 10:47 AM, Martin Peres wrote: That could

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

On 03/11/2016 05:25 PM, Martin Peres wrote: On 10/03/16 20:07, Adam Jackson wrote: On Thu, 2016-03-10 at 10:53 -0700, Kyle Brenneman wrote: On 03/10/2016 10:47 AM, Martin Peres wrote: That could be a hacky way of handling the case where multiple 3D drivers could be used to drive the same

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

a client can already find the screen number for a GLXFBConfig using glXGetVisualFromFBConfig and indirectly using glXGetFBConfigs. Revision History 1. 8 March 2016 - Initial draft. On 03/09/2016 12:53 PM, Kyle Brenneman wrote: On 03/09/2016 12:21 PM, Adam Jackson

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

On 03/10/2016 10:47 AM, Martin Peres wrote: On 09/03/16 20:15, Kyle Brenneman wrote: The current implementation of libglvnd uses a new X extension called x11glvnd to look up a vendor name for each screen and to find a screen number for a GLXDrawable. But, Adam Jackson pointed out that a GLX

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

On 03/09/2016 12:53 PM, Kyle Brenneman wrote: On 03/09/2016 12:21 PM, Adam Jackson wrote: On Wed, 2016-03-09 at 11:15 -0700, Kyle Brenneman wrote: The current implementation of libglvnd uses a new X extension called x11glvnd to look up a vendor name for each screen and to find a screen number

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

On 03/09/2016 12:21 PM, Adam Jackson wrote: On Wed, 2016-03-09 at 11:15 -0700, Kyle Brenneman wrote: The current implementation of libglvnd uses a new X extension called x11glvnd to look up a vendor name for each screen and to find a screen number for a GLXDrawable. But, Adam Jackson pointed

[Mesa-dev] GLX extension for vendor name lookup in libglvnd

, or suggestions are welcome, of course. -Kyle Name EXT_libglvnd Name Strings GLX_EXT_libglvnd Contact Kyle Brenneman, NVIDIA, kbrenneman at nvidia.com Contributors Kyle Brenneman Adam Jackson Status XXX - Not complete yet Version Last Modified Date: March 8, 2016

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 11/13/2015 12:50 PM, Kyle Brenneman wrote: On 10/08/2015 12:29 PM, Emil Velikov wrote: On 06/10/15 20:58, Kyle Brenneman wrote: On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman<kbrenne...@nvidia.com> wrote: On 10/06/2015 07:34 AM, Emil Velikov

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 11/24/2015 02:49 PM, Emil Velikov wrote: On 24 November 2015 at 20:22, Kyle Brenneman <kbrenne...@nvidia.com> wrote: On 11/13/2015 12:50 PM, Kyle Brenneman wrote: I agree that a separate directory from the other GL headers would be best. I'm leaning toward putting the libglvnd h

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 10/08/2015 12:29 PM, Emil Velikov wrote: On 06/10/15 20:58, Kyle Brenneman wrote: On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman <kbrenne...@nvidia.com> wrote: On 10/06/2015 07:34 AM, Emil Velikov wrote: Hello Kyle, A few questions/

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 10/08/2015 08:44 PM, Michel Dänzer wrote: On 07.10.2015 04:58, Kyle Brenneman wrote: On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman <kbrenne...@nvidia.com> wrote: On 10/06/2015 07:34 AM, Emil Velikov wrote: * The existing x11glvnd extension

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 10/08/2015 12:29 PM, Emil Velikov wrote: On 06/10/15 20:58, Kyle Brenneman wrote: On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman <kbrenne...@nvidia.com> wrote: On 10/06/2015 07:34 AM, Emil Velikov wrote: Hello Kyle, A few questions/

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman <kbrenne...@nvidia.com> wrote: On 10/06/2015 07:34 AM, Emil Velikov wrote: Hello Kyle, A few questions/points of discussion: * What is your take on having a libglvnd 'package', which pr

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 10/06/2015 07:34 AM, Emil Velikov wrote: Hello Kyle, A few questions/points of discussion: * What is your take on having a libglvnd 'package', which provides the headers (and maybe other materials), apart from the libraries ? I'm basically thinking about OpenGL.h, GLX.h, etc for programs

[Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

compatibility. Comments, questions, and suggestions are all welcome. Thanks, -Kyle Brenneman ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] glx: Fix build errors with --enable-mangling.

On 09/28/2015 11:26 AM, Emil Velikov wrote: Hi Kyle, On 24 September 2015 at 23:22, Kyle Brenneman <kbrenne...@nvidia.com> wrote: Rearranged the GLX_ALIAS macro in glextensions.h so that it will pick up the renames from glx_mangle.h. Fixed the alias attribute for glXGetProcAddres

[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

onf builds will work. v3: Fix the library filename in the Makefile. Signed-off-by: Kyle Brenneman <kbrenne...@nvidia.com> Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> Cc: "10.6 11.0" <mesa-sta...@lists.freedesktop.org> --- src/glx/Makefile.am | 1 + src/glx/dri_c

[Mesa-dev] [PATCH 1/2] glx: Fix build errors with --enable-mangling (v2)

/show_bug.cgi?id=2 Signed-off-by: Kyle Brenneman <kbrenne...@nvidia.com> Cc: "10.6 11.0" <mesa-sta...@lists.freedesktop.org> --- src/glx/glxcmds.c | 4 src/glx/glxextensions.h | 10 -- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/g

[Mesa-dev] [PATCH 2/2] mapi: Make _glapi_get_stub work with "gl" or "mgl" prefix.

hat starts with the normal "gl" prefix. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=2 Signed-off-by: Kyle Brenneman <kbrenne...@nvidia.com> Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> Cc: "10.6 11.0" <mesa-sta...@lists.freedesktop.org>

Re: [Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

On 09/28/2015 11:33 AM, Emil Velikov wrote: Hi Kyle, On 25 September 2015 at 21:01, Kyle Brenneman <kbrenne...@nvidia.com> wrote: Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDrive

[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver.

Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding "libGL.so.1". --- src/glx/Makefile.am | 1 + src/glx/dri_common.c | 2 +- 2 files changed,

[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding "libGL.so.1". v2: Add an #ifndef/#define for GL_LIB_NAME so that non-autoconf builds will

Re: [Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v2)

On 09/25/2015 11:58 AM, Ilia Mirkin wrote: On Fri, Sep 25, 2015 at 1:47 PM, Kyle Brenneman <kbrenne...@nvidia.com> wrote: Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDrive

[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v2)

Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding "libGL.so.1". v2: Add an #ifndef/#define for GL_LIB_NAME so that non-autoconf builds will

[Mesa-dev] [PATCH 2/2] mapi: Make _glapi_get_stub work with "gl" or "mgl" prefix.

When USE_MGL_NAMESPACE is defined, _glapi_get_stub will check for the "m" prefix before trying to skip it, so that "glFoo" and "mglFoo" are equivalent. This should let it work with all the places where something calls _glapi_get_proc_offset with a hard-coded name that starts with the normal "gl"

[Mesa-dev] [PATCH 1/2] glx: Fix build errors with --enable-mangling.

Rearranged the GLX_ALIAS macro in glextensions.h so that it will pick up the renames from glx_mangle.h. Fixed the alias attribute for glXGetProcAddress when USE_MGL_NAMESPACE is defined. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=2 --- src/glx/glxcmds.c | 4