Re: [Mesa-dev] Etnaviv on mesa master vs. Array._DrawVAO

> I'm looking into forward porting laanwj's patches for GC7000 support to > current mesa master. Luckily most of it already got merged last November > with mostly only the texture descriptor support missing( > https://github.com/laanwj/mesa/commit/b71802207432543745dff471c68fbc40495b4858) > >

Re: [Mesa-dev] [PATCH 5/7] gallium: add PIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER{S, _BUFFERS}

be able to use hw-atomics for some stages and not for > other, if needed. > > Signed-off-by: Erik Faye-Lund Etnaviv part Reviewed-by: Wladimir J. van der Laan > diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c > b/src/gallium/drivers/etnaviv/etnaviv_screen.c > index 108b9

Re: [Mesa-dev] [PATCH 4/7] gallium: add PIPE_CAP_MAX_COMBINED_SHADER_BUFFERS

by: Erik Faye-Lund Etnaviv part Reviewed-by: Wladimir J. van der Laan > diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c > b/src/gallium/drivers/etnaviv/etnaviv_screen.c > index 9669bd2f60..108b97d35c 100644 > --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c >

Re: [Mesa-dev] [PATCH v3 0/8] freedreno: a2xx improvements

> Patchset looks reasonable to me, from a quick look. Testing a22x > isn't so easy without resurrecting an ancient downstream kernel for > old snadragon devices, so I think it is ok to ignore that. If the Do you mean: - try to keep supporting a22x on best-effort basis by providing fallback

[Mesa-dev] [PATCH v3 6/8] freedreno: a2xx: Compressed textures support

Add support for: - PIPE_FORMAT_ETC1_RGB8 - PIPE_FORMAT_DXT1_RGB - PIPE_FORMAT_DXT1_RGBA - PIPE_FORMAT_DXT3_RGBA - PIPE_FORMAT_DXT5_RGBA Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> --- src/gallium/drivers/freedreno/a2x

[Mesa-dev] [PATCH v3 5/8] freedreno: a2xx: Support TEXTURE_RECT

Denormalized texture coordinates are required for text rendering in GALLIUM_HUD. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++- src/gallium/drivers/freedreno/a2

[Mesa-dev] [PATCH v3 8/8] freedreno: a2xx: Implement DP2 instruction

Use DOT2ADDv instruction with 0.0f constant add. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 + 1 file changed, 21 insertions(+) Change sinc

[Mesa-dev] [PATCH v3 3/8] freedreno: a2xx: Fix fd2_tex_swiz

Compose swizzles using util_format_compose_swizzles instead of the custom code (which somehow had a bug). This makes the GL_ALPHA internal format work. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> --- src/gallium/drive

[Mesa-dev] [PATCH v3 7/8] freedreno: a2xx: implement SEQ/SNE instructions

Extend translate_sge_slt to emit these, in analogous fashion but using CNDEv. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 --- 1 file

[Mesa-dev] [PATCH v3 2/8] freedreno: a2xx: Change use of BLEND_ to BLEND2_

Change use of BLEND_ to BLEND2_, BLEND_* a3xx_rb_blend_opcode BLEND2_* is a2xx_rb_blend_opcode This makes no effective difference as the used enumerant has the same value (0), but the other enumerants do not match 1-to-1 so this will avoid future problems. Signed-off-by: Wladimir J. van

[Mesa-dev] [PATCH v3 0/8] freedreno: a2xx improvements

7,8 Wladimir J. van der Laan (8): freedreno: a2xx: Update rnndb header for formats enumeration freedreno: a2xx: Change use of BLEND_ to BLEND2_ freedreno: a2xx: Fix fd2_tex_swiz freedreno: a2xx: Prevent crash in emit_texture if view is not set freedreno: a2xx: Support TEXTURE_R

[Mesa-dev] [PATCH v3 4/8] freedreno: a2xx: Prevent crash in emit_texture if view is not set

Textures will sometimes be updated if texture view state was un-set, without this change that causes an assertion crash or segfault. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> --- src/gallium/drivers/freedreno/a2xx/fd2

[Mesa-dev] [PATCH v3 1/8] freedreno: a2xx: Update rnndb header for formats enumeration

The format enumeration comes comes from the yamoto register headers that are part of the amd-gpu kernel driver. (see freedreno envytools commit 1b32c444f82cd7144d71602106462f59f146c1d0) Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Ilia Mirkin <imir...@alu

Re: [Mesa-dev] [PATCH v2 0/8] freedreno: a2xx improvements

On Thu, Mar 22, 2018 at 11:46:57AM -0400, Ilia Mirkin wrote: > With the minor whitespace issue I pointed out (which might also apply > to 8/8, couldn't tell), this is Looks like there is also a case in 5/8, will go over them and resubmit the ones with wacky spacing. (I think the issue here is

[Mesa-dev] [PATCH v2 8/8] freedreno: a2xx: Implement DP2 instruction

Use DOT2ADDv instruction with 0.0f constant add. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_compiler.c

[Mesa-dev] [PATCH v2 6/8] freedreno: a2xx: Compressed textures support

Add support for: - PIPE_FORMAT_ETC1_RGB8 - PIPE_FORMAT_DXT1_RGB - PIPE_FORMAT_DXT1_RGBA - PIPE_FORMAT_DXT3_RGBA - PIPE_FORMAT_DXT5_RGBA Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++ 1 file changed, 11 inse

[Mesa-dev] [PATCH v2 2/8] freedreno: a2xx: Change use of BLEND_ to BLEND2_

Change use of BLEND_ to BLEND2_, BLEND_* a3xx_rb_blend_opcode BLEND2_* is a2xx_rb_blend_opcode This makes no effective difference as the used enumerant has the same value (0), but the other enumerants do not match 1-to-1 so this will avoid future problems. Signed-off-by: Wladimir J. van

[Mesa-dev] [PATCH v2 5/8] freedreno: a2xx: Support TEXTURE_RECT

Denormalized texture coordinates are required for text rendering in GALLIUM_HUD. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 + src/gallium/drivers/freedren

[Mesa-dev] [PATCH v2 7/8] freedreno: a2xx: implement SEQ/SNE instructions

Extend translate_sge_slt to emit these, in analogous fashion but using CNDEv. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/g

[Mesa-dev] [PATCH v2 1/8] freedreno: a2xx: Update rnndb header for formats enumeration

The format enumeration comes comes from the yamoto register headers that are part of the amd-gpu kernel driver. (see freedreno envytools commit 1b32c444f82cd7144d71602106462f59f146c1d0) Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/a2xx

[Mesa-dev] [PATCH v2 4/8] freedreno: a2xx: Prevent crash in emit_texture if view is not set

Textures will sometimes be updated if texture view state was un-set, without this change that causes an assertion crash or segfault. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 13 ++--- 1 file changed, 10 inse

[Mesa-dev] [PATCH v2 0/8] freedreno: a2xx improvements

stack. Changes since first post: - Split up rnndb patch into a patch that changes formate numeration and one that changed BLEND->BLEND2. - fd2_emit emit_texture const correctness. I checked that there is no Gallium capability to be set for TEXTURE_RECT. Wladimir J. van der Laan (8): freedr

[Mesa-dev] [PATCH v2 3/8] freedreno: a2xx: Fix fd2_tex_swiz

Compose swizzles using util_format_compose_swizzles instead of the custom code (which somehow had a bug). This makes the GL_ALPHA internal format work. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +-

Re: [Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

Hello Ilia, On Thu, Jan 25, 2018 at 08:41:11AM -0500, Ilia Mirkin wrote: > Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's > called... I forget.) I checked and I don't think a capability exists for this (anymore?). Everywhere, the assumption is meant that all Gallium

Re: [Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

On Thu, Jan 25, 2018 at 08:41:11AM -0500, Ilia Mirkin wrote: > Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's > called... I forget.) Yes, good point, will add that. Wladimir ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [Freedreno] [PATCH 1/7] freedreno: a2xx: Update rnndb header

On Thu, Jan 25, 2018 at 08:40:00AM -0500, Ilia Mirkin wrote: > On Thu, Jan 25, 2018 at 8:29 AM, Wladimir J. van der Laan > <laa...@gmail.com> wrote: > > Also update BLEND_ to BLEND2_ opcodes to accomodate. > > Are you saying this doesn't compile right now? I would have exp

[Mesa-dev] [PATCH 6/7] freedreno: a2xx: implement SEQ/SNE instructions

Extend translate_sge_slt to emit these, in analogous fashion but using CNDEv. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/g

[Mesa-dev] [PATCH 7/7] freedreno: a2xx: Implement DP2 instruction

Use DOT2ADDv instruction with 0.0f constant add. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_compiler.c

[Mesa-dev] [PATCH 2/7] freedreno: a2xx: Fix fd2_tex_swiz

Compose swizzles using util_format_compose_swizzles instead of the custom code (which somehow had a bug). This makes the GL_ALPHA internal format work. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +-

[Mesa-dev] [PATCH 3/7] freedreno: a2xx: Prevent crash in emit_texture if view is not set

Textures will sometimes be updated if texture view state was un-set, without this change that causes an assertion crash or segfault. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 11 +-- 1 file changed, 9 insertions

[Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

Denormalized texture coordinates are required for text rendering in GALLIUM_HUD. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 + src/gallium/drivers/freedren

[Mesa-dev] [PATCH 5/7] freedreno: a2xx: Compressed textures support

Add support for: - PIPE_FORMAT_ETC1_RGB8 - PIPE_FORMAT_DXT1_RGB - PIPE_FORMAT_DXT1_RGBA - PIPE_FORMAT_DXT3_RGBA - PIPE_FORMAT_DXT5_RGBA Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++ 1 file changed, 11 inse

[Mesa-dev] [PATCH 1/7] freedreno: a2xx: Update rnndb header

Also update BLEND_ to BLEND2_ opcodes to accomodate. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/freedreno/a2xx/a2xx.xml.h | 33 +++ src/gallium/drivers/freedreno/a2xx/fd2_gmem.c | 4 ++-- 2 files changed, 15 insertions(

[Mesa-dev] [PATCH 0/7] freedreno: a2xx improvements

stack. Wladimir J. van der Laan (7): freedreno: a2xx: Update rnndb header freedreno: a2xx: Fix fd2_tex_swiz freedreno: a2xx: Prevent crash in emit_texture if view is not set freedreno: a2xx: Support TEXTURE_RECT freedreno: a2xx: Compressed textures support freedreno: a2xx: implement SEQ

[Mesa-dev] [PATCH v3 10/15] etnaviv: GC7000: State changes for HALTI3..5

Update state objects to add new state, and emit function to emit new state. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 249 +++--

Re: [Mesa-dev] [PATCH v2 12/17] etnaviv: GC7000: State changes for HALTI3..5

Hello Christian, On Sat, Nov 25, 2017 at 05:10:36PM +0100, Christian Gmeiner wrote: > 2017-11-18 10:44 GMT+01:00 Wladimir J. van der Laan <laa...@gmail.com>: > > Update state objects to add new state, and emit function to emit new > > state. > > > > Signed-off-

Re: [Mesa-dev] [PATCH] etnaviv: Emit vertex buffers consecutively

On Thu, Nov 23, 2017 at 10:37:15AM +0100, Lucas Stach wrote: > Am Donnerstag, den 23.11.2017, 10:08 +0100 schrieb Wladimir J. van der Laan: > > Vertex buffer legacy state is no longer picked up with new drawing > > commands. Change to use different cases depending on the numbe

[Mesa-dev] [PATCH] etnaviv: Emit vertex buffers consecutively

Vertex buffer legacy state is no longer picked up with new drawing commands. Change to use different cases depending on the number of vertex streams in the GPU specs. This results in slightly more compact state emission as well, on all vivantes. This needs to go in before "etnaviv: Use only

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

> Can confirm that this completely breaks rendering on GC3000. > > I don't know how this happened, I'm sure I tested this before :( maybe > with a slightly different version of the patch stack. Solved! Etnaviv is emitting vertex stream attributes in an unconvential way: - Write vertex stream

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

On Wed, Nov 22, 2017 at 07:29:18PM +0100, Wladimir J. van der Laan wrote: > > > I would really like to know what's wrong with this patch, as using the > > new draw command should be fine on GC3000 and we certainly want to > > support instanced drawing at some point. &g

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

> I would really like to know what's wrong with this patch, as using the > new draw command should be fine on GC3000 and we certainly want to > support instanced drawing at some point. Did you also apply the "etnaviv: Emit SCALE for vertex attributes" patch? If so maybe there's something wrong

Re: [Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

Hello Lucas, On Wed, Nov 22, 2017 at 02:29:33PM +0100, Lucas Stach wrote: > Hi Wladimir, > > Am Samstag, den 18.11.2017, 10:44 +0100 schrieb Wladimir J. van der Laan: > > The blob does this, as DRAW_INSTANCED can replace fully all the other > > draw commands. It is al

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

On Thu, Nov 16, 2017 at 01:38:32PM -0500, Ilia Mirkin wrote: > > Which is annoying as it means that shader state now depends on either the > > kind > > of primitive (which is per-draw), or the shading model (which is part of > > rasterizer state). > > I take it your hardware doesn't support

[Mesa-dev] [PATCH v2 17/17] etnaviv: GC7000: Factor out state based texture functionality

Prepare for two texture handling paths, the descriptor-based path will be added in a future commit. These are structured so that the texture implementation handles its own state emission. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <chris

[Mesa-dev] [PATCH v2 16/17] etnaviv: GC7000: Move active_samplers_bits to texture

This needs to be shared between texture_plain and texture_desc. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c| 12 src/gallium/dri

[Mesa-dev] [PATCH v2 12/17] etnaviv: GC7000: State changes for HALTI3..5

Update state objects to add new state, and emit function to emit new state. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 246 +++--

[Mesa-dev] [PATCH v2 05/17] etnaviv: GC7000: Support BLT as recipient for etna_stall

When the BLT is involved as source or target, add an extra BLT enable/disable sequence around the sync sequence. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 15 ++- 1 file changed, 14 insertions(+), 1 de

[Mesa-dev] [PATCH v2 15/17] etnaviv: GC7000: Factor out incompatible texture handling logic

This will be shared with the texture descriptor path. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_texture.c | 42 +-- src/gallium/dri

[Mesa-dev] [PATCH v2 10/17] etnaviv: GC7000: Update context reset for ..HALTI5

Update context reset for HALTI3..HALTI5, sorting states for the HALTI version that has them. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_co

[Mesa-dev] [PATCH v2 13/17] etnaviv: GC7000: Make point sprites work on HALTI5

Track varying component offset of the point size output, as well as provide the offset of the point coord input. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_com

[Mesa-dev] [PATCH v2 09/17] etnaviv: GC7000: No RS align when using BLT

RS align is not necessary and might even be harmful when using the BLT engine for blitting. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 15 +

[Mesa-dev] [PATCH v2 14/17] etnaviv: GC7000: Track dirty sampler views

Need this to efficiently emit texture descriptor invalidations. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_context.c | 1 + src/gallium/drivers/etnaviv/etnaviv_c

[Mesa-dev] [PATCH v2 08/17] etnaviv: GC7000: BLT engine blitting support

Add an implemenation of key clear_blit functions using the BLT engine that replaced the RS on GC7000. Also set level->size correctly for imported resources. This is important for the BLT resolve-in-place path to work for them. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com>

[Mesa-dev] [PATCH v2 11/17] etnaviv: GC7000: Update screen specs for HALTI5

- This core must load shaders from memory (AFAIK) - Yet another new location for UNIFORMS Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 +++

[Mesa-dev] [PATCH v2 02/17] etnaviv: Put HALTI level in specs

The HALTI level is an indication of the gross architecture of the GPU. It determines for significant part what feature level the GPU has, what state (especially frontend state) is there, and where it is located. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Chr

[Mesa-dev] [PATCH v2 03/17] etnaviv: Emit SCALE for vertex attributes

This is used by HALTI2+ (GC3000+) when drawing with DRAW_INSTANCED. It is also necessary when switching between integer and floating point vertex element formats. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com&

[Mesa-dev] [PATCH v2 07/17] etnaviv: GC7000: Factor out RS blit functionality

Prepare for BLT-based blitting path by moving RS-based blitting to the RS implementation file, making this self-contained. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 558 +-- src/gallium/drivers/e

[Mesa-dev] [PATCH v2 00/17] etnaviv: GC7000 preparation

using the Vivante kernel driver. If you want to see etnaviv_texture_desc.c in its current state, it's here: https://github.com/laanwj/mesa/blob/gc7000/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c Wladimir J. van der Laan (17): etnaviv: Const-correctness etnaviv_emit.h etnaviv: Put HALTI

[Mesa-dev] [PATCH v2 06/17] etnaviv: GC7000: Move etna_coalesce to emit header file

Want to be able to emit state from the texture implementation, and the blitter implementation. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv

[Mesa-dev] [PATCH v2 01/17] etnaviv: Const-correctness etnaviv_emit.h

The relocation structure is never changed by submitting it. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emi

[Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

this changes the behavior for GC3000-, by no longer using the index offset for DRAW_INDEXED but instead adding it to INDEX_ADDR. This should make no difference. Preparation for GC7000 support. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Philipp Zabel <p.za...@pengu

Re: [Mesa-dev] [PATCH] etnaviv: enable full overwrite when no color buffer is present

On Wed, Nov 15, 2017 at 05:33:17PM +0100, Lucas Stach wrote: > The OVERWRITE bit disables destination fetches, which is exactly what > we want when there is no valid color buffer bound. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J.

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

On Thu, Nov 16, 2017 at 12:26:05PM -0500, Ilia Mirkin wrote: > On Thu, Nov 16, 2017 at 7:15 AM, Wladimir wrote: > The point of the texcoord semantics is precisely point sprite > replacement. NVIDIA hardware (Fermi+) can only do point sprite > replacement on certain

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

> Sorry for noticing before, but this breaks glmark2 texture. I didn't > yet dig into the issue but it's definitely caused by this commit. > > To reproduce, simply run > glmark2-es2-drm -b texture:texture-filter=mipmap That's weird, as that neither uses point sprites nor flat shading. I'll have

[Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

: fix varying interpolation" Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c b/src/gallium

[Mesa-dev] [PATCH v2 1/5] etnaviv: rnndb update

Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/hw/common.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/common_3d.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/state.xml

[Mesa-dev] [PATCH v2 5/5] etnaviv: Add sampler TS support

when not using sampler TS, as resolve-in-place will now be skipped if a resource has no (valid) TS. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c| 26 +++

[Mesa-dev] [PATCH v2 2/5] etnaviv: Check that resource has a valid TS in etna_resource_needs_flush

Resources only need a resolve-to-itself if their TS is valid for any level, not just if it happens to be allocated. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 13 + src/gallium/drivers/etnaviv/etnaviv_reso

[Mesa-dev] [PATCH v2 4/5] etnaviv: Flush TS cache before changing TS configuration

This is to make sure that the TS is properly flushed to memory before rendering to a new surface starts. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH v2 0/5] etnaviv: Add sampler TS support

to a new surface starts). This should prevent missing tile artifacts. - Remove unused added arguments from etna_update_sampler_source / etna_configure_sampler_ts / etna_can_use_sampler_ts Wladimir J. van der Laan (5): etnaviv: rnndb update etnaviv: Check that resource has a valid TS

[Mesa-dev] [PATCH v2 3/5] etnaviv: Add TS_SAMPLER formats to etnaviv_format

Sampler TS introduces yet another format enumeration for renderable+textureable formats. Introduce it into the etnaviv_format table as another column. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_format.c

Re: [Mesa-dev] [PATCH v2] etnaviv: automake, meson: include common_3d.xml.h in the sources lists

gt; Thanks for updating the build systems. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > Wladimir, Christian: while looking at f1e1c60ff6, I noticed > state_blt.xml.h and texdesc_3d.xml.h were also added, but don't seem to > be used anywhere; were those files adde

Re: [Mesa-dev] [PATCH 3/3] etnaviv: Add sampler TS support

On Fri, Nov 10, 2017 at 07:42:12AM +0100, Wladimir J. van der Laan wrote: > Hello Lucas, > > On Thu, Nov 09, 2017 at 06:15:51PM +0100, Lucas Stach wrote: > > Hi Wladimir! > > > > etna_resource_needs_flush is only called from two places - here, and > > &

Re: [Mesa-dev] [PATCH 3/3] etnaviv: Add sampler TS support

Hello Lucas, On Thu, Nov 09, 2017 at 06:15:51PM +0100, Lucas Stach wrote: > Hi Wladimir! > > etna_resource_needs_flush is only called from two places - here, and > > in resource_flush, where it also determines whether to do a > > resolve-to-self, but before presenting the image. There it also

[Mesa-dev] [PATCH 1/3] etnaviv: rnndb update

Update rnndb to etna_viv 07c756a. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/hw/common.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/common_3d.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/state.xml.h | 4 ++-- src/gallium/d

[Mesa-dev] [PATCH 2/3] etnaviv: Add TS_SAMPLER formats to etnaviv_format

Sampler TS introduces yet another format enumeration for renderable formats. Introduce it into etnaviv_format as unobtrusively as possible. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_format.c | 19 +++ src/gallium/d

[Mesa-dev] [PATCH 0/3] etnaviv: Add sampler TS support

after: [shadow] : FPS: 244 FrameTime: 4.098 ms Wladimir J. van der Laan (3): etnaviv: rnndb update etnaviv: Add TS_SAMPLER formats to etnaviv_format etnaviv: Add sampler TS support src/gallium/drivers/etnaviv/etnaviv_emit.c | 26 +++ src/gallium/drivers/etnaviv/etnaviv_format.c

[Mesa-dev] [PATCH 3/3] etnaviv: Add sampler TS support

when not using sampler TS, as resolve-in-place will now be skipped if a resource has no (valid) TS. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c| 26 src/gallium/drivers/etnaviv/etnaviv_texture.

Re: [Mesa-dev] [PATCH 19/19] etnaviv: GC7000: Split off current texture code

On Sun, Nov 05, 2017 at 04:31:40PM +0100, Christian Gmeiner wrote: > > +#ifndef H_ETNAVIV_TEXTURE_PLAIN > > +#define H_ETNAVIV_TEXTURE_PLAIN > > + > > +#include > > + > > +#include "pipe/p_context.h" > > +#include "pipe/p_state.h" > > + > > +#include "hw/state_3d.xml.h" > > Is this include

[Mesa-dev] [PATCH 3/2] etnaviv: Don't over-pad compressed textures

HALIGN_FOUR/SIXTEEN has no meaning for compressed textures, and we can't render to them anyway. So use the tightest possible packing. This avoids bugs with non-power-of-two block sizes. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_reso

Re: [Mesa-dev] [PATCH 0/2] etnaviv: ASTC texture support

On Wed, Nov 01, 2017 at 01:27:30PM -0400, Ilia Mirkin wrote: > On Wed, Nov 1, 2017 at 1:19 PM, Wladimir J. van der Laan > <laa...@gmail.com> wrote: > > Add ASTC texture support for hardware that supports this > > (currently only GC3000 on i.MX6qp is known to have this

Re: [Mesa-dev] [PATCH 2/2] etnaviv: ASTC texture support

> These formats are in a completely different space from the others, in the > hardware (programmed through a different register), so IMO it makes sense to > add a new format bit for it, just like for EXT_FORMAT. > > Relying on mesa's judgement on whether something is astc seems brittle. > > >

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

On Wed, Nov 01, 2017 at 02:27:40PM +0100, Lucas Stach wrote: > Am Montag, den 30.10.2017, 17:14 +0100 schrieb Wladimir J. van der Laan: > > On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > > > I would prefer the shorter expression (!cb->buffer && !cb->

Re: [Mesa-dev] [PATCH 2/2] etnaviv: ASTC texture support

On Wed, Nov 01, 2017 at 06:38:21PM +0100, Christian Gmeiner wrote: > I would love to see a new format helper (util_format_is_astc(..) and not > even start thinking about adding a new format bit (ASTC_FORMAT). These formats are in a completely different space from the others, in the hardware

[Mesa-dev] [PATCH 1/2] etnaviv: Update from rnndb

Updated as of etnav_viv commit 3b4a8ec. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_format.c | 9 +- src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +- src/g

[Mesa-dev] [PATCH 0/2] etnaviv: ASTC texture support

drs Block 4x4. PIGLIT: {"subtest": {"sRGB decode full precision" : "fail"}} PIGLIT: {"subtest": {"sRGB skip decode" : "pass"}} This means all block sizes are working, and basic RGB/sRGB. Not sure why "sRGB decode full precisi

[Mesa-dev] [PATCH 2/2] etnaviv: ASTC texture support

Add ASTC texture support for hardware that supports this (currently only GC3000 on i.MX6qp is known to have this). Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 8 +++ src/gallium/drivers/etnaviv/etnaviv_format.c

Re: [Mesa-dev] [PATCH 05/19] etnaviv: Use only DRAW_INSTANCED on GC3000+

On Wed, Nov 01, 2017 at 11:57:39AM +0100, Philipp Zabel wrote: > On Mon, 2017-10-30 at 17:16 +0100, Wladimir J. van der Laan wrote: > > The blob does this, as DRAW_INSTANCED can replace fully all the other > > draw commands - the other path is only there for compatibility and &

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

On Wed, Nov 01, 2017 at 11:52:55AM +0100, Lucas Stach wrote: > Am Mittwoch, den 01.11.2017, 11:17 +0100 schrieb Wladimir J. van der Laan: > > GC3000 resolve-in-place assumes that the TS state is configured. > > If it is not, this will result in MMU errors. This is especially &g

[Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

GC3000 resolve-in-place assumes that the TS state is configured. If it is not, this will result in MMU errors. This is especially apparent when using glGenMipmaps(). Fixes a problem introduced in 78ade659569ee6fe9bd244170956139f19dd8c6c. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.

[Mesa-dev] [PATCH 16/19] etnaviv: GC7000: Factor out incompatible texture handling logic

This will be shared with the texture descriptor path. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_texture.c | 40 +-- src/gallium/drivers/etnaviv/etnaviv_texture.h | 5 2 files changed, 30 insertions(

[Mesa-dev] [PATCH 18/19] etnaviv: GC7000: Move etna_coalesce to emit header file

Want to be able to emit state from the texture implementation. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 83 -- src/gallium/drivers/etnaviv/etnaviv_emit.h | 83 ++ 2

[Mesa-dev] [PATCH 15/19] etnaviv: GC7000: Track dirty sampler views

Need this to efficiently emit texture descriptor invalidations. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_context.c | 1 + src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + src/gallium/drivers/etnaviv/etnaviv_emit.c| 1

[Mesa-dev] [PATCH 19/19] etnaviv: GC7000: Split off current texture code

Prepare for two texture handling paths, the descriptor-based path will be added in a future commit. These are structured so that the texture implementation handles its own state emission. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/Makefile.s

[Mesa-dev] [PATCH 13/19] etnaviv: GC7000: State changes for HALTI3..5

Update state objects to add new state, and emit function to emit new state. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 247 +++-- src/gallium/drivers/etnaviv/etnaviv_internal.h | 4 + src/gallium/d

[Mesa-dev] [PATCH 17/19] etnaviv: GC7000: Move active_samplers_bits to texture

This needs to be shared between texture_plain and texture_desc. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c| 12 src/gallium/drivers/etnaviv/etnaviv_texture.c | 6 ++ src/gallium/drivers/etnaviv/etnaviv_tex

[Mesa-dev] [PATCH 14/19] etnaviv: GC7000: Make point sprites work on HALTI5

Track varying component offset of the point size output, as well as provide the offset of the point coord input. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 7 ++- src/gallium/drivers/etnaviv/etnaviv_compiler.h | 1

[Mesa-dev] [PATCH 12/19] etnaviv: GC7000: Update screen specs for HALTI5

- This core must load shaders from memory (AFAIK) - Yet another new location for UNIFORMS Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 11/19] etnaviv: GC7000: Update context reset for ..HALTI5

Update context reset for HALTI3..HALTI5, sorting states for the HALTI version that has them. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_context.c | 37 +++ 1 file changed, 32 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH 10/19] etnaviv: GC7000: No RS align when using BLT

RS align is not necessary and might even be harmful when using the BLT engine for blitting. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 15 + src/gallium/drivers/etnaviv/etnaviv_surface.c

  1   2   3   >