Re: [Mesa-dev] [PATCH] radv/llvm: initialise passes static member.

2019-02-08 Thread Bas Nieuwenhuizen
The variable is not static? (initializing a static member in the
constructor would be nonsense ...)

With that word remove from the title:

Reviewed-by: Bas Nieuwenhuizen 

On Fri, Feb 8, 2019 at 6:26 AM Dave Airlie  wrote:
>
> From: Dave Airlie 
>
> Fixes coverity warning
> ---
>  src/amd/vulkan/radv_llvm_helper.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_llvm_helper.cpp 
> b/src/amd/vulkan/radv_llvm_helper.cpp
> index f651593ca62..d1e1e376f90 100644
> --- a/src/amd/vulkan/radv_llvm_helper.cpp
> +++ b/src/amd/vulkan/radv_llvm_helper.cpp
> @@ -29,7 +29,7 @@ class radv_llvm_per_thread_info {
>  public:
> radv_llvm_per_thread_info(enum radeon_family arg_family,
> enum ac_target_machine_options arg_tm_options)
> -   : family(arg_family), tm_options(arg_tm_options) {}
> +   : family(arg_family), tm_options(arg_tm_options), 
> passes(NULL) {}
>
> ~radv_llvm_per_thread_info()
> {
> --
> 2.20.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] radv/llvm: initialise passes static member.

2019-02-07 Thread Dave Airlie
From: Dave Airlie 

Fixes coverity warning
---
 src/amd/vulkan/radv_llvm_helper.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_llvm_helper.cpp 
b/src/amd/vulkan/radv_llvm_helper.cpp
index f651593ca62..d1e1e376f90 100644
--- a/src/amd/vulkan/radv_llvm_helper.cpp
+++ b/src/amd/vulkan/radv_llvm_helper.cpp
@@ -29,7 +29,7 @@ class radv_llvm_per_thread_info {
 public:
radv_llvm_per_thread_info(enum radeon_family arg_family,
enum ac_target_machine_options arg_tm_options)
-   : family(arg_family), tm_options(arg_tm_options) {}
+   : family(arg_family), tm_options(arg_tm_options), passes(NULL) 
{}
 
~radv_llvm_per_thread_info()
{
-- 
2.20.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev