Re: [Mesa-dev] [PATCH] radv: allow cmask transitions without fast clear

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen 

On Fri, Oct 21, 2016 at 1:36 AM, Dave Airlie  wrote:
> From: Dave Airlie 
>
> This fixes
> dEQP-VK.pipeline.multisample.sampled_image*
>
> These all render to multisampled image, and then
> sample from it, so we must transition it correctly,
> since we have a cmask and fmask this will cause
> the correct transition.
>
> Cc: "13.0" 
> Signed-off-by: Dave Airlie 
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c 
> b/src/amd/vulkan/radv_cmd_buffer.c
> index 3f1a6f4..690c739 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -2163,9 +2163,6 @@ static void radv_handle_cmask_image_transition(struct 
> radv_cmd_buffer *cmd_buffe
> radv_initialise_cmask(cmd_buffer, image, 0xu);
> } else if (radv_layout_has_cmask(image, src_layout) &&
>!radv_layout_has_cmask(image, dst_layout)) {
> -
> -   if (!cmd_buffer->device->allow_fast_clears)
> -   return;
> radv_fast_clear_flush_image_inplace(cmd_buffer, image);
> }
>  }
> --
> 2.5.5
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: allow cmask transitions without fast clear

[Edward O'Callaghan]

Acked-by: Edward O'Callaghan 

On 10/21/2016 10:36 AM, Dave Airlie wrote:
> From: Dave Airlie 
> 
> This fixes
> dEQP-VK.pipeline.multisample.sampled_image*
> 
> These all render to multisampled image, and then
> sample from it, so we must transition it correctly,
> since we have a cmask and fmask this will cause
> the correct transition.
> 
> Cc: "13.0" 
> Signed-off-by: Dave Airlie 
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c 
> b/src/amd/vulkan/radv_cmd_buffer.c
> index 3f1a6f4..690c739 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -2163,9 +2163,6 @@ static void radv_handle_cmask_image_transition(struct 
> radv_cmd_buffer *cmd_buffe
>   radv_initialise_cmask(cmd_buffer, image, 0xu);
>   } else if (radv_layout_has_cmask(image, src_layout) &&
>  !radv_layout_has_cmask(image, dst_layout)) {
> -
> - if (!cmd_buffer->device->allow_fast_clears)
> - return;
>   radv_fast_clear_flush_image_inplace(cmd_buffer, image);
>   }
>  }
> 



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: allow cmask transitions without fast clear

[Dave Airlie]

From: Dave Airlie 

This fixes
dEQP-VK.pipeline.multisample.sampled_image*

These all render to multisampled image, and then
sample from it, so we must transition it correctly,
since we have a cmask and fmask this will cause
the correct transition.

Cc: "13.0" 
Signed-off-by: Dave Airlie 
---
 src/amd/vulkan/radv_cmd_buffer.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 3f1a6f4..690c739 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2163,9 +2163,6 @@ static void radv_handle_cmask_image_transition(struct 
radv_cmd_buffer *cmd_buffe
radv_initialise_cmask(cmd_buffer, image, 0xu);
} else if (radv_layout_has_cmask(image, src_layout) &&
   !radv_layout_has_cmask(image, dst_layout)) {
-
-   if (!cmd_buffer->device->allow_fast_clears)
-   return;
radv_fast_clear_flush_image_inplace(cmd_buffer, image);
}
 }
-- 
2.5.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev