Re: [Mesa-dev] [PATCH] radv: fix resolve subpass restoring in compute resolve path.

[Bas Nieuwenhuizen]

How about not setting the subpass in the first place? It is a compute
shader ...

On Thu, Aug 24, 2017, at 02:26, Dave Airlie wrote:
> From: Dave Airlie 
> 
> We need to restore the subpass before we do the fast clear flush.
> 
> found while hacking around on vega.
> 
> Fixes: 19be95f71 (radv: add subpass resolve compute path)
> Signed-off-by: Dave Airlie 
> ---
>  src/amd/vulkan/radv_meta_resolve_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_meta_resolve_cs.c
> b/src/amd/vulkan/radv_meta_resolve_cs.c
> index d20d042..6ac8601 100644
> --- a/src/amd/vulkan/radv_meta_resolve_cs.c
> +++ b/src/amd/vulkan/radv_meta_resolve_cs.c
> @@ -543,7 +543,7 @@ radv_cmd_buffer_resolve_subpass_cs(struct
> radv_cmd_buffer *cmd_buffer)
>&(VkOffset2D) { 0, 0 },
>&(VkExtent2D) { fb->width, fb->height });
>   }
> -
> +   cmd_buffer->state.subpass = subpass;
>   radv_meta_restore_compute(_state, cmd_buffer, 16);
>  
>   for (uint32_t i = 0; i < subpass->color_count; ++i) {
> -- 
> 2.9.4
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: fix resolve subpass restoring in compute resolve path.

[Dave Airlie]

From: Dave Airlie 

We need to restore the subpass before we do the fast clear flush.

found while hacking around on vega.

Fixes: 19be95f71 (radv: add subpass resolve compute path)
Signed-off-by: Dave Airlie 
---
 src/amd/vulkan/radv_meta_resolve_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_meta_resolve_cs.c 
b/src/amd/vulkan/radv_meta_resolve_cs.c
index d20d042..6ac8601 100644
--- a/src/amd/vulkan/radv_meta_resolve_cs.c
+++ b/src/amd/vulkan/radv_meta_resolve_cs.c
@@ -543,7 +543,7 @@ radv_cmd_buffer_resolve_subpass_cs(struct radv_cmd_buffer 
*cmd_buffer)
 &(VkOffset2D) { 0, 0 },
 &(VkExtent2D) { fb->width, fb->height });
}
-
+   cmd_buffer->state.subpass = subpass;
radv_meta_restore_compute(_state, cmd_buffer, 16);
 
for (uint32_t i = 0; i < subpass->color_count; ++i) {
-- 
2.9.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev