Re: [Mesa-dev] [PATCH 0/7] MSAA on R700 and improvements for Evergreen

2012-08-23 Thread Dave Airlie
On Fri, Aug 24, 2012 at 1:09 AM, Marek Olšák  wrote:
> On Thu, Aug 23, 2012 at 4:38 PM, Jerome Glisse  wrote:
>> On Wed, Aug 22, 2012 at 9:54 PM, Marek Olšák  wrote:
>>> This series adds R700 MSAA support along with compression of MSAA 
>>> colorbuffers for R700 and Evergreen, which should save a lot of bandwidth 
>>> with MSAA. There are also some minor fixes.
>>>
>>> Please review.
>>>
>>> Marek Olšák (7):
>>>   gallium/u_blitter: initialize sample mask in resolve
>>>   r600g: set CB_TARGET_MASK to 0xf and not 0xff for resolve on evergreen
>>>   r600g: fix evergreen 8x MSAA sample positions
>>>   r600g: cleanup names around depth decompression
>>>   r600g: implement compression for MSAA colorbuffers for evergreen
>>>   r600g: change programming of CB_SHADER_MASK on r600-r700
>>>   r600g: implement MSAA for r700
>>
>> For the serie :
>> Reviewed-by: Jerome Glisse 
>>
>> What's wrong with r6xx ?
>
> Nothing, I haven't tried it yet. I will take a look at r6xx next (or cayman).

Just FYI, I think original r600 and rv6xx had different registers for
the sample locations.

Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 0/7] MSAA on R700 and improvements for Evergreen

2012-08-23 Thread Marek Olšák
On Thu, Aug 23, 2012 at 4:38 PM, Jerome Glisse  wrote:
> On Wed, Aug 22, 2012 at 9:54 PM, Marek Olšák  wrote:
>> This series adds R700 MSAA support along with compression of MSAA 
>> colorbuffers for R700 and Evergreen, which should save a lot of bandwidth 
>> with MSAA. There are also some minor fixes.
>>
>> Please review.
>>
>> Marek Olšák (7):
>>   gallium/u_blitter: initialize sample mask in resolve
>>   r600g: set CB_TARGET_MASK to 0xf and not 0xff for resolve on evergreen
>>   r600g: fix evergreen 8x MSAA sample positions
>>   r600g: cleanup names around depth decompression
>>   r600g: implement compression for MSAA colorbuffers for evergreen
>>   r600g: change programming of CB_SHADER_MASK on r600-r700
>>   r600g: implement MSAA for r700
>
> For the serie :
> Reviewed-by: Jerome Glisse 
>
> What's wrong with r6xx ?

Nothing, I haven't tried it yet. I will take a look at r6xx next (or cayman).

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 0/7] MSAA on R700 and improvements for Evergreen

2012-08-23 Thread Jerome Glisse
On Wed, Aug 22, 2012 at 9:54 PM, Marek Olšák  wrote:
> This series adds R700 MSAA support along with compression of MSAA 
> colorbuffers for R700 and Evergreen, which should save a lot of bandwidth 
> with MSAA. There are also some minor fixes.
>
> Please review.
>
> Marek Olšák (7):
>   gallium/u_blitter: initialize sample mask in resolve
>   r600g: set CB_TARGET_MASK to 0xf and not 0xff for resolve on evergreen
>   r600g: fix evergreen 8x MSAA sample positions
>   r600g: cleanup names around depth decompression
>   r600g: implement compression for MSAA colorbuffers for evergreen
>   r600g: change programming of CB_SHADER_MASK on r600-r700
>   r600g: implement MSAA for r700

For the serie :
Reviewed-by: Jerome Glisse 

What's wrong with r6xx ?

>
>  src/gallium/auxiliary/util/u_blitter.c  |   46 
>  src/gallium/auxiliary/util/u_blitter.h  |5 +
>  src/gallium/drivers/r600/evergreen_hw_context.c |   64 ++
>  src/gallium/drivers/r600/evergreen_state.c  |   87 ++--
>  src/gallium/drivers/r600/evergreend.h   |   76 ++-
>  src/gallium/drivers/r600/r600_blit.c|   97 -
>  src/gallium/drivers/r600/r600_hw_context.c  |   16 ++
>  src/gallium/drivers/r600/r600_pipe.c|6 +
>  src/gallium/drivers/r600/r600_pipe.h|   16 +-
>  src/gallium/drivers/r600/r600_resource.h|   14 +-
>  src/gallium/drivers/r600/r600_state.c   |  262 
> +++
>  src/gallium/drivers/r600/r600_state_common.c|   45 +++-
>  src/gallium/drivers/r600/r600_texture.c |  116 +-
>  src/gallium/drivers/r600/r600d.h|   20 ++
>  14 files changed, 770 insertions(+), 100 deletions(-)
>
> Marek
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 0/7] MSAA on R700 and improvements for Evergreen

2012-08-22 Thread Marek Olšák
This series adds R700 MSAA support along with compression of MSAA colorbuffers 
for R700 and Evergreen, which should save a lot of bandwidth with MSAA. There 
are also some minor fixes.

Please review.

Marek Olšák (7):
  gallium/u_blitter: initialize sample mask in resolve
  r600g: set CB_TARGET_MASK to 0xf and not 0xff for resolve on evergreen
  r600g: fix evergreen 8x MSAA sample positions
  r600g: cleanup names around depth decompression
  r600g: implement compression for MSAA colorbuffers for evergreen
  r600g: change programming of CB_SHADER_MASK on r600-r700
  r600g: implement MSAA for r700

 src/gallium/auxiliary/util/u_blitter.c  |   46 
 src/gallium/auxiliary/util/u_blitter.h  |5 +
 src/gallium/drivers/r600/evergreen_hw_context.c |   64 ++
 src/gallium/drivers/r600/evergreen_state.c  |   87 ++--
 src/gallium/drivers/r600/evergreend.h   |   76 ++-
 src/gallium/drivers/r600/r600_blit.c|   97 -
 src/gallium/drivers/r600/r600_hw_context.c  |   16 ++
 src/gallium/drivers/r600/r600_pipe.c|6 +
 src/gallium/drivers/r600/r600_pipe.h|   16 +-
 src/gallium/drivers/r600/r600_resource.h|   14 +-
 src/gallium/drivers/r600/r600_state.c   |  262 +++
 src/gallium/drivers/r600/r600_state_common.c|   45 +++-
 src/gallium/drivers/r600/r600_texture.c |  116 +-
 src/gallium/drivers/r600/r600d.h|   20 ++
 14 files changed, 770 insertions(+), 100 deletions(-)

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev