Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v5)

2018-06-20 Thread Dylan Baker
Quoting Gert Wollny (2018-06-20 01:24:51) > Hi Dylan & Eric, > > are you fine with how the flag is added now in meson? If you don't have > any complaints I'm going to push the changes later today. > > many thanks, > Gert > > Am Dienstag, den 19.06.2018, 10:07 +0200 schrieb Gert Wollny: > >

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v5)

2018-06-20 Thread Eric Engestrom
On Wednesday, 2018-06-20 10:24:51 +0200, Gert Wollny wrote: > Hi Dylan & Eric, > > are you fine with how the flag is added now in meson? If you don't have > any complaints I'm going to push the changes later today. Looks good to me, thanks! Reviewed-by: Eric Engestrom > > many thanks, >

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v5)

2018-06-20 Thread Gert Wollny
Hi Dylan & Eric, are you fine with how the flag is added now in meson? If you don't have any complaints I'm going to push the changes later today. many thanks, Gert Am Dienstag, den 19.06.2018, 10:07 +0200 schrieb Gert Wollny: > This warning is misleading: When a struct is partially

[Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v5)

2018-06-19 Thread Gert Wollny
This warning is misleading: When a struct is partially initialized without assigning to the structure members by name, then the remaining fields will be zeroed out, and this warning will be issued (if enabled). If, on the other hand, the partial initialization is done by assigning to named

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v2)

2018-06-15 Thread Gert Wollny
Hi Emil, Am Freitag, den 08.06.2018, 16:28 +0100 schrieb Emil Velikov: > On 8 June 2018 at 12:02, Gert Wollny wrote: > > From: Gert Wollny > > [...] > Out of curiosity: how many warnings are we walking about - is it > something like 20-50 or it's in the 100+ region? > > There's a small

[Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v4)

2018-06-11 Thread Gert Wollny
This warning is misleading: When a struct is partially initialized without assigning to the structure members by name, then the remaining fields will be zeroed out, and this warning will be issued (if enabled). If, on the other hand, the partial initialization is done by assigning to named

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v3)

2018-06-11 Thread Dylan Baker
Quoting Gert Wollny (2018-06-11 09:05:52) > Am Montag, den 11.06.2018, 11:05 +0100 schrieb Eric Engestrom: > > On Monday, 2018-06-11 11:33:20 +0200, Gert Wollny wrote: > > > This warning is misleading: When a struct is partially initialized > > > without > > > assigning to the structure members by

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v3)

2018-06-11 Thread Gert Wollny
Am Montag, den 11.06.2018, 11:05 +0100 schrieb Eric Engestrom: > On Monday, 2018-06-11 11:33:20 +0200, Gert Wollny wrote: > > This warning is misleading: When a struct is partially initialized > > without > > assigning to the structure members by name, then the remaining > > fields > > will be

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v3)

2018-06-11 Thread Eric Engestrom
On Monday, 2018-06-11 11:33:20 +0200, Gert Wollny wrote: > This warning is misleading: When a struct is partially initialized without > assigning to the structure members by name, then the remaining fields > will be zeroed out, and this warning will be issued (if enabled). If, on the > other hand,

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v2)

2018-06-11 Thread Gert Wollny
Am Freitag, den 08.06.2018, 16:28 +0100 schrieb Emil Velikov: > On 8 June 2018 at 12:02, Gert Wollny wrote: > > From: Gert Wollny > > > > This warning is misleading: When a struct is partially initialized > > without > > assigning to the struture members by name, then the un-initialized > >

[Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v3)

2018-06-11 Thread Gert Wollny
This warning is misleading: When a struct is partially initialized without assigning to the structure members by name, then the remaining fields will be zeroed out, and this warning will be issued (if enabled). If, on the other hand, the partial initialization is done by assigning to named

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers

2018-06-08 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-08 02:29:12) > On Tuesday, 2018-06-05 13:58:44 +0200, Gert Wollny wrote: > > This warning is misleading: When a struct is partially initialized without > > assigning to the structure members by name, then the remaining fields > > will be zeroed out, and this warning

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v2)

2018-06-08 Thread Emil Velikov
On 8 June 2018 at 12:02, Gert Wollny wrote: > From: Gert Wollny > > This warning is misleading: When a struct is partially initialized without > assigning to the struture members by name, then the un-initialized fields > will be zeroed out, and this warning will be issued (if enabled). If, on

[Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v2)

2018-06-08 Thread Gert Wollny
From: Gert Wollny This warning is misleading: When a struct is partially initialized without assigning to the struture members by name, then the un-initialized fields will be zeroed out, and this warning will be issued (if enabled). If, on the other hand, the partial initialization is done by

[Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v2)

2018-06-08 Thread Gert Wollny
From: Gert Wollny This warning is misleading: When a struct is partially initialized without assigning to the struture members by name, then the un-initialized fields will be zeroed out, and this warning will be issued (if enabled). If, on the other hand, the partial initialization is done by

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers

2018-06-08 Thread Eric Engestrom
On Tuesday, 2018-06-05 13:58:44 +0200, Gert Wollny wrote: > This warning is misleading: When a struct is partially initialized without > assigning to the structure members by name, then the remaining fields > will be zeroed out, and this warning will be issued (if enabled). If, on the > other

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers

2018-06-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jun 5, 2018 at 7:58 AM, Gert Wollny wrote: > This warning is misleading: When a struct is partially initialized without > assigning to the structure members by name, then the remaining fields > will be zeroed out, and this warning will be issued (if

[Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers

2018-06-05 Thread Gert Wollny
This warning is misleading: When a struct is partially initialized without assigning to the structure members by name, then the remaining fields will be zeroed out, and this warning will be issued (if enabled). If, on the other hand, the partial initialization is done by assigning to named