Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

On Thu, Jan 26, 2017 at 10:23 AM, Ian Romanick wrote: > I keep seeing patches like this... is it time to move BITFIELD64_* from > mtypes.h to somewhere in util for more general use? > It may be time > On 01/26/2017 05:18 AM, Emil Velikov wrote: > > From: Emil Velikov

Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

On Thu, Jan 26, 2017 at 10:22 AM, Jason Ekstrand wrote: > Ugh... windows defines long to be 32-bit on 32-bit platforms Yeah. long is 32-bit on 32-bit x86/Linux too... I think you mean they define long to be 32-bits on 64-bit platforms.

Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

I keep seeing patches like this... is it time to move BITFIELD64_* from mtypes.h to somewhere in util for more general use? On 01/26/2017 05:18 AM, Emil Velikov wrote: > From: Emil Velikov > > MSVC warns about implicit conversion as below. Annotate the literal >

Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

Ugh... windows defines long to be 32-bit on 32-bit platforms Yeah. Reviewed-by: Jason Ekstrand On Thu, Jan 26, 2017 at 6:05 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Reviewed-by: Lionel Landwerlin > > On 26/01/17

Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

Reviewed-by: Lionel Landwerlin On 26/01/17 13:18, Emil Velikov wrote: From: Emil Velikov MSVC warns about implicit conversion as below. Annotate the literal appropriately to silence the warning. nir_gather_info.c(249) : warning

[Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

From: Emil Velikov MSVC warns about implicit conversion as below. Annotate the literal appropriately to silence the warning. nir_gather_info.c(249) : warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)