Re: [Mesa-dev] [PATCH 2/3] mesa: fix pbuffers because internally they are front buffers

2019-04-30 Thread Marek Olšák
I have never understood why Mesa has gl_context::Visual and gl_framebuffer::Visual. The Mesa code also allows a non-matching doublebuffer setting between the two. libEGL also always uses a singlebuffered config for pixmaps and pbuffers even if the context config is doublebuffered. Marek On Tue,

Re: [Mesa-dev] [PATCH 2/3] mesa: fix pbuffers because internally they are front buffers

2019-04-30 Thread Adam Jackson
On Mon, 2019-04-29 at 20:35 -0400, Marek Olšák wrote: > Yeah that's possible. The thing is that a GL context can have a > doublebuffered config and begin with GL_BACK as the draw buffer, but > MakeCurrent can set a pbuffer with a singlebuffered config and then > nothing is rendered with Mesa

Re: [Mesa-dev] [PATCH 2/3] mesa: fix pbuffers because internally they are front buffers

2019-04-30 Thread Marek Olšák
On Tue, Apr 30, 2019 at 5:59 AM Mathias Fröhlich wrote: > > Adam, Marek, > > On Monday, 29 April 2019 18:28:21 CEST Adam Jackson wrote: > > On Fri, 2019-04-26 at 23:31 -0400, Marek Olšák wrote: > > > > I don't claim to know what this series is trying to fix, but: > > > > > +* 2) Pbuffers are

Re: [Mesa-dev] [PATCH 2/3] mesa: fix pbuffers because internally they are front buffers

2019-04-30 Thread Mathias Fröhlich
Adam, Marek, On Monday, 29 April 2019 18:28:21 CEST Adam Jackson wrote: > On Fri, 2019-04-26 at 23:31 -0400, Marek Olšák wrote: > > I don't claim to know what this series is trying to fix, but: > > > +* 2) Pbuffers are back buffers from the application point of view, > > +*but they

Re: [Mesa-dev] [PATCH 2/3] mesa: fix pbuffers because internally they are front buffers

2019-04-29 Thread Marek Olšák
On Mon, Apr 29, 2019 at 12:28 PM Adam Jackson wrote: > On Fri, 2019-04-26 at 23:31 -0400, Marek Olšák wrote: > > I don't claim to know what this series is trying to fix, but: > > > +* 2) Pbuffers are back buffers from the application point of view, > > +*but they are front buffers

Re: [Mesa-dev] [PATCH 2/3] mesa: fix pbuffers because internally they are front buffers

2019-04-29 Thread Adam Jackson
On Fri, 2019-04-26 at 23:31 -0400, Marek Olšák wrote: I don't claim to know what this series is trying to fix, but: > +* 2) Pbuffers are back buffers from the application point of view, > +*but they are front buffers from the Mesa point of view, > +*because they are always

[Mesa-dev] [PATCH 2/3] mesa: fix pbuffers because internally they are front buffers

2019-04-26 Thread Marek Olšák
From: Marek Olšák This fixes the egl_ext_device_base piglit test, which uses EGL pbuffers. --- src/mesa/main/buffers.c | 56 ++--- 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index