Re: [Mesa-dev] [PATCH 6/6] st/nir: Drop unused gl_program parameter in VS input handling helper.

2018-12-21 Thread Marek Olšák
For the series:

Reviewed-by: Marek Olšák 

Marek

On Mon, Dec 17, 2018 at 1:37 PM Kenneth Graunke 
wrote:

> Nobody uses this, so let's drop it.  This makes the helper callable
> from places without a gl_program.
> ---
>  src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> index 7406e26e2f8..5263edc5a6d 100644
> --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> @@ -81,7 +81,7 @@ st_nir_fixup_varying_slots(struct st_context *st, struct
> exec_list *var_list)
>   * on varying-slot w/ the VS outputs)
>   */
>  static void
> -st_nir_assign_vs_in_locations(struct gl_program *prog, nir_shader *nir)
> +st_nir_assign_vs_in_locations(nir_shader *nir)
>  {
> nir->num_inputs = 0;
> nir_foreach_variable_safe(var, >inputs) {
> @@ -810,7 +810,7 @@ st_finalize_nir(struct st_context *st, struct
> gl_program *prog,
>
> if (nir->info.stage == MESA_SHADER_VERTEX) {
>/* Needs special handling so drvloc matches the vbo state: */
> -  st_nir_assign_vs_in_locations(prog, nir);
> +  st_nir_assign_vs_in_locations(nir);
>/* Re-lower global vars, to deal with any dead VS inputs. */
>NIR_PASS_V(nir, nir_lower_global_vars_to_local);
>
> --
> 2.19.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH 6/6] st/nir: Drop unused gl_program parameter in VS input handling helper.

2018-12-17 Thread Kenneth Graunke
Nobody uses this, so let's drop it.  This makes the helper callable
from places without a gl_program.
---
 src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp 
b/src/mesa/state_tracker/st_glsl_to_nir.cpp
index 7406e26e2f8..5263edc5a6d 100644
--- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
+++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
@@ -81,7 +81,7 @@ st_nir_fixup_varying_slots(struct st_context *st, struct 
exec_list *var_list)
  * on varying-slot w/ the VS outputs)
  */
 static void
-st_nir_assign_vs_in_locations(struct gl_program *prog, nir_shader *nir)
+st_nir_assign_vs_in_locations(nir_shader *nir)
 {
nir->num_inputs = 0;
nir_foreach_variable_safe(var, >inputs) {
@@ -810,7 +810,7 @@ st_finalize_nir(struct st_context *st, struct gl_program 
*prog,
 
if (nir->info.stage == MESA_SHADER_VERTEX) {
   /* Needs special handling so drvloc matches the vbo state: */
-  st_nir_assign_vs_in_locations(prog, nir);
+  st_nir_assign_vs_in_locations(nir);
   /* Re-lower global vars, to deal with any dead VS inputs. */
   NIR_PASS_V(nir, nir_lower_global_vars_to_local);
 
-- 
2.19.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev