Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

2016-09-21 Thread Emil Velikov 
On 20 September 2016 at 09:32, Weng, Chuanbo  wrote:
> Hi Emil,
> What you mentioned about style issue in last round is:
> Please move the variable declaration in local scope and add 
> space between ){
> I think I have fixed these issue in this version. Maybe I have 
> misunderstood your meaning.

Reading back, I could have been more verbose. Please skim through the
patches in master, for future reference.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

2016-09-20 Thread Weng, Chuanbo 
Hi Emil,
What you mentioned about style issue in last round is:
Please move the variable declaration in local scope and add 
space between ){
I think I have fixed these issue in this version. Maybe I have 
misunderstood your meaning. Do you expect
the style like this:

struct dri2_egl_display *dri2_dpy = dri2_egl_display(disp);
struct dri2_egl_image *dri2_img = dri2_egl_image(img);
EGLint img_offset = 0;

(void) drv;

Or this style (put the variable declaration at the beginning of local 
scope):

if (offsets) {
EGLint img_offset = 0;
offsets[0] = 0;


Thanks,
Chuanbo Weng


-Original Message-
From: Emil Velikov [mailto:emil.l.veli...@gmail.com] 
Sent: Tuesday, September 20, 2016 5:13 AM
To: Jason Ekstrand <ja...@jlekstrand.net>
Cc: Weng, Chuanbo <chuanbo.w...@intel.com>; Nicolai Hähnle 
<nhaeh...@gmail.com>; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return 
corresponding offset.

On 19 September 2016 at 16:38, Jason Ekstrand <ja...@jlekstrand.net> wrote:
> It all looks fine to me.  Feel free to add a
>
> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net>
>
> That said, my knowledge of the details of the DRI vfuncs is very 
> limited so I'd like to see Emil or Axel sign off on it too, especially 
> since they were the ones who had all the comments.
>
Thanks for double-checking Jason.

Afaics patches have a few outstanding style issues (mentioned last round), but 
I'll squash those just before committing tomorrow morning.

Regards,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

2016-09-19 Thread Emil Velikov 
On 19 September 2016 at 16:38, Jason Ekstrand  wrote:
> It all looks fine to me.  Feel free to add a
>
> Reviewed-by: Jason Ekstrand 
>
> That said, my knowledge of the details of the DRI vfuncs is very limited so
> I'd like to see Emil or Axel sign off on it too, especially since they were
> the ones who had all the comments.
>
Thanks for double-checking Jason.

Afaics patches have a few outstanding style issues (mentioned last
round), but I'll squash those just before committing tomorrow morning.

Regards,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

2016-09-19 Thread Jason Ekstrand 
It all looks fine to me.  Feel free to add a

Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net>

That said, my knowledge of the details of the DRI vfuncs is very limited so
I'd like to see Emil or Axel sign off on it too, especially since they were
the ones who had all the comments.

--Jason

On Mon, Sep 19, 2016 at 3:55 AM, Weng, Chuanbo <chuanbo.w...@intel.com>
wrote:

> Seems they haven't got lost, because I see these patches in the
> mailing-list webpage:
> https://lists.freedesktop.org/archives/mesa-dev/2016-September/128847.html
> https://lists.freedesktop.org/archives/mesa-dev/2016-September/128845.html
> https://lists.freedesktop.org/archives/mesa-dev/2016-September/128846.html
> https://lists.freedesktop.org/archives/mesa-dev/2016-September/128844.html
>
> And my gmail account also receives these patches.
>
> Thanks,
> Chuanbo Weng
>
>
> -Original Message-
> From: Nicolai Hähnle [mailto:nhaeh...@gmail.com]
> Sent: Monday, September 19, 2016 4:53 PM
> To: Weng, Chuanbo <chuanbo.w...@intel.com>; mesa-dev@lists.freedesktop.org;
> emil.l.veli...@gmail.com
> Subject: Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA
> return corresponding offset.
>
> Those patches got lost somehow? Maybe they weren't sent out as replies to
> your first email, check the git configuration for sendemail.thread or the
> git send-email --thread flag.
>
> Cheers,
> Nicolai
>
> On 18.09.2016 09:04, Weng, Chuanbo wrote:
> > Ping for review. Thanks.
> >
> > -Original Message-
> > From: Weng, Chuanbo
> > Sent: Wednesday, September 14, 2016 1:07 AM
> > To: mesa-dev@lists.freedesktop.org; emil.l.veli...@gmail.com
> > Cc: Weng, Chuanbo <chuanbo.w...@intel.com>
> > Subject: [PATCH v3 0/3] Make eglExportDMABUFImageMESA return
> corresponding offset.
> >
> > This patchset makes eglExportDMABUFImageMESA return corresponding offset
> of EGLImage instead of 0 on intel platfrom with classic dri driver(i965).
> >
> > v2: Add version check of __DRIimageExtension implementation in egl
> loader (Suggested by Axel Davy).
> >
> > v3: Don't add version check of __DRIimageExtension implementation in
> > egl loader. Set the offset only when queryImage() succeeds. (Suggested
> > by Emil
> > Velikov)
> >
> > Chuanbo Weng (3):
> >   dri: add offset attribute and bump version of EGLImage extensions.
> >   egl: return corresponding offset of EGLImage instead of 0.
> >   i965: implement querying __DRI_IMAGE_ATTRIB_OFFSET.
> >
> >  include/GL/internal/dri_interface.h  | 4 +++-
> >  src/egl/drivers/dri2/egl_dri2.c  | 8 +++-
> >  src/mesa/drivers/dri/i965/intel_screen.c | 9 +++--
> >  3 files changed, 17 insertions(+), 4 deletions(-)
> >
> > --
> > 1.9.1
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

2016-09-19 Thread Weng, Chuanbo 
Seems they haven't got lost, because I see these patches in the mailing-list 
webpage:
https://lists.freedesktop.org/archives/mesa-dev/2016-September/128847.html
https://lists.freedesktop.org/archives/mesa-dev/2016-September/128845.html
https://lists.freedesktop.org/archives/mesa-dev/2016-September/128846.html
https://lists.freedesktop.org/archives/mesa-dev/2016-September/128844.html

And my gmail account also receives these patches.

Thanks,
Chuanbo Weng


-Original Message-
From: Nicolai Hähnle [mailto:nhaeh...@gmail.com] 
Sent: Monday, September 19, 2016 4:53 PM
To: Weng, Chuanbo <chuanbo.w...@intel.com>; mesa-dev@lists.freedesktop.org; 
emil.l.veli...@gmail.com
Subject: Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return 
corresponding offset.

Those patches got lost somehow? Maybe they weren't sent out as replies to your 
first email, check the git configuration for sendemail.thread or the git 
send-email --thread flag.

Cheers,
Nicolai

On 18.09.2016 09:04, Weng, Chuanbo wrote:
> Ping for review. Thanks.
>
> -Original Message-
> From: Weng, Chuanbo
> Sent: Wednesday, September 14, 2016 1:07 AM
> To: mesa-dev@lists.freedesktop.org; emil.l.veli...@gmail.com
> Cc: Weng, Chuanbo <chuanbo.w...@intel.com>
> Subject: [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding 
> offset.
>
> This patchset makes eglExportDMABUFImageMESA return corresponding offset of 
> EGLImage instead of 0 on intel platfrom with classic dri driver(i965).
>
> v2: Add version check of __DRIimageExtension implementation in egl loader 
> (Suggested by Axel Davy).
>
> v3: Don't add version check of __DRIimageExtension implementation in 
> egl loader. Set the offset only when queryImage() succeeds. (Suggested 
> by Emil
> Velikov)
>
> Chuanbo Weng (3):
>   dri: add offset attribute and bump version of EGLImage extensions.
>   egl: return corresponding offset of EGLImage instead of 0.
>   i965: implement querying __DRI_IMAGE_ATTRIB_OFFSET.
>
>  include/GL/internal/dri_interface.h  | 4 +++-
>  src/egl/drivers/dri2/egl_dri2.c  | 8 +++-
>  src/mesa/drivers/dri/i965/intel_screen.c | 9 +++--
>  3 files changed, 17 insertions(+), 4 deletions(-)
>
> --
> 1.9.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

2016-09-19 Thread Nicolai Hähnle 
Those patches got lost somehow? Maybe they weren't sent out as replies 
to your first email, check the git configuration for sendemail.thread or 
the git send-email --thread flag.


Cheers,
Nicolai

On 18.09.2016 09:04, Weng, Chuanbo wrote:

Ping for review. Thanks.

-Original Message-
From: Weng, Chuanbo
Sent: Wednesday, September 14, 2016 1:07 AM
To: mesa-dev@lists.freedesktop.org; emil.l.veli...@gmail.com
Cc: Weng, Chuanbo 
Subject: [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding 
offset.

This patchset makes eglExportDMABUFImageMESA return corresponding offset of 
EGLImage instead of 0 on intel platfrom with classic dri driver(i965).

v2: Add version check of __DRIimageExtension implementation in egl loader 
(Suggested by Axel Davy).

v3: Don't add version check of __DRIimageExtension implementation in egl 
loader. Set the offset only when queryImage() succeeds. (Suggested by Emil
Velikov)

Chuanbo Weng (3):
  dri: add offset attribute and bump version of EGLImage extensions.
  egl: return corresponding offset of EGLImage instead of 0.
  i965: implement querying __DRI_IMAGE_ATTRIB_OFFSET.

 include/GL/internal/dri_interface.h  | 4 +++-
 src/egl/drivers/dri2/egl_dri2.c  | 8 +++-
 src/mesa/drivers/dri/i965/intel_screen.c | 9 +++--
 3 files changed, 17 insertions(+), 4 deletions(-)

--
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

2016-09-18 Thread Weng, Chuanbo 
Ping for review. Thanks.

-Original Message-
From: Weng, Chuanbo 
Sent: Wednesday, September 14, 2016 1:07 AM
To: mesa-dev@lists.freedesktop.org; emil.l.veli...@gmail.com
Cc: Weng, Chuanbo 
Subject: [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding 
offset.

This patchset makes eglExportDMABUFImageMESA return corresponding offset of 
EGLImage instead of 0 on intel platfrom with classic dri driver(i965).

v2: Add version check of __DRIimageExtension implementation in egl loader 
(Suggested by Axel Davy).

v3: Don't add version check of __DRIimageExtension implementation in egl 
loader. Set the offset only when queryImage() succeeds. (Suggested by Emil
Velikov)

Chuanbo Weng (3):
  dri: add offset attribute and bump version of EGLImage extensions.
  egl: return corresponding offset of EGLImage instead of 0.
  i965: implement querying __DRI_IMAGE_ATTRIB_OFFSET.

 include/GL/internal/dri_interface.h  | 4 +++-
 src/egl/drivers/dri2/egl_dri2.c  | 8 +++-
 src/mesa/drivers/dri/i965/intel_screen.c | 9 +++--
 3 files changed, 17 insertions(+), 4 deletions(-)

--
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

2016-09-13 Thread Chuanbo Weng 
This patchset makes eglExportDMABUFImageMESA return corresponding offset
of EGLImage instead of 0 on intel platfrom with classic dri driver(i965).

v2: Add version check of __DRIimageExtension implementation in egl loader
(Suggested by Axel Davy).

v3: Don't add version check of __DRIimageExtension implementation in egl
loader. Set the offset only when queryImage() succeeds. (Suggested by Emil
Velikov)

Chuanbo Weng (3):
  dri: add offset attribute and bump version of EGLImage extensions.
  egl: return corresponding offset of EGLImage instead of 0.
  i965: implement querying __DRI_IMAGE_ATTRIB_OFFSET.

 include/GL/internal/dri_interface.h  | 4 +++-
 src/egl/drivers/dri2/egl_dri2.c  | 8 +++-
 src/mesa/drivers/dri/i965/intel_screen.c | 9 +++--
 3 files changed, 17 insertions(+), 4 deletions(-)

-- 
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev