[Mesa-dev] [PATCH] st/mesa: Check after _mesa_create_context()

2011-07-11 Thread Emil Velikov
In some cases _mesa_create_context() can return NULL an in the mesa state tracker, we do not concider the case, which may cause issues within st_create_context_priv() This patch adds a simple check (similar to the one in the dri drivers), as well as clears the function table 'funcs'

[Mesa-dev] [Bug 38842] Various valid GLX attributes are rejected by MESA glxChooseFBConfig

2011-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38842 --- Comment #9 from Jonathan Kirkham jonathan.kirk...@arm.com 2011-07-11 00:55:03 PDT --- (In reply to comment #8) (In reply to comment #7) The attributes are valid for glxChooseFBConfig, the attributes and their values are just ignore

Re: [Mesa-dev] [PATCH 00/13] Floating-point depth buffers

2011-07-11 Thread Marek Olšák
It should be fixed by now. There is a bug in our beloved build system such that the assert macro is disabled if some completely-unrelated configure options are enabled. I will send a fix for that soon as well. Marek On Mon, Jul 11, 2011 at 5:00 AM, Eric Anholt e...@anholt.net wrote: On Fri,  1

Re: [Mesa-dev] Mesa (master): mesa: fix assertion failure in _mesa_test_formats

2011-07-11 Thread Jose Fonseca
Marek, Please add the comment /* Z32_FLOAT_X24S8 has DataType of GL_NONE */ in from of DataType == GL_NONE, otherwise I think nobody will guess what that's about. Jose - Original Message - Module: Mesa Branch: master Commit: e134eaa2c5619b47e944e33d053ee23c61da7aa9 URL:

Re: [Mesa-dev] Mesa (master): mesa: fix assertion failure in _mesa_test_formats

2011-07-11 Thread Marek Olšák
Done. Marek On Mon, Jul 11, 2011 at 3:14 PM, Jose Fonseca jfons...@vmware.com wrote: Marek, Please add the comment /* Z32_FLOAT_X24S8 has DataType of GL_NONE */ in from of DataType == GL_NONE, otherwise I think nobody will guess what that's about. Jose - Original Message -

Re: [Mesa-dev] [PATCH 1/2] mesa: return early if mask is cleared to zero in BlitFramebuffer

2011-07-11 Thread Brian Paul
On 07/10/2011 12:30 PM, Marek Olšák wrote: From ARB_framebuffer_object: If a buffer is specified inmask and does not exist in both the read and draw framebuffers, the corresponding bit is silently ignored. --- src/mesa/main/fbobject.c |4 1 files changed, 4

Re: [Mesa-dev] [PATCH] st/mesa: Check after _mesa_create_context()

2011-07-11 Thread Brian Paul
On 07/09/2011 06:56 AM, Emil Velikov wrote: In some cases _mesa_create_context() can return NULL an in the mesa state tracker, we do not concider the case, which may cause issues within st_create_context_priv() This patch adds a simple check (similar to the one in the dri drivers), as well as

[Mesa-dev] [Bug 38842] Various valid GLX attributes are rejected by MESA glxChooseFBConfig

2011-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38842 Brian Paul bri...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] configure.ac: do not let LLVM_CONFIG to define NDEBUG and disable assertions

2011-07-11 Thread Jose Fonseca
Looks good. But this would be more correct: llvm-config --cppflags | sed 's/-DNDEBUG\//g' I'll do the same thing in scons. Jose - Original Message - Re-enables assertions in src/mesa. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Mesa-dev] [Bug 39116] [intel] manywin xdemo texture issue

2011-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39116 Brian Paul bri...@vmware.com changed: What|Removed |Added Summary|manywin xdemo texture issue |[intel] manywin xdemo

Re: [Mesa-dev] robust-tarballs branch (Was: Error building on Windows with SCons)

2011-07-11 Thread Brian Paul
On 07/09/2011 07:03 AM, Jose Fonseca wrote: I heard no concerns so I went ahead and made a branch where: - I removed GLUT - derived Mesa tarballs' file list from git ls-files. http://cgit.freedesktop.org/mesa/mesa/log/?h=robust-tarballs I've confirmed that both automake and scons+crossmingw32

[Mesa-dev] [PATCH] autoconf: Do not select Xlib when building DRI

2011-07-11 Thread Emil Velikov
As Chia-I Wu said 'There are two libGL providers, Xlib and DRI based they cannot coexist' Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index dde13c9..19cc531 100644 ---

[Mesa-dev] About merging pipe-video to master

2011-07-11 Thread Christian König
Hi guys, as the subject already indicates: I'm about to merge pipe-video to master and just wanted to ask if anybody has still any objections? After following Jose and Younes discussion on mesa-dev about how to design such an abstraction layer I took another round of cleaning up the interface

[Mesa-dev] [Bug 39147] New: egl_gallium.so: errors when linking

2011-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39147 Summary: egl_gallium.so: errors when linking Product: Mesa Version: git Platform: All OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium

[Mesa-dev] [Bug 39147] egl_gallium.so: errors when linking

2011-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39147 Laurent carlier lordhea...@gmail.com changed: What|Removed |Added CC|

Re: [Mesa-dev] robust-tarballs branch (Was: Error building on Windows with SCons)

2011-07-11 Thread Dave Airlie
On Mon, Jul 11, 2011 at 3:20 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - On 07/09/2011 07:03 AM, Jose Fonseca wrote: I heard no concerns so I went ahead and made a branch where: - I removed GLUT - derived Mesa tarballs' file list from git ls-files.

[Mesa-dev] [Bug 39147] egl_gallium.so: errors when linking

2011-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39147 a.ra...@arcor.de changed: What|Removed |Added CC||a.ra...@arcor.de -- Configure

[Mesa-dev] [PATCHv3] r600g: get and use backends mask for occlusion queries

2011-07-11 Thread Vadim Girlin
Use backend_map kernel query if supported, otherwise analyze ZPASS_DONE results to get the mask. Signed-off-by: Vadim Girlin vadimgir...@gmail.com --- src/gallium/drivers/r600/r600.h|4 + src/gallium/winsys/r600/drm/evergreen_hw_context.c |2 +

[Mesa-dev] [PATCH] linker: Only over-ride built-ins when a prototype has been seen

2011-07-11 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The GLSL spec says: If a built-in function is redeclared in a shader (i.e., a prototype is visible) before a call to it, then the linker will only attempt to resolve that call within the set of shaders that are linked with it. This

Re: [Mesa-dev] [PATCH 2/3] intel: Fix height in stencil buffer region allocation

2011-07-11 Thread Eric Anholt
On Sat, 9 Jul 2011 09:01:07 -0700, Chad Versace c...@chad-versace.us wrote: If the height of the stencil buffer were odd, then we allocated a region whose height was too small --- `height / 2` rather than `height / 2 + height % 2`. Generally this is written (height + 1) / 2 or ALIGN(height,

Re: [Mesa-dev] [PATCH 1/3] intel: Fix span functions for stencil buffer

2011-07-11 Thread Dan McCabe
On 07/09/2011 08:56 AM, Chad Versace wrote: Up until this point, we incorrectly believed that the stencil buffer is Y-tiled. In fact, it is W tiled. From PRM Vol 1 Part 2 Section 4.5.2.1 W-Major Tile Format: W-Major Tile Format is used for separate stencil. Since the stencil buffer is

[Mesa-dev] [PATCH 1/2] st/mesa: derive a stencil sampler format from the actual texture format

2011-07-11 Thread Marek Olšák
--- src/mesa/state_tracker/st_cb_drawpixels.c | 70 +++-- 1 files changed, 26 insertions(+), 44 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c index dca3324..f25656a 100644 ---

[Mesa-dev] [PATCH 2/2] st/mesa: get rid of unnecessary 'goto' in DrawPixels

2011-07-11 Thread Marek Olšák
--- src/mesa/state_tracker/st_cb_drawpixels.c | 16 ++-- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c index f25656a..d3e6aef 100644 ---

Re: [Mesa-dev] [PATCH 2/2] st/mesa: get rid of unnecessary 'goto' in DrawPixels

2011-07-11 Thread Brian Paul
On 07/11/2011 02:33 PM, Marek Olšák wrote: --- src/mesa/state_tracker/st_cb_drawpixels.c | 16 ++-- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c index f25656a..d3e6aef

Re: [Mesa-dev] [PATCH 1/2] st/mesa: derive a stencil sampler format from the actual texture format

2011-07-11 Thread Brian Paul
On 07/11/2011 02:33 PM, Marek Olšák wrote: --- src/mesa/state_tracker/st_cb_drawpixels.c | 70 +++-- 1 files changed, 26 insertions(+), 44 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c index

[Mesa-dev] [PATCH] st/mesa: choose a matching depth internal format for DrawPixels

2011-07-11 Thread Marek Olšák
This makes it easier to hit the fast path and get a float format when we ask for it. --- src/mesa/state_tracker/st_cb_drawpixels.c | 29 +++-- 1 files changed, 27 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c

Re: [Mesa-dev] About merging pipe-video to master

2011-07-11 Thread Johannes Obermayr
Christian König schrieb: Hi guys, as the subject already indicates: I'm about to merge pipe-video to master and just wanted to ask if anybody has still any objections? Yes [I am a watchman of compile/build errors (I know I am an old bitcher but code quality rules)]:

Re: [Mesa-dev] [PATCH 2/3] intel: Fix height in stencil buffer region allocation

2011-07-11 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/11/2011 12:08 PM, Eric Anholt wrote: On Sat, 9 Jul 2011 09:01:07 -0700, Chad Versace c...@chad-versace.us wrote: If the height of the stencil buffer were odd, then we allocated a region whose height was too small --- `height / 2` rather than

Re: [Mesa-dev] [PATCH] st/mesa: choose a matching depth internal format for DrawPixels

2011-07-11 Thread Brian Paul
On 07/11/2011 03:54 PM, Marek Olšák wrote: This makes it easier to hit the fast path and get a float format when we ask for it. --- src/mesa/state_tracker/st_cb_drawpixels.c | 29 +++-- 1 files changed, 27 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] autoconf: Do not select Xlib when building DRI

2011-07-11 Thread Marek Olšák
Looks good, thanks. I have pushed it. Marek On Mon, Jul 11, 2011 at 4:58 PM, Emil Velikov emil.l.veli...@gmail.com wrote: As Chia-I Wu said 'There are two libGL providers, Xlib and DRI based they cannot coexist' Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---  configure.ac |    2

Re: [Mesa-dev] [PATCH 1/3] intel: Fix span functions for stencil buffer

2011-07-11 Thread Dan McCabe
On 07/11/2011 04:03 PM, Chad Versace wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/11/2011 12:49 PM, Dan McCabe wrote: On 07/09/2011 08:56 AM, Chad Versace wrote: Up until this point, we incorrectly believed that the stencil buffer is Y-tiled. In fact, it is W tiled. From PRM Vol

[Mesa-dev] [PATCH 1/6] intel: Use _mesa_tex_target_to_face() helper function instead of our own.

2011-07-11 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_tex_image.c | 25 +++-- 1 files changed, 3 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_tex_image.c b/src/mesa/drivers/dri/intel/intel_tex_image.c index 269faef..1f8b885 100644 ---

[Mesa-dev] [PATCH 5/6] mesa: Fix assertion failure in X8_Z24/Z24_X8 texfetch.

2011-07-11 Thread Eric Anholt
--- src/mesa/main/texfetch_tmp.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texfetch_tmp.h b/src/mesa/main/texfetch_tmp.h index 3b1eedf..d170adf 100644 --- a/src/mesa/main/texfetch_tmp.h +++ b/src/mesa/main/texfetch_tmp.h @@ -2287,7 +2287,8 @@

[Mesa-dev] [PATCH 3/6] i915: Use _mesa_get_format_name to describe translate_tex_format() fail.

2011-07-11 Thread Eric Anholt
I don't want to go count up to what format number 29 is. --- src/mesa/drivers/dri/i915/i830_texstate.c |3 ++- src/mesa/drivers/dri/i915/i915_texstate.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i830_texstate.c

[Mesa-dev] [PATCH 4/6] i915: Fix depth texturing since 86e62b2357447b7c97f434be4834f4b50aa0764d

2011-07-11 Thread Eric Anholt
The 965 driver already had the X8_Z24 case, but 915 was missing it. --- src/mesa/drivers/dri/i915/i915_texstate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i915_texstate.c b/src/mesa/drivers/dri/i915/i915_texstate.c index 90ebee3..7cd6820

[Mesa-dev] [PATCH 2/6] i915: Fix map/unmap mismatches from leaving INTEL_FALLBACK during TNL.

2011-07-11 Thread Eric Anholt
The first rendering after context create didn't know of the color buffer yet, triggering a sw fallback. The intel_prepare_render() from intelSpanRenderStart then found the buffer and turned off fallbacks, but intelSpanRenderFinish was never called and things were left mapped. By checking buffers

[Mesa-dev] [PATCH 6/6] i915: Fix NPOT compressed textures on 915.

2011-07-11 Thread Eric Anholt
We were failing at rounding, misplacing the non-baselevels. Fixes: 3DFX_texture_compression_FXT1/fbo-generate-mipmaps ARB_texture_compression/fbo-generate-mipmaps EXT_texture_compression_s3tc/fbo-generate-mipmaps --- src/mesa/drivers/dri/i915/i915_tex_layout.c |4 ++-- 1 files changed, 2

Re: [Mesa-dev] [PATCH 1/6] intel: Use _mesa_tex_target_to_face() helper function instead of our own.

2011-07-11 Thread Kenneth Graunke
On 07/11/2011 06:53 PM, Eric Anholt wrote: --- src/mesa/drivers/dri/intel/intel_tex_image.c | 25 +++-- 1 files changed, 3 insertions(+), 22 deletions(-) I don't know enough to verify patch 2. Otherwise, for the series: Reviewed-by: Kenneth Graunke