[Mesa-dev] [PATCH] xlib: use strdup() instead of _mesa_strdup()

2015-03-12 Thread Brian Paul
--- src/mesa/drivers/x11/fakeglx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c index 3869e94..4fd6d75 100644 --- a/src/mesa/drivers/x11/fakeglx.c +++ b/src/mesa/drivers/x11/fakeglx.c @@ -40,6 +40,7 @@ */

[Mesa-dev] [PATCH 0/4] Support multiple state pipelines for i965

2015-03-12 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa i965-pipelines Gen8 appears to require a separate pipeline for CS support. Here is another take on the multiple pipelines idea. In contrast to the previous multiple pipeline series, it preserves usage of brw-state.dirty in most places. Now, it saves

[Mesa-dev] [PATCH 2/4] i965/state: Allow brw-atoms[] to be used by multiple pipelines

2015-03-12 Thread Jordan Justen
Convert brw-num_atoms to an int array. Adds brw_add_pipeline_atoms which copies the atoms for a pipeline, and sets brw-num_atoms[p] for pipeline p. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_context.h | 8 +++-

[Mesa-dev] [Bug 89553] Account request

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89553 Bug ID: 89553 Summary: Account request Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

Re: [Mesa-dev] [PATCH 2/2] mesa: use strdup() instead of _mesa_strdup()

2015-03-12 Thread Brian Paul
On 03/10/2015 08:47 PM, Ian Romanick wrote: On 03/10/2015 07:47 PM, Ian Romanick wrote: On 03/10/2015 06:42 PM, Brian Paul wrote: We were already using strdup() in various places in Mesa. Get rid of the _mesa_strdup() wrapper. All the callers pass a non-NULL argument so the NULL check isn't

[Mesa-dev] [Bug 89553] Account request

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89553 --- Comment #1 from Eduardo Lima Mitev el...@igalia.com --- Created attachment 114244 -- https://bugs.freedesktop.org/attachment.cgi?id=114244action=edit PGP public key -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [PATCH 2/4] gallium: introduce get_device_vendor() entrypoint for pipes

2015-03-12 Thread Giuseppe Bilotta
This will be needed by Clover to return the correct information to CL_DEVICE_VENDOR info queries. Signed-off-by: Giuseppe Bilotta giuseppe.bilo...@gmail.com Reviewed-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/docs/source/screen.rst | 6 ++ src/gallium/include/pipe/p_screen.h

[Mesa-dev] [PATCH 3/4] gallium: implement get_device_vendor() for existing drivers

2015-03-12 Thread Giuseppe Bilotta
The only hackish ones are llvmpipe and softpipe, which currently return the same string as for get_vendor(), while ideally they should return the CPU vendor. Signed-off-by: Giuseppe Bilotta giuseppe.bilo...@gmail.com --- src/gallium/drivers/freedreno/freedreno_screen.c | 8

[Mesa-dev] [Bug 35268] initial-exec TLS model breaks dlopen'ed libGL

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35268 Timo Teräs timo.te...@iki.fi changed: What|Removed |Added CC||timo.te...@iki.fi -- You

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Francisco Jerez
Vivek Dasmohapatra vi...@collabora.co.uk writes: Hi - Hi, As you probably already know, there can only be one version of libstdc++.so in your runtime link chain That's a common misconception, in principle several versions of libstdc++.so with different DT_SONAME (i.e. with mutually

Re: [Mesa-dev] [PATCH] i965: Fix out-of-bounds accesses into pull_constant_loc array

2015-03-12 Thread Ian Romanick
Given the age of this bug, should this be a candidate for 10.4 and 10.5 stable branches? On 03/10/2015 03:36 AM, Iago Toral Quiroga wrote: The piglit test glsl-fs-uniform-array-loop-unroll.shader_test was designed to do an out of bounds access into an uniform array to make sure that we handle

[Mesa-dev] Ask for some HELP with Graphic Driver

2015-03-12 Thread Mostafa Farzane
Hello all I'm a college student. I have a project and have to write a graphic driver for a fixed function GPU that implemented on a FPGA. my question is : is that possible? and where and how can I start(I ask for some reference). I'm apologize for my poor english and if this is the wrong place

[Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Vivek Dasmohapatra
Hi - As you probably already know, there can only be one version of libstdc++.so in your runtime link chain - This is usually not a problem, but when things are linked against the Steam runtime (for example), they can end up with two - one from the steam runtime, and one pulled in via the mesa

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Jose Fonseca
On 11/03/15 16:01, Francisco Jerez wrote: Vivek Dasmohapatra vi...@collabora.co.uk writes: Hi - Hi, As you probably already know, there can only be one version of libstdc++.so in your runtime link chain That's a common misconception, in principle several versions of libstdc++.so with

Re: [Mesa-dev] [PATCH 1/5] i965/vs: Add missing resolve_bool_comparison calls on GEN4 and GEN5

2015-03-12 Thread Abdiel Janulgue
On 03/11/2015 10:44 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The ir_unop_any problem was discovered by some later optimization passes that generate ir_triop_csel. I was also able to reproduce it by modifying the gl-2.0-vertexattribpointer vertex shader to generate

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Francisco Jerez
Ian Romanick i...@freedesktop.org writes: On 03/11/2015 09:31 AM, Tobias Klausmann wrote: The problem in not forcing this to link statically is, that if a distribution decides to not use this static option, the problem persists on that distribution. On top every lib pulled in by steam from

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-12 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: --- src/mesa/drivers/dri/i965/brw_eu.h | 19 ++-- src/mesa/drivers/dri/i965/brw_eu_emit.c | 58 ++--

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Ilia Mirkin
On Wed, Mar 11, 2015 at 12:40 PM, Ian Romanick i...@freedesktop.org wrote: On 03/11/2015 09:31 AM, Tobias Klausmann wrote: The problem in not forcing this to link statically is, that if a distribution decides to not use this static option, the problem persists on that distribution. On top

[Mesa-dev] [PATCH] mesa: move fpclassify work-arounds into c99_math.h

2015-03-12 Thread Brian Paul
v2: Use #error in the #else clause, per Jose. --- include/c99_math.h | 44 ++ src/mesa/main/querymatrix.c | 51 + 2 files changed, 45 insertions(+), 50 deletions(-) diff --git a/include/c99_math.h

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Store a pointer to brw_sampler_prog_key_data in the visitor.

2015-03-12 Thread Kenneth Graunke
On Wednesday, March 11, 2015 10:44:26 AM Pohjolainen, Topi wrote: On Mon, Mar 09, 2015 at 01:58:51AM -0700, Kenneth Graunke wrote: The NIR backend hardcodes brw_wm_prog_key at the moment, which won't work when we support scalar VS. We could use get_tex(), but it's a static method. I was

Re: [Mesa-dev] [PATCH] mesa: move fpclassify work-arounds into c99_math.h

2015-03-12 Thread Jose Fonseca
On 11/03/15 16:48, Brian Paul wrote: v2: Use #error in the #else clause, per Jose. --- include/c99_math.h | 44 ++ src/mesa/main/querymatrix.c | 51 + 2 files changed, 45 insertions(+), 50 deletions(-)

Re: [Mesa-dev] [PATCH ] i965/aa: fixing anti-aliasing bug for thinnest width lines.

2015-03-12 Thread Matt Turner
On Wed, Mar 11, 2015 at 2:09 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Mar 11, 2015 at 5:57 PM, marius.pre...@intel.com wrote: From: Marius Predut marius.pre...@intel.com Set your email from name correctly in git and then you won't have this line in your git send-email results.

Re: [Mesa-dev] [PATCH 1/2] glsl: Expose built-in packing functions under GLSL 4.2.

2015-03-12 Thread Marek Olšák
Thanks. I noticed this too, but was too busy to fix it. For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Mar 12, 2015 at 2:45 AM, Matt Turner matts...@gmail.com wrote: ARB_shading_language_packing is part of GLSL 4.2, not 4.0 as I mistakenly believed. The following

[Mesa-dev] New stable-branch 10.5 candidate pushed

2015-03-12 Thread Emil Velikov
Hello list, The candidate for the Mesa 10.5.1 is now available. The current patch queue is as follows: - 57 queued - 3 nominated (outstanding) - and 2 rejected (obsolete) patches This provides us with over a dozen i965 fixes for all over the driver, some r300g ones (correct handling of RGTC1

[Mesa-dev] [Bug 89553] Account request

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89553 Brian Paul bri...@vmware.com changed: What|Removed |Added Component|Mesa core |New Accounts

Re: [Mesa-dev] [RFC] i965: Factor out descriptor building for indirect send messages

2015-03-12 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Tue, Mar 10, 2015 at 11:07:26PM +0200, Francisco Jerez wrote: Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Mon, Mar 09, 2015 at 12:43:08PM +0200, Francisco Jerez wrote: Pohjolainen, Topi topi.pohjolai...@intel.com writes:

Re: [Mesa-dev] [PATCH] mesa: move fpclassify work-arounds into c99_math.h

2015-03-12 Thread Brian Paul
On 03/12/2015 04:41 AM, Jose Fonseca wrote: On 11/03/15 16:48, Brian Paul wrote: v2: Use #error in the #else clause, per Jose. --- include/c99_math.h | 44 ++ src/mesa/main/querymatrix.c | 51 + 2 files

[Mesa-dev] [PATCH] egl: fix cast to silence compiler warning

2015-03-12 Thread Brian Paul
eglcurrent.c: In function '_eglSetTSD': eglcurrent.c:57:4: warning: passing argument 2 of 'tss_set' discards 'const' qualifier from pointer target type [enabled by default] tss_set(_egl_TSD, (const void *) t); ^ In file included from ../../../include/c11/threads.h:72:0,

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-12 Thread Francisco Jerez
Francisco Jerez curroje...@riseup.net writes: Matt Turner matts...@gmail.com writes: On Wed, Mar 11, 2015 at 2:29 PM, Francisco Jerez curroje...@riseup.net wrote: Matt Turner matts...@gmail.com writes: commit 4c4934636cb286e7d7836afc26e9d392e2f0f155 Author: Paul Berry

Re: [Mesa-dev] [GSoC] Improved application of GLSL complier optimizations

2015-03-12 Thread Matt Turner
On Tue, Mar 3, 2015 at 11:43 AM, Alexander Mezin mezin.alexan...@gmail.com wrote: Hello. I plan to participate in GSoC this year as a student. And I've found a project idea which I like very much on X.Org's ideas page. It's called Improved application of GLSL compiler optimizations. For me,

[Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-12 Thread Matt Turner
Here are some ideas I think might be reasonable GSoC ideas. - GLSL linking in NIR - Would allow us to stop doing optimizations and other expensive things on GLSL IR - SSA in the i965/fs backend, and an SSA-based register allocator - Improve instruction scheduling in i965 (Nouveau has

[Mesa-dev] [PATCH] freedreno/a3xx: use the same layer size for all slices

2015-03-12 Thread Ilia Mirkin
We only program in one layer size per texture, so that means that all levels must share one size. This makes the piglit test bin/texelFetch fs sampler2DArray have the same breakage as its non-array version instead of being completely off. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.4

[Mesa-dev] [PATCH] freedreno: fix slice pitch calculations

2015-03-12 Thread Ilia Mirkin
For example if width were 65, the first slice would get 96 while the second would get 32. However the hardware appears to expect the second pitch to be 64, based on halving the 96 (and aligning up to 32). This fixes texelFetch piglit tests on a3xx. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-12 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 12:46 AM, Matt Turner matts...@gmail.com wrote: Here are some ideas I think might be reasonable GSoC ideas. - GLSL linking in NIR - Would allow us to stop doing optimizations and other expensive things on GLSL IR - SSA in the i965/fs backend, and an SSA-based

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-12 Thread Jason Ekstrand
Sean, I got ready to push this and ran it against piglit and one of the tests errored out. Looking into it further, it was a bug in the test. I've sent a patch: http://lists.freedesktop.org/archives/piglit/2015-March/015156.html I'll merge the mesa commit once we get piglit fixed. --Jason On

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Michel Dänzer
On 13.03.2015 03:07, Pierre-Loup A. Griffais wrote: On 03/11/2015 09:40 AM, Ian Romanick wrote: On 03/11/2015 09:31 AM, Tobias Klausmann wrote: The problem in not forcing this to link statically is, that if a distribution decides to not use this static option, the problem persists on that

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-12 Thread Jason Ekstrand
On Thu, Mar 12, 2015 at 9:24 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Sean, I got ready to push this and ran it against piglit and one of the tests errored out. Looking into it further, it was a bug in the test. I've sent a patch:

Re: [Mesa-dev] [PATCH 2/2] nir: Optimize a + neg(a)

2015-03-12 Thread Erik Faye-Lund
On Sat, Feb 28, 2015 at 9:19 PM, Matt Turner matts...@gmail.com wrote: On Sat, Feb 28, 2015 at 11:47 AM, Thomas Helland thomashellan...@gmail.com wrote: On Feb 28, 2015 8:39 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Both patches are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com

[Mesa-dev] [Bug 89562] glXSwapIntervalMESA crashes when making use of GLX_MESA_multithread_makecurrent

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89562 Bug ID: 89562 Summary: glXSwapIntervalMESA crashes when making use of GLX_MESA_multithread_makecurrent Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-12 Thread Matt Turner
On Thu, Mar 12, 2015 at 7:10 AM, Francisco Jerez curroje...@riseup.net wrote: Meh, I've modified PATCH 01 so it drops the send destination type changes in the Gen7 pull constant load code (see attachment). Do we know if the destination type of the SEND instruction has any other subtle

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Kai Wasserbäch
Michel Dänzer wrote on 12.03.2015 08:15: On 11.03.2015 05:07, Vivek Dasmohapatra wrote: Hi - As you probably already know, there can only be one version of libstdc++.so in your runtime link chain - This is usually not a problem, but when things are linked against the Steam runtime (for

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-12 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: Change brw_untyped_atomic() and brw_untyped_surface_read() to take the surface index as a register instead of a constant and to use brw_send_indirect_message() to emit the indirect variant of send with a dynamically calculated

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

2015-03-12 Thread Laura Ekstrand
Emil, I spoke with Neil Roberts, and the two patches of mine you have listed as rejected here are required basis for his four queued commits (all of these pertain to meta_pbo_texSubImage). The only patch that was reverted was my 1D ARRAY patch. Laura On Thu, Mar 12, 2015 at 6:50 AM, Emil

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-12 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: Change brw_untyped_atomic() and brw_untyped_surface_read() to take the surface index as a register instead of a constant and to use brw_send_indirect_message() to emit the indirect variant of send with a dynamically calculated

Re: [Mesa-dev] [PATCH 04/13] i965: Mask out unused Align16 components in brw_untyped_atomic.

2015-03-12 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:47PM +0200, Francisco Jerez wrote: This is currently not a problem because the vec4 visitor happens to mask out unused components from the destination, but it might become an issue when we start using atomics without writeback message. In any case it seems

Re: [Mesa-dev] [PATCH 04/13] i965: Mask out unused Align16 components in brw_untyped_atomic.

2015-03-12 Thread Pohjolainen, Topi
On Fri, Mar 06, 2015 at 02:56:24PM +0200, Francisco Jerez wrote: Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:47PM +0200, Francisco Jerez wrote: This is currently not a problem because the vec4 visitor happens to mask out unused components from the

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-12 Thread Pohjolainen, Topi
On Thu, Mar 12, 2015 at 07:25:34PM +0200, Francisco Jerez wrote: Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: Change brw_untyped_atomic() and brw_untyped_surface_read() to take the surface index as a register instead

Re: [Mesa-dev] [PATCH 3/4 v3] mesa: Separate PBO validation checks from buffer mapping, to allow reuse

2015-03-12 Thread Laura Ekstrand
On Thu, Mar 12, 2015 at 12:14 AM, Eduardo Lima Mitev el...@igalia.com wrote: Internal PBO functions such as _mesa_map_validate_pbo_source() and _mesa_validate_pbo_compressed_teximage() perform validation and buffer mapping within the same call. This patch takes out the validation into

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-12 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: Change brw_untyped_atomic() and brw_untyped_surface_read() to take the surface index as a register instead of a constant and to use brw_send_indirect_message() to emit the

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-12 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: Change brw_untyped_atomic() and brw_untyped_surface_read() to take the surface index as a register instead of a constant and to use brw_send_indirect_message() to emit the

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

2015-03-12 Thread Daniel Vetter
On Wed, Mar 11, 2015 at 09:10:01AM -0700, Ian Romanick wrote: On 03/06/2015 06:30 AM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 02:38:44PM -0800, Ian Romanick wrote: On 03/04/2015 10:28 AM, Chad Versace wrote: That text does not appear in the GL spec. When I read the manpage alongside

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

2015-03-12 Thread Laura Ekstrand
That's okay, just wanted to make sure that 10.5 was correct. On Thu, Mar 12, 2015 at 1:49 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 12/03/15 16:55, Laura Ekstrand wrote: Emil, I spoke with Neil Roberts, and the two patches of mine you have listed as rejected here are required

[Mesa-dev] [Bug 89563] Bug in configure verifying xcb version

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89563 Bug ID: 89563 Summary: Bug in configure verifying xcb version Product: Mesa Version: 10.5 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

2015-03-12 Thread Emil Velikov
On 12/03/15 16:55, Laura Ekstrand wrote: Emil, I spoke with Neil Roberts, and the two patches of mine you have listed as rejected here are required basis for his four queued commits (all of these pertain to meta_pbo_texSubImage). The only patch that was reverted was my 1D ARRAY patch. Hi

[Mesa-dev] [Bug 89563] Bug in configure verifying xcb version

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89563 --- Comment #1 from Jan Vesely jan.ves...@rutgers.edu --- (In reply to MichaelJ from comment #0) Incorrect error message DRI3 requires xcb = 1.9.3 when installed version of libxcb is 1.9-5, later then 1.9.3. libxcb -v returns 1.9-5.el7 but is

Re: [Mesa-dev] [PATCH 3/3] util: Optimize _mesa_roundeven with SSE 4.1.

2015-03-12 Thread Matt Turner
On Thu, Mar 12, 2015 at 1:11 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Mar 12, 2015 at 3:11 PM, Matt Turner matts...@gmail.com wrote: The SSE 4.1 ROUND instructions let us implement roundeven directly. Otherwise we assume that the rounding mode has not been modified (as we do in the

[Mesa-dev] [PATCH] Revert main: _mesa_cube_level_complete checks NumLayers.

2015-03-12 Thread Laura Ekstrand
This reverts commit 1ee000a0b6737d6c140d4f07b6044908b8ebfdc7. Failures with the GLES3 conformance suite and Synmark2 OGLHdrBloom revealed that this commit might be in error. A look at the offended test in GLES3 conformance suite, NPOT gen mipmap, suggests that NumLayers may not actually always be

[Mesa-dev] Resend [PATCH] glx: Handle out-of-sequence swap completion events correctly.

2015-03-12 Thread Mario Kleiner
Hi all, a respin of the bugfix for INTEL_swap_events + DRI3/Present. The code in the patch itself is identical to the one queued for Mesa 10.5.1, the one apparently nobody wants to review - I hate wraparound handling too... The only difference is a much longer commit message which explains why

Re: [Mesa-dev] [PATCH] Revert main: _mesa_cube_level_complete checks NumLayers.

2015-03-12 Thread Laura Ekstrand
It appears that our Piglit tests that hit glGenerateMipmap always create the cube map texture with Texture Storage, so Num Layers always gets set to 6. I will make a simple test this afternoon for non texture storage cube maps. On Mar 12, 2015 12:33 PM, Laura Ekstrand la...@jlekstrand.net wrote:

[Mesa-dev] [PATCH] glx: Handle out-of-sequence swap completion events correctly. (v2)

2015-03-12 Thread Mario Kleiner
The code for emitting INTEL_swap_events swap completion events needs to translate from 32-Bit sbc on the wire to 64-Bit sbc for the events and handle wraparound accordingly. It assumed that events would be sent by the server in the order their corresponding swap requests were emitted from the

Re: [Mesa-dev] [PATCH 3/3] util: Optimize _mesa_roundeven with SSE 4.1.

2015-03-12 Thread Ilia Mirkin
On Thu, Mar 12, 2015 at 3:11 PM, Matt Turner matts...@gmail.com wrote: The SSE 4.1 ROUND instructions let us implement roundeven directly. Otherwise we assume that the rounding mode has not been modified (as we do in the rest of Mesa) and use rint(). glibc uses the ROUND instruction in rint()

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptrRTDyldMemoryManager'

2015-03-12 Thread Jose Fonseca
On 12/03/15 18:07, Sedat Dilek wrote: On Fri, Mar 6, 2015 at 8:06 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 4 March 2015 at 18:07, Roland Scheidegger srol...@vmware.com wrote: Am 04.03.2015 um 12:38 schrieb Jose Fonseca: On 04/03/15 02:00, Emil Velikov wrote: On 27 February 2015 at

Re: [Mesa-dev] [RFC PATCH] mesa: Replace _mesa_round_to_even() with roundeven().

2015-03-12 Thread Matt Turner
On Wed, Mar 11, 2015 at 3:34 PM, Carl Worth cwo...@cworth.org wrote: So I think I'd like to see at least three or four commits here: 1. Change _mesa_round_to_even to return a float I don't think this is really meaningful as a separate change. The current _mesa_round_to_even function

[Mesa-dev] [PATCH 3/3] util: Optimize _mesa_roundeven with SSE 4.1.

2015-03-12 Thread Matt Turner
The SSE 4.1 ROUND instructions let us implement roundeven directly. Otherwise we assume that the rounding mode has not been modified (as we do in the rest of Mesa) and use rint(). glibc uses the ROUND instruction in rint() after a cpuid check. This patch just lets us inline it directly when we're

[Mesa-dev] [PATCH 2/3] util: Add a roundeven test.

2015-03-12 Thread Matt Turner
--- src/util/Makefile.am | 4 +- src/util/roundeven_test.c | 140 ++ 2 files changed, 143 insertions(+), 1 deletion(-) create mode 100644 src/util/roundeven_test.c diff --git a/src/util/Makefile.am b/src/util/Makefile.am index ec49dc6..2e7542e

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Apply gl_FrontFacing ? -1 : 1 optimization only for floats

2015-03-12 Thread Ian Romanick
On 03/11/2015 04:10 PM, Matt Turner wrote: On Wed, Mar 11, 2015 at 1:44 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com At the very least, unreal4/sun-temple/102.shader_test uses this pattern for a signed integer result. However, that shader did not

Re: [Mesa-dev] [PATCH 11/13] i965: Add untyped surface write opcode.

2015-03-12 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:54PM +0200, Francisco Jerez wrote: --- src/mesa/drivers/dri/i965/brw_defines.h| 1 + src/mesa/drivers/dri/i965/brw_eu.h | 7 +++ src/mesa/drivers/dri/i965/brw_eu_emit.c| 51 ++

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Pierre-Loup A. Griffais
On 03/11/2015 09:40 AM, Ian Romanick wrote: On 03/11/2015 09:31 AM, Tobias Klausmann wrote: The problem in not forcing this to link statically is, that if a distribution decides to not use this static option, the problem persists on that distribution. On top every lib pulled in by steam from

[Mesa-dev] [PATCH 1/3] mesa: Replace _mesa_round_to_even() with _mesa_roundeven().

2015-03-12 Thread Matt Turner
Eric's initial patch adding constant expression evaluation for ir_unop_round_even used nearbyint. The open-coded _mesa_round_to_even implementation came about without much explanation after a reviewer asked whether nearbyint depended on the application not modifying the rounding mode. Of course

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Make private copies of name strings provided by client.

2015-03-12 Thread Brian Paul
On 03/12/2015 04:34 PM, Mario Kleiner wrote: glXGetProcAddress(glFoo) ends up in stub_add_dynamic() to create dynamic stubs for dynamic functions. stub_add_dynamic() doesn't store the caller provided name string Foo in a mesa private copy, but just stores a pointer to the glFoo string passed to

Re: [Mesa-dev] [PATCH 1/3] mesa: Replace _mesa_round_to_even() with _mesa_roundeven().

2015-03-12 Thread Roland Scheidegger
Am 12.03.2015 um 23:53 schrieb Carl Worth: On Thu, Mar 12 2015, Matt Turner wrote: I think you misread. rint() *does* provide the behavior we want (round-to-nearest, half to even) when the rounding mode is the default round-to-nearest. Thanks. I did at least verify that behaviorally as I

[Mesa-dev] [PATCH] gallivm: (trivial) Fix typo in comment introduced by 70dc8a

2015-03-12 Thread Alexandre Demers
Fix typo in comment introduced by 70dc8a Signed-off-by: Alexandre Demers alexandre.f.dem...@gmail.com --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp

Re: [Mesa-dev] [PATCH 1/3] mesa: Replace _mesa_round_to_even() with _mesa_roundeven().

2015-03-12 Thread Matt Turner
On Thu, Mar 12, 2015 at 3:53 PM, Carl Worth cwo...@cworth.org wrote: On Thu, Mar 12 2015, Matt Turner wrote: I think you misread. rint() *does* provide the behavior we want (round-to-nearest, half to even) when the rounding mode is the default round-to-nearest. Thanks. I did at least verify

[Mesa-dev] [Bug 89563] Bug in configure verifying xcb version

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89563 --- Comment #3 from Matt Turner matts...@gmail.com --- This sounds to me like you have 1.9 with some patches applied. If that's the case, configure is rightly failing. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [PATCH] util: convert slab macros to inline functions

2015-03-12 Thread Brian Paul
--- src/gallium/auxiliary/util/u_slab.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_slab.h b/src/gallium/auxiliary/util/u_slab.h index 29d0252..8f8b29b 100644 --- a/src/gallium/auxiliary/util/u_slab.h +++

[Mesa-dev] [PATCH] mapi: Make private copies of name strings provided by client.

2015-03-12 Thread Mario Kleiner
glXGetProcAddress(glFoo) ends up in stub_add_dynamic() to create dynamic stubs for dynamic functions. stub_add_dynamic() doesn't store the caller provided name string Foo in a mesa private copy, but just stores a pointer to the glFoo string passed to glXGetProcAddress - a pointer into arbitrary

[Mesa-dev] [Bug 89563] Bug in configure verifying xcb version

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89563 --- Comment #2 from MichaelJ emjot...@gmail.com --- Response for this command is 1.9 Yum reports package 1.9-5.el7. this is latest available for my yum repositories. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 89563] Bug in configure verifying xcb version

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89563 MichaelJ emjot...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 1/3] mesa: Replace _mesa_round_to_even() with _mesa_roundeven().

2015-03-12 Thread Matt Turner
On Thu, Mar 12, 2015 at 2:59 PM, Carl Worth cwo...@cworth.org wrote: On Thu, Mar 12 2015, Matt Turner wrote: +/* The C standard library has functions round()/rint()/nearbyint() that round + * their arguments according to the rounding mode set in the floating-point + * control register. While

Re: [Mesa-dev] [PATCH 1/3] mesa: Replace _mesa_round_to_even() with _mesa_roundeven().

2015-03-12 Thread Carl Worth
On Thu, Mar 12 2015, Matt Turner wrote: I think you misread. rint() *does* provide the behavior we want (round-to-nearest, half to even) when the rounding mode is the default round-to-nearest. Thanks. I did at least verify that behaviorally as I just mentioned in a separate mail. As Eric

Re: [Mesa-dev] [PATCH 1/3] mesa: Replace _mesa_round_to_even() with _mesa_roundeven().

2015-03-12 Thread Carl Worth
On Thu, Mar 12 2015, Matt Turner wrote: +/* The C standard library has functions round()/rint()/nearbyint() that round + * their arguments according to the rounding mode set in the floating-point + * control register. While there are trunc()/ceil()/floor() functions that do + * a specific

Re: [Mesa-dev] [PATCH 1/3] mesa: Replace _mesa_round_to_even() with _mesa_roundeven().

2015-03-12 Thread Carl Worth
On Thu, Mar 12 2015, Carl Worth wrote: But beyond that, I'm actually confused---how can the default rounding mode (rounding toward nearest number, right?) give us an adequate implementation for roundeven()? Of course, I had asked for (and received) a patch with a test. And the test verifies

Re: [Mesa-dev] [PATCH] egl: Create queryable strings in eglInitialize().

2015-03-12 Thread Chad Versace
On 03/10/2015 09:15 PM, Matt Turner wrote: On Tue, Mar 10, 2015 at 8:19 PM, Ian Romanick i...@freedesktop.org wrote: On 03/10/2015 05:20 PM, Matt Turner wrote: Creating/recreating the strings in eglQueryString() is extra work and isn't thread-safe, as exhibited by shader-db's run.c using

Re: [Mesa-dev] [PATCH] i965: Defer the throttle until we submit new commands

2015-03-12 Thread Chad Versace
On 03/11/2015 05:36 AM, Chris Wilson wrote: Currently, we throttle before the user begins preparing commands for the next frame when we acquire the draw/read buffers. However, construction of the command buffer can itself take significant time relative to the frame time. If we move the

[Mesa-dev] [Bug 89387] Double delete in lp_bld_misc.cpp

2015-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89387 José Fonseca jfons...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-12 Thread Jose Fonseca
On 12/03/15 00:07, Emil Velikov wrote: On 9 March 2015 at 11:54, Jose Fonseca jfons...@vmware.com wrote: On 07/03/15 19:38, Emil Velikov wrote: On 07/03/15 07:23, Jose Fonseca wrote: ... we still didn't eliminate the use of non-portable _MTX_INITIALIZER_NP from Mesa tree gave me pause.

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-12 Thread Matt Turner
On Wed, Mar 11, 2015 at 1:07 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Wednesday, March 11, 2015 07:25:14 PM Francisco Jerez wrote: Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: @@ -1218,17 +1198,6 @@

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-12 Thread Sean Burke
Jason, No worries. It looks like my mail client munged the patch in some way. I'm sending it as an attachment in the hopes that it will remain untouched. Sean Burke On Wed, Mar 11, 2015 at 2:53 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Sean, Sorry it's taken so long for me to get to

Re: [Mesa-dev] [PATCH] util: convert slab macros to inline functions

2015-03-12 Thread Matt Turner
On Thu, Mar 12, 2015 at 2:54 PM, Brian Paul bri...@vmware.com wrote: --- src/gallium/auxiliary/util/u_slab.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_slab.h b/src/gallium/auxiliary/util/u_slab.h index 29d0252..8f8b29b

Re: [Mesa-dev] [PATCH] util: convert slab macros to inline functions

2015-03-12 Thread Brian Paul
On 03/12/2015 05:03 PM, Matt Turner wrote: On Thu, Mar 12, 2015 at 2:54 PM, Brian Paul bri...@vmware.com wrote: --- src/gallium/auxiliary/util/u_slab.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_slab.h

[Mesa-dev] [PATCH 3/4 v3] mesa: Separate PBO validation checks from buffer mapping, to allow reuse

2015-03-12 Thread Eduardo Lima Mitev
Internal PBO functions such as _mesa_map_validate_pbo_source() and _mesa_validate_pbo_compressed_teximage() perform validation and buffer mapping within the same call. This patch takes out the validation into separate functions to allow reuse of functionality by other code (i.e,

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-12 Thread Michel Dänzer
On 11.03.2015 05:07, Vivek Dasmohapatra wrote: Hi - As you probably already know, there can only be one version of libstdc++.so in your runtime link chain - This is usually not a problem, but when things are linked against the Steam runtime (for example), they can end up with two - one from

[Mesa-dev] [PATCH 4/4 v3] mesa: Check for valid PBO access in gl(Compressed)Tex(Sub)Image calls

2015-03-12 Thread Eduardo Lima Mitev
This patch adds two types of checks to the gl(Compressed)Tex(Sub)Imgage family of functions when a pixel buffer object is bound to GL_PIXEL_UNPACK_BUFFER: - That the buffer is not mapped. - The total data size is within the boundaries of the buffer size. It does so by calling auxiliary

Re: [Mesa-dev] [PATCH ] vbo: improve the code style by adjust the preprocessing c code directives.

2015-03-12 Thread Brian Paul
On 03/09/2015 01:44 PM, marius.pre...@intel.com wrote: From: Marius Predut marius.pre...@intel.com Brain Paul review suggestion: there's more macro use here than necessary. Brian Removed and redefine some #define preprocessing directives. Removed the directive input parameter 'T' . No

Re: [Mesa-dev] [PATCH 7/9] radeonsi: add support for easy opcodes from ARB_gpu_shader5

2015-03-12 Thread Marek Olšák
It seems overkill to use LLVM IR for BFE. There are several ways to express BFE(value, offset, bits) exactly, for example: # if bits == 0: # 0 # else if offset + bits 32: # (value (32 - offset - bits)) (32 - bits) # else: # value offset Which can be simplified to either: # both