Re: [Mesa-dev] [PATCH 01/18] gallium/util: clear up that debug_get_flags_option returns a 64-bit mask

2015-07-29 Thread Kai Wasserbäch
Marek Olšák wrote on 28.07.2015 21:42: On Tue, Jul 28, 2015 at 6:35 PM, Kai Wasserbäch k...@dev.carbon-project.org wrote: Marek Olšák wrote on 28.07.2015 12:05: From: Marek Olšák marek.ol...@amd.com --- src/gallium/auxiliary/util/u_debug.c | 8

Re: [Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-07-29 Thread Alex Deucher
On Wed, Jul 29, 2015 at 12:19 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Strictly speaking the xcb_connection_has_error() might be sufficient, yet the documentation does not mention what will happen if NULL is fed to the function. Keep things explicit, which will allow us to remove the

Re: [Mesa-dev] [PATCH] i965: Silence signed-unsigned int comparison warning by compiler

2015-07-29 Thread Anuj Phogat
On Wed, Jul 29, 2015 at 9:45 AM, Matt Turner matts...@gmail.com wrote: On Tue, Jul 28, 2015 at 4:45 PM, Anuj Phogat anuj.pho...@gmail.com wrote: brw_cs.cpp:386:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Anuj Phogat

[Mesa-dev] [PATCH] docs: rename/bump 10.7.0 release notes to 11.0.0

2015-07-29 Thread Emil Velikov
Recently a few drivers have grown OpenGL 4+ support so we might as well go all the way to... 11 ;-) Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- Hats down for all that made it possible. Keep up the amazing work ! -Emil docs/relnotes/{10.7.0.html = 11.0.0.html} | 12 ++-- 1

Re: [Mesa-dev] [PATCH] meta/copy_image: Stash off the scissor

2015-07-29 Thread Matt Turner
On Tue, Jul 28, 2015 at 12:06 PM, Jason Ekstrand ja...@jlekstrand.net wrote: The meta CopyImageSubData path uses BlitFramebuffers to do the actual copy. The only thing that can affect BlitFramebuffers other than the currently bound framebuffers is the scissor so we need to save that off and

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-29 Thread Anuj Phogat
On Wed, Jul 29, 2015 at 12:20 AM, Iago Toral ito...@igalia.com wrote: Funny, we had 3 instances of the same function with the same implementation :), there is still util_is_power_of_two in Gallium btw. Yes. I wasn't sure if we can use main/imports.h in gallium. So, I didn't touch it.

[Mesa-dev] [PATCH] i965/bxt: Don't use brw_device_info_skl_early on BXT

2015-07-29 Thread Neil Roberts
Previously it could end up using the “SKL early” device on BXT depending on the revision number. This would probably break things because for example has_llc would be wrong. --- src/mesa/drivers/dri/i965/brw_device_info.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] i965: Change the type of max_{vs, hs, ...}_threads variables to unsigned

2015-07-29 Thread Matt Turner
On Wed, Jul 29, 2015 at 10:11 AM, Anuj Phogat anuj.pho...@gmail.com wrote: Fixes following compiler warning: brw_cs.cpp:386:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Cc: Matt Turner

Re: [Mesa-dev] [PATCH] docs: rename/bump 10.7.0 release notes to 11.0.0

2015-07-29 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Do you also need to do something for it to claim it's 11.0-gblah in the version? On Wed, Jul 29, 2015 at 1:20 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Recently a few drivers have grown OpenGL 4+ support so we might as well go all the way

Re: [Mesa-dev] [PATCH] winsys/radeon: don't leak the fd when it is 0

2015-07-29 Thread Alex Deucher
On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue. Although it did not consider the (very unlikely) case where we might end up with the valid fd == 0. Fixes: 28dda47ae4d(winsys/radeon: Use dup fd as

[Mesa-dev] [PATCH] i965: Change the type of max_{vs, hs, ...}_threads variables to unsigned

2015-07-29 Thread Anuj Phogat
Fixes following compiler warning: brw_cs.cpp:386:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Cc: Matt Turner matts...@gmail.com --- src/mesa/drivers/dri/i965/brw_context.h | 12 ++--

Re: [Mesa-dev] [PATCH 5/6] egl/x11: trust our loader over the xserver for the drivername

2015-07-29 Thread Matt Turner
On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov emil.l.veli...@gmail.com wrote: This is a port of commit 7bd95ec437a(dri2: Trust our own driver name lookup over the server's.) from glx/dri2. Cc: Eric Anholt e...@anholt.net Cc: Julien Isorce julien.iso...@gmail.com Reported-by: Julien Isorce

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-29 Thread Neil Roberts
It seems a bit weird to modify the the is_power_of_two functions in format_parser.py, was that intentional? It doesn't look like those functions are actually used anywhere so maybe we could just remove them, although it would probably make sense to do that in a separate patch. Regards, - Neil

Re: [Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-07-29 Thread Matt Turner
On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Strictly speaking the xcb_connection_has_error() might be sufficient, yet the documentation does not mention what will happen if NULL is fed to the function. Keep things explicit, which will allow us to remove the

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-29 Thread Anuj Phogat
On Wed, Jul 29, 2015 at 8:16 AM, Neil Roberts n...@linux.intel.com wrote: It seems a bit weird to modify the the is_power_of_two functions in format_parser.py, was that intentional? It doesn't look like those functions are actually used anywhere so maybe we could just remove them, although it

Re: [Mesa-dev] [PATCH] i965: Silence signed-unsigned int comparison warning by compiler

2015-07-29 Thread Matt Turner
On Tue, Jul 28, 2015 at 4:45 PM, Anuj Phogat anuj.pho...@gmail.com wrote: brw_cs.cpp:386:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_cs.cpp | 2 +- 1 file

Re: [Mesa-dev] [PATCH] i965/bxt: Support 3src simd16 instructions

2015-07-29 Thread Neil Roberts
I tested this on my BXT by running the glsl-fs-color-matrix test (which ends up using MAD in SIMD16) and it worked fine. Tested-by: Neil Roberts n...@linux.intel.com Reviewed-by: Neil Roberts n...@linux.intel.com - Neil Ben Widawsky benjamin.widaw...@intel.com writes: This is easily

[Mesa-dev] [PATCH 2/6] egl/x11: remove dri2_dpy-conn checks

2015-07-29 Thread Emil Velikov
If the connection is NULL we won't be able to get here. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/drivers/dri2/platform_x11.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c

[Mesa-dev] [PATCH 4/6] egl/x11: open the device from within dri2_x11_connect()

2015-07-29 Thread Emil Velikov
Allows us, with the next commit, to use alternative driver_name rather than the one from xserver. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/drivers/dri2/platform_x11.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 5/6] egl/x11: trust our loader over the xserver for the drivername

2015-07-29 Thread Emil Velikov
This is a port of commit 7bd95ec437a(dri2: Trust our own driver name lookup over the server's.) from glx/dri2. Cc: Eric Anholt e...@anholt.net Cc: Julien Isorce julien.iso...@gmail.com Reported-by: Julien Isorce julien.iso...@gmail.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

[Mesa-dev] [PATCH 3/6] egl/x11: fetch the device_name prior to driver_name

2015-07-29 Thread Emil Velikov
With the follow up commits we're about to further reshuffle things. Thus we'll honour our our driver_name lookup (src/loader), and use the one provided by xserver as a fall-back. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/drivers/dri2/platform_x11.c | 10 +- 1 file

[Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

2015-07-29 Thread Emil Velikov
Strictly speaking the xcb_connection_has_error() might be sufficient, yet the documentation does not mention what will happen if NULL is fed to the function. Keep things explicit, which will allow us to remove the dri2_dpy-conn checking with the next commit. Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 6/6] egl/x11: auth with xserver before attempting to open the dri module

2015-07-29 Thread Emil Velikov
No real change, apart from keeping the calls to the underlying winsys (x11) next to each other. Just like platform_wayland. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/drivers/dri2/platform_x11.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] svga: scons: remove unused HAVE_SYS_TYPES_H define

2015-07-29 Thread Emil Velikov
On 28 July 2015 at 14:37, Brian Paul bri...@vmware.com wrote: On 07/28/2015 07:33 AM, Emil Velikov wrote: On 20 July 2015 at 17:12, Brian Paul bri...@vmware.com wrote: On 07/17/2015 02:14 PM, Emil Velikov wrote: On 17 July 2015 at 20:22, Brian Paul bri...@vmware.com wrote: Can you

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 Heiko lil_...@web.de changed: What|Removed |Added CC||lil_...@web.de --- Comment #40

Re: [Mesa-dev] [PATCH] winsys/radeon: don't leak the fd when it is 0

2015-07-29 Thread Mario Kleiner
On 07/29/2015 05:46 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue. Although it did not consider the (very unlikely) case where we might end up with the valid fd == 0.

Re: [Mesa-dev] [PATCH v2 05/23] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2015-07-29 Thread Marek Olšák
Hi, Where does the spec say we should fail to link? I don't see such a statement there. It looks like varyings with stream 0 should not be linked with the fragment shader. Marek On Wed, Jun 18, 2014 at 11:51 AM, Iago Toral Quiroga ito...@igalia.com wrote: Outputs that are linked to inputs in

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add GS multiple streams support (v1.1)

2015-07-29 Thread Marek Olšák
On Wed, Jul 29, 2015 at 1:20 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This is the final piece for ARB_gpu_shader5, The code is based on the r600 code from Glenn Kennard, and myself. While developing this, I'm not 100% sure of all the calculations made

Re: [Mesa-dev] [PATCH 13/17] glsl: Add default precision qualifiers to the symbol table

2015-07-29 Thread Ian Romanick
On 07/29/2015 02:50 PM, Ian Romanick wrote: On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: From: Iago Toral Quiroga ito...@igalia.com The GLSL ES spec specifies default precision qualifiers for certain types, so populate the symbol table with these. Notice that the desktop GLSL

Re: [Mesa-dev] [PATCH 16/17] glsl: Add link time checks for GLSL precision qualifiers

2015-07-29 Thread Ian Romanick
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: From: Iago Toral Quiroga ito...@igalia.com Currently, we only consider precision qualifiers at compile-time. This patch adds precision information to ir_variable so we can also do link time checks. Specifically, from the GLSL ES3 spec,

Re: [Mesa-dev] List of unsupported extensions per driver

2015-07-29 Thread Marek Olšák
R600/R700 can also do: - ARB_conditional_render_inverted - ARB_cull_distance Marek On Wed, Jul 29, 2015 at 11:46 PM, Marek Olšák mar...@gmail.com wrote: Hi Ilia, R600/R700: - can't do ARB_shader_storage_buffer_object - can do ARB_robust_buffer_access_behavior (I think this one can really

Re: [Mesa-dev] [PATCH] i965/bxt: Don't use brw_device_info_skl_early on BXT

2015-07-29 Thread Kenneth Graunke
On Wednesday, July 29, 2015 05:51:46 PM Neil Roberts wrote: Previously it could end up using the “SKL early” device on BXT depending on the revision number. This would probably break things because for example has_llc would be wrong. --- src/mesa/drivers/dri/i965/brw_device_info.c | 4 +++-

[Mesa-dev] [RFC] [PATCH 2/3 v2] nir: Add a LCSAA-pass

2015-07-29 Thread Thomas Helland
The pass is now working (it does the right thing) but something ends up crashing after the pass is run, for some reason. I haven't gotten to debug this yet, but thought I'd replace the incredibly faulty patch that was on the list with a better one. Sorry for the noise. I've confirmed that phi's

Re: [Mesa-dev] [PATCH 10/21] nir/cf: add block_ends_in_jump()

2015-07-29 Thread Kenneth Graunke
On Tuesday, July 21, 2015 07:54:24 PM Connor Abbott wrote: Signed-off-by: Connor Abbott connor.w.abb...@intel.com --- src/glsl/nir/nir_control_flow.c | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_control_flow.c b/src/glsl/nir/nir_control_flow.c index

Re: [Mesa-dev] List of unsupported extensions per driver

2015-07-29 Thread Marek Olšák
Hi Ilia, R600/R700: - can't do ARB_shader_storage_buffer_object - can do ARB_robust_buffer_access_behavior (I think this one can really be exposed unconditionally on all GL=3 hardware) - can do ARB_framebuffer_no_attachments - ARB_query_buffer_object can be emulated with a vertex shader to read

Re: [Mesa-dev] [PATCH 4/4] radeonsi: enable GL4.1 and update documentation (v2)

2015-07-29 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jul 29, 2015 at 1:20 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This enables GL4.1 for radeonsi, and updates the docs in the correct places. v2: enable only for llvm 3.7 which has fixes in place.

Re: [Mesa-dev] [PATCH 13/17] glsl: Add default precision qualifiers to the symbol table

2015-07-29 Thread Ian Romanick
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: From: Iago Toral Quiroga ito...@igalia.com The GLSL ES spec specifies default precision qualifiers for certain types, so populate the symbol table with these. Notice that the desktop GLSL spec also indicates defaults for some types

Re: [Mesa-dev] [PATCH 15/17] glsl: Add precision information to ir_variable

2015-07-29 Thread Ian Romanick
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: From: Iago Toral Quiroga ito...@igalia.com We will need this later on when we implement proper support for precision qualifiers in the drivers and also to do link time checks for uniforms as indicated by the spec. This patch also

[Mesa-dev] [PATCH] Delete unused functions in format parser

2015-07-29 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Cc: Neil Roberts n...@linux.intel.com --- src/mesa/main/format_parser.py | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/mesa/main/format_parser.py b/src/mesa/main/format_parser.py index 11184f7..799b14f 100755 ---

Re: [Mesa-dev] [PATCH 05/17] mesa: Fix GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE for default framebuffer.

2015-07-29 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com I think this patch could also be tagged for the 10.6.x series. On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: From: Iago Toral Quiroga ito...@igalia.com From section 9.2. Binding and Managing Framebuffer Objects:

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 Gustaw Smolarczyk wielkie...@gmail.com changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] i965/skl: Add production thread counts and URB size

2015-07-29 Thread Ben Widawsky
This patch adjusts the SKL values to the best known values we have. It also adds the missing HS/DS/CS fields. To support this patch I needed to add some default values to BXT. Those values are just minimal values which we can use for enabling. Note to backporter: You can drop the BXT change

Re: [Mesa-dev] [PATCH 06/17] mesa: Fix errors values returned by glShaderBinary()

2015-07-29 Thread Ian Romanick
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: From: Eduardo Lima Mitev el...@igalia.com Page 68, section 7.2 'Shader Binaries of the of the OpenGL ES 3.1, and page 88 of the OpenGL 4.5 specs state: An INVALID_VALUE error is generated if count or length is negative. An

Re: [Mesa-dev] [PATCH] Delete unused functions in format parser

2015-07-29 Thread Neil Roberts
Looks good to me. Reviewed-by: Neil Roberts n...@linux.intel.com - Neil Anuj Phogat anuj.pho...@gmail.com writes: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Cc: Neil Roberts n...@linux.intel.com --- src/mesa/main/format_parser.py | 7 --- 1 file changed, 7 deletions(-) diff

Re: [Mesa-dev] [PATCH] winsys/radeon: don't leak the fd when it is 0

2015-07-29 Thread Alex Deucher
On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner mario.kleiner...@gmail.com wrote: On 07/29/2015 05:46 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue. Although it did not

Re: [Mesa-dev] [PATCH 03/17] mesa: fix deletion of inactive bound transform feedback object

2015-07-29 Thread Ian Romanick
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: When a transform feedback object is bound and not active, the OpenGL ES 3.0 and GL_ARB_transform_feedback2 specs don't explicitly disallow its deletion. Only the deletion of the default framebuffer object is

Re: [Mesa-dev] [PATCH] winsys/radeon: don't leak the fd when it is 0

2015-07-29 Thread Mario Kleiner
On 07/29/2015 08:50 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner mario.kleiner...@gmail.com wrote: On 07/29/2015 05:46 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Earlier commit added an extra dup(fd) to

Re: [Mesa-dev] [PATCH] winsys/radeon: don't leak the fd when it is 0

2015-07-29 Thread Alex Deucher
On Wed, Jul 29, 2015 at 2:55 PM, Mario Kleiner mario.kleiner...@gmail.com wrote: On 07/29/2015 08:50 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner mario.kleiner...@gmail.com wrote: On 07/29/2015 05:46 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 10:44 AM,

Re: [Mesa-dev] [PATCH 11/17] mesa: Fix error returned by glCopyTexImage2D() upon an invalid internal format

2015-07-29 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com I think this patch could also be tagged for the 10.6.x series. On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: From: Eduardo Lima Mitev el...@igalia.com Page 161 of the OpenGL-ES 3.1 (PDF) spec, and page 207 of the

Re: [Mesa-dev] [PATCH] docs: rename/bump 10.7.0 release notes to 11.0.0

2015-07-29 Thread Emil Velikov
On 29 July 2015 at 18:21, Ilia Mirkin imir...@alum.mit.edu wrote: Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Do you also need to do something for it to claim it's 11.0-gblah in the version? Nice one, thanks. I'll squash the following hunk. diff --git a/VERSION b/VERSION index

[Mesa-dev] Mesa 11.0.0 release plan

2015-07-29 Thread Emil Velikov
Hi all, Below is the preliminary release schedule for Mesa 11.0.0 August 21st 2015 - Feature freeze/Release candidate 1 August 28th 2015 - Release candidate 2 September 04th 2015 - Release candidate 3 September 11th 2015 - Release candidate 4/Mesa 11.0.0 We have roughly three weeks for new

Re: [Mesa-dev] [PATCH] winsys/radeon: don't leak the fd when it is 0

2015-07-29 Thread Mario Kleiner
On 07/29/2015 09:05 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 2:55 PM, Mario Kleiner mario.kleiner...@gmail.com wrote: On 07/29/2015 08:50 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner mario.kleiner...@gmail.com wrote: On 07/29/2015 05:46 PM, Alex Deucher

Re: [Mesa-dev] [PATCH 09/17] mesa: Validate target before resolving tex obj in glTex(ture)SubImageXD

2015-07-29 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com This patch should definitely be tagged for the 10.6.x series. I suspect this problem was introduced when the DSA work landed. On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: From: Eduardo Lima Mitev el...@igalia.com

Re: [Mesa-dev] [PATCH 10/17] mesa: Add missing check of format and type in glTexSubImageXD on GLES 3.0

2015-07-29 Thread Ian Romanick
On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: From: Eduardo Lima Mitev el...@igalia.com Argument validation for glTexSubImageXD is missing a check of format and type against texture object's internal format when profile is OpenGL-ES 3.0+. Blarg. I see that we have nearly

[Mesa-dev] [PATCH] glsl: Initialize parse-state in constructor of lower_subroutine.

2015-07-29 Thread Matt Turner
Static analysis tools don't like partial object initializations. --- src/glsl/lower_subroutine.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/lower_subroutine.cpp b/src/glsl/lower_subroutine.cpp index e45ccfe..b29912a 100644 ---

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #42 from Thomas Hellström thellst...@vmware.com --- Hi! I'm on vacation and will be back on August 2nd 2015. Thanks, Thomas Hellstr?m -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 Furkan fal...@gmail.com changed: What|Removed |Added CC||jajo...@nvidia.com,

Re: [Mesa-dev] [PATCH] i965/bxt: Support 3src simd16 instructions

2015-07-29 Thread Ben Widawsky
On Wed, Jul 29, 2015 at 05:51:38PM +0100, Neil Roberts wrote: I tested this on my BXT by running the glsl-fs-color-matrix test (which ends up using MAD in SIMD16) and it worked fine. Tested-by: Neil Roberts n...@linux.intel.com Reviewed-by: Neil Roberts n...@linux.intel.com - Neil Crap.

Re: [Mesa-dev] Mesa 11.0.0 release plan

2015-07-29 Thread Rob Clark
On Wed, Jul 29, 2015 at 2:20 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Hi all, Below is the preliminary release schedule for Mesa 11.0.0 August 21st 2015 - Feature freeze/Release candidate 1 August 28th 2015 - Release candidate 2 September 04th 2015 - Release candidate 3 September

[Mesa-dev] [PATCH 1/2] r600: Fix some printf format warns pretaining to PRIi64

2015-07-29 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com --- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index

[Mesa-dev] [PATCH 0/2] Misc compiler warn fixes

2015-07-29 Thread Edward O'Callaghan
Rather boring patches to fix a few compiler warnings. Edward O'Callaghan (2): r600: Fix some printf format warns pretaining to PRIi64 mesa: Fix printf format specifier warn of the ptrdiff_t src/gallium/drivers/r600/compute_memory_pool.c | 8 src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix printf format specifier warn of the ptrdiff_t

2015-07-29 Thread Ilia Mirkin
I assume that you mean the C99 spec? I don't think MSVC supports %t or %z :( On Wed, Jul 29, 2015 at 7:46 PM, Edward O'Callaghan eocallag...@alterapraxis.com wrote: See §7.19.6.1, paragraph 7 of the ISO C specification. Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com ---

[Mesa-dev] [PATCH] radeonsi: add GS multiple streams support (v2)

2015-07-29 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This is the final piece for ARB_gpu_shader5, The code is based on the r600 code from Glenn Kennard, and myself. While developing this, I'm not 100% sure of all the calculations made in the GS registers, this is why the max_stream is worked out there and used

Re: [Mesa-dev] [PATCH 07/20] glsl: clean-up link uniform code

2015-07-29 Thread Timothy Arceri
On Wed, 2015-07-29 at 10:14 -0400, Ilia Mirkin wrote: On Wed, Jul 29, 2015 at 9:56 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: These changes are also needed to allow linking of struct and interface arrays of arrays. --- src/glsl/link_uniforms.cpp | 16 ++-- 1 file

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix printf format specifier warn of the ptrdiff_t

2015-07-29 Thread Ilia Mirkin
On Wed, Jul 29, 2015 at 10:18 PM, Edward O'Callaghan edward.ocallag...@koparo.com wrote: On Thu, Jul 30, 2015, at 09:53 AM, Ilia Mirkin wrote: I assume that you mean the C99 spec? I don't think MSVC supports %t or %z :( Correct, why not it is standard C99 sounds like a compiler bug to me if

[Mesa-dev] [PATCH 2/2] mesa/formats: 8-bit channel integer formats addition

2015-07-29 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com these also hit the problem case but I don't think this patch is the answer, do I need to flesh out the .8.8.8.8_UNORM ones into .8.8.8.8_UINT types? Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/glformats.c | 8 1 file changed, 8

[Mesa-dev] [PATCH 1/2] mesa/formats: add some formats from GL3.3

2015-07-29 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com GL3.3 added GL_ARB_texture_rgb10_a2ui, which specifies a lot more things than just rgb10/a2ui. While playing with ogl conform one of the tests must attempted all valid formats for GL3.3 and hits the unreachable here. This adds the first chunk of formats that

[Mesa-dev] [rfc] integer formats missing from mesa

2015-07-29 Thread Dave Airlie
I ran GL41-CTS.gtf32.* from ogl conform, and fell over a lot in the unreachable in glformats.c Looks like a bunch of stuff is missing, now I'm not sure how much is required to add it all, the first patch is probably okay, the second is just a hint on if I need to flesh out some types for the

[Mesa-dev] [PATCH] pipebuffer: Silence GCC unused-but-set-variable warning.

2015-07-29 Thread Vinson Lee
pb_buffer_fenced.c: In function 'fenced_buffer_fence': pb_buffer_fenced.c:849:18: warning: variable 'destroyed' set but not used [-Wunused-but-set-variable] boolean destroyed; ^ Signed-off-by: Vinson Lee v...@freedesktop.org ---

Re: [Mesa-dev] [PATCH] gallium/util: Silence GCC unused-but-set-variable warning.

2015-07-29 Thread Matt Turner
On Wed, Jul 29, 2015 at 8:12 PM, Vinson Lee v...@freedesktop.org wrote: u_surface.c: In function 'util_resource_copy_region': u_surface.c:257:21: warning: variable 'src_format' set but not used [-Wunused-but-set-variable] enum pipe_format src_format, dst_format; ^

[Mesa-dev] [PATCH] gallium/util: Silence GCC unused-but-set-variable warning.

2015-07-29 Thread Vinson Lee
u_surface.c: In function 'util_resource_copy_region': u_surface.c:257:21: warning: variable 'src_format' set but not used [-Wunused-but-set-variable] enum pipe_format src_format, dst_format; ^ Signed-off-by: Vinson Lee v...@freedesktop.org ---

[Mesa-dev] [PATCH] gallivm: Fix GCC unused-variable warning.

2015-07-29 Thread Vinson Lee
lp_bld_tgsi_soa.c: In function 'lp_emit_immediate_soa': lp_bld_tgsi_soa.c:3065:18: warning: unused variable 'size' [-Wunused-variable] const uint size = imm-Immediate.NrTokens - 1; ^ Signed-off-by: Vinson Lee v...@freedesktop.org ---

[Mesa-dev] [PATCH] draw: Silence GCC unused-variable warnings.

2015-07-29 Thread Vinson Lee
draw/draw_llvm.c: In function 'create_jit_sampler_type': draw/draw_llvm.c:178:22: warning: unused variable 'target' [-Wunused-variable] LLVMTargetDataRef target = gallivm-target; ^ draw/draw_llvm.c: In function 'create_jit_context_type': draw/draw_llvm.c:218:22: warning:

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix printf format specifier warn of the ptrdiff_t

2015-07-29 Thread Edward O'Callaghan
On Thu, Jul 30, 2015, at 09:53 AM, Ilia Mirkin wrote: I assume that you mean the C99 spec? I don't think MSVC supports %t or %z :( Correct, why not it is standard C99 sounds like a compiler bug to me if that is really the case :/ On Wed, Jul 29, 2015 at 7:46 PM, Edward O'Callaghan

Re: [Mesa-dev] [PATCH] gallium/util: Silence GCC unused-but-set-variable warning.

2015-07-29 Thread Vinson Lee
On Wed, Jul 29, 2015 at 8:33 PM, Matt Turner matts...@gmail.com wrote: On Wed, Jul 29, 2015 at 8:12 PM, Vinson Lee v...@freedesktop.org wrote: u_surface.c: In function 'util_resource_copy_region': u_surface.c:257:21: warning: variable 'src_format' set but not used [-Wunused-but-set-variable]

Re: [Mesa-dev] [PATCH 03/17] mesa: fix deletion of inactive bound transform feedback object

2015-07-29 Thread Samuel Iglesias Gonsálvez
On Wed, 2015-07-29 at 12:31 -0700, Ian Romanick wrote: On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: When a transform feedback object is bound and not active, the OpenGL ES 3.0 and GL_ARB_transform_feedback2 specs don't explicitly disallow its deletion. Only the deletion of

Re: [Mesa-dev] [PATCH V3] glsl: fix atomic buffer index for bindings other than 0

2015-07-29 Thread Iago Toral
On Sun, 2015-07-26 at 18:35 +1000, Timothy Arceri wrote: Since commit c0cd5b var-data.binding was being used as a replacement for atomic buffer index, but they don't have to be the same value they just happen to end up the same when binding is 0. Now we store atomic buffer index in the

Re: [Mesa-dev] [PATCH] mesa: enable texture stencil8 for multisample

2015-07-29 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu On Wed, Jul 29, 2015 at 4:10 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This fixes GL45-CTS.gtf44.GL31Tests.texture_stencil8.texture_stencil8_gl44 from the ogl conform suite. Signed-off-by: Dave Airlie

Re: [Mesa-dev] List of unsupported extensions per driver

2015-07-29 Thread Ilia Mirkin
Feel free to lift the info from my glxinfo page... http://people.freedesktop.org/~imirkin/glxinfo/glxinfo.html Note the grayed out bits... it's just a hardcoded list, search for UNSUPPORTED in http://people.freedesktop.org/~imirkin/glxinfo/glxinfo.js . Note that it's per hardware group, not per

Re: [Mesa-dev] [PATCH 1/3] gallivm: Don't use raw_debug_ostream for dissasembling

2015-07-29 Thread Jose Fonseca
On 23/07/15 17:06, Jose Fonseca wrote: On 20/07/15 21:39, Jose Fonseca wrote: On 20/07/15 18:35, Tom Stellard wrote: All LLVM API calls that require an ostream object have been removed from the disassemble() function, so we don't need to use this class to wrap _debug_printf() we can just call

Re: [Mesa-dev] [PATCH 2/4] radeon: add support for streams to the common streamout code. (v2)

2015-07-29 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jul 29, 2015 at 1:20 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This adds to the common radeon streamout code, support for multiple streams. It updates radeonsi/r600 to set the enabled mask up.

Re: [Mesa-dev] [PATCH] i965/bxt: Support 3src simd16 instructions

2015-07-29 Thread Ben Widawsky
On Tue, Jul 28, 2015 at 11:08:39PM -0700, Kenneth Graunke wrote: On Tuesday, July 28, 2015 08:00:54 PM Ben Widawsky wrote: This is easily accomplished by moving simd16 3src to GEN9_FEATURES. Signed-off-by: Ben Widawsky b...@bwidawsk.net --- src/mesa/drivers/dri/i965/brw_device_info.c

Re: [Mesa-dev] [PATCH] Delete duplicate function is_power_of_two() and use _mesa_is_pow_two()

2015-07-29 Thread Iago Toral
Funny, we had 3 instances of the same function with the same implementation :), there is still util_is_power_of_two in Gallium btw. Reviewed-by: Iago Toral Quiroga ito...@igalia.com On Tue, 2015-07-28 at 16:48 -0700, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com ---

[Mesa-dev] [PATCH] mesa: enable texture stencil8 for multisample

2015-07-29 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This fixes GL45-CTS.gtf44.GL31Tests.texture_stencil8.texture_stencil8_gl44 from the ogl conform suite. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/teximage.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [Bug 90213] glDrawPixels with GL_COLOR_INDEX never returns.

2015-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90213 Iago Toral ito...@igalia.com changed: What|Removed |Added CC||imir...@alum.mit.edu ---

Re: [Mesa-dev] [PATCH 1/4] radeon: move streamout buffer config to streamout enable function. (v2)

2015-07-29 Thread Marek Olšák
On Wed, Jul 29, 2015 at 1:01 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This will be used here later. v2: update atom sizes add check for old vs new enabled mask Signed-off-by: Dave Airlie airl...@redhat.com ---

Re: [Mesa-dev] [PATCH] docs/GL3.txt: consolidate nvc0 status

2015-07-29 Thread Fabio Pedretti
Yes, thanks. Il 28/lug/2015 11:27 PM, Ilia Mirkin imir...@alum.mit.edu ha scritto: Fine by me. Do you need someone to commit this? On Tue, Jul 28, 2015 at 2:53 PM, Fabio Pedretti fabio@libero.it wrote: ---   docs/GL3.txt | 36 ++--   1 file changed,

Re: [Mesa-dev] [PATCH v2 0/6] Improvements to the vec4 spilling code

2015-07-29 Thread Iago Toral
On Tue, 2015-07-28 at 18:17 +0300, Francisco Jerez wrote: Iago Toral Quiroga ito...@igalia.com writes: Link to v1: http://lists.freedesktop.org/archives/mesa-dev/2015-July/089766.html Changes after review (Curro) - Drop the patch that asserted that the reg size should always be 1

Re: [Mesa-dev] List of unsupported extensions per driver

2015-07-29 Thread Dieter Nützel
Am 29.07.2015 06:35, schrieb Romain Failliot: Hi! First, I wanted to thank you for the incredible work you've done to achieve OpenGL 4.1. The number of visitors exploded on mesamatrix, while the average was around 100 visits per day, I had more than 2500 visits just for the day of the news!

Re: [Mesa-dev] [PATCH] i965/bxt: Support 3src simd16 instructions

2015-07-29 Thread Kenneth Graunke
On Tuesday, July 28, 2015 08:00:54 PM Ben Widawsky wrote: This is easily accomplished by moving simd16 3src to GEN9_FEATURES. Signed-off-by: Ben Widawsky b...@bwidawsk.net --- src/mesa/drivers/dri/i965/brw_device_info.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

Re: [Mesa-dev] [PATCH 08/14] i965/fs: Initialize a builder explicitly in the gen4 send dependency work-arounds.

2015-07-29 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Tue, Jul 28, 2015 at 1:23 AM, Francisco Jerez curroje...@riseup.net wrote: Instead of relying on the default one. This shouldn't lead to any functional changes because DEP_RESOLVE_MOV overrides the execution controls of the instruction anyway.

Re: [Mesa-dev] [PATCH] Fix Android 5.1 build and runtime issues

2015-07-29 Thread Emil Velikov
On 29 July 2015 at 03:04, Bish, Jim jim.b...@intel.com wrote: On 07/28/2015 02:38 PM, Chad Versace wrote: On Tue 28 Jul 2015, Emil Velikov wrote: [snip] Do you know of any plans to use upstream libdrm ? Or at least rebase/merge with upstream changes ? would be nice but as far as I know there

Re: [Mesa-dev] [PATCH v2 0/6] Improvements to the vec4 spilling code

2015-07-29 Thread Francisco Jerez
Iago Toral ito...@igalia.com writes: On Tue, 2015-07-28 at 18:17 +0300, Francisco Jerez wrote: Iago Toral Quiroga ito...@igalia.com writes: Link to v1: http://lists.freedesktop.org/archives/mesa-dev/2015-July/089766.html Changes after review (Curro) - Drop the patch that asserted

[Mesa-dev] [Bug 91496] [clover] Multiple device probe fails since a27ec5dc460b91dc44675f48cddbbb2631ee824f

2015-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91496 --- Comment #2 from Emil Velikov emil.l.veli...@gmail.com --- (In reply to Francisco Jerez from comment #1) Yeah, you're right, sorry I didn't notice this during review. Emil, are you OK with reverting this patch? No objections at all. Feel

[Mesa-dev] [Bug 91496] [clover] Multiple device probe fails since a27ec5dc460b91dc44675f48cddbbb2631ee824f

2015-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91496 Francisco Jerez curroje...@riseup.net changed: What|Removed |Added CC|

[Mesa-dev] [Bug 91496] [clover] Multiple device probe fails since a27ec5dc460b91dc44675f48cddbbb2631ee824f

2015-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91496 Francisco Jerez curroje...@riseup.net changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 91496] [clover] Multiple device probe fails since a27ec5dc460b91dc44675f48cddbbb2631ee824f

2015-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91496 --- Comment #3 from Francisco Jerez curroje...@riseup.net --- This should be fixed in master now, patch reverted as e42d2948d3c58b86d3770d296b96fafcd1218858. -- You are receiving this mail because: You are the QA Contact for the bug. You are

Re: [Mesa-dev] [PATCH V3] glsl: fix atomic buffer index for bindings other than 0

2015-07-29 Thread Timothy Arceri
On Wed, 2015-07-29 at 09:57 +0200, Iago Toral wrote: On Sun, 2015-07-26 at 18:35 +1000, Timothy Arceri wrote: Since commit c0cd5b var-data.binding was being used as a replacement for atomic buffer index, but they don't have to be the same value they just happen to end up the same when

Re: [Mesa-dev] [PATCH 1/3] gallivm: Don't use raw_debug_ostream for dissasembling

2015-07-29 Thread Jose Fonseca
On 29/07/15 13:35, Tom Stellard wrote: On Wed, Jul 29, 2015 at 09:54:05AM +0100, Jose Fonseca wrote: On 23/07/15 17:06, Jose Fonseca wrote: On 20/07/15 21:39, Jose Fonseca wrote: On 20/07/15 18:35, Tom Stellard wrote: All LLVM API calls that require an ostream object have been removed from

Re: [Mesa-dev] List of unsupported extensions per driver

2015-07-29 Thread Romain Failliot
I'll have a look at that. I'll try to see which driver is for which GPU and then make a hardcoded list too. Thanks Ilia! 2015-07-29 4:25 GMT-04:00 Ilia Mirkin imir...@alum.mit.edu: Feel free to lift the info from my glxinfo page... http://people.freedesktop.org/~imirkin/glxinfo/glxinfo.html

  1   2   >