Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-10-03 Thread Albert Freeman
Yeah I think the value of having a date based system is to quickly check when the release was made, dayoutofdaysthatyear isn't really providing any extra benefit since its hard to read and that extra info is probably rather pointless for quick fix releases since the mesa-dev branch and a quick fix

Re: [Mesa-dev] [PATCH 7/8] i965: Drop _NEW_TRANSFORM from 3DSTATE_VS atom on Gen6-7.

2016-10-03 Thread Jason Ekstrand
On Wed, Sep 21, 2016 at 10:31 PM, Kenneth Graunke wrote: > commit e07457d0aec96970a39a2dd1cb4e46da6107eb77 removed the last use > of ctx->Transform on Gen6. It looks like Gen7 never needed this, but > Not so much... The mentioned commit actually contains a very nice

Re: [Mesa-dev] [PATCH 5/5] st/mesa: move all sampler view code into new st_sampler_view.[ch] files

2016-10-03 Thread Brian Paul
Actually, I just need to bracket some of the assertions with the test for GL_TEXTURE_BUFFER. I'll make that change and re-test before pushing. I suspect I did my piglit run w/ a release build on Windows. Thanks for reviewing. -Brian On 10/02/2016 02:53 PM, Marek Olšák wrote: One more fix

Re: [Mesa-dev] [PATCH] nv50/ra: let simplify return an error and handle that

2016-10-03 Thread Ilia Mirkin
Of course this only helps shader-db, right? Pretty sure you'll hit an assert if you try to draw... Either way, that can be fixed later. This is Reviewed-by: Ilia Mirkin On Mon, Oct 3, 2016 at 12:55 PM, Karol Herbst wrote: > fixes a crash in the case

Re: [Mesa-dev] [PATCH 4/9] anv/gen8_pipeline: Use Alternate floating point mode when use_alt_mode is set in prog_data

2016-10-03 Thread Anuj Phogat
On Sun, Oct 2, 2016 at 1:59 PM, Kenneth Graunke wrote: > On Friday, September 30, 2016 3:33:12 PM PDT Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/intel/vulkan/gen8_pipeline.c | 3 ++- >> 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

2016-10-03 Thread Zhang, Boyuan
Hi Andy, Thanks for the testings. Regarding to the inconsistencies, the current Vaapi dual instances encoding behaviour is random. Whether or not the dual instances is being used depends on how early the player calls sync_surface function according to the current gstreamer-vaapi's mechanism.

[Mesa-dev] [PATCH] nv50/ra: let simplify return an error and handle that

2016-10-03 Thread Karol Herbst
fixes a crash in the case simplify reports an error Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp

[Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Rob Clark
Fix potential issues if state-tracker passes in garbage in templ->next ptr. See: https://lists.freedesktop.org/archives/mesa-dev/2016-September/129867.html Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_resource.c | 2 ++

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Roland Scheidegger
I don't think that's really a good idea. Zero-initializing things is one thing, but explicitly overwrite things which were given to the driver by the st is something else. (I'm not even sure how it works if the driver always overwrites this to zero no matter what. Well I suppose those are the

Re: [Mesa-dev] [PATCH] autoconf: Make header install distinct for various APIs

2016-10-03 Thread Chuck Atkins
Ping? On Sep 30, 2016 2:37 PM, "Chuck Atkins" wrote: > This fixes a problem where GL headers would only get installed if > glx was enabled. So if osmesa was enabled but not glx, then the > GL headers required by osmesa would be missing from the install. > >

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Rob Clark
the interface is a bit hand-wavey, ie. w/ things like prsc->screen overwriten by driver.. I guess I can try to track down the screen->resource_create() callers that aren't zero-init'ing the templ, although the # of callers seemed much higher than # of drivers BR, -R On Mon, Oct 3, 2016 at 12:27

Re: [Mesa-dev] [PATCH] vl/dri3: fix warning about incompatible pointer type

2016-10-03 Thread Leo Liu
Reviewed and Pushed. On 10/01/2016 01:22 AM, Nayan Deshmukh wrote: Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Roland Scheidegger
In an ideal world everybody would zero-intialize the template I suppose - then it would easily survive such interface changes. I thought though there shouldn't be many callers but I might have been wrong about this... Roland Am 03.10.2016 um 18:48 schrieb Rob Clark: > the interface is a bit

Re: [Mesa-dev] [PATCH 0/2] clover: clEnqueueMigrateMemObjects

2016-10-03 Thread Serge Martin
Ping On Saturday 12 September 2015 21:08:20 Serge Martin wrote: > Now that mem object can be move back to the host, I think we should latter > come with a way to optimize read mapping for such objets. For the moment if > they are mapped for reading after been moved to the host, they will be send

Re: [Mesa-dev] [PATCH 9/9] anv/gen7_pipeline: Check for ksp0 when setting BarycentricInterpolationMode in 3DSTATE_WM

2016-10-03 Thread Anuj Phogat
On Fri, Sep 30, 2016 at 5:03 PM, Jason Ekstrand wrote: > On Sep 30, 2016 3:34 PM, "Anuj Phogat" wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/intel/vulkan/gen7_pipeline.c | 3 ++- >> 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH] nv50/ra: let simplify return an error and handle that

2016-10-03 Thread Samuel Pitoiset
On 10/03/2016 06:55 PM, Karol Herbst wrote: fixes a crash in the case simplify reports an error Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH] anv/gen7_pipeline: Fix typo in semicolon

2016-10-03 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/gen7_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index bafee28..c9d1f64 100644 --- a/src/intel/vulkan/gen7_pipeline.c +++

Re: [Mesa-dev] [PATCH] autoconf: Make header install distinct for various APIs

2016-10-03 Thread Emil Velikov
On 30 September 2016 at 19:37, Chuck Atkins wrote: > This fixes a problem where GL headers would only get installed if > glx was enabled. So if osmesa was enabled but not glx, then the > GL headers required by osmesa would be missing from the install. > > Signed-off-by:

[Mesa-dev] [PATCH V2 8/9] anv/gen7_pipeline: Set sample mask field in 3DSTATE_PS

2016-10-03 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/gen7_pipeline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 9411631..bafee28 100644 --- a/src/intel/vulkan/gen7_pipeline.c +++

Re: [Mesa-dev] [PATCH 8/9] anv/gen7_pipeline: Set few missing fields in 3DSTATE_PS

2016-10-03 Thread Anuj Phogat
On Fri, Sep 30, 2016 at 5:02 PM, Jason Ekstrand wrote: > On Sep 30, 2016 3:34 PM, "Anuj Phogat" wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/intel/vulkan/gen7_pipeline.c | 4 >> 1 file changed, 4 insertions(+) >>

Re: [Mesa-dev] [PATCH 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-03 Thread Emil Velikov
On 25 September 2016 at 04:24, Eric Engestrom wrote: > On Thu, Aug 25, 2016 at 05:18:32PM +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Duplicate a few lines at the expense of making the code-flow clearer >> while adding a few extra

[Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-03 Thread Emil Velikov
From: Emil Velikov Fold duplicate conditional blocks and add a few extra comments ;-) v2: Bring back the explicit "unbind" logic (Eric), remove NULL derefs. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 72

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2016-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #11 from Clément Guérin --- Hello, I built mesa 12.0.3 against llvm 3.9.0 on arch linux. Rocket League and Portal were working properly, however Tomb Raider was crashing right before the Feral logo. -- You are

Re: [Mesa-dev] [Request for Testing] i965: import prime buffers in the current context, not screen

2016-10-03 Thread Kristian Høgsberg
On Thu, Sep 29, 2016 at 7:33 AM Martin Peres wrote: > On 02/09/16 10:08, Martin Peres wrote: > > > > > > On 25/08/16 21:49, Kristian Høgsberg wrote: > >> On Thu, Aug 25, 2016 at 11:38 AM, Chad Versace > >> wrote: > >>> On Thu 25 Aug 2016,

Re: [Mesa-dev] [PATCH V2 8/9] anv/gen7_pipeline: Set sample mask field in 3DSTATE_PS

2016-10-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Oct 3, 2016 at 10:13 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/vulkan/gen7_pipeline.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] anv/gen7_pipeline: Fix typo in semicolon

2016-10-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Oct 3, 2016 at 10:44 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/vulkan/gen7_pipeline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2016-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 Clément Guérin changed: What|Removed |Added CC||geecko@free.fr

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

2016-10-03 Thread Andy Furniss
Zhang, Boyuan wrote: Hi Andy, Thanks for the testings. Regarding to the inconsistencies, the current Vaapi dual instances encoding behaviour is random. Whether or not the dual instances is being used depends on how early the player calls sync_surface function according to the current

[Mesa-dev] [PATCH v2 01/13] anv: Use blorp for VkCmdFillBuffer

2016-10-03 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_blorp.c | 106 + src/intel/vulkan/anv_meta_clear.c | 120 -- 2 files changed, 96 insertions(+), 130 deletions(-) diff --git

[Mesa-dev] [PATCH] Revert "mesa_glinterop: remove inclusion of GLX header"

2016-10-03 Thread Vinson Lee
This reverts commit 8472045b16b3e4621553fe451a20a9ba9f0d44b6. Conflicts: include/GL/mesa_glinterop.h This patch fixes this build error with GCC 4.4. Compiling src/glx/dri_common_interop.c ... In file included from src/glx/dri_common_interop.c:33: include/GL/mesa_glinterop.h:62:

Re: [Mesa-dev] [PATCH 1/2] nir: Add a nop intrinsic

2016-10-03 Thread Kenneth Graunke
On Thursday, September 15, 2016 9:16:04 PM PDT Jason Ekstrand wrote: > This intrinsic has no destination, no sources, no variables, and can be > eliminated. In other words, it does nothing and will always get deleted by > dead code elimination. However, it does provide a quick-and-easy way to >

Re: [Mesa-dev] [PATCH V2 07/11] anv/image: Memset hiz surfaces to 0 when binding memory

2016-10-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Sep 27, 2016 at 10:59 AM, Chad Versace wrote: > On Mon 26 Sep 2016, Nanley Chery wrote: > > From: Jason Ekstrand > > > > Nanley Chery (amend): > > - Change memset value from 0xff to

[Mesa-dev] [PATCH 2/2] mesa: Raise INVALID_ENUM in FramebufferTexture*D for unknown textargets.

2016-10-03 Thread Kenneth Graunke
ES3-CTS.functional.negative_api.buffer.framebuffer_texture2d expects glFramebufferTexture[123]D to raise GL_INVALID_ENUM when supplied a completely bogus textarget parameter (i.e. 0x). This is at odds with the spec. GLES 3.1 says: "An INVALID_OPERATION error is generated if texture

Re: [Mesa-dev] [PATCH 2/2] mesa: Raise INVALID_ENUM in FramebufferTexture*D for unknown textargets.

2016-10-03 Thread Timothy Arceri
Both are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH V2 05/11] anv: Allocate hiz surface

2016-10-03 Thread Jason Ekstrand
On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > From: Chad Versace > > Nanley Chery: > (rebase) > - Use isl_surf_get_hiz_surf() > (amend) > - Only add a HiZ surface onto a depth/stencil attachment > - Add comment above HiZ surface

[Mesa-dev] [PATCH 1/2] mesa: Reorganize check_textarget().

2016-10-03 Thread Kenneth Graunke
Having one top-level switch statement covering all known texture targets will make the next change easier to implement. Signed-off-by: Kenneth Graunke --- src/mesa/main/fbobject.c | 80 ++-- 1 file changed, 37 insertions(+), 43

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Rob Clark
There are a lot of callers for ->resource_create() and friends.. although I suspect it is a small subset that don't zero-init. But I'll have to go through all the call sites and check, but I didn't yet find time yet to do that today.. I don't want to annoy too many folks w/ broken piglits, so if

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Roland Scheidegger
Sounds reasonable to me. Roland Am 04.10.2016 um 01:44 schrieb Rob Clark: > There are a lot of callers for ->resource_create() and friends.. > although I suspect it is a small subset that don't zero-init. But > I'll have to go through all the call sites and check, but I didn't yet > find time

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Marek Olšák
BTW, I think fixing this in drivers is better, because the number of resource_create implementations is limited and they are easy to find. Marek On Tue, Oct 4, 2016 at 1:45 AM, Roland Scheidegger wrote: > Sounds reasonable to me. > > Roland > > Am 04.10.2016 um 01:44 schrieb

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Rob Clark
I know we do at least have an etnaviv gallium driver hanging out there waiting to be merged, and don't want to cause them unnecessary rebase pain.. so if $num_of_callsites_to_fix < $num_of_gallium_drivers, I don't mind fixing it at the call sites.. but I'll have to audit a whole bunch of

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Roland Scheidegger
The reason I don't like this isn't really the number of callers, rather that the driver is going actively against what the state tracker told it to do. But I'm not strongly opposed to this, since effectively restricting the next field to be only valid if the resource is created externally might be

[Mesa-dev] [PATCH 5/5] i965: fix unused variable warning in brw_emit_gpgpu_walker()

2016-10-03 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_compute.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compute.c b/src/mesa/drivers/dri/i965/brw_compute.c index cde3bad..d1d39d3 100644 --- a/src/mesa/drivers/dri/i965/brw_compute.c +++

[Mesa-dev] [PATCH 2/5] i965: fix unused variable warning in gen7_block_read_scratch()

2016-10-03 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_eu_emit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index c98867a..cfb3fa0 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c +++

[Mesa-dev] [PATCH 4/5] i965: wrap unused variable in #ifndef NDEBUG

2016-10-03 Thread Timothy Arceri
Fixes unused variable warning in release build. --- src/mesa/drivers/dri/i965/brw_tcs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_tcs.c b/src/mesa/drivers/dri/i965/brw_tcs.c index 1f1b1a5..01500e0 100644 --- a/src/mesa/drivers/dri/i965/brw_tcs.c +++

[Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

2016-10-03 Thread Timothy Arceri
This fixes an unused variable warning on release builds. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index dc000d9..ccf311d 100644 ---

[Mesa-dev] [PATCH 3/5] i965: wrap unused function in #ifndef NDEBUG

2016-10-03 Thread Timothy Arceri
This function is only ever used by an assert() this fixes an unused function warning in release builds. --- src/mesa/drivers/dri/i965/gen8_draw_upload.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen8_draw_upload.c

Re: [Mesa-dev] [PATCH V2 08/11] anv/cmd_buffer: Add code for performing HZ operations

2016-10-03 Thread Jason Ekstrand
On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > Create a function that performs one of three HiZ operations - > depth/stencil clears, HiZ resolve, and depth resolves. > > Signed-off-by: Nanley Chery > > --- > > v2. Add documentation >

Re: [Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

2016-10-03 Thread Dave Airlie
On 3 October 2016 at 05:45, Tobias Droste wrote: > This reuse the same logic gallium uses to determine if LLVM is needed or > not: > --enable-vulkan-llvm is set to yes if at least one vulkan driver is > active and the host is i3*6 or x86_64. > To build vulkan drivers without LLVM

[Mesa-dev] [PATCH] spirv: replace assert() with unreachable()

2016-10-03 Thread Timothy Arceri
This fixes an uninitialized warning for is_vertex_input. --- src/compiler/spirv/vtn_variables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 43bb3bc..f431c6f 100644 ---

[Mesa-dev] [PATCH] aubinator: Use less -RS instead of -r for the implicit pager.

2016-10-03 Thread Kenneth Graunke
From the less man page: "Warning: when the -r option is used, less cannot keep track of the actual appearance of the screen (since this depends on how the screen responds to each type of control character). Thus, various display problems may result, such as long lines being

Re: [Mesa-dev] [PATCH V2 09/11] genX/cmd_buffer: Enable rendering to HiZ

2016-10-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > From: Chad Versace > > Nanley Chery: > (rebase) > - Resolve conflicts with new anv_batch_emit macro > (amend) > - Handle a QPitch TODO > -

[Mesa-dev] [PATCH] intel: use the correct format specifier for printing uint64_t

2016-10-03 Thread Timothy Arceri
Fixes a bunch of warnings in 32-bit builds. --- src/intel/tools/aubinator.c | 17 + src/intel/tools/decoder.c | 7 --- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index a31dcb2..9b32e5b 100644

Re: [Mesa-dev] [PATCH] i965: Only emit 1 viewport when possible.

2016-10-03 Thread Ian Romanick
Reviewed-by: Ian Romanick On 09/26/2016 11:23 AM, Kenneth Graunke wrote: > In core profile, we support up to 16 viewports. However, in the > majority of cases, only 1 of them is actually used - we only need > the others if the last shader stage prior to the rasterizer

Re: [Mesa-dev] Mesa 12.1.0 release plan (Was Re: Next Mesa release, anyone?)

2016-10-03 Thread Rob Clark
On Thu, Sep 29, 2016 at 10:56 AM, Emil Velikov wrote: > On 28 September 2016 at 19:53, Marek Olšák wrote: >> Hi, >> >> It's been almost 4 months since the 12.0 branch was created, and soon >> it will have been 3 months since Mesa 12.0 was released. >>

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-03 Thread Jason Ekstrand
On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: > > On Tue 27 Sep 2016, Nanley Chery wrote: > > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > > > > > As a consequence of that

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Michel Dänzer
On 04/10/16 01:53 AM, Roland Scheidegger wrote: > In an ideal world everybody would zero-intialize the template I suppose > - then it would easily survive such interface changes. As long as there are no fields where 0 isn't a safe value... What's needed is an explicit definition of whether it's

Re: [Mesa-dev] [PATCH V2 00/11] anv: Implement HiZ for basic cases

2016-10-03 Thread Jason Ekstrand
The whole thing is Reviewed-by: Jason Ekstrand I'm still a little concerned about CLEAR_PARAMS in patch 10, but once chad's happy, I'll be happy. On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > This series is the second revision of the

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-03 Thread Jason Ekstrand
On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand wrote: > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery > wrote: > >> On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: >> > On Tue 27 Sep 2016, Nanley Chery wrote: >> > > On Tue, Sep 27, 2016

Re: [Mesa-dev] [PATCH] intel: fix compilation warning on gen_get_device_info

2016-10-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/10/16 07:32, Tapani Pälli wrote: (warning: 'const' type qualifier on return type has no effect) Signed-off-by: Tapani Pälli --- src/intel/common/gen_device_info.c | 2 +-

[Mesa-dev] [PATCH 28/77] glsl: store subroutine remap table in shader cache

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 55 +- 1 file changed, 49 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 793a909..cd18edc 100644 --- a/src/compiler/glsl/shader_cache.cpp +++

[Mesa-dev] [PATCH 29/77] glsl: add shader cache support for buffer blocks

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 154 + 1 file changed, 154 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index cd18edc..1c5c4f5 100644 --- a/src/compiler/glsl/shader_cache.cpp +++

Re: [Mesa-dev] [PATCH 01/77] .gitignore: Ignore src/compiler/spirv2nir

2016-10-03 Thread Timothy Arceri
Whoops these three patches where sent by mistake. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 09/77] glsl: add initial implementation of shader cache

2016-10-03 Thread Timothy Arceri
This uses the recently-added cache.c to write out a serialization of various state that's required in order to successfully load and use a binary written out by a drivers backend, this state is referred to as "metadata" throughout the implementation. This patch is based on the initial work done

[Mesa-dev] [PATCH 16/77] glsl: skip shader cache unless program is made up of vs or fs

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 529ec71..2fb8330 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/glsl/shader_cache.cpp @@

[Mesa-dev] [PATCH 17/77] glsl: cache more uniform storage values

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 2fb8330..b0a7876 100644 --- a/src/compiler/glsl/shader_cache.cpp +++

[Mesa-dev] [PATCH 18/77] glsl: cache SSBO uniform storage values

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index b0a7876..b4b7ee6 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/glsl/shader_cache.cpp @@ -148,6

[Mesa-dev] [PATCH 14/77] glsl: fix uniform remap table cache when explicit locations used

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 08927d9..529ec71 100644 --- a/src/compiler/glsl/shader_cache.cpp +++

[Mesa-dev] [PATCH 19/77] glsl: cache subroutine uniform storage value

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index b4b7ee6..854a21c 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/glsl/shader_cache.cpp @@ -149,6 +149,8

[Mesa-dev] [PATCH 23/77] glsl: add support for skipping shader cache to compiler and linker

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/linker.cpp | 5 +++-- src/compiler/glsl/program.h | 3 ++- src/compiler/glsl/standalone.cpp | 2 +- src/mesa/main/ff_fragment_shader.cpp | 2 +- src/mesa/main/shaderapi.c| 2 +- src/mesa/program/ir_to_mesa.cpp | 5 +++--

[Mesa-dev] [PATCH 10/77] glsl: add helper to convert pointers to uint64_t

2016-10-03 Thread Timothy Arceri
This will be used to store all pointers in the cache as 64bit ints allowing us to avoid issues when a 32bit program reads a cached shader that was created by a 64bit application. --- src/compiler/glsl/shader_cache.h | 10 ++ 1 file changed, 10 insertions(+) diff --git

[Mesa-dev] [PATCH 21/77] glsl: add shader cache support for samplers

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 34 ++ 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index abbd696..4903980 100644 --- a/src/compiler/glsl/shader_cache.cpp +++

[Mesa-dev] [PATCH 24/77] glsl: skip linking when current program has been retrieved from cache

2016-10-03 Thread Timothy Arceri
The scenario is a program has been linked for the first time and we cache the program metadata, then glLinkProgram() is called for a second time. Since we will now retrieve the program metadata from cache we need to skip linking. --- src/compiler/glsl/shader_cache.cpp | 1 + 1 file changed, 1

[Mesa-dev] [PATCH 34/77] glsl: cache clip distance array size

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 1d71068..ddf0c5d 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/glsl/shader_cache.cpp @@ -988,6 +988,8

[Mesa-dev] [PATCH 31/77] glsl: add support for serialising atomic and array types

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index a64f6e5..0937accd 100644 --- a/src/compiler/glsl/shader_cache.cpp +++

[Mesa-dev] [PATCH 30/77] glsl: add support for serialising image types

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 1c5c4f5..a64f6e5 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/glsl/shader_cache.cpp @@ -86,6

[Mesa-dev] [PATCH 22/77] glsl: compile shaders when program not found in cache

2016-10-03 Thread Timothy Arceri
We may have seen the individual shaders before and skipped compiling but they may not have been used together in this combination before. We could probably only compile the shaders which were skipped here but we need to be careful because the source may also have been changed since the last

[Mesa-dev] [PATCH 20/77] glsl: add basic support for resource list to shader cache

2016-10-03 Thread Timothy Arceri
This initially adds support for simple uniforms and varyings. --- src/compiler/glsl/shader_cache.cpp | 114 + 1 file changed, 114 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 854a21c..abbd696 100644

[Mesa-dev] [PATCH 37/77] glsl: cache uniform values

2016-10-03 Thread Timothy Arceri
These may be lowered constant arrays or uniform values that we set before linking so we need to cache the actual uniform values. --- src/compiler/glsl/shader_cache.cpp | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 35/77] glsl: cache some more image metadata

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index ddf0c5d..3e2e2f1 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/glsl/shader_cache.cpp @@

[Mesa-dev] [PATCH 41/77] i965: add image param shader cache support

2016-10-03 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_shader_cache.c | 31 +++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader_cache.c b/src/mesa/drivers/dri/i965/brw_shader_cache.c index 8b31e71..a3dc2a3 100644 ---

[Mesa-dev] [PATCH 40/77] glsl: track mesa version shader cache items were created with

2016-10-03 Thread Timothy Arceri
Also remove cache item and fallback to full recompile if current Mesa version differs. V2: don't leak buffer` --- src/compiler/glsl/shader_cache.cpp | 13 + 1 file changed, 13 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index

[Mesa-dev] [PATCH 36/77] glsl: make uniform values helper available for use elsewhere

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/link_uniforms.cpp | 2 +- src/compiler/glsl/linker.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index c9bb6ad..067db8d 100644 ---

[Mesa-dev] [PATCH 25/77] glsl, i965: add support for caching shaders with xfb qualifiers

2016-10-03 Thread Timothy Arceri
For now this disables the shader cache when transform feedback is enabled via the GL API. --- src/compiler/glsl/linker.cpp | 15 - src/compiler/glsl/shader_cache.cpp | 89 src/mesa/drivers/dri/i965/brw_shader_cache.c | 7 +++ 3 files

[Mesa-dev] [PATCH 33/77] glsl: cache interpolation qualifier for frag shader

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 6213d63..1d71068 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/glsl/shader_cache.cpp @@

[Mesa-dev] [PATCH 12/77] glsl, i965: make use of on disk shader cache

2016-10-03 Thread Timothy Arceri
The hash key for glsl metadata is a hash of the hashes of each GLSL source string. This commit uses the put_key/get_key support in the cache put the SHA-1 hash of the source string for each successfully compiled shader into the cache. This allows for early, optimistic returns from glCompileShader

[Mesa-dev] [PATCH 32/77] glsl: add support for caching atomic buffers

2016-10-03 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 87 ++ 1 file changed, 87 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 0937accd..6213d63 100644 --- a/src/compiler/glsl/shader_cache.cpp +++

[Mesa-dev] [Bug 97230] MATLAB hangs if DRI3 enabled with intel driver

2016-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97230 --- Comment #6 from sergio.calleg...@gmail.com --- Number of threads is very very large... anything that can be grepped? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-10-03 Thread Jason Ekstrand
On Oct 3, 2016 12:19 AM, "Albert Freeman" wrote: > > year.month or year.dayoutofdaysthatyear Why are we adding more options to an already confused discussion? > dayoutoofdaysthatyear skips lots of integers quickly: reducing > confusion of where is release x.(y -

[Mesa-dev] [Bug 97230] MATLAB hangs if DRI3 enabled with intel driver

2016-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97230 --- Comment #7 from Eero Tamminen --- (In reply to sergio.callegari from comment #6) > Number of threads is very very large... anything that can be grepped? It's better to see the whole output. If the output is long,

[Mesa-dev] [PATCH 13/77] glsl: Serialize three additional hash tables with program metadata

2016-10-03 Thread Timothy Arceri
From: Carl Worth The three additional tables are AttributeBindings, FragDataBindings, and FragDataIndexBindings. The first table (AttributeBindings) was identified as missing by trying to test the shader cache with a program that called glGetAttribLocation. Many thanks to

[Mesa-dev] [PATCH 08/77] mesa: add new MESA_GLSL flag for printing shader cache debug info

2016-10-03 Thread Timothy Arceri
--- docs/shading.html | 1 + src/mesa/main/mtypes.h| 1 + src/mesa/main/shaderapi.c | 2 ++ 3 files changed, 4 insertions(+) diff --git a/docs/shading.html b/docs/shading.html index cf989ce..51d0986 100644 --- a/docs/shading.html +++ b/docs/shading.html @@ -49,6 +49,7 @@ execution.

[Mesa-dev] [PATCH 15/77] glsl: add param to force shader recompile

2016-10-03 Thread Timothy Arceri
This will be used to skip checking the cache and force a recompile. --- src/compiler/glsl/glsl_parser_extras.cpp | 22 -- src/compiler/glsl/program.h | 2 +- src/compiler/glsl/standalone.cpp | 3 ++- src/mesa/main/shaderapi.c| 2 +- 4

[Mesa-dev] [PATCH 07/77] glsl: stub out _mesa_reference_program() in standalone compiler

2016-10-03 Thread Timothy Arceri
The shader cache will start calling these from the compiler. --- src/compiler/glsl/standalone_scaffolding.cpp | 8 src/compiler/glsl/standalone_scaffolding.h | 4 2 files changed, 12 insertions(+) diff --git a/src/compiler/glsl/standalone_scaffolding.cpp

[Mesa-dev] [PATCH 04/77] glsl: add new uniform fields to be used to restore state from cache

2016-10-03 Thread Timothy Arceri
From: Carl Worth Signed-off-by: Timothy Arceri --- src/compiler/glsl/link_uniforms.cpp | 4 src/mesa/main/mtypes.h | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_uniforms.cpp

[Mesa-dev] [PATCH 11/77] i965: add initial implementation of on disk shader cache

2016-10-03 Thread Timothy Arceri
This uses the recently-added cache.c to write out the final linked binary for vertex and fragment shader programs. This is based off the initial implementation done by Carl. --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_shader_cache.c | 375

[Mesa-dev] [PATCH 01/77] i965: move program id generation

2016-10-03 Thread Timothy Arceri
This generates the program ids at cache upload time rather than at program creation time. Moving the id generation here will be useful for on-disk shader cache support because it means we don't generate ids if there was a cache miss and we had to fall back to compiling from source. This increases

[Mesa-dev] [PATCH 02/77] docs: add shader cache environment variables

2016-10-03 Thread Timothy Arceri
Reviewed-by: Eric Anholt --- docs/envvars.html | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index cf57ca5..f0f18b3 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -112,6 +112,17 @@ glGetString(GL_VERSION) for

[Mesa-dev] [PATCH 03/77] glsl: Switch to disable-by-default for the GLSL shader cache

2016-10-03 Thread Timothy Arceri
From: Carl Worth The shader cache is expected to be developed incrementally over a fairly long series of commits. For that period of instability, we require users to opt into the shader cache by setting: MESA_GLSL_CACHE_ENABLE=1 In the future, when the shader cache

[Mesa-dev] [PATCH 05/77] i965: add new field for storing program size

2016-10-03 Thread Timothy Arceri
From: Carl Worth This will be used by the on disk shader cache. Signed-off-by: Timothy Arceri --- src/mesa/drivers/dri/i965/brw_compiler.h | 4 src/mesa/drivers/dri/i965/brw_vs.c | 2 ++ src/mesa/drivers/dri/i965/brw_wm.c | 2

[Mesa-dev] [PATCH 06/77] glsl: add cache to ctx and add sha1 string fields

2016-10-03 Thread Timothy Arceri
From: Carl Worth V2: dont leak cache Signed-off-by: Timothy Arceri --- src/mesa/main/context.c | 6 ++ src/mesa/main/mtypes.h | 5 + 2 files changed, 11 insertions(+) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c

  1   2   >