[Mesa-dev] [PATCH 1/2] mesa: add support for GL_INTEL_conservative_rasterization

2016-12-01 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/compiler/glsl/ast.h | 5 src/compiler/glsl/ast_to_hir.cpp | 5 src/compiler/glsl/ast_type.cpp | 16 +++- src/compiler/glsl/glsl_parser.yy | 34

[Mesa-dev] [PATCH 2/2] i965: enable INTEL_conservative_rasterization on Gen9+

2016-12-01 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- docs/relnotes/13.1.0.html| 1 + src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 1 +

[Mesa-dev] [PATCH 0/2] Add INTEL_conservative_rasterization support

2016-12-01 Thread Lionel Landwerlin
Hi, Here are a couple of patches to add support for the INTEL_conservative_rasterization extension. This is available on Gen9+ platforms. You can find associated piglit tests here : https://patchwork.freedesktop.org/series/16230/ Cheers, Lionel Landwerlin (2): mesa: add support for

Re: [Mesa-dev] [PATCH 0/3] gallium driver for Vivante GPUs

2016-12-01 Thread Emil Velikov
Hi Christian, Hats off for the tremendous work - both to you and fellow etnaviv hackers ! On 30 November 2016 at 13:44, Christian Gmeiner wrote: > As the original patchstack is now about 300 patches, I have choosen to > squash the patches together into three

Re: [Mesa-dev] [PATCH 3/3] imx: gallium driver for imx-drm scanout driver

2016-12-01 Thread Emil Velikov
On 30 November 2016 at 13:44, Christian Gmeiner wrote: > The imx (stub) driver is needed to get hardware acceleration from > etnaviv on a platform using imx-drm kms driver. This adds support > for wayland and native kms egl apps. > > Signed-off-by: Christian Gmeiner

Re: [Mesa-dev] [PATCH 1/3] gallium: add renderonly library

2016-12-01 Thread Emil Velikov
On 1 December 2016 at 12:00, Nicolai Hähnle wrote: > Congratulations on a huge amount of work! Obviously I can't say much about > the driver itself. Some things that I noticed for the renderonly library. > > On 30.11.2016 14:44, Christian Gmeiner wrote: >> >> This a very

Re: [Mesa-dev] [PATCH 00/10] mesa: support for EGL_ANDROID_native_fence_sync (vN+1)

2016-12-01 Thread Chad Versace
Hi Rob, just checking on the status on the patch set. Do you plan to send a revised series or commit them as-is? I ask because my i965 patches depend on your patches 1-4, and I'm trying to decide to when to resend them. On Fri 18 Nov 2016, Rob Clark wrote: > This patchset implements support for

Re: [Mesa-dev] [PATCH 0/2] Add INTEL_conservative_rasterization support

2016-12-01 Thread Lionel Landwerlin
Forgot to mentioned that this is based on top of Plamena's work (in case you want to test) : https://patchwork.freedesktop.org/series/15512/ On 01/12/16 15:56, Lionel Landwerlin wrote: Hi, Here are a couple of patches to add support for the INTEL_conservative_rasterization extension. This

Re: [Mesa-dev] [PATCH 25/50] glsl: Add "built-in" functions to do 64x64 => 64 multiplication

2016-12-01 Thread Ian Romanick
On 11/30/2016 12:19 PM, Matt Turner wrote: > On 11/28, Ian Romanick wrote: >> From: Ian Romanick [snip] >> + if (parser->extension_list) { >> + /* If MESA_shader_integer_functions is supported, then the >> building >> + * blocks required for the 64x64 =>

Re: [Mesa-dev] [PATCH 27/50] glsl: Add "built-in" function for 64-bit integer sign()

2016-12-01 Thread Ian Romanick
On 11/30/2016 12:46 PM, Matt Turner wrote: > On 11/28, Ian Romanick wrote: >> From: Ian Romanick >> >> These functions are directly available in shaders. A #define is added >> to detect the presence. This allows these functions to be tested using >> piglit regardless

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for GL_INTEL_conservative_rasterization

2016-12-01 Thread Ilia Mirkin
Ah, I see. The difference is that it exists, unlike the ARB one :) I was confusing with the NV variant. On Dec 1, 2016 2:10 PM, "Ilia Mirkin" wrote: Is this different from the arb variant? On Dec 1, 2016 10:56 AM, "Lionel Landwerlin" wrote:

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for GL_INTEL_conservative_rasterization

2016-12-01 Thread Ilia Mirkin
Is this different from the arb variant? On Dec 1, 2016 10:56 AM, "Lionel Landwerlin" wrote: > Signed-off-by: Lionel Landwerlin > --- > src/compiler/glsl/ast.h | 5 > src/compiler/glsl/ast_to_hir.cpp |

[Mesa-dev] [PATCH 3/3] i965: Delete the meta-base CopyImageSubData implementation

2016-12-01 Thread Jason Ekstrand
When I originally implemented the ARB_copy_image extension, the fast-path was written in meta using texture views. This path only worked if both images were uncompressed color images. All of the other cases fell back to the blitter or, in the worst case, mapping and memcpy on the CPU. Now that

[Mesa-dev] [PATCH 1/3] i965/blit: Break the guts of intel_miptree_blit into a helper

2016-12-01 Thread Jason Ekstrand
Cc: "13.0" --- src/mesa/drivers/dri/i965/intel_blit.c | 151 ++--- 1 file changed, 84 insertions(+), 67 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c index 4944b8c..15e45d4

[Mesa-dev] [PATCH 2/3] i965/copy_image: Re-implement the blitter path with emit_miptree_blit

2016-12-01 Thread Jason Ekstrand
By using emit_miptree_blit which does chunking, this fixes the blitter path for the case where the image is too tall to blit normally. We also pull it into intel_blit as intel_miptree_copy. This matches the naming of the blorp blit and copy functions brw_blorp_blit and brw_blorp_copy. Cc:

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: Actually use the stencil dimension

2016-12-01 Thread Nanley Chery
On Wed, Nov 30, 2016 at 05:55:32PM -0800, Jason Ekstrand wrote: > On Wed, Nov 30, 2016 at 10:20 AM, Nanley Chery > wrote: > > > On Tue, Nov 29, 2016 at 05:41:58PM -0800, Jason Ekstrand wrote: > > > In an attempt to fix 3DSTATE_DEPTH_BUFFER for stencil-only cases, I > > >

Re: [Mesa-dev] [PATCH 1/2] mesa: add support for GL_INTEL_conservative_rasterization

2016-12-01 Thread Chris Forbes
Ilia, it is different from the NV variant -- NV unfortunately threw a bunch of other stuff in (extra subpixel bits in conservative mode). Series is: Reviewed-by: Chris Forbes On Fri, Dec 2, 2016 at 8:21 AM, Ilia Mirkin wrote: > Ah, I see. The

[Mesa-dev] [PATCH 14/27] i965: Allow aux buffers to have an offset

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Previously our aux buffers (MCS, and HiZ) never had an offset because they were in their own buffer object. When using the CCS lossless compression feature, it's desirable to store the data at an offset from the main framebuffer, ie. share a buffer object.

[Mesa-dev] [PATCH 01/27] gbm: Move getters to match order in header file (trivial)

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Other things are out of order, but I need to add a getter so I'm just fixing those. This helps people adding to GBM know where the right place to put things is. Signed-off-by: Ben Widawsky --- src/gbm/main/gbm.c | 22

[Mesa-dev] [PATCH 16/27] i965/miptree: Allocate mcs_buf for an image's CCS_E

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky This code will disable actually creating these buffers for the scanout, but it puts the allocation in place. Primarily this patch is split out for review, it can be squashed in later if preferred. Signed-off-by: Ben Widawsky ---

[Mesa-dev] [PATCH 08/27] dri: Add an image creation with modifiers

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Modifiers will be obtains or guessed by the client and passed in during image creation/import. This requires bumping the DRIimage version. Signed-off-by: Ben Widawsky --- include/GL/internal/dri_interface.h | 28

[Mesa-dev] [PATCH 09/27] gbm: Introduce modifiers into surface/bo creation

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This information is directly passed in (and stored) so that the DRI implementation can create an image

[Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky This will be used by clients that need to know the number of planes allocated for them on behalf of the GL or other API. The best current example of this is when an extra "plane" is allocated to store compression data for the primary plane. Cc: Daniel Stone

[Mesa-dev] [PATCH 11/27] gbm: Get modifiers from DRI

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky v2: Use stored modifiers from create instead of queryImage Discussion with Kristian yielded that there is no need for per plane modifiers. Signed-off-by: Ben Widawsky --- src/gbm/backends/dri/gbm_dri.c | 32

[Mesa-dev] [PATCH 06/27] gbm: Export a per plane getter for offset

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Unlike stride, there was no previous offset getter, so it can be right on the first try. Signed-off-by: Ben Widawsky --- src/gbm/backends/dri/gbm_dri.c | 27 +++ src/gbm/gbm-symbols-check | 1 +

[Mesa-dev] [PATCH 22/27] i965: Change resolve flags to enum

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky In the foreseeable future it doesn't seem to make sense to have multiple resolve flags. What does make sense is to have the caller give an indication to the lower layers what it things should be done for resolve. The enum change distinguishes this binary

[Mesa-dev] [PATCH 26/27] i965: Remove scanout restriction from lossless compression

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Cc: Topi Pohjolainen Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 15/27] i965/miptree: Add a helper functions for image creation

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky This provides a common function or creating miptrees when there is an existing DRIimage to use. That provides an easy way to add CCS allocation. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_fbo.c | 17

[Mesa-dev] [PATCH 23/27] i965: Plumb resolve hints from miptrees to blorp

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++- src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++-- 3 files changed, 6 insertions(+), 4

[Mesa-dev] [PATCH 19/27] i965/miptree: Allocate mt earlier in update winsys

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Allows us to continue utilizing common miptree creation using __DRIimage without creating a new DRIimage (for the intel_process_dri2_buffer() case). This is a bit ugly, but I think it's the best one can do. Signed-off-by: Ben Widawsky

[Mesa-dev] [PATCH 02/27] gbm: Fix width height getters return type (trivial)

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Signed-off-by: Ben Widawsky --- src/gbm/main/gbm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gbm/main/gbm.h b/src/gbm/main/gbm.h index 59daaa1..efb329e 100644 --- a/src/gbm/main/gbm.h +++

[Mesa-dev] [PATCH 04/27] gbm: Create a gbm_device getter for stride

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky This will be used so we can query information per plane. Signed-off-by: Ben Widawsky --- src/gbm/backends/dri/gbm_dri.c | 7 +++ src/gbm/main/gbm.c | 2 +- src/gbm/main/gbmint.h | 1 + 3 files changed, 9

[Mesa-dev] [PATCH 00/27] Renderbuffer Decompression (and GBM modifiers)

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky This patch series ultimately adds support within the i965 driver for Renderbuffer Decompression with GBM. In short, this feature reduces memory bandwidth by allowing the GPU to work with losslessly compressed data and having that compression scheme

[Mesa-dev] [PATCH] nir/gcm: Rework the schedule late loop

2016-12-01 Thread Jason Ekstrand
This fixes a bug in code motion that occurred when the best block is the same as the schedule early block. In this case, because we're checking (lca != def->parent_instr->block) at the top of the loop, we never get to the check for loop depth so we wouldn't move it out of the loop. This commit

[Mesa-dev] [PATCH 27/27] i965: Handle compression modifier

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky FINISHME: Use the kernel's final choice for the fb modifier bwidawsk@norris2:~/intel-gfx/kmscube (modifiers $) ~/scripts/measure_bandwidth.sh ./kmscube none Read bandwidth: 603.91 MiB/s Write bandwidth: 615.28 MiB/s bwidawsk@norris2:~/intel-gfx/kmscube

[Mesa-dev] [PATCH 20/27] i965: Pretend that CCS modified images are two planes

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c

[Mesa-dev] [PATCH 05/27] gbm: Export a per plane getter for stride

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Signed-off-by: Ben Widawsky --- src/gbm/backends/dri/gbm_dri.c | 26 +- src/gbm/gbm-symbols-check | 1 + src/gbm/main/gbm.c | 15 ++- src/gbm/main/gbm.h | 3 +++ 4 files

[Mesa-dev] [PATCH 18/27] i965/miptree: Add a return for updating of winsys

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky There is nothing particularly useful to do currently if the update fails, but there is no point carrying on either. As a result, this has a behavior change. Signed-off-by: Ben Widawsky ---

[Mesa-dev] [PATCH 10/27] i965: Handle Y-tile modifier

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky This doesn't actually enable Y-tiling, it simply parses it and moves on. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_image.h | 1 + src/mesa/drivers/dri/i965/intel_screen.c | 36

[Mesa-dev] [PATCH 12/27] i965: Bring back always Y-tiled on SKL+

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky commit 6a0d036483caf87d43ebe2edd1905873446c9589 Author: Ben Widawsky Date: Thu Apr 21 20:14:58 2016 -0700 i965: Always use Y-tiled buffers on SKL+ Aside from the benchmark gains that were initially posted, I was able to collect

[Mesa-dev] [PATCH 25/27] i965: Use partial resolves for CCS buffers being scanned out

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky On Gen9 hardware, the display engine is able to scanout a compressed framebuffer by providing an offset to auxiliary compression information. Unfortunately, the hardware is incapable of doing the same thing for the fast clear color. To mitigate this, the

[Mesa-dev] [PATCH 24/27] i965: Add new resolve hints full and partial

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Upper layers of the code will have the need to specify full or partial resolves (more on this in the next patch). This code simply adds the new enums and plumbs it in as minimally as necessary. Signed-off-by: Ben Widawsky ---

[Mesa-dev] [PATCH 13/27] i965: Separate image allocation with modifiers

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Since the code doesn't support modifiers yet, this patch should do nothing other than prepare for more patches. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 73 ++-- 1 file

[Mesa-dev] [PATCH 21/27] i965: Make CCS stride match kernel's expectations

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Cc: Ville Syrjälä Cc: Jason Ekstrand Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 17/27] i965: Create correctly sized mcs for an image

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 37 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c

Re: [Mesa-dev] Mesa 13.1.0 release plan

2016-12-01 Thread Marek Olšák
On Wed, Nov 30, 2016 at 9:23 PM, Emil Velikov wrote: > Hi all, > > With holidays not far off, it might be a nice idea to consider the > branchpoint/release schedule for the next release. > > I will be having limited internet access during 20 Dec - 7 Jan, thus > the I'm

[Mesa-dev] [PATCH 07/27] i965/dri: Store the screen associated with the image

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky I intend to need to get to the devinfo structure, and storing the screen is an easy way to do that. It seems to be the consensus that you cannot share an image between multiple screens. Scape-goat: Rob Clark Signed-off-by: Ben

Re: [Mesa-dev] [PATCH] nir: Get rid of nir_constant_data

2016-12-01 Thread Jason Ekstrand
On Thu, Dec 1, 2016 at 12:46 AM, Iago Toral wrote: > On Tue, 2016-11-29 at 22:51 -0800, Jason Ekstrand wrote: > > This has bothered me for about as long as NIR has been around. Why > > do we > > have two different unions for constants? No good reason other than > > one of >

Re: [Mesa-dev] [PATCH v2 3/7] intel/blorp_blit: Adjust blorp surface parameters for split blits

2016-12-01 Thread Jason Ekstrand
On Wed, Nov 30, 2016 at 8:12 PM, Jordan Justen wrote: > If try_blorp_blit() previously returned that a blit was too large, > shrink_surface_params() will be used to update the surface parameters > for the smaller blit so the blit operation can proceed. > > v2: > * Use

Re: [Mesa-dev] Mesa 13.1.0 release plan

2016-12-01 Thread Timothy Arceri
On Wed, 2016-11-30 at 20:23 +, Emil Velikov wrote: > Hi all, > > With holidays not far off, it might be a nice idea to consider the > branchpoint/release schedule for the next release. > > I will be having limited internet access during 20 Dec - 7 Jan, thus > the I'm leaning towards

Re: [Mesa-dev] [PATCH 14/27] i965: Allow aux buffers to have an offset

2016-12-01 Thread Ben Widawsky
On 16-12-01 14:41:20, Kenneth Graunke wrote: On Thursday, December 1, 2016 2:09:55 PM PST Ben Widawsky wrote: From: Ben Widawsky Previously our aux buffers (MCS, and HiZ) never had an offset because they were in their own buffer object. When using the CCS lossless

Re: [Mesa-dev] [PATCH 14/18] i965: Replace reg_type_size[] with a function.

2016-12-01 Thread Matt Turner
On Sun, Nov 27, 2016 at 1:26 AM, Kenneth Graunke wrote: > On Tuesday, November 22, 2016 11:59:48 AM PST Matt Turner wrote: >> A function is necessary to handle immediate types. >> --- >> src/mesa/drivers/dri/i965/brw_disasm.c | 35 >>

[Mesa-dev] [Bug 97524] Samplers referring to the same texture unit with different types should raise GL_INVALID_OPERATION

2016-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97524 --- Comment #17 from Timothy Arceri --- Created attachment 128306 --> https://bugs.freedesktop.org/attachment.cgi?id=128306=edit Validate sampler types across the whole program It's untested but this patch should do the

[Mesa-dev] [PATCH v2] nir: Get rid of nir_constant_data

2016-12-01 Thread Jason Ekstrand
This has bothered me for about as long as NIR has been around. Why do we have two different unions for constants? No good reason other than one of them is a direct port from GLSL IR. --- src/compiler/glsl/glsl_to_nir.cpp | 35 +--- src/compiler/nir/nir.c | 32

Re: [Mesa-dev] [PATCH 14/27] i965: Allow aux buffers to have an offset

2016-12-01 Thread Kenneth Graunke
On Thursday, December 1, 2016 2:09:55 PM PST Ben Widawsky wrote: > From: Ben Widawsky > > Previously our aux buffers (MCS, and HiZ) never had an offset because > they were in their own buffer object. When using the CCS lossless > compression feature, it's desirable to store

[Mesa-dev] [PATCH] tgsi: store writes_primid when scanning tgsi

2016-12-01 Thread Tim Rowley
--- src/gallium/auxiliary/tgsi/tgsi_scan.c | 3 +++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 84d6456..77fe6b3 100644 ---

Re: [Mesa-dev] [PATCH] tgsi: store writes_primid when scanning tgsi

2016-12-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Dec 1, 2016 at 6:14 PM, Tim Rowley wrote: > --- > src/gallium/auxiliary/tgsi/tgsi_scan.c | 3 +++ > src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git

[Mesa-dev] [AppVeyor] mesa master #2862 failed

2016-12-01 Thread AppVeyor
Build mesa 2862 failed Commit 6bf63b0119 by Timothy Arceri on 11/9/2016 4:01 AM: st/mesa: get Version from gl_program rather than gl_shader_program\n\nReviewed-by: Nicolai Hähnle Configure your notification preferences

[Mesa-dev] [AppVeyor] mesa master #2862 failed

2016-12-01 Thread Dieter Nützel
Hello Timothy, it fails, here: state_tracker/st_atom_texture.c: In function 'update_textures': state_tracker/st_atom_texture.c:130:49: error: 'const struct ' has no member named 'data' prog->sh.data->Version);

Re: [Mesa-dev] [PATCH 12/22] spirv/nir: implement DF conversions

2016-12-01 Thread Jason Ekstrand
On Fri, Nov 25, 2016 at 12:52 AM, Juan A. Suarez Romero wrote: > From: Samuel Iglesias Gonsálvez > > SPIR-V does not have special opcodes for DF conversions. We need to > identify > them by checking the bit size of the operand and the result. > >

Re: [Mesa-dev] [PATCH 04/22] spirv: add DF support to vtn_const_ssa_value()

2016-12-01 Thread Jason Ekstrand
If you don't mind rebasing on it, my "get rid of nir_constant_data" patch should let you drop most of this and patch 5. On Fri, Nov 25, 2016 at 12:52 AM, Juan A. Suarez Romero wrote: > From: Samuel Iglesias Gonsálvez > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 16/22] isl: fix VA64 support for double and dvecN vertex attributes

2016-12-01 Thread Jason Ekstrand
On Fri, Nov 25, 2016 at 12:52 AM, Juan A. Suarez Romero wrote: > From: Samuel Iglesias Gonsálvez > > We use *64*_PASSTHRU formats to upload vertex attributes of 64 bits > to avoid conversions. From the BDW PRM, Volume 2d, page 586 >

[Mesa-dev] [PATCH] swr: Fix active_queries count

2016-12-01 Thread Bruce Cherniak
The active_query count was incorrect for query types that don't require a begin_query. Removed the unnecessary assert. --- src/gallium/drivers/swr/swr_query.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/swr/swr_query.cpp

Re: [Mesa-dev] [PATCH 50/58] st/mesa: get Version from gl_program rather than gl_shader_program

2016-12-01 Thread Timothy Arceri
On Thu, 2016-12-01 at 12:38 +0100, Nicolai Hähnle wrote: > Hmm, I wonder what the rules are when different shaders have > different  > versions and are linked together? Yeah I was wondering the same when I changed this. It seems that in linker.cpp we get the max version from the shaders and store

Re: [Mesa-dev] [PATCH v2] nir: Get rid of nir_constant_data

2016-12-01 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2016-12-01 at 16:07 -0800, Jason Ekstrand wrote: > This has bothered me for about as long as NIR has been around.  Why > do we > have two different unions for constants?  No good reason other than > one of > them is a direct port from

Re: [Mesa-dev] [PATCH 1/3] gallium: add renderonly library

2016-12-01 Thread Nicolai Hähnle
Congratulations on a huge amount of work! Obviously I can't say much about the driver itself. Some things that I noticed for the renderonly library. On 30.11.2016 14:44, Christian Gmeiner wrote: This a very lightweight library to add basic support for renderonly GPUs. It does all the magic

Re: [Mesa-dev] Mesa 13.1.0 release plan

2016-12-01 Thread Nicolai Hähnle
On 30.11.2016 21:23, Emil Velikov wrote: Hi all, With holidays not far off, it might be a nice idea to consider the branchpoint/release schedule for the next release. +1 on the 17.0 question. I will be having limited internet access during 20 Dec - 7 Jan, thus the I'm leaning towards

Re: [Mesa-dev] Mesa 13.1.0 release plan

2016-12-01 Thread Christian Gmeiner
2016-11-30 21:23 GMT+01:00 Emil Velikov : > Hi all, > > With holidays not far off, it might be a nice idea to consider the > branchpoint/release schedule for the next release. > > I will be having limited internet access during 20 Dec - 7 Jan, thus > the I'm leaning

Re: [Mesa-dev] [PATCH] nir: Get rid of nir_constant_data

2016-12-01 Thread Iago Toral
On Tue, 2016-11-29 at 22:51 -0800, Jason Ekstrand wrote: > This has bothered me for about as long as NIR has been around.  Why > do we > have two different unions for constants?  No good reason other than > one of > them is a direct port from GLSL IR. > --- >  src/compiler/glsl/glsl_to_nir.cpp  |

Re: [Mesa-dev] [PATCH] mesa: reset linked_stages bitmask when re-linking

2016-12-01 Thread Nicolai Hähnle
On 30.11.2016 22:58, Timothy Arceri wrote: 34953f8907fdd added this bitmask but it wasn't being reset when a program was relinked. If a stage was removed from the new program then it could case a crash as we expect the linked shader for that stage to not be null. Fixes crashes in:

Re: [Mesa-dev] [PATCH 2/2] i965: Add i965 plumbing for ARB_post_depth_coverage for i965 (gen9+).

2016-12-01 Thread Lionel Landwerlin
On 01/12/16 04:02, Chris Forbes wrote: A couple of notes on existing weirdness here: - Naming of GEN9_PSX_SHADER_NORMAL_COVERAGE_MASK_SHIFT is bizarre (not your fault) - Is BRW_PSICMS_INNER really the right thing for the normal mode? Why not BRW_PSICMS_NORMAL? Perhaps whoever added this stuff

Re: [Mesa-dev] [PATCH] mesa: only verify that enabled arrays have backing buffers

2016-12-01 Thread Tapani Pälli
On 12/01/2016 12:59 PM, Ilia Mirkin wrote: On Thu, Dec 1, 2016 at 5:50 AM, Tapani Pälli wrote: On 12/01/2016 12:19 PM, Tapani Pälli wrote: On 12/01/2016 12:04 AM, Ilia Mirkin wrote: We were previously also verifying that no backing buffers were available when

Re: [Mesa-dev] [PATCH 48/58] st/mesa: pass gl_program to st_bind_ubos()

2016-12-01 Thread Nicolai Hähnle
Patches 44-48: Reviewed-by: Nicolai Hähnle On 20.11.2016 14:29, Timothy Arceri wrote: We no longer need anything from gl_linked_shader. --- src/mesa/state_tracker/st_atom_constbuf.c | 24 1 file changed, 12 insertions(+), 12 deletions(-)

Re: [Mesa-dev] [PATCH 50/58] st/mesa: get Version from gl_program rather than gl_shader_program

2016-12-01 Thread Nicolai Hähnle
Hmm, I wonder what the rules are when different shaders have different versions and are linked together? Then again, the use of the glsl_version in st_sampler_view.c pretty much admits that it's already a hack, so I think this is fine. Patches 49 & 50: Reviewed-by: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] mesa: only verify that enabled arrays have backing buffers

2016-12-01 Thread Tapani Pälli
On 12/01/2016 12:19 PM, Tapani Pälli wrote: On 12/01/2016 12:04 AM, Ilia Mirkin wrote: We were previously also verifying that no backing buffers were available when an array wasn't enabled. This is has no basis in the spec, and it causes GLupeN64 to fail as a result. I'm a bit puzzled

Re: [Mesa-dev] [PATCH] mesa: only verify that enabled arrays have backing buffers

2016-12-01 Thread Tapani Pälli
On 12/01/2016 12:04 AM, Ilia Mirkin wrote: We were previously also verifying that no backing buffers were available when an array wasn't enabled. This is has no basis in the spec, and it causes GLupeN64 to fail as a result. I'm a bit puzzled about the API usage here, is the app attempting to

Re: [Mesa-dev] [PATCH] mesa: only verify that enabled arrays have backing buffers

2016-12-01 Thread Ilia Mirkin
On Thu, Dec 1, 2016 at 5:50 AM, Tapani Pälli wrote: > > > On 12/01/2016 12:19 PM, Tapani Pälli wrote: >> >> >> On 12/01/2016 12:04 AM, Ilia Mirkin wrote: >>> >>> We were previously also verifying that no backing buffers were available >>> when an array wasn't enabled. This

Re: [Mesa-dev] [PATCH 19/22] anv/nir: add support for dvec3/4 consuming two locations

2016-12-01 Thread Jason Ekstrand
I'm not sure how I feel about this one. It seems like it would almost be easier to just pick one convention or the other for NIR and adjust one of the drivers accordingly. I don't know that I have a huge preference which convention we choose. I guess the Vulkan convention matches our hardware a

Re: [Mesa-dev] [PATCH 19/22] anv/nir: add support for dvec3/4 consuming two locations

2016-12-01 Thread Jason Ekstrand
+Ken On Thu, Dec 1, 2016 at 10:17 PM, Jason Ekstrand wrote: > I'm not sure how I feel about this one. It seems like it would almost be > easier to just pick one convention or the other for NIR and adjust one of > the drivers accordingly. I don't know that I have a huge

Re: [Mesa-dev] [AppVeyor] mesa master #2862 failed

2016-12-01 Thread Timothy Arceri
On Fri, 2016-12-02 at 04:51 +0100, Dieter Nützel wrote: > Hello Timothy, > > it fails, here: > > state_tracker/st_atom_texture.c: In function 'update_textures': > state_tracker/st_atom_texture.c:130:49: error: 'const struct  > ' has no member named 'data' >    

[Mesa-dev] [AppVeyor] mesa master #2863 completed

2016-12-01 Thread AppVeyor
Build mesa 2863 completed Commit c45d84ad83 by Timothy Arceri on 12/2/2016 5:44 AM: Revert "st/mesa: get Version from gl_program rather than gl_shader_program"\n\nThis reverts commit 6bf63b011992dbbc899a28bde5692070dbcf965a.\n\nA patch that adds a reference to