Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-07 Thread Timothy Arceri
On 08/12/17 04:57, Matt Turner wrote: On Tue, Dec 5, 2017 at 3:40 PM, Jordan Justen wrote: On 2017-12-05 14:49:28, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 09:13:11, Mark Janes wrote: Jordan Justen

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 14/48] i965/fs: Extend the live ranges of VGRFs which leave loops

2017-12-07 Thread Connor Abbott
On Thu, Dec 7, 2017 at 5:30 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Fri, Oct 27, 2017 at 5:24 PM, Francisco Jerez >> wrote: >> >>> I've submitted an alternative to this approach here [1], more along the >>>

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

2017-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100708 Alexander Tsoy changed: What|Removed |Added CC||alexan...@tsoy.me

[Mesa-dev] [PATCH 1/2] gallium/aux: include nr_samples in util_resource_size() computation

2017-12-07 Thread Brian Paul
This function is only used in two places: 1. VMware driver, but only for HUD reporting 2. st/nine state tracker, used for texture memory accounting --- src/gallium/auxiliary/util/u_resource.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/2] gallium/util: don't pass a pipe_resource to util_resource_is_array_texture()

2017-12-07 Thread Brian Paul
No need to pass a pipe_resource when we can just pass the target. This makes the function potentially more usable. Rename it too. --- src/gallium/auxiliary/util/u_resource.h | 6 +++--- src/gallium/drivers/radeon/r600_texture.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 14/48] i965/fs: Extend the live ranges of VGRFs which leave loops

2017-12-07 Thread Francisco Jerez
Connor Abbott writes: > On Thu, Dec 7, 2017 at 5:30 PM, Francisco Jerez wrote: >> Jason Ekstrand writes: >> >>> On Fri, Oct 27, 2017 at 5:24 PM, Francisco Jerez >>> wrote: >>> I've submitted an

Re: [Mesa-dev] [PATCH 3/8] spirv: Add basic type validation for OpLoad, OpStore, and OpCopyMemory

2017-12-07 Thread Jason Ekstrand
On Thu, Dec 7, 2017 at 11:54 AM, Michael Schellenberger Costa < mschellenbergerco...@googlemail.com> wrote: > Hi Jason, > > > Am 07.12.2017 um 17:12 schrieb Jason Ekstrand: > >> --- >> src/compiler/spirv/vtn_variables.c | 18 ++ >> 1 file changed, 14 insertions(+), 4

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 14/48] i965/fs: Extend the live ranges of VGRFs which leave loops

2017-12-07 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, Oct 27, 2017 at 5:24 PM, Francisco Jerez > wrote: > >> I've submitted an alternative to this approach here [1], more along the >> lines of the v1 patch you borrowed from my jenkins branch. Most of the >> reasons for

Re: [Mesa-dev] [PATCH 2/2] gallium/util: don't pass a pipe_resource to util_resource_is_array_texture()

2017-12-07 Thread Roland Scheidegger
For the series: Reviewed-by: Roland Scheidegger Am 07.12.2017 um 23:25 schrieb Brian Paul: > No need to pass a pipe_resource when we can just pass the target. > This makes the function potentially more usable. Rename it too. > --- > src/gallium/auxiliary/util/u_resource.h

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-07 Thread Jordan Justen
On 2017-12-07 09:57:48, Matt Turner wrote: > On Tue, Dec 5, 2017 at 3:40 PM, Jordan Justen > wrote: > > On 2017-12-05 14:49:28, Mark Janes wrote: > >> Jordan Justen writes: > >> > On 2017-12-05 09:13:11, Mark Janes wrote: > >> >> Adding a

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-07 Thread Kenneth Graunke
On Thursday, December 7, 2017 9:57:48 AM PST Matt Turner wrote: [snip] > But the entire API boils down to a comparatively small set of > non-orthogonal state. The configuration of those nobs seems to me like > the place things are most likely to break. I do like Matt's idea of adding Piglit tests

Re: [Mesa-dev] [PATCH 15/23] main: add binary support to ProgramBinary

2017-12-07 Thread Tapani Pälli
13,14,15 Reviewed-by: Tapani Pälli On 11/29/2017 03:24 AM, Timothy Arceri wrote: From: Jordan Justen V2: call generic mesa_program_binary() helper rather than driver function directly to allow greater code sharing. Signed-off-by:

Re: [Mesa-dev] [RFC PATCH 0/6] r600: speed up tesselation shaders

2017-12-07 Thread Dave Airlie
On 15 November 2017 at 19:29, Gert Wollny wrote: > Dear all, > > since on r600 the tesselation shaders don't go through the sb-optimizer I > though it might help to improve performance by applying some optimizations > to the created assembly. The patches are experimental but

[Mesa-dev] [PATCH 4/4] spirv: Handle image and sampler function parameters

2017-12-07 Thread Jason Ekstrand
--- src/compiler/spirv/vtn_cfg.c | 73 1 file changed, 73 insertions(+) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index ac98f02..f05aa2f 100644 --- a/src/compiler/spirv/vtn_cfg.c +++ b/src/compiler/spirv/vtn_cfg.c @@

[Mesa-dev] [PATCH 1/4] spirv: Make sampled images a real type

2017-12-07 Thread Jason Ekstrand
Previously, we just gave them exactly the same type as the respective image (which already had a sampler2D or similar type). Now they have their own base type and a pointer to the vtn_type for the image. --- src/compiler/spirv/spirv_to_nir.c | 5 - src/compiler/spirv/vtn_private.h | 7

Re: [Mesa-dev] [PATCH 2/2] gallium/util: don't pass a pipe_resource to util_resource_is_array_texture()

2017-12-07 Thread Charmaine Lee
Series looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, December 7, 2017 2:25:05 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Roland Scheidegger Subject: [PATCH

Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

2017-12-07 Thread Tapani Pälli
On 12/07/2017 08:45 PM, Emil Velikov wrote: Hi Harish, On 7 December 2017 at 13:34, Harish Krupo wrote: From android cts 8.0_r4, a new test case checks if all the required egl extensions are exposed. In the current implementation we expose KHR_image if

[Mesa-dev] [PATCH 2/4] spirv/cfg: Be a bit more precise about function parameters

2017-12-07 Thread Jason Ekstrand
Pointers with no storage type are converted to inout variables but SSA values and pointers with a storage type (which turns into a uint or uvec2) are just input variables. --- src/compiler/spirv/vtn_cfg.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 3/4] spirv/cfg: Refactor the function parameter loop a bit

2017-12-07 Thread Jason Ekstrand
--- src/compiler/spirv/vtn_cfg.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index 1b672bb..ac98f02 100644 --- a/src/compiler/spirv/vtn_cfg.c +++ b/src/compiler/spirv/vtn_cfg.c @@ -51,16 +51,20 @@

Re: [Mesa-dev] [PATCH] nir/opcodes: Fix constant-folding of bitfield_insert

2017-12-07 Thread Alex Smith
Pushed. On 6 December 2017 at 17:35, Matt Turner wrote: > On Wed, Dec 6, 2017 at 3:55 AM, James Legg > wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104119 > > CC: > > CC: Samuel Pitoiset

[Mesa-dev] [PATCH] mesa/spirv: move and rename nir_spirv_supported_capabilities

2017-12-07 Thread Alejandro Piñeiro
To avoid any vulkan driver to include the GL mtypes.h. Renamed as eventually this could be used by drivers not using nir. --- Sending the proposed alternative in advance, so if Jason agrees, it is just about Rb it. src/compiler/spirv/nir_spirv.h | 4 ++-- src/compiler/spirv/spirv.h | 15

Re: [Mesa-dev] [PATCH] mesa: define nir_spirv_supported_capabilities

2017-12-07 Thread Alejandro Piñeiro
On 07/12/17 06:23, Jason Ekstrand wrote: > On Wed, Dec 6, 2017 at 8:48 PM, Timothy Arceri > wrote: > > On 07/12/17 00:23, Alejandro Piñeiro wrote: > > On 06/12/17 13:29, Pierre Moreau wrote: > > Hello Alejandro, > >

Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

2017-12-07 Thread Tapani Pälli
Looks good, indeed KHR_image spec does not require KHR_image_pixmap or KHR_image_base. Wayland might also be able to enable this but not sure if makes sense there or not. Reviewed-by: Tapani Pälli On 07.12.2017 15:34, Harish Krupo wrote: From android cts 8.0_r4, a

[Mesa-dev] [PATCH mesa] meson: add dep_thread to every lib that includes threads.h

2017-12-07 Thread Eric Engestrom
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104141 Signed-off-by: Eric Engestrom --- src/broadcom/meson.build| 2 +- src/gallium/auxiliary/meson.build | 2 +- src/gallium/state_trackers/nine/meson.build | 1 +

Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

2017-12-07 Thread Eric Engestrom
On Thursday, 2017-12-07 19:04:41 +0530, Harish Krupo wrote: > From android cts 8.0_r4, a new test case checks if all the required egl > extensions are exposed. In the current implementation we expose KHR_image > if KHR_image_base and KHR_image_pixmap are supported but KHR_image spec > does not

[Mesa-dev] [Bug 104141] include/c11/threads_posix.h:96: undefined reference to `pthread_once'

2017-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104141 --- Comment #1 from Eric Engestrom --- Yup, I noticed the same issue, but there are more libs missing dep_thread. Sent a patch to the ML that fixes all of them:

[Mesa-dev] [PATCH 2/3] broadcom/vc4: Add support for extended CL submission

2017-12-07 Thread Boris Brezillon
Recent versions of the VC4 driver support CL extensions, which allows one to pass extra attributes to the CL submission. In order to make this feature backward compatible with the existing SUBMIT_CL ioctl, we had to add a new flag and re-use the optional bin_cl fields. Binner CL are now passed as

[Mesa-dev] [PATCH 1/3] drm-uapi: Update vc4 header with CL chunks and perfmon related definitions

2017-12-07 Thread Boris Brezillon
Signed-off-by: Boris Brezillon --- include/drm-uapi/vc4_drm.h | 156 ++--- 1 file changed, 146 insertions(+), 10 deletions(-) diff --git a/include/drm-uapi/vc4_drm.h b/include/drm-uapi/vc4_drm.h index

[Mesa-dev] [PATCH 3/3] broadcom/vc4: Add support for HW perfmon

2017-12-07 Thread Boris Brezillon
The V3D engine provides several perf counters. Implement ->get_driver_query_[group_]info() so that these counters are exposed through the GL_AMD_performance_monitor extension. Signed-off-by: Boris Brezillon --- src/gallium/drivers/vc4/vc4_context.h | 13 +++

[Mesa-dev] [PATCH 0/3] broadcom/v4: Expose VC4 HW perf counters

2017-12-07 Thread Boris Brezillon
Hello, This series makes use of the VC4 perfmon ioctls to expose HW perf counters through the GL_AMD_performance_monitor interface. This patches depends on their kernel counterparts and should not be applied until the kernel patches have reached the drm tree. Regards, Boris Boris Brezillon

Re: [Mesa-dev] [PATCH v2 19/25] mesa/glspirv: Add a _mesa_spirv_link_shaders() placeholder

2017-12-07 Thread Eduardo Lima Mitev
On 12/07/2017 05:51 AM, Timothy Arceri wrote: > Please squash this with patch 22 tis is just code churn. > Ok, this makes sense, though I will have to re-order a bit the patches to keep each single one building fine. I the squashed result would keep your R-b from patch 22, right? thnaks,

Re: [Mesa-dev] [PATCH 04/23] main, glsl: Add UniformDataDefaults which stores uniform defaults

2017-12-07 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 11/29/2017 03:24 AM, Timothy Arceri wrote: From: Jordan Justen The ARB_get_program_binary extension requires that uniform values in a program be restored to their initial value just after linking. This patch

[Mesa-dev] [Bug 104119] radv: OpBitFieldInsert produces 0 with a loop counter for Insert

2017-12-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104119 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

2017-12-07 Thread Eric Engestrom
On Tuesday, 2017-12-05 09:40:53 -0800, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > meson.build | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meson.build b/meson.build > index 3e8ea7d17e0..bf6bd551f08 100644 > ---

Re: [Mesa-dev] [RFC] r600/evergreen compute shader + glsl 4.30 support

2017-12-07 Thread Gert Wollny
Am Donnerstag, den 07.12.2017, 09:35 +1000 schrieb Dave Airlie: > > > I've pushed a bunch of the code, except for the final enables, > > Care to give my r600-gl-4.3 branch a spin? It shows quite some regressions w.r.t the WIP branch: WIP gl-4.3

Re: [Mesa-dev] testing for certain compiler options does not work

2017-12-07 Thread Marc Dietrich
Hi Ian, Am Mittwoch, 6. Dezember 2017, 21:21:53 CET schrieb Ian Romanick: > On 11/29/2017 08:16 AM, Marc Dietrich wrote: > > Hi, > > > > just found that my gcc 'gcc (SUSE Linux) 7.2.1 20171020 [gcc-7-branch > > revision 253932]' does not warn when using the negative form of > > unsupported

[Mesa-dev] [PATCH mesa v2] meson: fix pl111 dependency on vc4

2017-12-07 Thread Eric Engestrom
src/gallium/winsys/pl111/drm/libpl111winsys.a(pl111_drm_winsys.c.o): In function `pl111_drm_screen_create': pl111_drm_winsys.c:(.text+0x33): undefined reference to `vc4_drm_screen_create_renderonly' Signed-off-by: Eric Engestrom Reviewed-by: Dylan Baker

Re: [Mesa-dev] [PATCH] util/disk_cache: Remove unneeded free() on always null string

2017-12-07 Thread Eric Engestrom
On Monday, 2017-12-04 11:47:33 +0200, vadim.shovkopl...@gmail.com wrote: > From: Vadym Shovkoplias > > At this point dc_job->cache_item_metadata.keys always equals > NULL, so call to free() is useless > > Fixes: b86ecea3446 ("util/disk_cache: write cache item

Re: [Mesa-dev] V3 i965/Gallium ARB_get_program_binary support

2017-12-07 Thread Tapani Pälli
On 12/07/2017 01:47 PM, Tapani Pälli wrote: Hi; I've been testing this functionality with little app I have and I noticed one thing by accident. If I call link twice for a regular program like this: glLinkProgram(program); glLinkProgram(program); everything's fine, sequential calls do

[Mesa-dev] [PATCH] radv: fix TC-compat HTILE with VK_FORMAT_D32_SFLOAT_S8_UINT on Vega

2017-12-07 Thread Samuel Pitoiset
Copied from RadeonSI. This fixes all CTS dEQP-VK.renderpass.dedicated_allocation.formats.d32_sfloat_s8_uint.clear.* And some other ones which use the same format. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 6 ++ 1 file changed, 6

Re: [Mesa-dev] V3 i965/Gallium ARB_get_program_binary support

2017-12-07 Thread Tapani Pälli
Hi; I've been testing this functionality with little app I have and I noticed one thing by accident. If I call link twice for a regular program like this: glLinkProgram(program); glLinkProgram(program); everything's fine, sequential calls do not generate errors. However for program loaded

[Mesa-dev] [PATCH v2] mesa/spirv: move and rename nir_spirv_supported_capabilities

2017-12-07 Thread Alejandro Piñeiro
To avoid any vulkan driver to include the GL mtypes.h. Renamed as eventually this could be used by drivers not using nir. v2: remove compiler/spirv/spirv.h from mtypes (Alejandro) --- The include on v1 was a leftover, when I tested if adding the SpirVCapabilities on gl_constant was working fine,

Re: [Mesa-dev] [PATCH 12/23] mesa: Add Mesa ARB_get_program_binary helper functions

2017-12-07 Thread Tapani Pälli
This looks good as well, I've spent also some quality debugger time today with these bits and my EGL_ANDROID_blob_cache branch. I'll be using these functions and probably do some minor refactors so that glGetProgramBinary() errors won't get printed when Android cache calls this. Reviewed-by:

Re: [Mesa-dev] [PATCH v4] egl/wayland: Support for KHR_partial_update

2017-12-07 Thread Harish Krupo
Harish Krupo writes: > This passes 33/37 deqp tests related to partial_update, 4 are not > supported. Tests not supported: > dEQP-EGL.functional.negative_partial_update.not_postable_surface > dEQP-EGL.functional.negative_partial_update.not_current_surface >

[Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

2017-12-07 Thread Harish Krupo
From android cts 8.0_r4, a new test case checks if all the required egl extensions are exposed. In the current implementation we expose KHR_image if KHR_image_base and KHR_image_pixmap are supported but KHR_image spec does not mandate the existence of both the extensions. This patch preserves the

Re: [Mesa-dev] [PATCH mesa] meson: add dep_thread to every lib that includes threads.h

2017-12-07 Thread Emil Velikov
On 7 December 2017 at 14:51, Eric Engestrom wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104141 > Signed-off-by: Eric Engestrom > --- > src/broadcom/meson.build| 2 +- >

[Mesa-dev] [PATCH 04/10] swrast: remove non-applicable GLX_SWAP_COPY_OML comment

2017-12-07 Thread Emil Velikov
From: Emil Velikov Noticed while skimming for GLX_ instances i the dri codebase. Comment is completely off and was in such a state since day 1. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/swrast/swrast.c | 3 --- 1 file changed,

Re: [Mesa-dev] [PATCH mesa v2] meson: fix pl111 dependency on vc4

2017-12-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Thanks for making those changes. Quoting Eric Engestrom (2017-12-07 03:25:58) > src/gallium/winsys/pl111/drm/libpl111winsys.a(pl111_drm_winsys.c.o): In > function `pl111_drm_screen_create': > pl111_drm_winsys.c:(.text+0x33): undefined reference to

[Mesa-dev] [PATCH 01/10] mapi: autotools: remove unused MAPI_FILES file list

2017-12-07 Thread Emil Velikov
From: Emil Velikov The sole user was OpenVG, which was removed couple of years ago. Signed-off-by: Emil Velikov --- src/mapi/Makefile.sources | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/mapi/Makefile.sources

[Mesa-dev] [PATCH 02/10] mapi: remove non applicable HAVE_DIX_CONFIG_H hunk

2017-12-07 Thread Emil Velikov
From: Emil Velikov Seeming artefact from when the xserver build was diving directly into mesa's tree. Signed-off-by: Emil Velikov --- src/mapi/glapi/glapi_priv.h | 6 -- 1 file changed, 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

2017-12-07 Thread Dylan Baker
Quoting Eric Engestrom (2017-12-07 04:17:58) > On Tuesday, 2017-12-05 09:40:53 -0800, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > --- > > meson.build | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/meson.build

Re: [Mesa-dev] [PATCH] meson: Add lmsensors to gallium libgl-xlib target.

2017-12-07 Thread Dylan Baker
I don't suppose someone would like to ack this? Quoting Dylan Baker (2017-12-04 14:05:12) > Fixes: 5e71efef44b992b5d70b ("meson: Add lmsensors support") > Signed-off-by: Dylan Baker > --- > src/gallium/targets/libgl-xlib/meson.build | 2 +- > 1 file changed, 1

[Mesa-dev] [PATCH] radeon/vce: move destroy command before feedback command

2017-12-07 Thread Leo Liu
VCE processing IBs starts from session and task info at first level, other commands processed subsequently. The task info for destroy is embedded to destroy command, resulting that feedback command is not properly procoessed. This is causing kernel spin VM fault messages on Polaris and Vega10 card

Re: [Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

2017-12-07 Thread Eric Engestrom
On Thursday, 2017-12-07 09:16:24 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-12-07 04:17:58) > > On Tuesday, 2017-12-05 09:40:53 -0800, Dylan Baker wrote: > > > Signed-off-by: Dylan Baker > > > --- > > > meson.build | 6 +++--- > > > 1 file changed, 3

[Mesa-dev] [PATCH 2/2] gallium/u_blitter: replace tabs with spaces

2017-12-07 Thread Brian Paul
--- src/gallium/auxiliary/util/u_blitter.c | 36 +- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 2a2fd17..5e8800e 100644 ---

[Mesa-dev] [PATCH 1/2] gallium/u_blitter: enable MSAA when blitting to MSAA surfaces

2017-12-07 Thread Brian Paul
If we're doing a Z -> Z MSAA blit (for example) we need to enable msaa rasterization when drawing the quads so that we can properly write the per-sample values. This fixes a number of Piglit ext_framebuffer_multisample blit tests such as ext_framebuffer_multisample/no-color 2 depth combined with

Re: [Mesa-dev] [PATCH mesa] meson: add dep_thread to every lib that includes threads.h

2017-12-07 Thread Dylan Baker
Quoting Emil Velikov (2017-12-07 08:40:27) > On 7 December 2017 at 14:51, Eric Engestrom wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104141 > > Signed-off-by: Eric Engestrom > > --- > > src/broadcom/meson.build

Re: [Mesa-dev] [PATCH mesa] meson: add dep_thread to every lib that includes threads.h

2017-12-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-12-07 06:51:41) > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104141 > Signed-off-by: Eric Engestrom > --- > src/broadcom/meson.build| 2 +- >

Re: [Mesa-dev] [PATCH mesa 1/6] meson: dedup gallium-vdpau logic

2017-12-07 Thread Eric Engestrom
On Thursday, 2017-12-07 09:29:26 -0800, Dylan Baker wrote: > I didn't look at these super closely after the vdpau one, but we use this > logic > elsewhere in the meson build, > > For the series, > Reviewed-by: Dylan Baker Thanks; I've actually found a few more bits of code

Re: [Mesa-dev] [PATCH v2] mesa/spirv: move and rename nir_spirv_supported_capabilities

2017-12-07 Thread Jason Ekstrand
On Thu, Dec 7, 2017 at 12:38 AM, Alejandro Piñeiro wrote: > To avoid any vulkan driver to include the GL mtypes.h. Renamed as > eventually this could be used by drivers not using nir. > > v2: remove compiler/spirv/spirv.h from mtypes (Alejandro) > --- > > The include on v1

[Mesa-dev] [PATCH 2/8] spirv: Add a prepass to set types on vtn_values

2017-12-07 Thread Jason Ekstrand
This autogenerated pass will automatically find and set the type field on all vtn_values. This way we always have the type and can use it for validation and other checks. --- src/compiler/Makefile.nir.am | 4 + src/compiler/nir/meson.build | 11 ++-

[Mesa-dev] [PATCH 1/8] spirv: Add a vtn_type field to all vtn_values

2017-12-07 Thread Jason Ekstrand
At the moment, this just lets us drop the const_type for constants and unify things a bit. Eventually, we will use this to store the types of all SPIR-V SSA values. --- src/compiler/spirv/spirv_to_nir.c | 63 +-- src/compiler/spirv/vtn_private.h | 7 ++--- 2

[Mesa-dev] [PATCH 0/8] spirv: Types, types, and OpSwitch

2017-12-07 Thread Jason Ekstrand
When I started working on switching spirv_to_nir from having piles of assert() to vtn_assert/fail, Ian and I both agreed that we should start moving in a direction where we had vtn_fail with reasonable error messages rather than vtn_assert() with some compiler-internal garbage message. However

[Mesa-dev] [PATCH 8/8] spirv: Add support for all bit sizes in OpSwitch

2017-12-07 Thread Jason Ekstrand
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101560 Cc: Juan A. Suarez Romero --- src/compiler/spirv/vtn_cfg.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/src/compiler/spirv/vtn_cfg.c

[Mesa-dev] [PATCH 4/8] spirv: Set lengths on scalar and vector types

2017-12-07 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index a2426bc..253a012 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -887,6 +887,7 @@

[Mesa-dev] [PATCH v3] mesa/spirv: move and rename nir_spirv_supported_capabilities

2017-12-07 Thread Alejandro Piñeiro
To avoid any vulkan driver to include the GL mtypes.h. Renamed as eventually this could be used by drivers not using nir. v2: remove compiler/spirv/spirv.h from mtypes (Alejandro) v3: added the definition at compiler/shader_info.h (Jason Ekstrand) --- Sorry for not realizing that spirv.h was a

[Mesa-dev] [PATCH 3/8] spirv: Add basic type validation for OpLoad, OpStore, and OpCopyMemory

2017-12-07 Thread Jason Ekstrand
--- src/compiler/spirv/vtn_variables.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index cf44ed3..8ce19ff 100644 --- a/src/compiler/spirv/vtn_variables.c +++

[Mesa-dev] [PATCH 6/8] spirv: Add better parameter validation for vector and matrix types

2017-12-07 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 11c8c2a..4b93b11 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++

[Mesa-dev] [PATCH 7/8] spirv: Restructure the case loop in OpSwitch handling

2017-12-07 Thread Jason Ekstrand
Instead of calling vtn_add_case for the default case and then looping, add an is_default variable and do everything inside the loop. This will make the next commit easier. --- src/compiler/spirv/vtn_cfg.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 5/8] spirv: Add type validation for OpSelect

2017-12-07 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 32 1 file changed, 32 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 253a012..11c8c2a 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++

[Mesa-dev] [PATCH 06/10] dri/common: move the required GLX_* token definitions locally

2017-12-07 Thread Emil Velikov
From: Emil Velikov Will allow us to remove even bigger hack elsewhere. But more importantly, we should not be using _any_ GLX tokens in DRI. Document the gory details about the current side-effects. Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 03/10] mapi: remove duplicate GL typedefs

2017-12-07 Thread Emil Velikov
From: Emil Velikov Remove the instances already available in gl.h or glext.h. Sadly GLclampx is only available in GLES(1) so we need to keep that one. Signed-off-by: Emil Velikov --- src/mapi/glapi/glapi_priv.h | 7 --- 1 file

[Mesa-dev] [PATCH 08/10] i965: reference __DRI_ATTRIB_SWAP_COPY token over the GLX one

2017-12-07 Thread Emil Velikov
From: Emil Velikov Earlier commit updated the code to use the DRI tokens, yet forgot to update the comment. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 09/10] mesa: remove duplicate declarations from glheader.h

2017-12-07 Thread Emil Velikov
From: Emil Velikov Remove all the desktop GL and GLX entries from the list. Former are pulled by the gl.h and glext.h includes at the top while the latter are not longer needed. Signed-off-by: Emil Velikov --- src/mesa/main/glheader.h |

[Mesa-dev] [PATCH 10/10] mesa: reorder and document the tokens in glheader.h

2017-12-07 Thread Emil Velikov
From: Emil Velikov Split into different sections, document each one as well as strange cases like GL_ATI_texture_compression_3dc. Signed-off-by: Emil Velikov --- src/mesa/main/glheader.h | 39 +++ 1

[Mesa-dev] [PATCH 07/10] i915: reference __DRI_ATTRIB_SWAP_COPY token over the GLX one

2017-12-07 Thread Emil Velikov
From: Emil Velikov Earlier commit updated the code to use the DRI tokens, yet forgot to update the comment. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 05/10] dri/common: use __DRI_ATTRIB_SWAP* instances when describing db_modes

2017-12-07 Thread Emil Velikov
From: Emil Velikov Somewhat recently Thomas Hellstrom added the respective DRI tokens and updated the drivers. Update the documentation to match reality. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/common/utils.c | 11

Re: [Mesa-dev] [PATCH mesa 1/6] meson: dedup gallium-vdpau logic

2017-12-07 Thread Dylan Baker
I didn't look at these super closely after the vdpau one, but we use this logic elsewhere in the meson build, For the series, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-12-07 08:52:17) > Signed-off-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH v3] mesa/spirv: move and rename nir_spirv_supported_capabilities

2017-12-07 Thread Jason Ekstrand
Thanks! Reviewed-by: Jason Ekstrand On Thu, Dec 7, 2017 at 8:12 AM, Alejandro Piñeiro wrote: > To avoid any vulkan driver to include the GL mtypes.h. Renamed as > eventually this could be used by drivers not using nir. > > v2: remove

[Mesa-dev] [PATCH mesa 4/6] meson: dedup gallium-va logic

2017-12-07 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/meson.build b/meson.build index 1917b474b1ff4505651a..5a957ad13d1b39b5f709 100644 --- a/meson.build +++

[Mesa-dev] [PATCH mesa 5/6] meson: dedup gallium-xa logic

2017-12-07 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/meson.build b/meson.build index 5a957ad13d1b39b5f709..04e2fdd19d7274aa5ecf 100644 --- a/meson.build +++ b/meson.build @@

[Mesa-dev] [PATCH mesa 6/6] meson: simplify dri3 logic

2017-12-07 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 04e2fdd19d7274aa5ecf..1ab790462daeef8b56e0 100644 --- a/meson.build +++ b/meson.build @@ -344,15 +344,9 @@ endif

[Mesa-dev] [PATCH mesa 3/6] meson: dedup gallium-omx logic

2017-12-07 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/meson.build b/meson.build index 08c9c4b92313e97f0eb1..1917b474b1ff4505651a 100644 --- a/meson.build +++

[Mesa-dev] [PATCH mesa 2/6] meson: dedup gallium-xvmc logic

2017-12-07 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/meson.build b/meson.build index d8f317e1aaf350c26687..08c9c4b92313e97f0eb1 100644 --- a/meson.build +++

[Mesa-dev] [PATCH mesa 1/6] meson: dedup gallium-vdpau logic

2017-12-07 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 45 + 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/meson.build b/meson.build index 1ea63fb12915c93a67d5..d8f317e1aaf350c26687 100644 --- a/meson.build +++

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Rewrite assign_constant_locations

2017-12-07 Thread Pohjolainen, Topi
On Wed, Dec 06, 2017 at 08:34:19PM -0800, Jason Ekstrand wrote: > This rewires the logic for assigning uniform locations to work in terms > of "complex alignments". The basic idea is that, as we walk the list of > instructions, we keep track of the alignment and continuity requirements > of each

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Rewrite assign_constant_locations

2017-12-07 Thread Jason Ekstrand
On Thu, Dec 7, 2017 at 9:10 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Dec 06, 2017 at 08:34:19PM -0800, Jason Ekstrand wrote: > > This rewires the logic for assigning uniform locations to work in terms > > of "complex alignments". The basic idea is that, as we walk the

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Rewrite assign_constant_locations

2017-12-07 Thread Pohjolainen, Topi
On Thu, Dec 07, 2017 at 09:25:08AM -0800, Jason Ekstrand wrote: > On Thu, Dec 7, 2017 at 9:10 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Wed, Dec 06, 2017 at 08:34:19PM -0800, Jason Ekstrand wrote: > > > This rewires the logic for assigning uniform locations to work in

Re: [Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

2017-12-07 Thread Dylan Baker
Quoting Eric Engestrom (2017-12-07 09:37:47) > On Thursday, 2017-12-07 09:16:24 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-12-07 04:17:58) > > > On Tuesday, 2017-12-05 09:40:53 -0800, Dylan Baker wrote: > > > > Signed-off-by: Dylan Baker > > > > --- > > >

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-07 Thread Matt Turner
On Tue, Dec 5, 2017 at 3:40 PM, Jordan Justen wrote: > On 2017-12-05 14:49:28, Mark Janes wrote: >> Jordan Justen writes: >> >> > On 2017-12-05 09:13:11, Mark Janes wrote: >> >> Jordan Justen writes: >> >> >> >> >

Re: [Mesa-dev] [PATCH] meson: Add lmsensors to gallium libgl-xlib target.

2017-12-07 Thread Eric Engestrom
On Thursday, 2017-12-07 09:32:39 -0800, Dylan Baker wrote: > I don't suppose someone would like to ack this? > > Quoting Dylan Baker (2017-12-04 14:05:12) > > Fixes: 5e71efef44b992b5d70b ("meson: Add lmsensors support") > > Signed-off-by: Dylan Baker > > --- > >

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Implement GRF bank conflict mitigation pass.

2017-12-07 Thread Matt Turner
On Thu, Jun 22, 2017 at 12:20 PM, Francisco Jerez wrote: > Unnecessary GRF bank conflicts increase the issue time of ternary > instructions (the overwhelmingly most common of which is MAD) by > roughly 50%, leading to reduced ALU throughput. This pass attempts to >

Re: [Mesa-dev] [PATCH] radeon/vce: move destroy command before feedback command

2017-12-07 Thread Christian König
Am 07.12.2017 um 18:37 schrieb Leo Liu: VCE processing IBs starts from session and task info at first level, other commands processed subsequently. The task info for destroy is embedded to destroy command, resulting that feedback command is not properly procoessed. This is causing kernel spin VM

Re: [Mesa-dev] [PATCH] meson: Add lmsensors to gallium libgl-xlib target.

2017-12-07 Thread Dylan Baker
Quoting Eric Engestrom (2017-12-07 09:49:30) > On Thursday, 2017-12-07 09:32:39 -0800, Dylan Baker wrote: > > I don't suppose someone would like to ack this? > > > > Quoting Dylan Baker (2017-12-04 14:05:12) > > > Fixes: 5e71efef44b992b5d70b ("meson: Add lmsensors support") > > > Signed-off-by:

Re: [Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

2017-12-07 Thread Dylan Baker
Quoting Eric Engestrom (2017-12-07 10:13:27) > On Thursday, 2017-12-07 09:57:19 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-12-07 09:37:47) > > > On Thursday, 2017-12-07 09:16:24 -0800, Dylan Baker wrote: > > > > Quoting Eric Engestrom (2017-12-07 04:17:58) > > > > > On Tuesday,

Re: [Mesa-dev] [PATCH] meson: Fix building gallium media targets with gallium-xlib glx

2017-12-07 Thread Eric Engestrom
On Thursday, 2017-12-07 09:57:19 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-12-07 09:37:47) > > On Thursday, 2017-12-07 09:16:24 -0800, Dylan Baker wrote: > > > Quoting Eric Engestrom (2017-12-07 04:17:58) > > > > On Tuesday, 2017-12-05 09:40:53 -0800, Dylan Baker wrote: > > > > >

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Implement GRF bank conflict mitigation pass.

2017-12-07 Thread Matt Turner
On Wed, Dec 6, 2017 at 12:38 PM, Francisco Jerez wrote: > This series (which is ready for production and improves the cycle count > of over 46k shaders) has been sitting here for nearly half a year. I'm > planning to self-review it and land it (along with PATCH 3/2 I just

Re: [Mesa-dev] [PATCH] meson: Add lmsensors to gallium libgl-xlib target.

2017-12-07 Thread Eric Engestrom
On Thursday, 2017-12-07 10:16:01 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-12-07 09:49:30) > > On Thursday, 2017-12-07 09:32:39 -0800, Dylan Baker wrote: > > > I don't suppose someone would like to ack this? > > > > > > Quoting Dylan Baker (2017-12-04 14:05:12) > > > > Fixes:

Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

2017-12-07 Thread Emil Velikov
Hi Harish, On 7 December 2017 at 13:34, Harish Krupo wrote: > From android cts 8.0_r4, a new test case checks if all the required egl > extensions are exposed. In the current implementation we expose KHR_image > if KHR_image_base and KHR_image_pixmap are supported but

Re: [Mesa-dev] [PATCH 1/9] i965/fs: Rewrite assign_constant_locations

2017-12-07 Thread Jason Ekstrand
On Thu, Dec 7, 2017 at 9:57 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Thu, Dec 07, 2017 at 09:25:08AM -0800, Jason Ekstrand wrote: > > On Thu, Dec 7, 2017 at 9:10 AM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Wed, Dec 06, 2017 at 08:34:19PM

  1   2   >