Re: [Mesa-dev] [PATCH 1/2] ac/nir: set the DA field when performing atomics on 3D images

On 02/21/2018 09:24 AM, Timothy Arceri wrote: On 21/02/18 19:22, Samuel Pitoiset wrote: On 02/21/2018 05:11 AM, Timothy Arceri wrote: On 21/02/18 07:29, Samuel Pitoiset wrote: On VI, 3D images are considered as 2D arrays. RadeonSI sets DA for loads/stores/atomics and RADV only for

Re: [Mesa-dev] [PATCH 1/2] ac/nir: set the DA field when performing atomics on 3D images

On 02/21/2018 05:11 AM, Timothy Arceri wrote: On 21/02/18 07:29, Samuel Pitoiset wrote: On VI, 3D images are considered as 2D arrays. RadeonSI sets DA for loads/stores/atomics and RADV only for loads/stores, so I guess there is a reason for that? I've changed the nir->llvm code recently in

[Mesa-dev] [PATCH v4] anv/blorp: multisample resolve all attachment layers

We were only resolving the first. v2: - Do not require that the number of layers on dst and src are an exact match, it is okay if the dst has more layers so long as it has at least the same that we are going to resolve. - Do not always resolve array_len layers, we should resolve

Re: [Mesa-dev] [PATCH 1/2] ac/nir: set the DA field when performing atomics on 3D images

On 21/02/18 19:22, Samuel Pitoiset wrote: On 02/21/2018 05:11 AM, Timothy Arceri wrote: On 21/02/18 07:29, Samuel Pitoiset wrote: On VI, 3D images are considered as 2D arrays. RadeonSI sets DA for loads/stores/atomics and RADV only for loads/stores, so I guess there is a reason for that?

[Mesa-dev] [PATCH v11 02/15] vulkan/wsi: Add drm_modifier member to wsi_image

Not yet used anywhere. Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/vulkan/Makefile.am | 1 + src/vulkan/wsi/meson.build | 2 +- src/vulkan/wsi/wsi_common.c | 3 +++

[Mesa-dev] [PATCH v11 14/15] egl/x11: Support DRI3 v1.1

From: Louis-Francis Ratté-Boulianne Add support for DRI3 v1.1, which allows pixmaps to be backed by multi-planar buffers, or those with format modifiers. This is both for allocating render buffers, as well as EGLImage imports from a native pixmap (EGL_NATIVE_PIXMAP_KHR).

[Mesa-dev] [PATCH v11 10/15] vulkan/wsi/x11: Add support for DRI3 v1.1

Adds support for multiple planes and buffer modifiers. v4: Rename "has_dri3_v1_1" to "has_dri3_modifiers" Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 185 1 file changed, 168 insertions(+), 17 deletions(-)

[Mesa-dev] [PATCH v11 15/15] egl/x11: Re-allocate buffers if format is suboptimal

From: Louis-Francis Ratté-Boulianne If PresentCompleteNotify event says the pixmap was presented with mode PresentCompleteModeSuboptimalCopy, it means the pixmap could possibly have been flipped instead if allocated with a different format/modifier. Signed-off-by:

[Mesa-dev] [PATCH v11 06/15] vulkan/wsi/wayland: Add support for zwp_dmabuf

zwp_linux_dmabuf_v1 lets us use multi-planar images and buffer modifiers. Signed-off-by: Daniel Stone --- src/vulkan/Makefile.am | 10 +++ src/vulkan/Makefile.sources | 4 +- src/vulkan/wsi/meson.build | 2 +

[Mesa-dev] [PATCH v11 03/15] vulkan/wsi: Add modifiers support to wsi_create_native_image

From: Jason Ekstrand This involves extending our fake extension a bit to allow for additional querying and passing of modifier information. The added bits are intended to look a lot like the draft of VK_EXT_image_drm_format_modifier. Once the extension gets finalized,

[Mesa-dev] [PATCH v11 11/15] vulkan/wsi/x11: Return VK_SUBOPTIMAL_KHR for X11

From: Louis-Francis Ratté-Boulianne When it is detected that a window could have been flipped but has been copied because of suboptimal format/modifier. The Vulkan client should then re-create the swapchain. Signed-off-by: Louis-Francis Ratté-Boulianne

[Mesa-dev] [PATCH v11 05/15] anv/image: Add support for modifiers for WSI

From: Jason Ekstrand This adds support for the modifiers portion of the WSI "extension". Reviewed-by: Daniel Stone Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_formats.c | 38

[Mesa-dev] [PATCH v11 04/15] anv/image: Separate modifiers from legacy scanout

From: Jason Ekstrand For a bit there, we had a bug in i965 where it ignored the tiling of the modifier and used the one from the BO instead. At one point, we though this was best fixed by setting a tiling from Vulkan. However, we've decided that i965 was just doing

[Mesa-dev] [PATCH v11 08/15] vulkan/wsi/x11: Consistently update swapchain status

Use a helper function for updating the swapchain status. This will be used later to handle VK_SUBOPTIMAL_KHR, where we need to make a non-error status stick to the swapchain until recreation. Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 90

[Mesa-dev] [PATCH v11 07/15] vulkan/wsi/x11: Expand set of swapchain statuses

Instead of direct comparisons to VK_SUCCESS, test for negative numbers meaning an error status, and positive numbers indicating non-error statuses. Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 16 1 file changed, 8 insertions(+), 8

[Mesa-dev] [PATCH v11 00/15] Modifiers for X11 EGL/Vulkan, WL/VK

Hi, This series adds support for buffer modifiers through ANV and the common WSI infrastructure (AMD has no defined modifiers), as well as specifically for X11 and Wayland. It also adds support for the X11 DRI3 v1.1 and Present v1.2 protocols to EGL and GLX, which does not require changes to the

Re: [Mesa-dev] [PATCH 1/2] radv: remove one invalid case in radv_tex_dim()

On 02/21/2018 03:37 PM, Józef Kucia wrote: On Wed, Feb 21, 2018 at 3:27 PM, Samuel Pitoiset wrote: According to "Table 1. Image and image view parameter compatibility requirements", this is invalid. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH] etnaviv: npot_tex_any_wrap needs one bit only

Am Dienstag, den 20.02.2018, 20:47 +0100 schrieb Christian Gmeiner: > Reduces size of struct etna_specs from 100 to 94 bytes. > > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- >  

Re: [Mesa-dev] [PATCH 0/6] i965: Fix TFP for CCS modifiers

Hi Jason, On 24 January 2018 at 23:46, Jason Ekstrand wrote: > This patch series provides fixes for the texture_from_pixmap path when > modifiers are used. All but the first and last patches are reviewed. I > haven't pushed to land anything yet because ee57b15ec764736e

Re: [Mesa-dev] [PATCH] nir: lower fexp2(fmul(flog2(a), 2)) to fmul(a, a)

Reviewed-by: Bas Nieuwenhuizen On Wed, Feb 7, 2018 at 10:29 AM, Samuel Pitoiset wrote: > > > On 02/06/2018 12:29 AM, Ian Romanick wrote: > >> Do you have any data from shader-db for this change (and the other patch)? >> > > We didn't see any

Re: [Mesa-dev] [PATCH] radv: enable lowering of fpow to fexp2 and flog2

Reviewed-by: Bas Nieuwenhuizen On Fri, Feb 2, 2018 at 7:04 PM, Samuel Pitoiset wrote: > There is no fpow in hardware, so it's always lowered somewhere, > but it appears that lowering at NIR level is better. Figured while > comparing compute

[Mesa-dev] [PATCH v3 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

When multiview is active a subpass clear may only clear a subset of the attachment layers. Other subpasses in the same render pass may also clear too and we want to honor those clears as well, however, we need to ensure that we only clear a layer once, on the first subpass that uses a particular

[Mesa-dev] [PATCH v3 2/2] anv/cmd_buffer: honor pending clear views for depth/stencil attachments

v2: - rebased on top of subpass rework. --- src/intel/vulkan/genX_cmd_buffer.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index a9e5b2e78c..010b52c10a 100644 ---

Re: [Mesa-dev] [PATCH 03/17] intel: Disable 64-bit extensions on platforms without 64-bit types

On Tue, 2018-02-20 at 21:15 -0800, Matt Turner wrote: > Gen11 does not support DF, Q, UQ types in hardware. As a result, we > have > to disable some GL extensions until they can be reimplemented. > --- > src/intel/common/gen_device_info.c | 3 +++ > src/intel/common/gen_device_info.h

Re: [Mesa-dev] [PATCH] nir: remove old assert

Reviewed-by: Iago Toral Quiroga On Wed, 2018-02-21 at 14:42 +1100, Timothy Arceri wrote: > This was originally intended to make sure the remap location > was not -1. However the code has changed alot since then, > the location is now never set to -1 and we also handle >

Re: [Mesa-dev] [PATCH v11 12/15] x11/dri3: Don't open-code ARRAY_SIZE

On Wednesday, 2018-02-21 14:05:56 +, Daniel Stone wrote: > Signed-off-by: Daniel Stone > --- > src/loader/loader_dri3_helper.c | 5 +++-- > src/loader/meson.build | 2 +- Assuming automake already has the right include path, Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Properly handle cases where screen creation fails

> > Something doesn't look quite right - it seems that xmesa_init_display > should be fixed instead. > > Currently it returns non-NULL when either of the following fail: > - driver.create_pipe_screen() > - CALLOC_STRUCT > > I would add an explicit check after those + goto err_path. > The latter

[Mesa-dev] [PATCH v11 01/15] vulkan/wsi: Add multiple planes to wsi_image

Not currently used. Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/vulkan/wsi/wsi_common.c | 20 src/vulkan/wsi/wsi_common_private.h | 9 + src/vulkan/wsi/wsi_common_wayland.c | 11 +++

[Mesa-dev] [PATCH v11 13/15] x11/dri3: Store raw present completion mode

The DRI3 drawable info struct currently stores a boolean for whether the last completed operation was a flip or not. As we need to track the full completion mode for handling suboptimal returns, change the 'flipping' field to the raw present completion mode from the server. Signed-off-by: Daniel

[Mesa-dev] [PATCH v11 09/15] vulkan/wsi/x11: Cleanly handle shutdowns in FIFO thread

The FIFO thread signals shutdown by pushing UINT32_MAX into the acquire queue, and shutdown is signaled to it by pushing UINT32_MAX into the present queue. Explicitly catch a push of UINT32_MAX in either direction and treat this as error. Signed-off-by: Daniel Stone ---

[Mesa-dev] [PATCH v11 12/15] x11/dri3: Don't open-code ARRAY_SIZE

Signed-off-by: Daniel Stone --- src/loader/loader_dri3_helper.c | 5 +++-- src/loader/meson.build | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index

[Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

This fixes a segfault exposed by a29d63ecf7 which occurs when swr is used on an unsupported architecture. Signed-off-by: Chuck Atkins Cc: mesa-sta...@lists.freedesktop.org Cc: George Kyriazis Cc: Bruce Cherniak ---

[Mesa-dev] [PATCH 1/2] radv: remove one invalid case in radv_tex_dim()

According to "Table 1. Image and image view parameter compatibility requirements", this is invalid. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_image.c

[Mesa-dev] [PATCH 2/2] ac/nir: clean up a hack about rounding 2nd coord component

It's basically just the opposite, and it only makes sense to round the layer for 2D texture arrays. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Properly handle cases where screen creation fails

Sorry for the repeat, I was adding the Intel devs to the CC list since it's related to swr -Chuck On Wed, Feb 21, 2018 at 9:26 AM, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > >

Re: [Mesa-dev] [PATCH 1/2] radv: remove one invalid case in radv_tex_dim()

On Wed, Feb 21, 2018 at 3:27 PM, Samuel Pitoiset wrote: > According to "Table 1. Image and image view parameter compatibility > requirements", this is invalid. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c | 5 +

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

On Wednesday, 2018-02-21 09:26:34 -0500, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > Signed-off-by: Chuck Atkins > Cc: mesa-sta...@lists.freedesktop.org > Cc: George Kyriazis

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Properly handle cases where screen creation fails

On 21 February 2018 at 14:26, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > Signed-off-by: Chuck Atkins > Cc: mesa-sta...@lists.freedesktop.org > Cc: George

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Properly handle cases where screen creation fails

On 21 February 2018 at 14:41, Emil Velikov wrote: > On 21 February 2018 at 14:26, Chuck Atkins wrote: >> This fixes a segfault exposed by a29d63ecf7 which occurs when swr is >> used on an unsupported architecture. >> >> Signed-off-by: Chuck

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

> > - if (xmdpy->smapi->destroy) > > - xmdpy->smapi->destroy(xmdpy->smapi); > > - free(xmdpy->smapi); > > + if (xmdpy->smapi) > > + { > > + if (xmdpy->smapi->destroy) > > + xmdpy->smapi->destroy(xmdpy->smapi); > > + free(xmdpy->smapi); > > + } > > I don't know this

Re: [Mesa-dev] [PATCH v11 13/15] x11/dri3: Store raw present completion mode

On Wednesday, 2018-02-21 14:05:57 +, Daniel Stone wrote: > The DRI3 drawable info struct currently stores a boolean for whether the > last completed operation was a flip or not. As we need to track the full > completion mode for handling suboptimal returns, change the 'flipping' > field to the

[Mesa-dev] [AppVeyor] mesa master #6986 completed

Build mesa 6986 completed Commit c7e22483fe by Daniel Stone on 2/20/2018 8:56 PM: vulkan/wsi/x11: Consistently update and return swapchain status\n\nUse a helper function for updating the swapchain status. This will be\nused later to handle VK_SUBOPTIMAL_KHR,

Re: [Mesa-dev] [PATCH 01/17] intel: Add a preliminary device for Ice Lake

On Wed, Feb 21, 2018 at 11:04 AM, Matt Turner wrote: > On Wed, Feb 21, 2018 at 10:37 AM, Anuj Phogat wrote: >> On Wed, Feb 21, 2018 at 9:22 AM, Rafael Antognolli >> wrote: >>> My understanding is that this commit is enough

[Mesa-dev] [PATCH v3 16/21] clover: Implement clCreateProgramWithILKHR

Signed-off-by: Pierre Moreau --- Notes: v3: * Remove the const on the length argument to CreateProgramWithILKHR (Francisco Jerez); * Capitalize comment (Francisco Jerez); * Store the IL as a std::vector instead of a pointer + size (Francisco Jerez);

[Mesa-dev] [PATCH v3 19/21] clover: Advertise cl_khr_il_program

Signed-off-by: Pierre Moreau --- Notes: v3: Advertise cl_khr_il_program if if the device support NATIVE as IR src/gallium/state_trackers/clover/api/platform.cpp | 2 ++ src/gallium/state_trackers/clover/core/device.cpp | 4 +++- 2 files changed, 5 insertions(+), 1

[Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

Signed-off-by: Pierre Moreau --- Notes: v3: * Bump the required version of SPIRV-Tools to the latest release; * Add a dependency on llvm-spirv. configure.ac | 10 ++ meson.build | 4 2 files changed, 14 insertions(+) diff --git a/configure.ac

[Mesa-dev] [PATCH v3 17/21] clover: Handle CL_PROGRAM_IL_KHR in clGetProgramInfo

Signed-off-by: Pierre Moreau --- Notes: v3: Switch from using a pointer attribute to a vector (Francisco Jerez) src/gallium/state_trackers/clover/api/program.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH v3 21/21] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 3 +-- src/gallium/state_trackers/clover/api/program.cpp | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp

[Mesa-dev] [PATCH v3 20/21] clover: Implement clCreateProgramWithIL from OpenCL 2.1

Signed-off-by: Pierre Moreau --- Notes: v3: Remove the const from the length argument of clCreateProgramWithIL src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 8 2 files changed, 9

[Mesa-dev] [AppVeyor] mesa master #6985 failed

Build mesa 6985 failed Commit cdeac00267 by Timothy Arceri on 2/21/2018 3:36 AM: nir: remove old assert\n\nThis was originally intended to make sure the remap location\nwas not -1. However the code has changed alot since then,\nthe location is now never set to

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-22 10:57 GMT+10:00 Dieter Nützel : > Making all in vulkan > make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten > make[3]: *** Keine Regel vorhanden, um das Ziel > „/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml“, > benötigt von

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

Am 22.02.2018 02:35, schrieb Dave Airlie: 2018-02-22 10:57 GMT+10:00 Dieter Nützel : Making all in vulkan make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten make[3]: *** Keine Regel vorhanden, um das Ziel „/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml“,

Re: [Mesa-dev] [PATCH] glsl: Parse 'layout' as a token with advanced blending or bindless

On Tue, Feb 20, 2018 at 6:28 AM, Kenneth Graunke wrote: > Both KHR_blend_equation_advanced and ARB_bindless_texture provide > layout qualifiers, and are exposed in compatibility contexts. We > need to parse the layout qualifier as a token in order for those > to work, but

[Mesa-dev] [PATCH v3 02/21] clover: update ICD table to support everything up to 2.2

From: Karol Herbst v2: add more prototypes Signed-off-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/dispatch.cpp | 29 +++- src/gallium/state_trackers/clover/api/dispatch.hpp | 190

[Mesa-dev] [PATCH v3 00/21] Introducing SPIR-V support to clover

Hello, This updated series contains some additional fixes to clover, updates to the OpenCL headers shipped with Mesa, the removal of the TGSI backend in clover (as unused), the introduction of a new dependency, llvm-spirv, and some more changes summarised further down. llvm-spirv can be

[Mesa-dev] [PATCH v3 08/21] clover: Disallow creating libraries from other libraries

If creating a library, do not allow non-compiled object in it, as executables are not allowed, and libraries would make it really hard to enforce the "-enable-link-options" flag. Reviewed-by: Francisco Jerez Signed-off-by: Pierre Moreau --- Notes:

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

On 22 February 2018 at 11:58, Dieter Nützel wrote: > Am 22.02.2018 02:35, schrieb Dave Airlie: >> >> 2018-02-22 10:57 GMT+10:00 Dieter Nützel : >>> >>> Making all in vulkan >>> make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten >>> make[3]: ***

Re: [Mesa-dev] [PATCH v3 11/21] clover: Move platform extensions definitions to clover/platform.cpp

6 is Acked-By: Aaron Watry 7-11 (regardless of my comment in 9) are Reviewed-By: Aaron Watry --Aaron On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote: > Reviewed-by: Francisco Jerez > Signed-off-by: Pierre

Re: [Mesa-dev] [PATCH 1/6] i965/state: Ignore intel_obj->_Format for depth/stencil and ETC2

On Tue 20 Feb 2018, Jason Ekstrand wrote: > On Mon, Feb 19, 2018 at 10:01 AM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Wed 24 Jan 2018, Jason Ekstrand wrote: > > We're about to start letting the intel_obj->_Format be the "real" > > texture format.  For depth/stencil

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.4 release candidate

Kenneth Graunke writes: > On Thursday, February 8, 2018 8:47:00 PM PST Emil Velikov wrote: >> Rejected (9) >> >> Jason Ekstrand (2): >> e52a9f18d69c94b7cb7f81361cdb9e2582c3d742 i965: Replace >> draw_aux_buffer_disabled with draw_aux_usage >>

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

Making all in vulkan make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten make[3]: *** Keine Regel vorhanden, um das Ziel „/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml“, benötigt von „wsi/linux-dmabuf-unstable-v1-protocol.c“, zu erstellen. Schluss. make[3]: Verzeichnis

Re: [Mesa-dev] [PATCH v3 09/21] clover: Track flags per module section

On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote: > One flag that needs to be tracked is whether a library is allowed to > received mathematics optimisations or not, as the authorisation is given > when creating the library while the optimisations are specified when >

Re: [Mesa-dev] [PATCH v4] anv/blorp: multisample resolve all attachment layers

On Wed, 2018-02-21 at 09:58 -0800, Nanley Chery wrote: > On Wed, Feb 21, 2018 at 09:18:49AM +0100, Iago Toral Quiroga wrote: > > We were only resolving the first. > > > > v2: > > - Do not require that the number of layers on dst and src are an > > exact match, it is okay if the dst has more

Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

On 30/01/18 01:24, Roland Scheidegger wrote: > Am 29.01.2018 um 17:03 schrieb Alejandro Piñeiro: >> On 29/01/18 16:38, Roland Scheidegger wrote: >>> Am 29.01.2018 um 09:09 schrieb Alejandro Piñeiro: On 27/01/18 12:09, Roland Scheidegger wrote: > Am 27.01.2018 um 09:52 schrieb Alejandro

Re: [Mesa-dev] [PATCH v11 14/15] egl/x11: Support DRI3 v1.1

On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > Add support for DRI3 v1.1, which allows pixmaps to be backed by > multi-planar buffers, or those with format modifiers. This is both > for allocating render

Re: [Mesa-dev] [PATCH v11 00/15] Modifiers for X11 EGL/Vulkan, WL/VK

Assuming you're ok with the squash-in and modifications in my branch, the whole lot is Reviewed-by: Jason Ekstrand except, of course, for the ones written by me. Let's make this happen! --Jason On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone wrote:

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov wrote: > On 21 February 2018 at 18:50, Rob Herring wrote: >> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov >> wrote: >>> Hi all, >>> >>> Pardon for dropping in late. I think

Re: [Mesa-dev] [PATCH 6/6] intel/isl: Improve the documentation on get_default_aux_state

On Wed 24 Jan 2018, Jason Ekstrand wrote: > Cc: Chad Versace > --- > src/intel/isl/isl.h | 24 > 1 file changed, 20 insertions(+), 4 deletions(-) > > diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h > index e3acb0e..cf53b5a 100644 > ---

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

On Wed 21 Feb 2018, Daniel Vetter wrote: > On Tue, Feb 20, 2018 at 10:14:47PM -0800, Chad Versace wrote: > > On Thu 21 Dec 2017, Daniel Vetter wrote: > > > On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen > > > wrote: > > >> On Wed, Dec 20, 2017 at 12:41 PM, Miguel

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace wrote: > On Thu 21 Dec 2017, Daniel Vetter wrote: >> On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen >> wrote: >>> On Wed, Dec 20, 2017 at 12:41 PM, Miguel Angel Vico >>>

Re: [Mesa-dev] [PATCH v3 05/21] clover/device: Replace usage of "1 << PIPE_SHADER_IR_*" with supports_ir

Patches 1-5: Reviewed-By: Aaron Watry On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/core/device.cpp | 6 +- > 1 file changed, 1 insertion(+), 5

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

https://bugs.freedesktop.org/show_bug.cgi?id=105161 Kenneth Graunke changed: What|Removed |Added Resolution|--- |NOTABUG

[Mesa-dev] [PATCH v3 09/21] clover: Track flags per module section

One flag that needs to be tracked is whether a library is allowed to received mathematics optimisations or not, as the authorisation is given when creating the library while the optimisations are specified when creating the executable. Signed-off-by: Pierre Moreau ---

[Mesa-dev] [PATCH v3 06/21] clover/api: Rework the validation of devices for building

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/program.cpp | 39 +- src/gallium/state_trackers/clover/core/program.cpp | 3 +- 2 files changed, 25 insertions(+), 17 deletions(-) diff --git

[Mesa-dev] [PATCH v3 05/21] clover/device: Replace usage of "1 << PIPE_SHADER_IR_*" with supports_ir

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/core/device.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp index

[Mesa-dev] [PATCH v3 12/21] clover: Remove the TGSI backend as unused

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/Makefile.am | 11 +- src/gallium/state_trackers/clover/Makefile.sources | 4 - src/gallium/state_trackers/clover/core/program.cpp | 15 +-- src/gallium/state_trackers/clover/meson.build | 9

[Mesa-dev] [PATCH v3 03/21] clover/api: Fix tab indentation to spaces

Acked-by: Francisco Jerez Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v3 18/21] clover/api: Implement CL_DEVICE_IL_VERSION_KHR

Signed-off-by: Pierre Moreau --- Notes: v3: Throw an exception if the cl_khr_il_program extension is not supported (Francisco Jerez) src/gallium/state_trackers/clover/api/device.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH v3 11/21] clover: Move platform extensions definitions to clover/platform.cpp

Reviewed-by: Francisco Jerez Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- src/gallium/state_trackers/clover/core/platform.cpp | 5 + src/gallium/state_trackers/clover/core/platform.hpp | 2 ++ 3

[Mesa-dev] [PATCH v3 15/21] include/CL: Add cl_khr_il_program

Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- include/CL/cl_ext.h | 37 + 1 file changed, 37 insertions(+) diff --git a/include/CL/cl_ext.h b/include/CL/cl_ext.h index 5078e8f45f..5ea4968042 100644 ---

[Mesa-dev] [PATCH v3 14/21] clover/llvm: Allow translating from SPIR-V to LLVM IR

Signed-off-by: Pierre Moreau --- .../state_trackers/clover/llvm/invocation.cpp | 26 ++ .../state_trackers/clover/llvm/invocation.hpp | 4 src/gallium/state_trackers/clover/meson.build | 2 +- 3 files changed, 31 insertions(+), 1

[Mesa-dev] [PATCH v3 04/21] clover: Add an helper for checking if an IR is supported

Signed-off-by: Pierre Moreau --- Notes: v3: * Dropped supported_irs() (Francisco Jerez) * Changed supports_ir() argument type to `enum pipe_shader_ir` (Francisco Jerez) src/gallium/state_trackers/clover/core/device.cpp | 6 ++

[Mesa-dev] [PATCH v3 10/21] clover: Move device extensions definitions to core/device.cpp

Reviewed-by: Francisco Jerez Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 14 ++

[Mesa-dev] [PATCH v3 07/21] clover/api: Fail if trying to build a non-executable binary

From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram): > If program is created with clCreateProgramWithBinary, then the > program binary must be an executable binary (not a compiled binary or > library). Signed-off-by: Pierre Moreau ---

[Mesa-dev] [PATCH 06/13] vbo: Use _DrawVAO for array type draw commands.

From: Mathias Fröhlich Switch over to use the _DrawVAO for all the array type draws. The _DrawVAO needs to be set before we enter _mesa_update_state, so move setting the draw method in front of the first call to _mesa_update_state which is in turn called from the

[Mesa-dev] [PATCH 07/13] mesa: Add flush_vertices to _mesa_{enable, disable}_vertex_array_attrib.

From: Mathias Fröhlich We will need the flush_vertices argument later in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 18 +++--- src/mesa/main/enable.c | 4 ++--

[Mesa-dev] [PATCH 10/13] vbo: Implement tool functions for vbo specific VAO setup.

From: Mathias Fröhlich Correct VBO_MATERIAL_SHIFT value. The functions will be used next in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_attrib.h | 4 ++-- src/mesa/vbo/vbo_private.h | 53

[Mesa-dev] [PATCH 13/13] vbo: Make use of _DrawVAO from the dlist code.

From: Mathias Fröhlich Finally use an internal VAO to execute display list draws. Avoid duplicate state validation for display list draws. Remove client arrays previously used exclusively for display lists. Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 03/13] vbo: Remove get_vp_mode() and enum vp_mode.

From: Mathias Fröhlich Is now unused. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_private.h | 27 --- 1 file changed, 27 deletions(-) diff --git a/src/mesa/vbo/vbo_private.h b/src/mesa/vbo/vbo_private.h

[Mesa-dev] [PATCH 01/13] mesa: Provide an alternative to get_vp_mode()

From: Mathias Fröhlich To get equivalent information than get_vp_mode(), track the vertex processing mode in a per context variable at gl_vertex_program_state::_VPMode. This aims to replace get_vp_mode() as seen in the vbo module. But instead of the get_vp_mode()

[Mesa-dev] [PATCH 04/13] mesa: Introduce a yet unused _DrawVAO.

From: Mathias Fröhlich During the patch series this VAO gets populated with either the currently bound VAO or an internal VAO that will be used for immediate mode and dlist rendering. v2: More comments about the _DrawVAO, filter and enabled mask. Rename

[Mesa-dev] [PATCH 05/13] vbo: Implement method to track the inputs array.

From: Mathias Fröhlich Provided the _DrawVAO and the derived state that is maintained if we have the _DrawVAO set, implement a method to incrementally update the array of gl_vertex_array input pointers. v2: Add some more comments. Rename _vbo_array_init to

[Mesa-dev] [PATCH] nv50, nvc0: fix integer MS resolves using 2d engine

We don't want filtering for integer textures, same as depth/stencil. Fixes: KHR-GL45.direct_state_access.renderbuffers_storage_multisample Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_blit.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 02/13] vbo: Use _VPMode instead of get_vp_mode().

From: Mathias Fröhlich At those places where we used get_vp_mode() use gl_vertex_program_state::_VPMode instead. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec.c | 4 ++-- src/mesa/vbo/vbo_exec_array.c | 11 ++-

[Mesa-dev] [PATCH 11/13] vbo: Make use of _DrawVAO from immediate mode draw

From: Mathias Fröhlich Finally use an internal VAO to execute immediate mode draws. Avoid duplicate state validation for immediate mode draws. Remove client arrays previously used exclusively for immediate mode draws. Signed-off-by: Mathias Fröhlich

[Mesa-dev] [PATCH 00/13] Switch over to use VAOs for drawing v2.

From: Mathias Fröhlich Hi Brian, Thanks for the review on v1!! The following series moves over to draw via a VAO in all draw paths. At the current stage this introduces an additional indirection for the immediate mode and display list draws. But in the mid term using

[Mesa-dev] [PATCH 09/13] mesa: Add flush_vertices to _mesa_bind_vertex_buffer.

From: Mathias Fröhlich We will need the flush_vertices argument later in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 16 +--- src/mesa/main/bufferobj.c | 2 +- src/mesa/main/varray.c

[Mesa-dev] [PATCH 08/13] mesa: Make _mesa_vertex_attrib_binding public.

From: Mathias Fröhlich Change vertex_attrib_binding() to _mesa_vertex_attrib_binding(), add a flush_vertices argument, and make it publically available. The function will be needed later in the series. Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 12/13] mesa: Use atomics for shared VAO reference counts.

From: Mathias Fröhlich VAOs will be used in the next change as immutable object across multiple contexts. Only reference counting may write concurrently on the VAO. So, make the reference count thread safe for those and only those VAO objects. Signed-off-by: Mathias

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Thu, Feb 22, 2018 at 7:23 AM, Rob Herring wrote: > > On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov > wrote: > > On 21 February 2018 at 18:50, Rob Herring wrote: > >> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov

  1   2   >