Re: [Mesa-dev] [PATCH 03/16] ac/nir: Add vote_ieq/vote_feq lowering pass.

2018-03-10 Thread Timothy Arceri
This causes radeonsi to segfault on the piglit testss e.g. R600_DEBUG=nir /bin/shader_runner tests/spec/arb_shader_group_vote/cs-eq.shader_test -auto -fbo On 08/03/18 01:47, Bas Nieuwenhuizen wrote: The old vote_eq implementation supported only booleans, but now we have to support arbitrary v

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

2018-03-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105171 --- Comment #10 from Clemens Eisserer --- I bisected the regression again, this time with the benchmark mentioned in the post above (JXRenderMark) and I was agin led to the following commit: [ce@localhost mesa]$ git bisect good 8b3a257851905ff4

Re: [Mesa-dev] [PATCH] u_blit: (trivial) u_blit.h needs to include p_defines.h

2018-03-10 Thread Mathias Fröhlich
Hi, Looks like missing the enum: Reviewed-by: Mathias Fröhlich best Mathias On Saturday, 10 March 2018 02:49:16 CET srol...@vmware.com wrote: > From: Roland Scheidegger > > (For the pipe_tex_filter enum) > --- > src/gallium/auxiliary/util/u_blit.h | 1 + > 1 file changed, 1 insertion(+) >

[Mesa-dev] [Bug 105412] [OpenGL] [HD 7790] - VSYNC always ON in all videogames

2018-03-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105412 Michel Dänzer changed: What|Removed |Added Attachment #137954|text/x-log |text/plain mime type|

[Mesa-dev] [Bug 105412] [OpenGL] [HD 7790] - VSYNC always ON in all videogames

2018-03-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105412 --- Comment #6 from Michel Dänzer --- (In reply to Matias N. Goldberg from comment #2) > This could be caused by the Ubuntu's Unity Compositor (Compiz). > You could try forcing VSync off in one of Compiz config/tweak tools. > > It could also be

[Mesa-dev] [PATCH] travis: bump libxcb version to 1.13

2018-03-10 Thread Christian Gmeiner
Fixes following dependency problem: Native dependency xcb-dri3 found: NO found '1.11' but need: '>= 1.13' Signed-off-by: Christian Gmeiner --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index dcd150b482..45c5b80cba 100644 --- a

[Mesa-dev] [PATCH] etnaviv: remove superfluous \n from DBG(..) callers

2018-03-10 Thread Christian Gmeiner
The DBG(..) macro appends a \n already so there is no need to do it twice. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_blt.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_rs.c| 2 +- src/gallium/drivers/etnaviv/etnaviv_screen.c| 6 +++---

[Mesa-dev] [PATCH] etnaviv: add layout string to resource debug output

2018-03-10 Thread Christian Gmeiner
This is quite helpful for debug purposes. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c b/src/gallium/drivers/etnavi

Re: [Mesa-dev] [PATCH] travis: bump libxcb version to 1.13

2018-03-10 Thread Daniel Stone
On 10 March 2018 at 14:53, Christian Gmeiner wrote: > Fixes following dependency problem: > Native dependency xcb-dri3 found: NO found '1.11' but need: '>= 1.13' Oh, oops! Thanks for the catch Christian. Reviewed-by: Daniel Stone Fixes: c80c08e22603 ("vulkan/wsi/x11: Add support for DRI3 v1.2

Re: [Mesa-dev] [PATCH] travis: bump libxcb version to 1.13

2018-03-10 Thread Christian Gmeiner
2018-03-10 16:19 GMT+01:00 Daniel Stone : > On 10 March 2018 at 14:53, Christian Gmeiner > wrote: >> Fixes following dependency problem: >> Native dependency xcb-dri3 found: NO found '1.11' but need: '>= 1.13' > > Oh, oops! Thanks for the catch Christian. > You are welcome - pushed it. > Revie

Re: [Mesa-dev] [PATCH 03/16] ac/nir: Add vote_ieq/vote_feq lowering pass.

2018-03-10 Thread Jason Ekstrand
On Wed, Mar 7, 2018 at 6:47 AM, Bas Nieuwenhuizen wrote: > The old vote_eq implementation supported only booleans, but now > we have to support arbitrary values, so use the read_first_invocation > intrinsic + ballot. > > I took this as an opportunity to figure out how easy it was to do this > in

Re: [Mesa-dev] [PATCH 03/16] ac/nir: Add vote_ieq/vote_feq lowering pass.

2018-03-10 Thread Jason Ekstrand
On Sat, Mar 10, 2018 at 1:55 AM, Timothy Arceri wrote: > This causes radeonsi to segfault on the piglit testss e.g. > I'm pretty sure I see the bug. > R600_DEBUG=nir /bin/shader_runner > tests/spec/arb_shader_group_vote/cs-eq.shader_test > -auto -fbo > > > On 08/03/18 01:47, Bas Nieuwenhuizen

[Mesa-dev] [PATCH 0/2] nir: Move the si vote lowering to common code

2018-03-10 Thread Jason Ekstrand
This tiny series moves the pass that Bas wrote for lowering vote instructions to ballots into common code. As you can see from the diffstat below, it cuts the size of the pass in half by removing boilerplate. The new version (in nir_lower_subgroups) also contains two bugfixes: 1) The old pass w

[Mesa-dev] [PATCH 1/2] nir/subgroups: Add lowering for vote_ieq/vote_feq to a ballot

2018-03-10 Thread Jason Ekstrand
This is based heavily on 97f10934edf8ac, "ac/nir: Add vote_ieq/vote_feq lowering pass." from Bas Nieuwenhuizen. This version is a bit more general since it's in common code. It also properly handles NaN due to not flipping the comparison for floats. --- src/compiler/nir/nir.h |

[Mesa-dev] [PATCH 2/2] ac/nir: Use lower_vote_eq_to_ballot instead of ac_nir_lower_subgroups

2018-03-10 Thread Jason Ekstrand
--- src/amd/Makefile.sources | 1 - src/amd/common/ac_lower_subgroups.c | 92 src/amd/common/ac_nir_to_llvm.c | 3 - src/amd/common/ac_nir_to_llvm.h | 2 - src/amd/common/meson.build | 1 - sr

Re: [Mesa-dev] [PATCH 1/2] nir/subgroups: Add lowering for vote_ieq/vote_feq to a ballot

2018-03-10 Thread Jason Ekstrand
On Sat, Mar 10, 2018 at 10:18 AM, Jason Ekstrand wrote: > This is based heavily on 97f10934edf8ac, "ac/nir: Add vote_ieq/vote_feq > lowering pass." from Bas Nieuwenhuizen. This version is a bit more > general since it's in common code. It also properly handles NaN due to > not flipping the comp

[Mesa-dev] [PATCH v2 1/2] nir/subgroups: Add lowering for vote_ieq/vote_feq to a ballot

2018-03-10 Thread Jason Ekstrand
This is based heavily on 97f10934edf8ac, "ac/nir: Add vote_ieq/vote_feq lowering pass." from Bas Nieuwenhuizen. This version is a bit more general since it's in common code. It also properly handles NaN due to not flipping the comparison for floats. v2 (Jason Ekstrand); - Fixed various little b

Re: [Mesa-dev] [PATCH 0/2] nir: Move the si vote lowering to common code

2018-03-10 Thread Jason Ekstrand
On Sat, Mar 10, 2018 at 10:18 AM, Jason Ekstrand wrote: > This tiny series moves the pass that Bas wrote for lowering vote > instructions to ballots into common code. As you can see from the diffstat > below, it cuts the size of the pass in half by removing boilerplate. The > new version (in ni

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

2018-03-10 Thread Jason Ekstrand
On Wed, Mar 7, 2018 at 4:42 PM, Dylan Baker wrote: > Quoting Jason Ekstrand (2018-03-07 06:34:52) > > The original string map assumed that the mapping from strings to > > entrypoints was a bijection. This will not be true the moment we > > add entrypoint aliasing. This reworks things to be an a

[Mesa-dev] [PATCH 1/2] radv: fix stale comment in generated vk_format_table.c

2018-03-10 Thread Grazvydas Ignotas
It seems to be a leftover from u_format_table.py. --- src/amd/vulkan/vk_format_table.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/vk_format_table.py b/src/amd/vulkan/vk_format_table.py index 36352b1..c33a4ce 100644 --- a/src/amd/vulkan/vk_format_table.py +

[Mesa-dev] [PATCH 2/2] radv: make vk_format_description structures static

2018-03-10 Thread Grazvydas Ignotas
No need to bother the linker about them. --- src/amd/vulkan/vk_format_table.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/vk_format_table.py b/src/amd/vulkan/vk_format_table.py index c33a4ce..cd1af62 100644 --- a/src/amd/vulkan/vk_format_table.py +++ b/src/

[Mesa-dev] [Bug 102571] vulkaninfo fails with "trap divide error"

2018-03-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102571 Sven Arvidsson changed: What|Removed |Added CC||s...@whiz.se --- Comment #4 from Sven

Re: [Mesa-dev] [PATCH] i965: Emit texture cache invalidates around blorp_copy

2018-03-10 Thread Kenneth Graunke
On Friday, March 9, 2018 9:27:36 PM PST Jason Ekstrand wrote: > This is a terrible hack but it fixes CTS regressions. It's still > incredibly unclear exactly what is going wrong in the hardware to cause > this to be an issue so this isn't a good fix by any means. However, it > does fix tests so t

Re: [Mesa-dev] [PATCH 2/2] radv: make vk_format_description structures static

2018-03-10 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Sat, Mar 10, 2018 at 8:28 PM, Grazvydas Ignotas wrote: > No need to bother the linker about them. > --- > src/amd/vulkan/vk_format_table.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/vk_format_table.

Re: [Mesa-dev] [PATCH 1/5] i965: Hard code scratch_ids_per_subslice for Cherryview

2018-03-10 Thread Jordan Justen
On 2018-03-09 09:51:31, Mark Janes wrote: > Could this be the reason that BSW systems never reliably passed all unit > tests? Up to now, we re-execute each failing test, and mark it as a > pass if it succeeds a second time. > > I'd like to remove that crutch if possible. It is possible. We basic