On 10/23/18 8:56 AM, Eduardo Lima Mitev wrote:
There exists _mesa_components_in_format() which already includes
all cases handled in _mesa_base_format_component_count().
I guess the idea here was that one function only covers 'base formats'
and other one all formats. But I guess none of the
On 10/23/2018 08:17 AM, Tapani Pälli wrote:
>
> On 10/23/18 8:56 AM, Eduardo Lima Mitev wrote:
>> There exists _mesa_components_in_format() which already includes
>> all cases handled in _mesa_base_format_component_count().
>
> I guess the idea here was that one function only covers 'base
On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand wrote:
>
> D3D booleans use a 32-bit 0/-1 representation. Because this previously
> matched NIR exactly, we didn't have to really optimize for it. Now that
> we have 1-bit booleans, we need some specific optimizations to chew
> through the
https://bugs.freedesktop.org/show_bug.cgi?id=107765
--- Comment #14 from Samuel Pitoiset ---
Can you try this branch please?
https://cgit.freedesktop.org/~hakzsam/mesa/log/?h=radv_itoi_r32g32b32
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee
https://bugs.freedesktop.org/show_bug.cgi?id=108524
Bug ID: 108524
Summary: [RADV] GPU lockup on event synchronization
Product: Mesa
Version: 18.2
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Cc stable?
On 10/23/18 10:59 AM, Bas Nieuwenhuizen wrote:
Since the CPU can read them we need to execute any GPU->CPU
flushes before the event is written.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108524
Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver"
---
Reviewed-by: Bas Nieuwenhuizen
On Mon, Oct 22, 2018 at 3:41 PM Samuel Pitoiset
wrote:
>
> Fixes: 593996bc02 ("radv: implement buffer to image operations for R32G32B32")
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_meta_bufimage.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
Since the CPU can read them we need to execute any GPU->CPU
flushes before the event is written.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108524
Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver"
---
src/amd/vulkan/radv_cmd_buffer.c | 2 ++
1 file changed, 2
On Mon, 2018-10-22 at 17:13 -0500, Jason Ekstrand wrote:
> This is something that Connor and I have talked about quite a bit
> over the
> last couple of months. The core idea is to replace NIR's current 32-
> bit
> 0/-1 D3D10-style booleans with a 1-bit data type. All in all, I
> think it
>
On Friday, October 19, 2018 3:04:45 PM PDT Marek Olšák wrote:
> On Mon, Oct 15, 2018 at 6:35 PM Kenneth Graunke
> wrote:
>
> > From: Jason Ekstrand
> >
> > They're not required to be the same as the access flag on the image
> > unit. For hardware that does shader image lowering based on the
>
From: Samuel Pitoiset
The linking opts shouldn't try removing or compacting XFB varyings
in the consumer. To avoid this we copy the always_active_io flag
from the producer.
---
src/compiler/nir/nir.h | 1 +
src/compiler/nir/nir_linking_helpers.c | 33 ++
nir_lower_io_to_scalar_early() is really part of the link time
optimisations. Moving it here allows the code to be simplified
and also keeps the code easy to follow in the next patch.
---
src/amd/vulkan/radv_pipeline.c | 44 ++
1 file changed, 18 insertions(+), 26
---
src/amd/vulkan/radv_pipeline.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index 396b44d25a1..c21ca1743a4 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -1792,6 +1792,10 @@
https://bugs.freedesktop.org/show_bug.cgi?id=108524
--- Comment #1 from Bas Nieuwenhuizen ---
I did not see a lockup* but this fixes the data issue:
https://patchwork.freedesktop.org/patch/257901/
*: I got some what looks like the program just trying to dump too much stuff
too the terminal,
Reviewed-by: Samuel Pitoiset
On 10/23/18 10:59 AM, Bas Nieuwenhuizen wrote:
Since the CPU can read them we need to execute any GPU->CPU
flushes before the event is written.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108524
Fixes: f4e499ec791 "radv: add initial non-conformant radv
Suggested-by: Timothy Arceri
Signed-off-by: Eric Engestrom
---
Timothy, I opted to remove them all instead of adding even more, as it
would break again next time something changes (the set_foreach() one was
already broken before my patch for instance) and result in lots of
unnecessary churn for
On 10/23/2018 08:33 AM, Connor Abbott wrote:
> On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand wrote:
>>
>> This should be useful for drivers that don't support real integers.
>>
>> Cc: Alyssa Rosenzweig
>> ---
>> src/compiler/Makefile.sources | 1 +
>>
CC: Emil Velikov
CC: Juan A. Romero Suarez
---
docs/release-calendar.html | 38 +-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/docs/release-calendar.html b/docs/release-calendar.html
index a525c62..6bd4fc0c0e8 100644
---
anv_GetPhysicalDeviceSurfaceSupportKHR will already return success for
this, but anv_GetPhysicalDevice{Xcb,Xlib}PresentationSupportKHR do not.
Apps which check for presentation support via the latter (all Feral
Vulkan games at least) will therefore fail.
This allows me to render on an Intel GPU
The commit message is correct but doesn't match the patch.
On October 23, 2018 08:59:25 "Juan A. Suarez Romero"
wrote:
Commit 16870de8a0a introduced the use of nir_src_as_* functions, so
copy_propagation tests need to check expected value for the first
component.
Fixes: 16870de8a0a ("nir:
Rb
On October 23, 2018 09:26:16 Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_wsi_wayland.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/intel/vulkan/anv_wsi_wayland.c
b/src/intel/vulkan/anv_wsi_wayland.c
index
Hi,
With this commit, both radeonsi and radv fail to load for me with:
amdgpu: amdgpu_query_hw_ip_info(vcn_jpeg) failed.
If I comment out that query in ac_gpu_info.c, then they work again. I'm
running kernel 4.18.7 with a Vega 64 - is the DRM version check on that
correct?
Thanks,
Alex
On
https://bugs.freedesktop.org/show_bug.cgi?id=106157
Dylan Baker changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=106157
Dylan Baker changed:
What|Removed |Added
Depends on|107870 |
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=108530
Dylan Baker changed:
What|Removed |Added
Depends on||107870
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=107870
Dylan Baker changed:
What|Removed |Added
Blocks|106157 |18530
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=106157
Dylan Baker changed:
What|Removed |Added
Depends on||107870
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=107870
Dylan Baker changed:
What|Removed |Added
Blocks|18530 |108530
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=107870
Dylan Baker changed:
What|Removed |Added
Blocks||106157
Referenced Bugs:
Hi List,
It's that time again, release time! We're a little late getting started, but
here's the plan:
Branch point/RC1: 10/31
RC2: 11/7
RC3: 11/14
RC4/final release: 11/21
With point releases following the normal two week period, this would also
require adding two additional 18.2 releases:
https://bugs.freedesktop.org/show_bug.cgi?id=108530
Michel Dänzer changed:
What|Removed |Added
Depends on||108330
Referenced Bugs:
On 2018-10-23 4:55 p.m., Juan A. Suarez Romero wrote:
> Use nir_src_comp_as_uint() to read the proper second component, as
> nir_src_as_uint() returns the first one.
>
> v2: Use nir_src_comp_as_uint() [Jason]
>
> Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core
>
Reviewed-by: Lionel Landwerlin
On 23/10/2018 15:31, Eric Engestrom wrote:
snprintf() guarantees that it will not write more chars than allowed,
and that the string will be null-terminated, without the need to fill
the whole thing with zeroes to begin with.
Signed-off-by: Eric Engestrom
---
I think there are a few cases below where your change "over reports"
meaning reporting the same error that has been signaled previously
(device lost in particular).
And cases where the application is just giving a wrong value, I might be
wrong but I don't think we should report those ones
From: Boyuan Zhang
Use utility function for converting h264 pipe video profile to profile idc,
instead of using array.
Signed-off-by: Boyuan Zhang
---
src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 5 +
src/gallium/drivers/radeon/radeon_vce_52.c | 5 +
2 files changed, 2
From: Boyuan Zhang
Adding a function for converting h264 pipe video profile to profile idc
Signed-off-by: Boyuan Zhang
---
src/gallium/auxiliary/util/u_video.h | 24
1 file changed, 24 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_video.h
Hi Jason,
this change caused an assertion failure for me during make check, in the
nir/tests/vars_tests test under src/compiler. See the attached backtrace.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_queue.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_queue.c b/src/intel/vulkan/anv_queue.c
index db89385b86644417d47a..05739cb26df571c5f4db 100644
--- a/src/intel/vulkan/anv_queue.c
+++
Reviewed-by: Lionel Landwerlin
On 23/10/2018 15:25, Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_wsi_wayland.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/intel/vulkan/anv_wsi_wayland.c
b/src/intel/vulkan/anv_wsi_wayland.c
index
From: Boyuan Zhang
Use utility function for converting h264 pipe video profile to profile idc,
instead of using array.
Signed-off-by: Boyuan Zhang
---
src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
On Tue, 2018-10-23 at 09:26 -0500, Jason Ekstrand wrote:
> The commit message is correct but doesn't match the patch.
>
> On October 23, 2018 08:59:25 "Juan A. Suarez Romero"
> wrote:
>
> > Commit 16870de8a0a introduced the use of nir_src_as_* functions, so
> > copy_propagation tests need to
Use nir_src_comp_as_uint() to read the proper second component, as
nir_src_as_uint() returns the first one.
v2: Use nir_src_comp_as_uint() [Jason]
Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core
code")
Signed-off-by: Juan A. Suarez Romero
---
Reviewed-by: Lionel Landwerlin
On 23/10/2018 15:37, Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_queue.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_queue.c b/src/intel/vulkan/anv_queue.c
index
It's better to let most applications make use of adaptive sync
by default. Problematic applications can be placed on the blacklist
or the user can manually disable the feature.
Signed-off-by: Nicholas Kazlauskas
---
src/gallium/drivers/radeonsi/driinfo_radeonsi.h | 4
1 file changed, 4
This option lets the user decide whether mesa should notify the
window manager / DDX driver that the current application is adaptive
sync capable.
It's off by default.
Signed-off-by: Nicholas Kazlauskas
---
src/util/xmlpool/t_options.h | 5 +
1 file changed, 5 insertions(+)
diff --git
Applications that don't present at a predictable rate (ie. not games)
shouldn't have adapative sync enabled. This list covers some of the
common desktop compositors, web browsers and video players.
Signed-off-by: Nicholas Kazlauskas
---
src/util/00-mesa-defaults.conf | 82
The DDX driver can be notified of adaptive sync suitability by
flagging the application's window with the _VARIABLE_REFRESH property.
This property is set on the first swap the application performs
when adaptive_sync is set to true in the drirc.
It's performed here instead of when the loader is
Reviewed-by: Dylan Baker
Quoting Juan A. Suarez Romero (2018-10-05 02:17:45)
> I'll take care of 18.2 releases series on Andres behalf.
>
> CC: Andres Gomez
> CC: Dylan Baker
> CC: Emil Velikov
> ---
> docs/release-calendar.html | 8
> 1 file changed, 4 insertions(+), 4
snprintf() guarantees that it will not write more chars than allowed,
and that the string will be null-terminated, without the need to fill
the whole thing with zeroes to begin with.
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_device.c | 7 +++
1 file changed, 3 insertions(+), 4
On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand wrote:
>
> This should be useful for drivers that don't support real integers.
>
> Cc: Alyssa Rosenzweig
> ---
> src/compiler/Makefile.sources | 1 +
> src/compiler/nir/meson.build | 1 +
>
Some programs start with the path and command line arguments in
argv[0] (program_invocation_name). Chromium is an example of
an application using mesa that does this.
This tries to query the real path for the symbolic link /proc/self/exe
to find the program name instead. It only uses the realpath
These patches are part of a proposed new interface for supporting variable
refresh rate via DRM properties.
It adds a new option for supporting adaptive sync to drirc along with the
implementation of notifying the window manager/DDX of the support via a window
property.
The option is enabled
JPEG was added after DRM version 3.26
Signed-off-by: Leo Liu
Fixes: 4558758c51749(amd/common: add vcn jpeg ip info query)
Cc: Boyuan Zhang
Cc: Alex Smith
---
src/amd/common/ac_gpu_info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/common/ac_gpu_info.c
Reviewed-by: Jason Ekstrand
On Tue, Oct 23, 2018 at 9:55 AM Juan A. Suarez Romero
wrote:
> Use nir_src_comp_as_uint() to read the proper second component, as
> nir_src_as_uint() returns the first one.
>
> v2: Use nir_src_comp_as_uint() [Jason]
>
> Fixes: 16870de8a0a ("nir: Use nir_src_is_const
Quoting Juan A. Suarez Romero (2018-10-23 09:53:03)
> On Tue, 2018-10-23 at 09:30 -0700, Dylan Baker wrote:
> > CC: Emil Velikov
> > CC: Juan A. Romero Suarez
> > ---
> > docs/release-calendar.html | 38 +-
> > 1 file changed, 37 insertions(+), 1 deletion(-)
Commit 16870de8a0a introduced the use of nir_src_as_* functions, so
copy_propagation tests need to check expected value for the first
component.
Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core
code")
Signed-off-by: Juan A. Suarez Romero
---
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_wsi_wayland.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/intel/vulkan/anv_wsi_wayland.c
b/src/intel/vulkan/anv_wsi_wayland.c
index 3aeb1994110c563456cd..26383f42387ea28af0b5 100644
--- a/src/intel/vulkan/anv_wsi_wayland.c
+++
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_android.c | 2 +-
src/intel/vulkan/anv_device.c | 10 +-
src/intel/vulkan/anv_formats.c | 2 +-
src/intel/vulkan/anv_image.c | 2 +-
src/intel/vulkan/anv_queue.c | 6 +++---
https://bugs.freedesktop.org/show_bug.cgi?id=107502
Dylan Baker changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=107457
Dylan Baker changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=108530
Bug ID: 108530
Summary: [Tracker] Mesa 18.3 Release Tracker
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
Status: NEW
Severity: normal
On Tue, Oct 23, 2018 at 1:06 PM Liu, Leo wrote:
>
> JPEG was added after DRM version 3.26
>
> Signed-off-by: Leo Liu
> Fixes: 4558758c51749(amd/common: add vcn jpeg ip info query)
> Cc: Boyuan Zhang
> Cc: Alex Smith
Reviewed-by: Alex Deucher
> ---
> src/amd/common/ac_gpu_info.c | 2 +-
> 1
On Tue, Oct 23, 2018 at 12:04 PM Christian Gmeiner <
christian.gmei...@gmail.com> wrote:
> Am Di., 23. Okt. 2018 um 18:31 Uhr schrieb Ian Romanick <
> i...@freedesktop.org>:
> >
> > On 10/23/2018 08:33 AM, Connor Abbott wrote:
> > > On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand
> wrote:
> > >>
On Tue, 2018-10-23 at 09:30 -0700, Dylan Baker wrote:
> CC: Emil Velikov
> CC: Juan A. Romero Suarez
> ---
> docs/release-calendar.html | 38 +-
> 1 file changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/docs/release-calendar.html
https://bugs.freedesktop.org/show_bug.cgi?id=108532
Bug ID: 108532
Summary: make check
nir_copy_prop_vars_test.store_store_load_different_com
ponents regression
Product: Mesa
Version: git
Hardware:
Am Di., 23. Okt. 2018 um 18:31 Uhr schrieb Ian Romanick :
>
> On 10/23/2018 08:33 AM, Connor Abbott wrote:
> > On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand
> > wrote:
> >>
> >> This should be useful for drivers that don't support real integers.
> >>
> >> Cc: Alyssa Rosenzweig
> >> ---
> >>
Patches 2-3 are:
Reviewed-by: Samuel Pitoiset
Thanks!
On 10/23/18 12:56 PM, Timothy Arceri wrote:
---
src/amd/vulkan/radv_pipeline.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index 396b44d25a1..c21ca1743a4
I found a remnant of texture_float build option that wasn't removed in
https://gitlab.freedesktop.org/mesa/mesa/commit/66673bef941af344314fe9c91cad8cd330b245eb
This patch removes it.
---
common.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/common.py b/common.py
index f4f2bb4..be3ccfc
Build mesa 9135 failed
Commit 0ff1ccca25 by Timothy Arceri on 10/23/2018 10:56 AM:
radv: call nir_link_xfb_varyings()\n\nReviewed-by: Samuel Pitoiset
Configure your notification preferences
___
mesa-dev
CC: Ian Romanick
CC: Marek Olšák
Fixes: b3c17330e631695b5e5dc209ba9ea1a528618c97
("mesa: expose AMD_gpu_shader_int64")
---
src/mapi/glapi/gen/Makefile.am | 1 +
src/mapi/glapi/gen/meson.build | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mapi/glapi/gen/Makefile.am
There are two problems with the fixed patch. First, it fails to create a
dependency on the sourced .c file, so changes to intel_tiled_memcpy.c
won't trigger a rebuild. It also doesn't get included in the dist
tarball.
CC: Tapani Pälli
Fixes: 11b1afdc92db98e93f2ca50beeb7fc481a11e708
extra_files is just a nice way to to tell certain IDE's (and those
reading the file) that this file is also a dependency. Meson will use
the .d file generated by the compiler to figure out what the target
actually depends on.
---
src/mesa/drivers/dri/i965/meson.build | 22 --
Which is also required to put it in the tarball, a requirement for
building with meson from the tarball.
CC: Ian Romanick
CC: Marek Olšák
Fixes: 263c962cfdee6b43578ee5f28601309ea77d1434
("mesa: expose EXT_vertex_attrib_64bit")
---
src/mapi/glapi/gen/Makefile.am | 1 +
After discussion with Timothy Arceri. disk_cache_get_function_identifier
was using only the first byte of the sha1 build-id. Replace
disk_cache_get_function_identifier with implementation from
radv_get_build_id. Instead of writing a uint32_t it now writes to a
mesa_sha1. All drivers using
This patch fixes a problem where only the first byte of the build hash
was being used for the disk cache id. There was some discussion on
gitlab:
https://gitlab.freedesktop.org/mesa/mesa/commit/83ea8dd99bb16e5d9bb880e64cd2047abc536b70#note_52154
I've tested radeon_si and radv locally, but not
https://bugs.freedesktop.org/show_bug.cgi?id=108532
Vinson Lee changed:
What|Removed |Added
Keywords||bisected
CC|
Following the commit 2385d7b066 and 8e798e28f7, for resource dependancy
tracking.
Fixes:
dEQP-GLES31.functional.image_load_store.early_fragment_tests.no_early_fragment_tests_depth_fbo
with FD_MESA_DEBUG=inorder
---
src/gallium/drivers/freedreno/a5xx/fd5_blitter.c | 2 +-
Since ir3_register struct has union, it could return true even
if it's an array register accidentally when checking whether it
is address/predicate register.
Fixes: dEQP-GLES31.functional.ssbo.layout.random.arrays_of_arrays.6
---
src/gallium/drivers/freedreno/ir3/ir3.h | 4 ++--
1 file changed,
Hello Marek,
better late then...
Tested-by: Dieter Nützel
Merged it into current git (0ff1ccca25).
Do you need any special tests?
Dieter
Am 08.09.2018 00:06, schrieb Marek Olšák:
Hi Dieter,
Here:
https://cgit.freedesktop.org/~mareko/mesa/log/?h=ext_gpu_shader4
Marek
On Tue, Sep 4, 2018
Please CC and close https://bugs.freedesktop.org/show_bug.cgi?id=108532
when you push this.
--Jason
On Tue, Oct 23, 2018 at 12:12 PM Jason Ekstrand
wrote:
> Reviewed-by: Jason Ekstrand
>
> On Tue, Oct 23, 2018 at 9:55 AM Juan A. Suarez Romero
> wrote:
>
>> Use nir_src_comp_as_uint() to read
https://bugs.freedesktop.org/show_bug.cgi?id=108530
Vinson Lee changed:
What|Removed |Added
Depends on||108532
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=108530
Vinson Lee changed:
What|Removed |Added
Depends on||108082
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=108532
Vinson Lee changed:
What|Removed |Added
Blocks||108530
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=108082
Vinson Lee changed:
What|Removed |Added
Blocks||108530
Referenced Bugs:
On Tue, Oct 23, 2018 at 1:38 AM Connor Abbott wrote:
> On Tue, Oct 23, 2018 at 12:16 AM Jason Ekstrand
> wrote:
> >
> > D3D booleans use a 32-bit 0/-1 representation. Because this previously
> > matched NIR exactly, we didn't have to really optimize for it. Now that
> > we have 1-bit
From: Gert Wollny
This GLES extension gives the applications the control over deciding whether
the conversion from linear space to sRGB is necessary by enabling or
disabling this conversion at framebuffer write or blending time just
like it is possible for desktop GL.
v2: - Correct the
Yeah, I saw this while I was working on the bus_info stuff and I'm not sure
why we never enabled PRIME for Intel. I think I may have had a reason but
I have no idea what it was and I don't see a problem with it.
Reviewed-by: Jason Ekstrand
On Tue, Oct 23, 2018 at 10:32 AM Alex Smith
wrote:
>
From: Gert Wollny
another update to the series,
thanks for reviewing,
Gert
v4: Use PIPE_FORMAT_R8G8B8A8_SRGB as key format to check support
for this extension.
v3: correct Gallium to only create sRGB renderbuffers based on
Visual.srgbCapable when on desktop GL.
v2:
- core:
From: Gert Wollny
With this patch the extension EXT_sRGB_write_control is enabled for
gallium drivers that support sRGB formats as render targets.
Tested (and pass) on r600 (evergreen) and softpipe:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled*
with
From: Gert Wollny
v2: Fix ordering of extensions (Ian Romanick)
Enables and passes on i965:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled*
Signed-off-by: Gert Wollny
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On Tue, Oct 23, 2018 at 7:56 AM Juan A. Suarez Romero
wrote:
>
> Use nir_src_comp_as_uint() to read the proper second component, as
> nir_src_as_uint() returns the first one.
>
> v2: Use nir_src_comp_as_uint() [Jason]
>
> Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core
>
Thanks for fixing these issues;
Reviewed-by: Tapani Pälli
On 10/24/18 1:56 AM, Dylan Baker wrote:
There are two problems with the fixed patch. First, it fails to create a
dependency on the sourced .c file, so changes to intel_tiled_memcpy.c
won't trigger a rebuild. It also doesn't get
Reviewed-by: Tapani Pälli
On 10/24/18 1:56 AM, Dylan Baker wrote:
extra_files is just a nice way to to tell certain IDE's (and those
reading the file) that this file is also a dependency. Meson will use
the .d file generated by the compiler to figure out what the target
actually depends on.
https://bugs.freedesktop.org/show_bug.cgi?id=106881
--- Comment #8 from Yang Gu ---
Yang is OOO from Oct 15 to 26 for vacation and TPAC 2018. Please expect slow
response.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the
https://bugs.freedesktop.org/show_bug.cgi?id=106881
Tapani Pälli changed:
What|Removed |Added
Resolution|FIXED |DUPLICATE
--- Comment #7 from Tapani
https://bugs.freedesktop.org/show_bug.cgi?id=106810
--- Comment #6 from Tapani Pälli ---
*** Bug 106881 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the
96 matches
Mail list logo
