[Mesa-dev] [PATCH] Revert "imx: make use of loader_open_render_node(..) helper"

2018-10-29 Thread Christian Gmeiner
This reverts commit 773d6ea6e715d207bda3a53a9dfc8acf686035b0. Since kernel 4.17 (drm/etnaviv: remove the need for a gpu-subsystem DT node) the etnaviv DRM driver doesn't have an associated DT node anymore. This is technically correct, as the etnaviv device is a virtual device driving multiple

[Mesa-dev] [PATCH] radeonsi: add support for Raven2 (v2)

2018-10-29 Thread Marek Olšák
From: Marek Olšák v2: fix enabling primitive binning --- src/amd/addrlib/amdgpu_asic_addr.h | 2 ++ src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +- src/amd/common/ac_gpu_info.c| 6 ++ src/amd/common/ac_llvm_util.c | 2 ++

[Mesa-dev] [PATCH 06/11] gallium/util: move memory debug declarations into u_debug_gallium

2018-10-29 Thread Dylan Baker
--- src/gallium/auxiliary/util/u_debug.c | 1 - src/gallium/auxiliary/util/u_debug.h | 7 --- src/gallium/auxiliary/util/u_debug_gallium.h | 6 ++ src/gallium/auxiliary/util/u_debug_memory.c | 1 + src/gallium/state_trackers/wgl/stw_device.c | 1 + 5 files changed, 8

[Mesa-dev] [PATCH 02/11] gallium/util: start splitting u_debug into generic and gallium specific components

2018-10-29 Thread Dylan Baker
In order to pull u_debug into src/util we need to break the generically useful bits from the bits that are tightly coupled to gallium. --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/meson.build| 2 + src/gallium/auxiliary/util/u_debug.c | 10

[Mesa-dev] [PATCH 09/11] util: Move os_misc to util

2018-10-29 Thread Dylan Baker
this is needed by u_debug --- src/gallium/auxiliary/Makefile.sources | 2 -- src/gallium/auxiliary/meson.build| 2 -- src/gallium/auxiliary/util/u_debug.h | 2 +- src/gallium/drivers/i915/i915_screen.c | 2 +- src/gallium/drivers/llvmpipe/lp_screen.c | 2 +-

[Mesa-dev] [PATCH 00/11] Fix MacOS build

2018-10-29 Thread Dylan Baker
After pulling u_math into src/util to fix 32 bit windows builds of nir, I broke the MacOS build. This series fixes that platform by pulling down cpu_info into src/util as well. I would have liked to replace some of the duplication that cpu_info has with core mesa bits, but this is really needed

[Mesa-dev] [PATCH 10/11] util: Move u_debug to utils

2018-10-29 Thread Dylan Baker
This needs to be tested with autotools and scons --- src/gallium/auxiliary/Makefile.sources | 2 -- src/gallium/auxiliary/meson.build | 2 -- src/gallium/auxiliary/util/u_cpu_detect.c | 2 +- src/gallium/auxiliary/util/u_debug_stack.c | 2 +-

[Mesa-dev] [PATCH 04/11] gallium/util: move debug_print_bind_flags to u_debug_gallium

2018-10-29 Thread Dylan Baker
This also appears to be unused. --- src/gallium/auxiliary/util/u_debug.c | 33 src/gallium/auxiliary/util/u_debug.h | 4 --- src/gallium/auxiliary/util/u_debug_gallium.c | 33 src/gallium/auxiliary/util/u_debug_gallium.h | 3 ++ 4 files

[Mesa-dev] [PATCH 05/11] gallium/util: move debug_print_tranfer_flags to u_debug_galilum

2018-10-29 Thread Dylan Baker
This also appears to be unused. --- src/gallium/auxiliary/util/u_debug.c | 18 -- src/gallium/auxiliary/util/u_debug.h | 3 --- src/gallium/auxiliary/util/u_debug_gallium.c | 13 + src/gallium/auxiliary/util/u_debug_gallium.h | 3 +++ 4 files changed,

Re: [Mesa-dev] [PATCH 11/11] util: move u_cpu_detect to util

2018-10-29 Thread Dylan Baker
Quoting Brian Paul (2018-10-29 12:24:13) > On 10/29/2018 12:57 PM, Dylan Baker wrote: > > CC: v...@freedesktop.org > > CC: Roland Scheidegger > > Bugzilla: > >

Re: [Mesa-dev] [PATCH 05/15] ac: revert new LLVM 7.0 behavior for fdiv

2018-10-29 Thread Marek Olšák
Fixed in master. Marek On Mon, Oct 29, 2018 at 6:50 AM Connor Abbott wrote: > ctx->f32_1 probably needs to be replaced by the appropriately-sized > float, like LLVMConstReal(1., ...) > On Mon, Oct 29, 2018 at 11:45 AM Timothy Arceri > wrote: > > > > Hi Marek, > > > > It's late and I haven't

Re: [Mesa-dev] [PATCH 11/11] util: move u_cpu_detect to util

2018-10-29 Thread Brian Paul
On 10/29/2018 12:57 PM, Dylan Baker wrote: > CC: v...@freedesktop.org > CC: Roland Scheidegger > Bugzilla: >

Re: [Mesa-dev] [PATCH] i965/icl: Disable prefetching of sampler state entries

2018-10-29 Thread Kenneth Graunke
On Wednesday, October 24, 2018 11:33:53 AM PDT Anuj Phogat wrote: > From: Topi Pohjolainen > > In the same spirit as commit a5889d70f2074201ceaeac4f96a9a0c0b1f68a31 > "i965/icl: Disable binding table prefetching". Fixes some 110+ > intermittent piglit failures with tex-miplevel-selection

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add support for Raven2

2018-10-29 Thread Marek Olšák
On Sat, Oct 27, 2018 at 4:35 AM Gustaw Smolarczyk wrote: > sob., 27 paź 2018 o 04:28 Marek Olšák napisał(a): > > > > From: Marek Olšák > > > > --- > > src/amd/addrlib/amdgpu_asic_addr.h | 2 ++ > > src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +- > >

[Mesa-dev] [PATCH 07/11] gallium/util: remove p_format.h from u_debug.h

2018-10-29 Thread Dylan Baker
--- src/gallium/auxiliary/tgsi/tgsi_ureg.h | 1 + src/gallium/auxiliary/util/u_debug.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.h b/src/gallium/auxiliary/tgsi/tgsi_ureg.h index c974ed02069..f23e3fa98f8 100644 ---

[Mesa-dev] [PATCH 01/11] gallium: split u_prim_name out of u_debug.h

2018-10-29 Thread Dylan Baker
This allows us to pull u_prim.h out of u_debug.h --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/meson.build | 1 + src/gallium/auxiliary/util/u_debug.c | 26 -- src/gallium/auxiliary/util/u_prim.c| 48 ++ 4 files changed,

[Mesa-dev] [PATCH 08/11] gallium/util: remove u_inlines.h from u_debug.c

2018-10-29 Thread Dylan Baker
It's not used, and I'm not pulling u_inlines into src/util. --- src/gallium/auxiliary/util/u_debug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_debug.c b/src/gallium/auxiliary/util/u_debug.c index 2584a1f297d..f6ed0138c1f 100644 ---

[Mesa-dev] [PATCH 11/11] util: move u_cpu_detect to util

2018-10-29 Thread Dylan Baker
CC: v...@freedesktop.org CC: Roland Scheidegger Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107870 Fixes: 80825abb5d1a7491035880253ffd531c55acae6b ("move u_math to src/util") --- Roland, you noticed that the previous attempt to fix this issue broke windows. I've run scons with

[Mesa-dev] [PATCH 03/11] gallium/util: move debug_print_usage_enum to the u_debug_gallium

2018-10-29 Thread Dylan Baker
This isn't used in mesa, maybe vmware uses this in a closed source state tracker? --- src/gallium/auxiliary/util/u_debug.c | 19 --- src/gallium/auxiliary/util/u_debug.h | 3 --- src/gallium/auxiliary/util/u_debug_gallium.c | 19 +++

Re: [Mesa-dev] [PATCH 1/2] intel/icl: Disable combining of vertices from separate instances

2018-10-29 Thread Kenneth Graunke
On Monday, October 29, 2018 5:38:57 AM PDT Topi Pohjolainen wrote: > This is new hardware feature, and should be disabled until it is > clear our VS kernels are prepared for it. Thread payload has new > bit (See Bspec: Pipeline Stages - 3D Pipeline Geometry - > Vertex Shader (VS) Stage - Payloads

[Mesa-dev] [Bug 107870] Undefined symbols for architecture x86_64: "_util_cpu_caps"

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107870 --- Comment #4 from Dylan Baker --- New series sent out to fix this. -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] Meson windows v5 (10/19/2018) review

2018-10-29 Thread Dylan Baker
Quoting Jose Fonseca (2018-10-25 04:02:42) > On 21/10/18 20:54, Liviu Prodea wrote: > > 1. When using Meson 0.48.x both -Dc_args -Dcpp_args and -Db_vscrt > > methods of selecting the CRT are ineffective on changing the CRT from MD > > to MT resulting in build failure if LLVM is built with MT

Re: [Mesa-dev] [PATCH 1/3] radeonsi/gfx9: set optimal OVERWRITE_COMBINER_WATERMARK

2018-10-29 Thread Marek Olšák
The values can't be set per CB. Marek On Mon, Oct 29, 2018 at 7:04 AM Samuel Pitoiset wrote: > Are the values similar when they are set per CB instead of globally? > > On 10/27/18 4:28 AM, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/gallium/drivers/radeonsi/si_pipe.h | 1

[Mesa-dev] [ANNOUNCE] Mesa 18.2.4 release candidate

2018-10-29 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.4 is now available. Currently we have: - 22 queued - 0 nominated (outstanding) - and 1 rejected patch The current queue consists of: Different fixes for different drivers: freedreno, radeonsi, swr, anv and radv. Also there are fixes for ac,

Re: [Mesa-dev] [PATCH] glsl/linker: Fix out variables linking during single stage

2018-10-29 Thread Timothy Arceri
On 29/10/18 10:05 pm, Vadim Shovkoplias wrote: Hi Timothy, Thanks for the review. Piglit patch is updated with the additional out var: https://patchwork.freedesktop.org/patch/258899/ Original reporter confirmed that issue is finally fixed with the current patch and closed it. Can I ask to

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/1] util: Change remaining uint32 cache ids to sha1

2018-10-29 Thread Timothy Arceri
On 26/10/18 9:18 pm, Juan A. Suarez Romero wrote: On Fri, 2018-10-26 at 14:52 +1100, Timothy Arceri wrote: Pushed. Thanks again! Ccing stable in case the Fixes tag isnt enough for this to get picked up (since the previous cache fix this fixes was also backported) Enqueued for 18.2. I didn't

[Mesa-dev] [PATCH] i965: Respect GL_TEXTURE_SRGB_DECODE_EXT in GenerateMipmaps()

2018-10-29 Thread Kenneth Graunke
Apparently, we're supposed to look at the texture object's built-in sampler object's sRGB decode setting in order to decide whether to decode/downsample/re-encode, or simply downsample as-is. Previously, I had always done the decoding/encoding. Fixes SKQP's Skia_Unit_Tests.SRGBMipMaps test. ---

[Mesa-dev] [PATCH 2/3] radv: only enable gl_SampleMask if MSAA is enabled too

2018-10-29 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index c21ca1743a..6c793c30f0 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [PATCH 1/3] radv: use radeon_info::num_good_cu_per_sh

2018-10-29 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 1c6be300b4..55c213b384 100644 --- a/src/amd/vulkan/radv_device.c +++

[Mesa-dev] [PATCH 3/3] radv: set PA_SU_PRIM_FILTER_CNTL optimally

2018-10-29 Thread Samuel Pitoiset
Ported from RadeonSI. It's always TRUE for CIK+ because RADV doesn't support 16 samples. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

Re: [Mesa-dev] [PATCH 05/15] ac: revert new LLVM 7.0 behavior for fdiv

2018-10-29 Thread Connor Abbott
ctx->f32_1 probably needs to be replaced by the appropriately-sized float, like LLVMConstReal(1., ...) On Mon, Oct 29, 2018 at 11:45 AM Timothy Arceri wrote: > > Hi Marek, > > It's late and I haven't dug into this any further but this patch causes > a whole bunch of f64 piglit tests to fail for

[Mesa-dev] [Bug 105731] linker error "fragment shader input ... has no matching output in the previous stage" when previous stage's output declaration in a separate shader object

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105731 --- Comment #11 from vadym --- Hi Marcel, Glad to hear this issue is finally fixed! Thanks a lot for such a high quality bug report and assistance/testing. Piglit test is also updated with the additional out variable:

Re: [Mesa-dev] [PATCH 1/2] blorp: Emit a dummy 3DSTATE_WM prior to 3DSTATE_WM_HZ_OP

2018-10-29 Thread Juan A. Suarez Romero
On Tue, 2018-10-16 at 15:12 -0500, Jason Ekstrand wrote: > Suggested-by: Francisco Jerez > --- > src/intel/blorp/blorp_genX_exec.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/intel/blorp/blorp_genX_exec.h > b/src/intel/blorp/blorp_genX_exec.h > index

Re: [Mesa-dev] [PATCH mesa] intel/batch-decoder: remove never-used function

2018-10-29 Thread Lionel Landwerlin
Feel free to remove it from src/intel/tools/aubinator_viewer_decoder.cpp too. Reviewed-by: Lionel Landwerlin Thanks, - Lionel On 28/10/2018 17:09, Eric Engestrom wrote: This function was there when the file was introduced in commit 38f10d5a03542c60a589 "intel: tools: add aubinator viewer",

Re: [Mesa-dev] [PATCH 05/15] ac: revert new LLVM 7.0 behavior for fdiv

2018-10-29 Thread Timothy Arceri
Hi Marek, It's late and I haven't dug into this any further but this patch causes a whole bunch of f64 piglit tests to fail for the radeonsi nir backend. e.g. ./bin/shader_runner generated_tests/spec/glsl-4.00/execution/built-in-functions/fs-inverse-dmat2.shader_test -auto -fbo LLVM

Re: [Mesa-dev] [PATCH 2/2] Revert "anv/skylake: disable ForceThreadDispatchEnable"

2018-10-29 Thread Juan A. Suarez Romero
On Tue, 2018-10-16 at 15:12 -0500, Jason Ekstrand wrote: > This reverts commit 0fa9e6d7b304f6a8064ed78a4b9c557e1026e7e5. The real > issue appears to have been that HiZ ops don't like having WM thread > dispatch force-enabled. The previous commit fixes that problem so we > can go back to using

Re: [Mesa-dev] [PATCH 2/3] mesa/st: Add Gallium support for EXT_texture_sRGB_R8

2018-10-29 Thread Gert Wollny
Am Montag, den 29.10.2018, 04:27 -0400 schrieb Ilia Mirkin: > On Mon, Oct 29, 2018 at 3:41 AM Gert Wollny m> wrote: > > > > This only adds support on the Gallium core level, for the drivers > > it is likely that additional changes are needed to support the > > new texture format. > > > >

Re: [Mesa-dev] [PATCH 1/3] radeonsi/gfx9: set optimal OVERWRITE_COMBINER_WATERMARK

2018-10-29 Thread Samuel Pitoiset
Are the values similar when they are set per CB instead of globally? On 10/27/18 4:28 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 14 +- 2 files changed, 14 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] glsl/linker: Fix out variables linking during single stage

2018-10-29 Thread Vadim Shovkoplias
Hi Timothy, Thanks for the review. Piglit patch is updated with the additional out var: https://patchwork.freedesktop.org/patch/258899/ Original reporter confirmed that issue is finally fixed with the current patch and closed it. Can I ask to push the patch please ? Regards, Vadym сб, 27 окт.

[Mesa-dev] [PATCH] st/mesa: calculate buffer size correctly for packed uniforms

2018-10-29 Thread Timothy Arceri
Fixes: edded1237607 ("mesa: rework ParameterList to allow packing") --- src/mesa/state_tracker/st_atom_constbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_constbuf.c b/src/mesa/state_tracker/st_atom_constbuf.c index

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-29 Thread Eric Engestrom
On Monday, 2018-10-29 10:44:28 +0200, Sergii Romantsov wrote: > Hello, > > > > What problem are we solving? > > That we don't get fast paths in rounding.h by default on i686, I think? > > Yes, it adds optimization for rounding.h. On x86_64 msse is enabled by > default (as example by gcc). > And

Re: [Mesa-dev] [PATCH mesa 4/4] vulkan/wsi: fix pointer casting warning on 32bit

2018-10-29 Thread Eric Engestrom
On Sunday, 2018-10-28 17:29:34 -0500, Jason Ekstrand wrote: > On October 28, 2018 08:45:30 Eric Engestrom wrote: > > > Signed-off-by: Eric Engestrom > > --- > > src/vulkan/wsi/wsi_common_wayland.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git

Re: [Mesa-dev] [PATCH] glsl/linker: validate attribute aliasing before optimizations

2018-10-29 Thread Tapani Pälli
On 10/27/18 1:32 AM, Timothy Arceri wrote: On Fri, Oct 12, 2018, at 5:04 AM, Tapani Pälli wrote: Patch does a 'dry run' of assign_attribute_or_color_locations before optimizations to catch cases where we have aliasing of unused attributes which is forbidden by the GLSL ES 3.x specifications.

Re: [Mesa-dev] [PATCH mesa v2 1/4] anv: add missing meson build dependency

2018-10-29 Thread Eric Engestrom
On Sunday, 2018-10-28 17:26:18 -0500, Jason Ekstrand wrote: > Rb Thanks! I assume that's just anv, not the rest of the series? > > On October 28, 2018 08:19:19 Eric Engestrom wrote: > > > Fixes: e4538b93f5d5177318f2 "anv: Implement VK_KHR_driver_properties" > > Signed-off-by: Eric Engestrom

[Mesa-dev] [PATCH 1/3] mesa/core: Add definitions and translations for EXT_texture_sRGB_R8

2018-10-29 Thread Gert Wollny
EXT_texture_sRGB_R8 adds a GLES sRGB texture format with only one channel. v2: - fix format definition line - disable for desktop GL - don't add GL_R8_EXT to glext.h since it is already in GLES2/gl2ext.h in glext.h and include this header where needed (all Emil) v3: -

Re: [Mesa-dev] [PATCH 2/3] mesa/st: Add Gallium support for EXT_texture_sRGB_R8

2018-10-29 Thread Ilia Mirkin
On Mon, Oct 29, 2018 at 3:41 AM Gert Wollny wrote: > > This only adds support on the Gallium core level, for the drivers > it is likely that additional changes are needed to support the > new texture format. > > Enables on softpipe and makes pass: >

[Mesa-dev] [PATCH 0/3] Add support for EXT_texture_sRGB_R8 to core and gallium

2018-10-29 Thread Gert Wollny
Dear all, this series adds support for the GLES texture format to mesa/core, Gallium, and some Gallium drivers. For dri/swrast and Gallium/svga format function tables needed to be added to make mesa compile, but dri/swrast is GLES 2.0 only, so ít doesn't support the extension per se, and

[Mesa-dev] [PATCH] configure.ac: make judgement logic cleaner

2018-10-29 Thread Zhaowei Yuan
The purpose of judegment here is to output error message and abort configure procedure if gbm is not enabled, the original statement makes it work, however, its logic is not clear and easy to make people confused. Signed-off-by: Zhaowei Yuan --- configure.ac | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH 2/3] mesa/st: Add Gallium support for EXT_texture_sRGB_R8

2018-10-29 Thread Gert Wollny
This only adds support on the Gallium core level, for the drivers it is likely that additional changes are needed to support the new texture format. Enables on softpipe and makes pass: dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.* v2: - add include for getting GL_SR8_EXT -

[Mesa-dev] [PATCH 3/3] r600: Add support for EXT_texture_sRGB_R8

2018-10-29 Thread Gert Wollny
Mark the one channel format as valid sRGB format. Enables on R600 and makes pass: dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.* dEQP-GLES31.functional.texture.filtering.cube_array.formats.sr8* v2: remove chunk for dri/radeon (Emil) Signed-off-by: Gert Wollny ---

Re: [Mesa-dev] [PATCH 1/3] mesa/core: Add definitions and translations for EXT_texture_sRGB_R8

2018-10-29 Thread Ilia Mirkin
On Mon, Oct 29, 2018 at 3:39 AM Gert Wollny wrote: > > EXT_texture_sRGB_R8 adds a GLES sRGB texture format with only one channel. > > v2: - fix format definition line > - disable for desktop GL > - don't add GL_R8_EXT to glext.h since it is already in > GLES2/gl2ext.h in glext.h

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-29 Thread Sergii Romantsov
Hello, > > What problem are we solving? That we don't get fast paths in rounding.h by default on i686, I think? Yes, it adds optimization for rounding.h. On x86_64 msse is enabled by default (as example by gcc). And additionally helps to fix autotools 32b build (missed linkage with m-lib if no

[Mesa-dev] [PATCH 02/14] vbo: Remove the VBO_SAFE_FALLBACK flag.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich On finishing a display list playback the VBO_SAFE_FALLBACK bit is still kept in vbo_save_context::replay_flags. But examining replay_flags and the display list flags that feed this value the corresponding bit is never set these days anymore. So, since it is nowhere set or

[Mesa-dev] [PATCH 06/14] vbo: Remove the always false branch dlist replay.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich The previous patch left a constant if (0) in the code. Clean that up now. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save_loopback.c | 30 +- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git

[Mesa-dev] [PATCH 04/14] vbo: Remove VBO_SAVE_PRIM_WEAK from vbo_save_NotifyBegin calls.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Now looking at the implementation of vbo_save_NotifyBegin. The VBO_SAVE_PRIM_WEAK flag, delivered in the primitive mode argument to vbo_save_NotifyBegin, is not evaluated anymore. The two users of the mode argument are the primitive mode itself, where the

[Mesa-dev] [PATCH 03/14] vbo: Remove set but not used weak field from _mesa_prim.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich The only reader of the weak field in _mesa_prim is pretty console printing. By that, remove the weak field from _mesa_prim. Signed-off-by: Mathias Fröhlich --- src/mesa/state_tracker/st_cb_rasterpos.c | 1 - src/mesa/vbo/vbo.h | 3 +--

[Mesa-dev] [PATCH 08/14] vbo: Move no_current_update out of _mesa_prim.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich The _mesa_prim::no_current_update flag should tell the compiled display list if the current attributes that are placed in the dlists vbo shall take a defined state past replay of a display list. Immediate mode draws compiled into display lists should set the current

[Mesa-dev] [PATCH 01/14] vbo: Remove unused vbo_save_fallback function.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save.c | 15 --- src/mesa/vbo/vbo_save.h | 1 - 2 files changed, 16 deletions(-) diff --git a/src/mesa/vbo/vbo_save.c b/src/mesa/vbo/vbo_save.c index 73bc49a24b..7e77123ba8 100644 ---

[Mesa-dev] [PATCH 00/14] Various cleanups on display lists and draw code.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, The series collects some of that cleanup opportunities that I found while working on the vao changes from this spring. There are two groups of changes. The first bunch removes unreachable code paths from the dlist code and removes related functions and flags. That is

[Mesa-dev] [PATCH 13/14] mesa/vbo: Move _vbo_draw_indirect -> _mesa_draw_indirect

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/driverfuncs.c | 4 +- src/mesa/main/draw.c | 74 +++ src/mesa/main/draw.h | 11 src/mesa/vbo/vbo.h| 10

[Mesa-dev] [PATCH 07/14] vbo: Remove the now unused VBO_SAVE_PRIM_WEAK define.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index d00700166e..65293c93f0 100644 --- a/src/mesa/vbo/vbo_save.h +++ b/src/mesa/vbo/vbo_save.h @@ -137,7

[Mesa-dev] [PATCH 10/15] anv/android: support creating images from external format

2018-10-29 Thread Tapani Pälli
Since we don't know the exact format at creation time, some initialization is done only when bound with memory in vkBindImageMemory. v2: demand dedicated allocation in vkGetImageMemoryRequirements2 if image has external format v3: refactor prepare_ahw_image, support vkBindImageMemory2,

[Mesa-dev] [PATCH 11/15] anv: support VkExternalFormatANDROID in vkCreateSamplerYcbcrConversion

2018-10-29 Thread Tapani Pälli
If external format is used, we store the external format identifier in conversion to be used later when creating VkImageView. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/intel/vulkan/anv_formats.c

[Mesa-dev] [PATCH 15/15] anv/android: turn on VK_ANDROID_external_memory_android_hardware_buffer

2018-10-29 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_extensions.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index ab9240f9fd8..ca414284fdd 100644 --- a/src/intel/vulkan/anv_extensions.py +++

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #11 from Ahmed Elsayed --- I made a system restore to roll back to the stable Mesa release, and installed the new Mesa 18.3 driver released yesterday. The Witcher III: still the same. Mafia III: the graphic glitches decreased but

[Mesa-dev] [PATCH 00/15] VK_ANDROID_external_memory_android_hardware_buffer

2018-10-29 Thread Tapani Pälli
Hi; Here are fixes to earlier series with some refactoring, addressing Jason's comments and fixing some bugs I found when running Android CTS suite. With these changes following android.graphics.cts.BasicVulkanGpuTest tests start to pass: testBasicBufferImportAndRenderingExternalFormat

[Mesa-dev] [PATCH 02/15] anv: refactor make_surface to use data from anv_image

2018-10-29 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_image.c | 78 ++ src/intel/vulkan/anv_private.h | 5 +++ 2 files changed, 46 insertions(+), 37 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index

[Mesa-dev] [PATCH 01/15] anv: add create_flags as part of anv_image

2018-10-29 Thread Tapani Pälli
This will make it possible for next patch to rip anv_image_create_info out from make_surface function. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_image.c | 1 + src/intel/vulkan/anv_private.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 05/15] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

2018-10-29 Thread Tapani Pälli
Use the anv_format address in formats table as implementation-defined external format identifier for now. When adding YUV format support this might need to change. v2: code cleanup (Jason) v3: set anv_format address as identifier Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_android.c |

[Mesa-dev] [PATCH 04/15] anv: add from/to helpers with android and vulkan formats

2018-10-29 Thread Tapani Pälli
v2: handle R8G8B8X8 as R8G8B8_UNORM (Jason) Signed-off-by: Tapani Pälli --- src/intel/vulkan/vk_format_info.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/src/intel/vulkan/vk_format_info.h b/src/intel/vulkan/vk_format_info.h index

[Mesa-dev] [PATCH 06/15] anv: add anv_ahw_usage_from_vk_usage helper function

2018-10-29 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_android.c | 31 +++ src/intel/vulkan/anv_private.h | 3 +++ 2 files changed, 34 insertions(+) diff --git a/src/intel/vulkan/anv_android.c b/src/intel/vulkan/anv_android.c index 67e9adee73e..d0a20dd85c5 100644 ---

[Mesa-dev] [PATCH 08/15] anv/android: support import/export of AHardwareBuffer objects

2018-10-29 Thread Tapani Pälli
v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB) v3: properly handle usage bits when creating from image v4: refactor, code cleanup (Jason) Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_android.c | 128 + src/intel/vulkan/anv_device.c |

[Mesa-dev] [PATCH 12/15] anv: introduce helper to resolve vk_format from anv_format

2018-10-29 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 18 ++ src/intel/vulkan/anv_private.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index 1d3b1f67928..166b50f5a07 100644 ---

[Mesa-dev] [PATCH 13/15] anv: support VkSamplerYcbcrConversionInfo in vkCreateImageView

2018-10-29 Thread Tapani Pälli
If a conversion struct was passed, then we resolve the format from conversion structure. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_image.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 14/15] anv: ignore VkSamplerYcbcrConversion on non-yuv formats

2018-10-29 Thread Tapani Pälli
This fulfills a requirement for clients that want to utilize same code path for images with external formats (VK_FORMAT_UNDEFINED) and "regular" RGBA images where format is known. This is similar to how OES_EGL_image_external works. To support this, we allow color conversion samplers for non-YUV

[Mesa-dev] [PATCH 09/15] anv/android: add ahardwarebuffer external memory properties

2018-10-29 Thread Tapani Pälli
v2: have separate memory properties for android, set usage flags for buffers correctly v3: code cleanup (Jason) + limit maxArrayLayers to 1 for AHardwareBuffer based images Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 46 ++ 1 file

[Mesa-dev] [PATCH 03/15] anv: make anv_get_image_format_features public

2018-10-29 Thread Tapani Pälli
This will be utilized later by GetAndroidHardwareBufferPropertiesANDROID. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 22 +++--- src/intel/vulkan/anv_private.h | 5 + 2 files changed, 16 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 07/15] anv: refactor, remove else block in AllocateMemory

2018-10-29 Thread Tapani Pälli
This makes it cleaner to introduce more cases where we import memory from different types of external memory buffers. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_device.c | 64 +++ 1 file changed, 34 insertions(+), 30 deletions(-) diff --git

[Mesa-dev] [PATCH 05/14] vbo: Test for VBO_SAVE_PRIM_WEAK in _mesa_prim::mode is false.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich When setting the _mesa_prim::mode field we always filter out all non OpenGL primitive mode bits. So this tested bit cannot be there anymore and the test evaluates to zero. The zero is removed with the next patch to ease review. Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 10/14] vbo: Preserve vbo_save::no_current_update on primitive restart.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich With this change we preserve the no_current_update property when we observe a glPrimitiveRestart call. That means that we now also get the no_current_update optimization for display lists that are made out of indexed draws using primitive restart. Signed-off-by: Mathias

[Mesa-dev] [PATCH 11/14] vbo: Pull the _mesa_set_draw_vao calls out of the if clauses.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich These calls are just the same in each if branch. So pull that before the if. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_array.c | 114 -- 1 file changed, 38 insertions(+), 76 deletions(-) diff --git

[Mesa-dev] [PATCH 09/14] vbo: Make no_current_update an argument to vbo_save_NotifyBegin.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Instead of coding additional information into the primitive mode, make the only remaining flag there a direct argument to vbo_save_NotifyBegin. Signed-off-by: Mathias Fröhlich --- src/mesa/main/dlist.c | 2 +- src/mesa/vbo/vbo.h | 3 ++-

[Mesa-dev] [PATCH 12/14] mesa/vbo: Move src/mesa/vbo/vbo_exec_array.c -> src/mesa/main/draw.c

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich The array type draw is no longer directly dependent on the vbo module. Thus move array type draws into mesa/main/draw.c. Rename symbols starting with vbo_* to _mesa_* and apply some reindenting to make it consistent. Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 14/14] mesa: Collect all the draw functions in draw.{h, c}.

2018-10-29 Thread Mathias . Froehlich
From: Mathias Fröhlich Some of these functions were distributed across different implementation and header files. Put them at a central place. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 1 + src/mesa/main/draw.c | 43 ++

Re: [Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

2018-10-29 Thread Wentland, Harry
On 2018-10-26 7:22 a.m., Daniel Vetter wrote: > On Fri, Oct 26, 2018 at 1:08 PM Daniel Stone wrote: >> >> Hi, >> >> On Fri, 26 Oct 2018 at 11:57, Daniel Vetter wrote: >>> On Fri, Oct 26, 2018 at 10:13:51AM +1000, Peter Hutterer wrote: On Wed, Oct 17, 2018 at 02:37:25PM +0200, Daniel Vetter

Re: [Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

2018-10-29 Thread Daniel Vetter
On Mon, Oct 29, 2018 at 01:24:56PM +, Wentland, Harry wrote: > On 2018-10-26 7:22 a.m., Daniel Vetter wrote: > > On Fri, Oct 26, 2018 at 1:08 PM Daniel Stone wrote: > >> > >> Hi, > >> > >> On Fri, 26 Oct 2018 at 11:57, Daniel Vetter wrote: > >>> On Fri, Oct 26, 2018 at 10:13:51AM +1000,

[Mesa-dev] [PATCH v2] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-29 Thread Toni Lönnberg
Use the 'DWord Length' and 'bias' fields from the instruction definition to parse the packet length from the command stream when possible. The hardcoded mechanism is used whenever an instruction doesn't have this field. --- src/intel/common/gen_decoder.c | 30 +++---

Re: [Mesa-dev] [PATCH] intel/blorp: Define the clear value bounds for HiZ clears

2018-10-29 Thread Jason Ekstrand
That's likely because Nanley forgot to CC this one too stable: https://cgit.freedesktop.org/mesa/mesa/commit/?id=5bcf479524b96554cab7d2429dacf650b4054638 On October 29, 2018 06:49:47 "Juan A. Suarez Romero" wrote: On Thu, 2018-10-25 at 16:25 -0700, nanleych...@gmail.com wrote: From:

Re: [Mesa-dev] [PATCH] intel: tools: Add handling for video pipe

2018-10-29 Thread Lionel Landwerlin
Looks correct to me. Maybe you'll find something useful from this series : https://patchwork.freedesktop.org/series/50135/ Reviewed-by: Lionel Landwerlin On 29/10/2018 14:05, Toni Lönnberg wrote: Preliminary work for adding handling of different pipes to gen_decoder. We need to be able to

Re: [Mesa-dev] [PATCH] intel: tools: Add handling for video pipe

2018-10-29 Thread Toni Lönnberg
Hadn't noticed your patch series before, sorry for that. I'd like to get rid of the magic numbers for the registers and have the code use the definitions instead for sure. Can you push this one in? On Mon, Oct 29, 2018 at 03:36:12PM +, Lionel Landwerlin wrote: > Looks correct to me. Maybe

Re: [Mesa-dev] [PATCH 2/3] mesa/st: Add Gallium support for EXT_texture_sRGB_R8

2018-10-29 Thread Gert Wollny
Am Montag, den 29.10.2018, 15:52 + schrieb Roland Scheidegger: > This patch should probably be split into adding the format to gallium > and using it in mesa/st. Seems reasonable, I'll give it a shot. > More comments inline. As of Ilia's comments I already work on changing the svga part,

[Mesa-dev] [PATCH 3/3] ac/nir: set cache policy when loading/storing buffer images

2018-10-29 Thread Samuel Pitoiset
This was missing. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 736b726beb..eaf400e2fe 100644 ---

[Mesa-dev] [PATCH 2/3] uac/nir: add get_cache_policy() helper and use it

2018-10-29 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 38 ++--- 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index e5fbe003f5..736b726beb 100644 ---

[Mesa-dev] [PATCH 1/3] ac/nir: make use of i1false in few more places

2018-10-29 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 5ab81987d0..e5fbe003f5 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

Re: [Mesa-dev] [PATCH mesa v2 1/4] anv: add missing meson build dependency

2018-10-29 Thread Dylan Baker
for the series: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-10-28 06:18:39) > Fixes: e4538b93f5d5177318f2 "anv: Implement VK_KHR_driver_properties" > Signed-off-by: Eric Engestrom > --- > src/intel/vulkan/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #10 from Samuel Pitoiset --- VK_EXT_transform_feedback is upstream. Please rebase and try to reproduce your problem now. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [AppVeyor] mesa master #9173 failed

2018-10-29 Thread AppVeyor
Build mesa 9173 failed Commit b4eb029062 by Samuel Pitoiset on 10/5/2018 4:04 PM: radv: implement VK_EXT_transform_feedback\n\nThis implementation should work and potential bugs can be\nfixed during the release candidates window anyway.\n\nSigned-off-by:

[Mesa-dev] [Bug 108581] llvmpipe crashes using kms_swrast_dri.so

2018-10-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108581 --- Comment #4 from Roland Scheidegger --- Looks like the buffer disappeared when it still had pending rendering commands to it (in this case, a clear command). I think this happens because these (kms) surfaces aren't allocated within llvmpipe

Re: [Mesa-dev] [PATCH 2/3] mesa/st: Add Gallium support for EXT_texture_sRGB_R8

2018-10-29 Thread Roland Scheidegger
This patch should probably be split into adding the format to gallium and using it in mesa/st. More comments inline. Am 29.10.18 um 08:35 schrieb Gert Wollny: > This only adds support on the Gallium core level, for the drivers > it is likely that additional changes are needed to support the > new

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-29 Thread Dylan Baker
Quoting Sergii Romantsov (2018-10-29 01:44:28) > Hello, > > What problem are we solving? > > That we don't get fast paths in rounding.h by default on i686, I think? > > Yes, it adds optimization for rounding.h. On x86_64 msse is enabled by default > (as example by gcc). > And

  1   2   >