Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-16 Thread Rhys Perry
Rise of the Tomb Raider from without to with the change (average of 3 runs): SpineOfTheMountain: 73.46667 fps -> 73.56667 fps (+0.14%) ProphetsTomb: 58.4 fps -> 58.46667 fps (+0.11%) GeothermalValley: 57.2 fps -> 57.46667 fps (+0.47%) So not much improvement (if any). On Wed, 16

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-16 Thread Lionel Landwerlin
On 16/01/2019 14:01, Daniel Stone wrote: Hi, On Wed, 16 Jan 2019 at 13:01, Lionel Landwerlin wrote: - It seems we only get notifications when adding to an MR, I could like to subscribe to particular tags If you go to https://gitlab.freedesktop.org/mesa/mesa/labels/ then you can subscribe to

Re: [Mesa-dev] [PATCH v4] anv/device: fix maximum number of images supported

2019-01-16 Thread Iago Toral
Jason, does this version look good to you? On Mon, 2019-01-14 at 12:42 +0100, Iago Toral Quiroga wrote: > We had defined MAX_IMAGES as 8, which we used to size the array for > image push constant data. The comment there stated that this was for > gen8, but anv_nir_apply_pipeline_layout runs for

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-16 Thread Rhys Perry
Seems I accidentally had it use Fedora 29's mesa build in both the before and after runs... Running again I get (again, average of 3 runs): GeothermalValley: 58.2 fps -> 59.633 fps (+2.5%) ProphetsTomb: 59 fps -> 60 fps (+1.7%) SpineOfTheMountain: 64 fps -> 64.06667 fps (+0.1%) (1 extreme

Re: [Mesa-dev] [PATCH v4] etnaviv: fix resource usage tracking across different pipe_context's

2019-01-16 Thread Lukas Hartmann
FYI I tested this in production for a few days and encountered no problems. Cheers Lukas > On 16. Jan 2019, at 12:14, Lucas Stach wrote: > > Am Samstag, den 12.01.2019, 22:22 +0100 schrieb Marek Vasut: >>> From: Christian Gmeiner >> >> A pipe_resource can be shared by all the pipe_context's

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-16 Thread Daniel Stone
Hi, On Tue, 15 Jan 2019 at 23:47, Matt Turner wrote: > On Mon, Jan 14, 2019 at 4:36 AM Daniel Stone wrote: > > On Fri, 11 Jan 2019 at 17:05, Jason Ekstrand wrote: > > > 5. There's no way with gitlab for Reviewed-by tags to get automatically > > > applied as part of the merging process. This

Re: [Mesa-dev] [PATCH 2/4] intel/sanitize_gpu: add help/gdb options to wrapper

2019-01-16 Thread Lionel Landwerlin
On 16/01/2019 01:31, Matt Turner wrote: On Mon, Oct 29, 2018 at 11:16 AM Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_sanitize_gpu.in | 55 ++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-16 Thread Lionel Landwerlin
- I'm pretty happy with the discussion on a particular point/location of a change.   A lot more readable than a long chain of email. - Having issues with the comments not always showing up on a particular commit of an MR (but it looks like gitlab is aware of that issue) - The Rb/Ab tags were

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-16 Thread Daniel Stone
Hi, On Wed, 16 Jan 2019 at 13:01, Lionel Landwerlin wrote: > - It seems we only get notifications when adding to an MR, I could like to > subscribe to particular tags If you go to https://gitlab.freedesktop.org/mesa/mesa/labels/ then you can subscribe to things per-label. That applies to both

Re: [Mesa-dev] [PATCH] egl/wayland: break double/tripple buffering feedback loops

2019-01-16 Thread Lucas Stach
Am Dienstag, den 15.01.2019, 10:35 -0600 schrieb Derek Foreman: > On 1/15/19 8:02 AM, Daniel Stone wrote: > > Hi, > > > > > > On Tue, 18 Dec 2018 at 17:59, Lucas Stach > > > > wrote: > > > Am Dienstag, den 18.12.2018, 17:43 + schrieb Emil Velikov: > > > > > On Tue, 18 Dec 2018 at 11:16,

Re: [Mesa-dev] [PATCH v4] etnaviv: fix resource usage tracking across different pipe_context's

2019-01-16 Thread Lucas Stach
Am Samstag, den 12.01.2019, 22:22 +0100 schrieb Marek Vasut: > > From: Christian Gmeiner > > A pipe_resource can be shared by all the pipe_context's hanging off the > same pipe_screen. > > > Signed-off-by: Christian Gmeiner > > Signed-off-by: Marek Vasut > To: mesa-dev@lists.freedesktop.org >

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-16 Thread Eric Engestrom
On Saturday, 2019-01-12 13:24:38 -0500, Ilia Mirkin wrote: > On Sat, Jan 12, 2019 at 9:40 AM Gert Wollny wrote: > > I will not push it with > > the strong NAK you gave, Ilia. To me consensus means that all who > > contribute significantly to the project (like you certainly do) agree > > or

[Mesa-dev] NIR + softfp64 problem

2019-01-16 Thread Gert Wollny
Hello, I'm trying to get soft-fp64 working with my experimental r600-nir backend, and thanks to Dave's contribution it is already tied in, some instructions are not yet supported by the backend, but when running the piglits I have already 24 tests passing. However, there are also 1099 test

Re: [Mesa-dev] [PATCH] intel/fs: Do the grf127 hack on SIMD8 instructions in SIMD16 mode

2019-01-16 Thread Chema Casanova
El 16/1/19 a las 0:55, Matt Turner escribió: > On Tue, Jan 15, 2019 at 8:58 AM Jason Ekstrand wrote: >> >> Previously, we only applied the fix to shaders with a dispatch mode of >> SIMD8 but the code it relies on for SIMD16 mode only applies to SIMD16 >> instructions. If you have a SIMD8

[Mesa-dev] [MR] intel: Media instructions support

2019-01-16 Thread Toni Lönnberg
Added instructions for the video engine to the genxml files. https://gitlab.freedesktop.org/mesa/mesa/merge_requests/118 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-16 Thread Rob Clark
On Tue, Jan 15, 2019 at 5:51 PM Daniel Stone wrote: > > Hey, > > On Tue, 15 Jan 2019 at 20:22, Rob Clark wrote: > > On Tue, Jan 15, 2019 at 7:40 AM Daniel Stone wrote: > > > My question would again be what value that brings you. Do you just > > > like seeing the name there, or do you go poke

Re: [Mesa-dev] [PATCH] intel/fs: Do the grf127 hack on SIMD8 instructions in SIMD16 mode

2019-01-16 Thread Chema Casanova
If Matt concerns about the validation rule are solved this is. Reviewed-by: Jose Maria Casanova Crespo El 15/1/19 a las 17:58, Jason Ekstrand escribió: > Previously, we only applied the fix to shaders with a dispatch mode of > SIMD8 but the code it relies on for SIMD16 mode only applies to

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

2019-01-16 Thread Adam Jackson
On Wed, 2019-01-16 at 04:41 +, Strasser, Kevin wrote: > Emil Velikov wrote: > > > > Please split this up a bit. I'm thinking of: > > - dri_interface > > - mesa > > - egl > > - gbm > > - glx - seems sparse on updates, guessting you're followed in laster > > patches? > > Sure, I can

Re: [Mesa-dev] [PATCH v4] anv/device: fix maximum number of images supported

2019-01-16 Thread Jason Ekstrand
Yup. Reviewed-by: Jason Ekstrand On Wed, Jan 16, 2019 at 6:08 AM Iago Toral wrote: > Jason, does this version look good to you? > > On Mon, 2019-01-14 at 12:42 +0100, Iago Toral Quiroga wrote: > > We had defined MAX_IMAGES as 8, which we used to size the array for > > image push constant

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

2019-01-16 Thread Strasser, Kevin
Adam Jackson wrote: > On Wed, 2019-01-16 at 04:41 +, Strasser, Kevin wrote: > > Emil Velikov wrote: > > > > > > Please split this up a bit. I'm thinking of: > > > - dri_interface > > > - mesa > > > - egl > > > - gbm > > > - glx - seems sparse on updates, guessting you're followed in

Re: [Mesa-dev] NIR + softfp64 problem

2019-01-16 Thread Matt Turner
On Wed, Jan 16, 2019 at 3:53 AM Gert Wollny wrote: > > Hello, > > I'm trying to get soft-fp64 working with my experimental r600-nir > backend, and thanks to Dave's contribution it is already tied in, > some instructions are not yet supported by the backend, but when > running the piglits I have

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-16 Thread Matt Turner
On Fri, Jan 11, 2019 at 2:11 PM Matt Turner wrote: > > From: Gert Wollny > > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > NAKed-by: Ilia Mirkin > Acked-by: Eric Engestrom >

Re: [Mesa-dev] [PATCH v2 23/32] intel/isl: Allow Yf and Ys tiling

2019-01-16 Thread Nanley Chery
On Fri, Oct 12, 2018 at 01:46:53PM -0500, Jason Ekstrand wrote: > They are both implemented in ISL now. Instead of disabling them in ISL, > we disable them in the two dirvers. "drivers" is misspelled. > > Reviewed-by: Topi Pohjolainen > --- > src/intel/isl/isl_gen7.c | 8

Re: [Mesa-dev] [PATCH 5/5] radeonsi/nir: add missing pieces for bindless image/sampler support

2019-01-16 Thread Marek Olšák
A bindless handle is a temporary (coming from a shader input, UBO, SSBO, image, or inline constant), so the bindless code shouldn't have any awareness of where it's coming from. Patches 1-4: Reviewed-by: Marek Olšák Marek On Wed, Jan 9, 2019 at 3:54 AM Timothy Arceri wrote: > --- >

[Mesa-dev] [MR] Copy propagate direct access of vector elements

2019-01-16 Thread Caio Marcelo de Oliveira Filho
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/121 First teach copy_prop_vars not to do the wrong thing when it sees an array deref of a vector; then teach it how to read direct array derefs -- effectively treating them as a masked access to the full vector. Those cases don't happen now

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2019-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 andrew.m.mcma...@gmail.com changed: What|Removed |Added Depends on||109331 Referenced Bugs:

Re: [Mesa-dev] [PATCH v11 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-16 Thread Dylan Baker
Quoting Pierre Moreau (2019-01-16 12:30:37) > Changes since: > * v10: > - Add a new flag (`--enable-opencl-spirv` for autotools, and > `-Dopencl-spirv=true` for meson) for enabling SPIR-V support in > clover, and never automagically enable it without that flag. (Dylan Baker) > - When

[Mesa-dev] [PATCH v3 4/5] nv50/ir: use suld.p on GM107+

2019-01-16 Thread Rhys Perry
v3: rebase v3: move RA code into it's own function Signed-off-by: Rhys Perry --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 +++ .../nouveau/codegen/nv50_ir_emit_gm107.cpp| 34 --- .../drivers/nouveau/codegen/nv50_ir_print.cpp | 17 ++

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

2019-01-16 Thread Adam Jackson
On Wed, 2019-01-16 at 17:58 +, Strasser, Kevin wrote: > Adam Jackson wrote: > > > Probably what I'd do is only define those masks to non-zero for <=32bpp > > formats, > > Not sure if I understood this statement. Do you mean if we keep the _HI and > _LO > attributes, only make them valid

[Mesa-dev] [PATCH v3 3/5] st/mesa: add support for EXT_shader_image_load_formatted

2019-01-16 Thread Rhys Perry
v3: rebase Signed-off-by: Rhys Perry Reviewed-by: Marek Olšák (v2) --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 4628079260..b713eed969 100644 ---

[Mesa-dev] [PATCH v3 1/5] gallium: add support for formatted image loads

2019-01-16 Thread Rhys Perry
v3: rebase v3: make use of u_pipe_screen_get_param_defaults Signed-off-by: Rhys Perry --- src/gallium/auxiliary/util/u_screen.c | 1 + src/gallium/docs/source/screen.rst | 1 + src/gallium/drivers/nouveau/nv30/nv30_screen.c | 1 +

[Mesa-dev] [PATCH v3 0/5] nvc0: Implement EXT_shader_image_load_formatted

2019-01-16 Thread Rhys Perry
This patch series implements EXT_shader_image_load_formatted on Maxwell+. It should implement all of the spec except, if the extension is enabled, passing image variables without a format qualifier to atomic operations will not raise a compilation error like it should. This is because knowing

[Mesa-dev] [PATCH v3 5/5] nvc0, nv50/ir: enable support for formatted image loads on GM107+

2019-01-16 Thread Rhys Perry
v3: rebase Signed-off-by: Rhys Perry --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 3 +-- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c| 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v3 2/5] mesa, glsl: add support for EXT_shader_image_load_formatted

2019-01-16 Thread Rhys Perry
v3: rebase Signed-off-by: Rhys Perry Reviewed-by: Marek Olšák (v2) --- src/compiler/glsl/ast_to_hir.cpp | 5 + src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 7 +++ src/mesa/main/extensions_table.h | 1 +

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

2019-01-16 Thread Strasser, Kevin
Adam Jackson wrote: > On Wed, 2019-01-16 at 17:58 +, Strasser, Kevin wrote: > > Adam Jackson wrote: > > > > > Probably what I'd do is only define those masks to non-zero for <=32bpp > > > formats, > > > > Not sure if I understood this statement. Do you mean if we keep the _HI and > > _LO

Re: [Mesa-dev] NIR + softfp64 problem

2019-01-16 Thread Gert Wollny
Hello Matt, Am Mittwoch, den 16.01.2019, 10:17 -0800 schrieb Matt Turner: > any idea how to quell this would be very welcome. > > It's required to scalarize fp64 operations before this lowering code > will work. It looks to me like it's trying to call __fadd64 with a > dvec4 argument, when the

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::last_block

2019-01-16 Thread Eric Anholt
Marek Olšák writes: > From: "Jiang, Sonny" > > and add radeonsi support. This will be used by radeonsi internally. > > Signed-off-by: Sonny Jiang It's still strange to me to be proposing changes to gallium core with no users of the change. signature.asc Description: PGP signature

[Mesa-dev] [PATCH v11 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-16 Thread Pierre Moreau
Changes since: * v10: - Add a new flag (`--enable-opencl-spirv` for autotools, and `-Dopencl-spirv=true` for meson) for enabling SPIR-V support in clover, and never automagically enable it without that flag. (Dylan Baker) - When enabling the SPIR-V support, the SPIRV-Tools and

Re: [Mesa-dev] [PATCH 1/7] mesa: implement ARB/KHR_parallel_shader_compile

2019-01-16 Thread Marek Olšák
So is this an ack? Marek On Thu, Jan 3, 2019 at 2:41 PM Ian Romanick wrote: > On 1/3/19 11:40 AM, Ian Romanick wrote: > > On 11/28/18 6:59 PM, Marek Olšák wrote: > >> From: Marek Olšák > >> > >> Tested by piglit. > > > > It doesn't look like there are any piglit test > > Ignore that. I

[Mesa-dev] [PATCH demos] cmake: Search also for debug GLEW

2019-01-16 Thread Tuomo Rinne
Building debug GLEW using CMake adds a "d" postfix to the library name. This fix finds the libary with that convention too. Signed-off-by: Tuomo Rinne --- CMakeLists.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index

[Mesa-dev] [PATCH] radeonsi: disable render cond & pipeline stats for internal compute dispatches

2019-01-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute_blit.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute_blit.c b/src/gallium/drivers/radeonsi/si_compute_blit.c index c547d124507..bfc9fa4ece2 100644 ---

[Mesa-dev] [Bug 109258] Weston drm-backend.so seems to fail with Mesa master and LIBGL_ALWAYS_SOFTWARE=1

2019-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109258 --- Comment #4 from Daniel van Vugt --- mutter has the same issue with LIBGL_ALWAYS_SOFTWARE=1 in Ubuntu 19.04 right now. It just fails to start in a similar way. mutter version 3.30.2-4 says: (mutter:14910): mutter-WARNING **: 12:53:43.586:

Re: [Mesa-dev] [PATCH v3 5/5] nvc0, nv50/ir: enable support for formatted image loads on GM107+

2019-01-16 Thread Ilia Mirkin
Still some bits missing (I think from 4/5): NVC0LoweringPass::handleSurfaceOpGM107(TexInstruction *su) { processSurfaceCoordsGM107(su); if (su->op == OP_SULDP) { convertSurfaceFormat(su); insertOOBSurfaceOpResult(su); } and convertSurfaceFormat will unconditionally flip

Re: [Mesa-dev] [PATCH 5/5] radeonsi/nir: add missing pieces for bindless image/sampler support

2019-01-16 Thread Timothy Arceri
On 17/1/19 9:41 am, Marek Olšák wrote: A bindless handle is a temporary (coming from a shader input, UBO, SSBO, image, or inline constant), so the bindless code shouldn't have any awareness of where it's coming from. This is a far point, I should move this to nir_to_llvm where we know what

[Mesa-dev] [PATCH] intel/fs: Don't apply the des stride alignment rule to accumulators

2019-01-16 Thread Jason Ekstrand
The pass was discovered to cause problems with the MUL+MACH combination we emit for nir_[iu]mul_high. In an experimental branch of mine, I ran into issues where the MUL+MACH ended up using a strided source due to working on half of a uint64_t and the new lowering pass helpfully tried to fix the

[Mesa-dev] [Bug 109258] Weston drm-backend.so seems to fail with Mesa master and LIBGL_ALWAYS_SOFTWARE=1

2019-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109258 Daniel van Vugt changed: What|Removed |Added CC||daniel.van.vugt@canonical.c

Re: [Mesa-dev] [PATCH v3 2/5] mesa, glsl: add support for EXT_shader_image_load_formatted

2019-01-16 Thread Ilia Mirkin
On Wed, Jan 16, 2019 at 6:20 PM Rhys Perry wrote: > > v3: rebase > > Signed-off-by: Rhys Perry > Reviewed-by: Marek Olšák (v2) > --- > src/compiler/glsl/ast_to_hir.cpp | 5 + > src/compiler/glsl/glsl_parser_extras.cpp | 1 + > src/compiler/glsl/glsl_parser_extras.h | 7 +++ >

[Mesa-dev] [AppVeyor] mesa master #9771 completed

2019-01-16 Thread AppVeyor
Build mesa 9771 completed Commit a311aa631d by Tapani Pälli on 1/16/2019 12:15 PM: anv: do not advertise AHW support if extension not enabled\n\nFixes following failing vk-gl-cts cases on Linux desktop:\n\n

[Mesa-dev] [PATCH v2] wayland/egl: Ensure EGL surface is resized on DRI update_buffers()

2019-01-16 Thread Carlos Garnacho
Fullscreening and unfullscreening a totem window while playing a video sometimes results in the video subsurface not changing size along. This is also reproducible with epiphany. If a surface gets resized while we have an active back buffer for it, the resized dimensions won't get neither

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-16 Thread Erik Faye-Lund
On Fri, 2019-01-11 at 10:57 -0600, Jason Ekstrand wrote: > All, > > The mesa project has now hit 100 merge requests (36 are still open). > I (and I'm sure others) would be curious to hear people's initial > thoughts on the process. What's working well? What's not working? > Is it total fail

[Mesa-dev] [AppVeyor] mesa ahw-fix #9770 failed

2019-01-16 Thread AppVeyor
Build mesa 9770 failed Commit a311aa631d by Tapani Pälli on 1/16/2019 12:15 PM: anv: do not advertise AHW support if extension not enabled\n\nFixes following failing vk-gl-cts cases on Linux desktop:\n\n

[Mesa-dev] [PATCH 1/2] glsl: don't skip GLSL IR opts on first-time compiles

2019-01-16 Thread Timothy Arceri
This basically reverts c2bc0aa7b188. By running the opts we reduce memory using in Team Fortress 2 from 1.5GB -> 1.3GB from start-up to game menu. This will likely increase Deus Ex start up times as per commit c2bc0aa7b188. However currently 32bit games like Team Fortress 2 can run out of

[Mesa-dev] [PATCH 2/2] glsl: be much more aggressive when skipping shader compilation

2019-01-16 Thread Timothy Arceri
Currently only add a cache key for a shader once it is linked. However games like Team Fortress 2 compile a whole bunch of shaders which are never actually linked. These compiled shaders can take up a bunch of memory. This patch changes things so that we add the key for the shader to the cache as

Re: [Mesa-dev] [PATCH] intel/fs: Don't apply the des stride alignment rule to accumulators

2019-01-16 Thread Matt Turner
On Wed, Jan 16, 2019 at 8:40 PM Jason Ekstrand wrote: > > The pass was discovered to cause problems with the MUL+MACH combination > we emit for nir_[iu]mul_high. In an experimental branch of mine, I ran > into issues where the MUL+MACH ended up using a strided source due to > working on half of

[Mesa-dev] Double free error on etnaviv driver.

2019-01-16 Thread Nazarov Sergey
Hello! I use mesa+etnaviv Gallium driver on iMX6Q based board. I have double free error at the end of any application using mesa. I've found that the problem comes from current ARM g++ compilers (at least from 4.9.4 up to latest ones) which call static objects destructors before on_exit handler.

Re: [Mesa-dev] [PATCH] intel/fs: Promote execution type to 32-bit when any half-float conversion is needed.

2019-01-16 Thread Iago Toral
Tested-by: Iago Toral Quiroga Reviewed-by: Iago Toral Quiroga On Tue, 2019-01-15 at 23:31 -0800, Francisco Jerez wrote: > The docs are fairly incomplete and inconsistent about it, but this > seems to be the reason why half-float destinations are required to be > DWORD-aligned on BDW+ projects.

Re: [Mesa-dev] [PATCH] radv: prevent dirtying of dynamic state when it does not change

2019-01-16 Thread Samuel Pitoiset
I wrote a similar patch in the past but I didn't notice any improvements. Though, as we already check state changes in some other places, I think it's better to be consistent. With the TODO comment removed, patch is: Reviewed-by: Samuel Pitoiset On 1/15/19 10:59 PM, Rhys Perry wrote: DXVK