This fixes the world.
Fixes: 5f5ac19f138 ("radv: Implement VK_EXT_pipeline_creation_feedback.")"
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pipeline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_pipeline.c
On 20/03/2019 23:47, Axel Davy wrote:
On 20/03/2019 21:38, Andre Heider wrote:
iris is thread safe, enable csmt for a ~5% performace boost.
Signed-off-by: Andre Heider
---
src/gallium/state_trackers/nine/device9.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
What's the expected change in behavior? Does it fix any bugs?
Regards
//Ernst
Den ons 20 mars 2019 kl 16:42 skrev Liu, Leo :
>
> The wait here is unnecessary since we got a pool of back buffers,
> and the wait for swap buffer will happen before the present pixmap,
> at the same time the previous
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index b5bb399eef1..2c6fecb91db 100644
--- a/src/amd/common/ac_llvm_build.c
+++
doh, it seems I used reply-list instead of reply-all, sending again with
original author of the patch ..
On 3/21/19 9:14 AM, Tapani Pälli wrote:
Hello;
One *very late* comment below ..
On 10/23/18 6:38 PM, Nicholas Kazlauskas wrote:
Some programs start with the path and command line
Hello Bas,
sorry but your latest commit #5f5ac19f138
radv: Implement VK_EXT_pipeline_creation_feedback.
sigfault with every Vulkan apps for me.
Reverting it SOLVED it.
5f5ac19f138125b04d8ddedd6334b996f8925a4a is the first bad commit
commit 5f5ac19f138125b04d8ddedd6334b996f8925a4a
Author: Bas
Yeah, my bad... I have just sent a fix.
Thanks
On 3/21/19 7:22 AM, Dieter Nützel wrote:
Hello Bas,
sorry but your latest commit #5f5ac19f138
radv: Implement VK_EXT_pipeline_creation_feedback.
sigfault with every Vulkan apps for me.
Reverting it SOLVED it.
Hello;
One *very late* comment below ..
On 10/23/18 6:38 PM, Nicholas Kazlauskas wrote:
Some programs start with the path and command line arguments in
argv[0] (program_invocation_name). Chromium is an example of
an application using mesa that does this.
This tries to query the real path for
Samuel,
The get_reviewer script mentioned you as the reviewer for the src/amd/vulcan
directory. I was wondering
what is directly TODO. Don't know if that script is correct but if not I CCed
the list to let other's
chip in.
Cheers,
Nick
___
mesa-dev
r-b
On Thu, Mar 21, 2019 at 9:16 AM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_llvm_build.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
> index
On Thu, Mar 21, 2019 at 11:59 AM Samuel Pitoiset
wrote:
>
> This fixes the following LLVM error when ckeckir is set:
> Type too small for ZExt
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_nir_to_llvm.c | 33 +
> 1 file changed, 21 insertions(+),
On 2019-03-20 4:42 p.m., Liu, Leo wrote:
> The wait here is unnecessary since we got a pool of back buffers,
> and the wait for swap buffer will happen before the present pixmap,
> at the same time the previous back buffer will be put back to pool
> for reuse after the check for PresentIdleNotify
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 2 ++
src/amd/common/ac_llvm_build.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 2c6fecb91db..608f16a78f8 100644
---
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 608f16a78f8..8701d2ca43a 100644
--- a/src/amd/common/ac_llvm_build.c
+++
r-b for both.
On Thu, Mar 21, 2019 at 10:11 AM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_llvm_build.c | 2 ++
> src/amd/common/ac_llvm_build.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/src/amd/common/ac_llvm_build.c
On Tue, Mar 12, 2019 at 4:11 PM Józef Kucia wrote:
> src/mesa/main/get.c | 3 +++
> 1 file changed, 3 insertions(+)
Ping.
The patch fixes glGetIntegerv(GL_NUM_DEVICE_UUIDS_EXT, ...).
GL_NUM_DEVICE_UUIDS_EXT is implemented in the same way in
find_value_indexed().
On 3/21/19 11:09 AM, Bas Nieuwenhuizen wrote:
Honestly the zero tests is worrying me. This is a pretty big extension
and I have questions like:
to 16-bit loads + 16-bit ALU actually work together or have we been
silently relying on the fact there is always a ZExt cast after and
that did not
https://bugs.freedesktop.org/show_bug.cgi?id=110211
--- Comment #3 from Pierre Labastie ---
Thanks for the quick fix.
--
You are receiving this mail because:
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
On 2019-03-21 4:15 a.m., Ernst Sjöstrand wrote:
> What's the expected change in behavior?
The change will make vl_dri3_screen_texture_from_drawable() call not to
hold the pipeline. Because of the multiple of back buffers, we can get
the texture of the ongoing presented back buffer, and no
GLC/SLC are boolean.
This fixes the following LLVM error when checkir is set:
Intrinsic has incorrect argument type!
void (i32, <4 x i32>, i32, i32, i32, i32, i32, i32, i32, i32)*
@llvm.amdgcn.tbuffer.store.i32
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 8
1
https://bugs.freedesktop.org/show_bug.cgi?id=110211
--- Comment #5 from Dylan Baker ---
:(
Yes, I know how to fix it. Just need more code.
I'm on mobile, please excuse autocorrect fail.
On Thu, Mar 21, 2019, 04:34 wrote:
> *Comment # 4
https://bugs.freedesktop.org/show_bug.cgi?id=110216
Bug ID: 110216
Summary: radv: Segfault when compiling compute shaders from
Assassin's Creed Odyssey (regression, bisected)
Product: Mesa
Version: git
Hardware: Other
On 3/21/19 1:47 PM, Józef Kucia wrote:
On Tue, Mar 12, 2019 at 4:11 PM Józef Kucia wrote:
src/mesa/main/get.c | 3 +++
1 file changed, 3 insertions(+)
Ping.
The patch fixes glGetIntegerv(GL_NUM_DEVICE_UUIDS_EXT, ...).
GL_NUM_DEVICE_UUIDS_EXT is implemented in the same way in
On Thursday, 2019-03-21 09:14:15 +0200, Tapani Pälli wrote:
> Hello;
>
> One *very late* comment below ..
>
> On 10/23/18 6:38 PM, Nicholas Kazlauskas wrote:
> > Some programs start with the path and command line arguments in
> > argv[0] (program_invocation_name). Chromium is an example of
> >
https://bugs.freedesktop.org/show_bug.cgi?id=106151
--- Comment #32 from Samuel Pitoiset ---
Does this still happen with mesa 19.0 ?
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
https://bugs.freedesktop.org/show_bug.cgi?id=110216
Timothy Arceri changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Timothy
https://bugs.freedesktop.org/show_bug.cgi?id=110216
Timothy Arceri changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
This fixes the following LLVM error when ckeckir is set:
Type too small for ZExt
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 33 +
1 file changed, 21 insertions(+), 12 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c
https://bugs.freedesktop.org/show_bug.cgi?id=110211
--- Comment #4 from Rafael Castillo ---
Hi, dylan your patch broke ArchLinux PKGBUILD for mesa since your patch for
some reason bypass fakeinstall paths and try to install directly in /usr/lib,
any suggestions?
--
You are receiving this mail
Should be safe to enable as all instructions seem to support 16-bit.
Unfortunately, there is no CTS test.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_extensions.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/amd/vulkan/radv_extensions.py
Honestly the zero tests is worrying me. This is a pretty big extension
and I have questions like:
to 16-bit loads + 16-bit ALU actually work together or have we been
silently relying on the fact there is always a ZExt cast after and
that did not care about input size?
On Thu, Mar 21, 2019 at
r-b
On Thu, Mar 21, 2019 at 12:41 PM Samuel Pitoiset
wrote:
>
> GLC/SLC are boolean.
>
> This fixes the following LLVM error when checkir is set:
> Intrinsic has incorrect argument type!
> void (i32, <4 x i32>, i32, i32, i32, i32, i32, i32, i32, i32)*
> @llvm.amdgcn.tbuffer.store.i32
>
>
Report 320 for a6xx, which isn't *quite* true (no geom/tess, in
particular), but other caps keep the reported GL and GLSL versions
correct (3.1 / 3.10 es). But reporting 320 will switch on
EXT_gpu_shader5, which is the goal.
Signed-off-by: Rob Clark
---
Adds a new cap to allow drivers to expose higher shading language
versions in GLES contexts, to avoid having to report an artificially
low version for the benefit of GL contexts.
The motivation is to expose EXT_gpu_shader5 even though a driver may
not support all the features needed for the
For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a
sufficiently high ESSL feature level, even if the GLSL feature level
isn't high enough.
This allows drivers to support EXT_gpu_shader5 in GLES contexts before
they support all the additional features of ARB_gpu_shader5 in GL
On Thu, Mar 21, 2019 at 1:24 PM Tapani Pälli wrote:
> Yeah, checked that value matches of find_value_indexed;
>
> Reviewed-by: Tapani Pälli
I don't have commits rights. Please push the patch for me.
> Does this affect 'ext_semaphore-api-errors' Piglit test that calls this
> in any way?
No.
Reviewed-by: Alok Hota l
> -Original Message-
> From: Vinson Lee [mailto:v...@freedesktop.org]
> Sent: Monday, March 18, 2019 2:11 PM
> To: Kyriazis, George ; Hota, Alok
>
> Cc: Philip Meulengracht ; mesa-
> d...@lists.freedesktop.org
> Subject: [PATCH] swr: Fix build with llvm-9.0.
>
>
On Thu, Mar 21, 2019 at 10:09 AM Ilia Mirkin wrote:
>
> On Thu, Mar 21, 2019 at 9:55 AM Rob Clark wrote:
> >
> > For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a
> > sufficiently high ESSL feature level, even if the GLSL feature level
> > isn't high enough.
> >
> > This allows
https://bugs.freedesktop.org/show_bug.cgi?id=110211
--- Comment #8 from Pierre Labastie ---
(In reply to Benoit Pierre from comment #6)
> Created attachment 143747 [details] [review]
> fix DESTDIR handling in install_megadrivers.py
>
> This how I fixed it locally. I only tested the PKGBUILD on
https://bugs.freedesktop.org/show_bug.cgi?id=110211
Dylan Baker changed:
What|Removed |Added
Resolution|FIXED |---
Status|RESOLVED
https://bugs.freedesktop.org/show_bug.cgi?id=110211
--- Comment #10 from Luke A. Guest ---
(In reply to Dylan Baker from comment #9)
> ---
> if os.path.isabs(args.libdir):
> destdir=os.environ.get('DESTDIR','')
> if len(destdir) == 0:
> destdir = '/'
> to =
All four patches look good to me
Reviewed-by: Brian Paul
On 03/20/2019 10:16 PM, Dave Airlie wrote:
From: Dave Airlie
These didn't deal with the width == 32 case that TGSI is defined with.
Fixes piglit tests if ARB_gpu_shader5 is enabled.
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 14
On Thu, Mar 21, 2019 at 10:18 AM Rob Clark wrote:
>
> On Thu, Mar 21, 2019 at 10:09 AM Ilia Mirkin wrote:
> >
> > On Thu, Mar 21, 2019 at 9:55 AM Rob Clark wrote:
> > >
> > > For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a
> > > sufficiently high ESSL feature level, even if
On Thu, Mar 21, 2019 at 9:55 AM Rob Clark wrote:
>
> For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a
> sufficiently high ESSL feature level, even if the GLSL feature level
> isn't high enough.
>
> This allows drivers to support EXT_gpu_shader5 in GLES contexts before
> they
https://bugs.freedesktop.org/show_bug.cgi?id=110211
--- Comment #7 from Denis ---
agree, also faced with this issue. Reproduced it on Ubuntu 18.04 and Manjaro.
--
You are receiving this mail because:
You are the QA Contact for the bug.___
mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=110211
--- Comment #11 from Dylan Baker ---
Have a look at this MR, which is basically the same patch with some style
cleanups:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/505
--
You are receiving this mail because:
You are the QA
On Thu, Mar 21, 2019 at 2:19 PM Ilia Mirkin wrote:
>
> On Thu, Mar 21, 2019 at 1:45 PM Rob Clark wrote:
> >
> > For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a
> > sufficiently high ESSL feature level, even if the GLSL feature level
> > isn't high enough.
> >
> > This allows
I've just put up a new repo that I'm hoping to use to enable automatic
shader-db results for various drivers on Gitlab CI merge requests (and
maybe with some more work, delete the simulator backends of vc4 and v3d).
https://gitlab.freedesktop.org/anholt/drm-shim
I've copied a bit of Mesa stuff
https://bugs.freedesktop.org/show_bug.cgi?id=110211
--- Comment #6 from Benoit Pierre ---
Created attachment 143747
--> https://bugs.freedesktop.org/attachment.cgi?id=143747=edit
fix DESTDIR handling in install_megadrivers.py
This how I fixed it locally. I only tested the PKGBUILD on Arch
On 3/21/19 4:03 PM, Józef Kucia wrote:
On Thu, Mar 21, 2019 at 1:24 PM Tapani Pälli wrote:
Yeah, checked that value matches of find_value_indexed;
Reviewed-by: Tapani Pälli
I don't have commits rights. Please push the patch for me.
sure
Does this affect 'ext_semaphore-api-errors'
For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a
sufficiently high ESSL feature level, even if the GLSL feature level
isn't high enough.
This allows drivers to support EXT_gpu_shader5 in GLES contexts before
they support all the additional features of ARB_gpu_shader5 in GL
On Thu, Mar 21, 2019 at 1:45 PM Rob Clark wrote:
>
> For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a
> sufficiently high ESSL feature level, even if the GLSL feature level
> isn't high enough.
>
> This allows drivers to support EXT_gpu_shader5 in GLES contexts before
> they
Reviewed-by: Ilia Mirkin
On Thu, Mar 21, 2019 at 9:55 AM Rob Clark wrote:
>
> Adds a new cap to allow drivers to expose higher shading language
> versions in GLES contexts, to avoid having to report an artificially
> low version for the benefit of GL contexts.
>
> The motivation is to expose
Reviewed-by: Ilia Mirkin
Thanks for bearing with my nits.
On Thu, Mar 21, 2019 at 2:43 PM Rob Clark wrote:
>
> For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a
> sufficiently high ESSL feature level, even if the GLSL feature level
> isn't high enough.
>
> This allows drivers
On 2019-03-20 1:56 p.m., Michel Dänzer wrote:
> On 2019-03-20 4:42 p.m., Liu, Leo wrote:
>> The wait here is unnecessary since we got a pool of back buffers,
>> and the wait for swap buffer will happen before the present pixmap,
>> at the same time the previous back buffer will be put back to
For GLES2+ contexts, enable EXT_gpu_shader5 if the driver exposes a
sufficiently high ESSL feature level, even if the GLSL feature level
isn't high enough.
This allows drivers to support EXT_gpu_shader5 in GLES contexts before
they support all the additional features of ARB_gpu_shader5 in GL
https://bugs.freedesktop.org/show_bug.cgi?id=110211
--- Comment #12 from Pierre Labastie ---
I told you I was not a Python geek :) The MR seems to work in all cases I can
imagine (unset DESTDIR, empty DESTDIR, DESTDIR set to non-empty) when
abs.libdir starts with '/' (sorry if this is not the
When we destroy a context, we need to temporarily make that context
the current one for the thread.
That's because during context tear-down we make many calls to
_mesa_reference_texobj(, NULL). Note there's no context
parameter. If the texture's refcount goes to zero and we need to
delete it,
Reviewed-by: Jason Ekstrand
On Thu, Mar 21, 2019 at 8:20 PM Brian Paul wrote:
> ---
> src/compiler/nir_types.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp
> index aff575c..3bf93c5 100644
> ---
---
src/compiler/nir_types.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp
index aff575c..3bf93c5 100644
--- a/src/compiler/nir_types.cpp
+++ b/src/compiler/nir_types.cpp
@@ -690,7 +690,7 @@
Am 21.03.19 um 05:16 schrieb Dave Airlie:
> From: Dave Airlie
>
> Fixes piglits if ARB_gpu_shader5 is enabled
> ---
> src/gallium/auxiliary/tgsi/tgsi_exec.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c
>
The world is saved...
you rocket man!
Greetings.
Dieter
Am 21.03.2019 09:00, schrieb Samuel Pitoiset:
Yeah, my bad... I have just sent a fix.
Thanks
On 3/21/19 7:22 AM, Dieter Nützel wrote:
Hello Bas,
sorry but your latest commit #5f5ac19f138
radv: Implement
Fix this build error with GCC 4.4.7.
CC nir/nir_opt_copy_prop_vars.lo
nir/nir_opt_copy_prop_vars.c: In function ‘load_element_from_ssa_entry_value’:
nir/nir_opt_copy_prop_vars.c:454: error: unknown field ‘ssa’ specified in
initializer
nir/nir_opt_copy_prop_vars.c:455: error: unknown field
Thanks for the fix!
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, March 21, 2019 6:19 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH] st/mesa: fix texture deletion context mix-up issues
When we destroy
On 3/21/19 12:02 PM, Eric Engestrom wrote:
On Thursday, 2019-03-21 09:14:15 +0200, Tapani Pälli wrote:
Hello;
One *very late* comment below ..
On 10/23/18 6:38 PM, Nicholas Kazlauskas wrote:
Some programs start with the path and command line arguments in
argv[0] (program_invocation_name).
65 matches
Mail list logo
