Re: [Mesa-dev] [PATCH] gallivm: Translate all util_cpu_caps bits to LLVM attributes.

2015-10-21 Thread Gustaw Smolarczyk
I am just a bystander, but I have one suggestion to this patch. 2015-10-21 18:25 GMT+02:00 Jose Fonseca : > This should prevent disparity between features Mesa and LLVM > believe are supported by the CPU. > > http://lists.freedesktop.org/archives/mesa-dev/2015-October/thread.html#96990 > > Tested

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

2017-02-07 Thread Gustaw Smolarczyk
2017-02-07 14:11 GMT+01:00 Eero Tamminen : > Hi, > > On 06.02.2017 22:26, Samuel Pitoiset wrote: >> >> On 02/06/2017 04:45 PM, Eero Tamminen wrote: >>> >>> Results from quick try on Ubuntu 16.04 with today's version of the game >>> (ARK: Survival Evolved)... >>> >>> With (Ubuntu 16.04 default) Mesa

Re: [Mesa-dev] [PATCH 2/3] radv/ac: use shader umsb helper.

2017-02-16 Thread Gustaw Smolarczyk
I think you meant "shared" and not "shader" in the first line of the commit message. Gustaw 16 lut 2017 04:55 "Dave Airlie" napisał(a): From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-)

Re: [Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

2017-02-20 Thread Gustaw Smolarczyk
2017-02-20 11:19 GMT+01:00 Edward O'Callaghan : > > On 02/20/2017 09:15 PM, Edward O'Callaghan wrote: >> The name has become a little misleading now that it applies >> to both r600g and radeonsi. >> >> V.2: Michel Dänzer - R600_DEBUG must continue to work. >> >> Signed-off-by: Edward O'Callaghan >

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

2017-02-21 Thread Gustaw Smolarczyk
21 lut 2017 03:47 "Jason Ekstrand" napisał(a): Fine by me Reviewed-by: Jason Ekstrand On Mon, Feb 20, 2017 at 6:26 PM, Dave Airlie wrote: > From: Dave Airlie > > For prime support I need to access this, so move it in advance. > > Signed-off-by: Dave Airlie > --- > src/vulkan/wsi/wsi_commo

[Mesa-dev] About "freedreno/a4xx: MRT support"

2015-08-05 Thread Gustaw Smolarczyk
Hi Rob, I recreationally looked at your recent patch set and saw that you left the comment above "#define MAX_RENDER_TARGETS" in 054526e49abb5e7fd49fed6f589cff6f1ab4c9f6. I think you intended to remove this comment after this delivery. If I am wrong, please disregard this message. Regards, Gusta

Re: [Mesa-dev] [PATCH V2] docs: Update with GLES3.2 entries and status

2015-08-12 Thread Gustaw Smolarczyk
Hello. I've just spotted a simple typo. 2015-08-12 15:07 GMT+02:00 Thomas Helland : > > V2: -Change to "not started" for most entries > -Add status for multisample_2d_array > -Change shader_multisample_interpolation to "not_stared" > > Signed-off-by: Thomas Helland > Reviewed-by: Tapani P

Re: [Mesa-dev] [PATCH 8/9] gallium/radeon: implement get_query_result_resource

2016-09-16 Thread Gustaw Smolarczyk
2016-09-16 15:57 GMT+02:00 Nicolai Hähnle : > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 3 + > src/gallium/drivers/radeon/r600_pipe_common.h | 2 + > src/gallium/drivers/radeon/r600_query.c | 391 > +- > src/gallium/drivers/r

Re: [Mesa-dev] Error when trying to compile RADV

2016-10-01 Thread Gustaw Smolarczyk
Hello, I might not be an expert, but it seems that the build system failed to locate radeon_llvm_check function. I heard somewhere on this list that there is currently a problem with it being used before it's defined. I think you will need to modify configure.ac and move it from line 2323 to, e.g.

Re: [Mesa-dev] Error when trying to compile RADV

2016-10-01 Thread Gustaw Smolarczyk
I don't think your fix with the symlinks is correct. You've just worked-around one part of the problem (missing include directories) leaving the total lack of detection of llvm alone. Now you lack the HAVE_LLVM define that should be automatically created by the build system if it recognizes llvm co

Re: [Mesa-dev] [PATCH 4/4] radv: toplevel configure/make changes required to build (v1.1)

2016-10-05 Thread Gustaw Smolarczyk
2016-10-05 2:48 GMT+02:00 Dave Airlie : > From: Dave Airlie > > This moves some of the llvm checks around to allow them > to be used for non-gallium drivers as well. > > radv requires llvm 3.9.0 as vulkan requires compute shaders. > > v1.1: add all make infrastructure to this patch for easier > re

[Mesa-dev] radv vs vulkan loader

2016-10-05 Thread Gustaw Smolarczyk
Hello, I have encountered a following problem while trying to use radv through LunarG's vulkan loader. It seems that the loader dlopens() the ICD library twice. First, it looks up "vk_icdNegotiateLoaderICDInterfaceVersion" symbol, which seems to be the new mechanism used to determine the version

Re: [Mesa-dev] [PATCH 4/4] radv: toplevel configure/make changes required to build (v1.1)

2016-10-05 Thread Gustaw Smolarczyk
XCB_DRI3, but it's only set when building GLX with DRI3 enabled. 2016-10-05 21:58 GMT+02:00 Gustaw Smolarczyk : > 2016-10-05 2:48 GMT+02:00 Dave Airlie : >> From: Dave Airlie >> >> This moves some of the llvm checks around to allow them >> to be used for non-gal

Re: [Mesa-dev] radv vs vulkan loader

2016-10-05 Thread Gustaw Smolarczyk
2016-10-06 0:05 GMT+02:00 Emil Velikov : > On 5 October 2016 at 21:45, Gustaw Smolarczyk wrote: >> Hello, >> >> I have encountered a following problem while trying to use radv >> through LunarG's vulkan loader. >> >> It seems that the loader dlopens()

[Mesa-dev] [PATCH 0/2] Quick radv fixes.

2016-10-05 Thread Gustaw Smolarczyk
Hello, I understand that radv has not been merged yet, but I wanted to publish my 2 patches that make the LunarG's Hologram sample work on SI. If you decide to merge my patches, please push them yourself as I don't possess appropriate access. Regards, Gustaw Gustaw Smolarczyk (2):

[Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument.

2016-10-05 Thread Gustaw Smolarczyk
It's supposed to be how much at least we want to grow the cs, not the minimum size of the cs after growth. --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/

[Mesa-dev] [PATCH 1/2] radv: Skip already signalled fences.

2016-10-05 Thread Gustaw Smolarczyk
If the user created a fence with VK_FENCE_CREATE_SIGNALED_BIT set, we shouldn't fail to wait for a fence if it was not submitted since that is not necessary. --- src/amd/vulkan/radv_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/sr

[Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-06 Thread Gustaw Smolarczyk
It's supposed to be how much at least we want to grow the cs, not the minimum size of the cs after growth. v2: Unbreak use_ib_bos. Don't mask the ib_size when !use_ib_bos, since it's not needed. --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 11 +++ 1 file changed, 7 insertions(+

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Gustaw Smolarczyk
Ping. 2016-10-06 19:50 GMT+02:00 Gustaw Smolarczyk : > It's supposed to be how much at least we want to grow the cs, not the > minimum size of the cs after growth. > > v2: Unbreak use_ib_bos. > Don't mask the ib_size when !use_ib_bos, since it's not needed.

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-10 Thread Gustaw Smolarczyk
your time. Regards, Gustaw > > Yours sincerely, > Bas Nieuwenhuizen > > > On Oct 10, 2016 1:22 PM, "Gustaw Smolarczyk" wrote: >> >> Ping. >> >> 2016-10-06 19:50 GMT+02:00 Gustaw Smolarczyk : >> > It's supposed to be how much a

[Mesa-dev] [PATCH] radv/winsys: Fail early on overgrown cs.

2016-10-13 Thread Gustaw Smolarczyk
When !use_ib_bos, we can't easily chain ibs one to another. If the required cs size grows over 1Mi - 8 dwords just fail the cs so that we won't assert-fail in radv_amdgpu_winsys_cs_submit later on. --- Please, push the patch after it has been reviewed. src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.

Re: [Mesa-dev] [PATCH] vbo: increase VBO_SAVE_BUFFER_SIZE from 8k to 256k dwords

2016-08-18 Thread Gustaw Smolarczyk
Hi, Will this help Minecraft? I believe it currently uses VBOs (if they are enabled) and display lists. I might test it when I'm home next week. Regards, Gustaw Smolarczyk 2016-08-18 7:26 GMT+02:00 Mathias Fröhlich : > Hi, > > On Wednesday, 17 August 2016 11:00:48 CEST Ti

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

2016-09-06 Thread Gustaw Smolarczyk
executes a jump without any branch prediction data cached for it, it assumes that it doesn't jump. 2. Move the unlikely parts of code outside of a function or to the end of a function. That increases instruction cache and fetch usage for likely code. In the end, it would be best to measure

Re: [Mesa-dev] [PATCH 2/3] nir: add conditional discard optimisation

2016-11-03 Thread Gustaw Smolarczyk
I am not really that much familiar with nir, so I apologize if what I write below is wrong. What if we had something like: a = 0; if (x) { discard_if(y); a = 1; } Then if (x && !y), we must not discard and both at the same time set a to 1. Your transformation would probably change it to: a

Re: [Mesa-dev] [PATCH] radv: fix GetFenceStatus for signaled fences

2016-11-09 Thread Gustaw Smolarczyk
Looks like a follow-up to 24815bd7b3b50d2e634b56ca607856ecf08ec4ee Note sure if my rb is helpful, but: Reviewed-by: Gustaw Smolarczyk 2016-11-09 8:43 GMT+01:00 Bas Nieuwenhuizen : > Reviewed-by: Bas Nieuwenhuizen > > On Wed, Nov 9, 2016 at 2:22 AM, Dave Airlie wrote: > > Fr

Re: [Mesa-dev] [PATCH] mesa: if MESA_DEBUG=context, create a debug context

2016-11-17 Thread Gustaw Smolarczyk
2016-11-16 0:05 GMT+01:00 Brian Paul : > A number of drivers report useful debug/perf information accessible > through GL_ARB_debug_output and with debug contexts (i.e. setting the > GLX_CONTEXT_DEBUG_BIT_ARB flag). But few applications actually use > the GL_ARB_debug_output extension. > > This c

Re: [Mesa-dev] [PATCH] [rfc] radv: add initial prime support.

2016-11-23 Thread Gustaw Smolarczyk
2016-11-23 6:28 GMT+01:00 Dave Airlie : > From: Dave Airlie > > This is kind of a gross hacks, but vulkan doesn't specify anything > but it would be nice to let people with prime systems at least > see some stuff rendering for now. > > This creates a linear shadow image in GART that gets blitted

Re: [Mesa-dev] Mesa 13.0.2 release candidate

2016-11-24 Thread Gustaw Smolarczyk
2016-11-24 18:25 GMT+01:00 Emil Velikov : > Hello list, > > The candidate for the Mesa 13.0.2 is now available. Currently we have: > - 49 queued > - 4 nominated (outstanding) > - and 1 rejected patch(es) > > > With this series we have - fixes for vc4, i965 and radeon drivers. In > addition > to

Re: [Mesa-dev] [PATCH 05/10] radeonsi: check for sampler state CSO corruption

2016-12-02 Thread Gustaw Smolarczyk
2016-12-02 21:39 GMT+01:00 Marek Olšák : > From: Marek Olšák > > It really happens. > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 1 + > src/gallium/drivers/radeonsi/si_pipe.h| 3 +++ > src/gallium/drivers/radeonsi/si_state.c | 5 + > 3 files changed, 9 insertions(+)

[Mesa-dev] [PATCH] configure: Strip LLVMX86Asm* dependencies.

2016-12-04 Thread Gustaw Smolarczyk
They are picked automatically by the provided llvm-config flags, but are not needed. Fixes loading radv through a vulkan loader. Cc: 13.0 --- It's work-around for: https://lists.freedesktop.org/archives/mesa-dev/2016-October/130765.html Since there are other people than me dealing with this is

Re: [Mesa-dev] [PATCH v2 2/4] nir: Add foreach_register helper macros

2016-12-15 Thread Gustaw Smolarczyk
15 gru 2016 18:19 "Jason Ekstrand" napisał(a): --- src/compiler/nir/nir.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f1c99ce..4a9fe65 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -373,6 +373,11 @@ typedef s

Re: [Mesa-dev] [PATCH v2 4/4] nir: Rewrite lower_regs_to_ssa to use the phi builder

2016-12-15 Thread Gustaw Smolarczyk
15 gru 2016 18:19 "Jason Ekstrand" napisał(a): This keeps some of Connor's original code. However, while I was at it, I updated this very old pass to a bit more modern NIR. --- src/compiler/nir/nir_lower_regs_to_ssa.c | 582 --- 1 file changed, 155 insertions(+), 427

Re: [Mesa-dev] radv vs vulkan loader

2016-12-16 Thread Gustaw Smolarczyk
2016-12-16 14:50 GMT+01:00 Emil Velikov : > On 5 October 2016 at 23:12, Gustaw Smolarczyk > wrote: > > 2016-10-06 0:05 GMT+02:00 Emil Velikov : > >> On 5 October 2016 at 21:45, Gustaw Smolarczyk > wrote: > >>> Hello, > >>> > >>> I h

Re: [Mesa-dev] radv vs vulkan loader

2016-12-16 Thread Gustaw Smolarczyk
2016-12-16 17:57 GMT+01:00 Emil Velikov : > On 16 December 2016 at 15:27, Gustaw Smolarczyk wrote: >> 2016-12-16 14:50 GMT+01:00 Emil Velikov : >>> >>> On 5 October 2016 at 23:12, Gustaw Smolarczyk >>> wrote: >>> > 2016-10-06 0:05 GMT+02:00

Re: [Mesa-dev] radv vs vulkan loader

2016-12-16 Thread Gustaw Smolarczyk
2016-12-16 18:12 GMT+01:00 Gustaw Smolarczyk : > 2016-12-16 17:57 GMT+01:00 Emil Velikov : >> On 16 December 2016 at 15:27, Gustaw Smolarczyk wrote: >>> 2016-12-16 14:50 GMT+01:00 Emil Velikov : >>>> >>>> On 5 October 2016 at 23:12, Gustaw Smolarczyk &g

Re: [Mesa-dev] [PATCH] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-20 Thread Gustaw Smolarczyk
2016-12-20 6:32 GMT+01:00 Jason Ekstrand : > This sequence shows up The Talos Principal, at least under Vulkan, > and prevents loop analysis from properly computing trip counts in a > few loops. > --- > src/compiler/nir/nir_opt_algebraic.py | 8 > 1 file changed, 8 insertions(+) > > diff

Re: [Mesa-dev] [PATCH] mesa/st: reduce size of state->st bitmask

2016-07-14 Thread Gustaw Smolarczyk
2016-07-14 22:14 GMT+02:00 Rob Clark : > In d035d50 this changed to 64b.. which I'm pretty sure was > unintentional. Revert it back to 32b so the entire state struct > is a nice round 64b (cache-line size). Actually, cache line size, at least on most x86 and ARM processors, is 64B (bytes) not 64b

Re: [Mesa-dev] [PATCH 2/7] gallium/auxiliary: Add u_bitcast.h header.

2016-07-29 Thread Gustaw Smolarczyk
: http://dbp-consulting.com/tutorials/StrictAliasing.html Look especially at footnote 85 of 6.5.2.3. Regards, Gustaw Smolarczyk 2016-07-29 15:22 GMT+02:00 Roland Scheidegger : > Am 29.07.2016 um 06:55 schrieb Connor Abbott: >> On Thu, Jul 28, 2016 at 7:58 PM, Roland Scheidegger >>

Re: [Mesa-dev] [PATCH] radv: fix compiler issues with GCC 9

2019-02-11 Thread Gustaw Smolarczyk
FWIW, Reviewed-by: Gustaw Smolarczyk pon., 11 lut 2019 o 10:15 Samuel Pitoiset napisał(a): > > "The C standard says that compound literals which occur inside of > the body of a function have automatic storage duration associated > with the enclosing block. Older GCC releases

[Mesa-dev] Hang in dri3_wait_for_event

2016-01-08 Thread Gustaw Smolarczyk
, Gustaw Smolarczyk [1] https://bugs.freedesktop.org/show_bug.cgi?id=84252 [2] https://bugs.freedesktop.org/show_bug.cgi?id=81623 [3] https://bugs.freedesktop.org/show_bug.cgi?id=90202 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] Hang in dri3_wait_for_event

2016-01-08 Thread Gustaw Smolarczyk
Hi. 2016-01-08 18:11 GMT+01:00 Martin Peres : > On 08/01/16 18:37, Gustaw Smolarczyk wrote: >> >> Hello, >> >> There are already quite a few bug reports[1][2][3] related to thread >> hang when DRI3 is enabled. The problem still exists, at least for me. >> S

Re: [Mesa-dev] Hang in dri3_wait_for_event

2016-01-10 Thread Gustaw Smolarczyk
18:44 GMT+01:00 Gustaw Smolarczyk : > Hi. > > 2016-01-08 18:11 GMT+01:00 Martin Peres : >> On 08/01/16 18:37, Gustaw Smolarczyk wrote: >>> >>> Hello, >>> >>> There are already quite a few bug reports[1][2][3] related to thread >>> han

[Mesa-dev] radeonsi: "Warning: Compiler emitted unknown config register: 0x286d0"

2016-01-14 Thread Gustaw Smolarczyk
about? Should I file a bug? I am using mesa from git and llvm from svn (currently 3.9.0svn), both compiled an hour ago. Regards, Gustaw Smolarczyk ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Print "LLVM emitted unknown config register" warning only once

2016-01-15 Thread Gustaw Smolarczyk
Hi Michel. What will happen if there are 2 different uknown registers? With this patch, only the first one will be shown. Gustaw Smolarczyk 2016-01-15 10:23 GMT+01:00 : > This series is, > > Reviewed-by: Edward O'Callaghan > > > On 2016-01-15 14:23, Michel Dänzer wr

Re: [Mesa-dev] [PATCH 3/3] st/mesa: don't allocate bitmap drawing state until needed

2016-02-08 Thread Gustaw Smolarczyk
b/src/mesa/state_tracker/st_cb_bitmap.h > @@ -42,9 +42,6 @@ extern void > st_init_bitmap_functions(struct dd_function_table *functions); > > extern void > -st_init_bitmap(struct st_context *st); > - > -extern void > st_destroy_bitmap(struct st_context *st); > > extern void > diff --git a/src/mesa/state_tracker/st_context.c > b/src/mesa/state_tracker/st_context.c > index 446ebfb..9016846 100644 > --- a/src/mesa/state_tracker/st_context.c > +++ b/src/mesa/state_tracker/st_context.c > @@ -231,7 +231,6 @@ st_create_context_priv( struct gl_context *ctx, struct > pipe_context *pipe, > st->cso_context = cso_create_context(pipe); > > st_init_atoms( st ); > - st_init_bitmap(st); > st_init_clear(st); > st_init_draw( st ); > st_init_pbo_upload(st); > -- > 1.9.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Regards, Gustaw Smolarczyk ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] EXT/ARB direct state access extensions

2014-11-15 Thread Gustaw Smolarczyk
Hello all, I would like to ask what is the status of DSA (direct state access) extensions in mesa. If I understand correctly, there was a GSoC project by Dylan Noblesmith and there currently is a dsa branch in mesa repo, but it's not actively worked on at the moment. Is there any particular reason

Re: [Mesa-dev] EXT/ARB direct state access extensions

2014-11-16 Thread Gustaw Smolarczyk
15, 2014 10:42:47 PM Gustaw Smolarczyk wrote: >> Hello all, >> >> I would like to ask what is the status of DSA (direct state access) >> extensions in mesa. If I understand correctly, there was a GSoC >> project by Dylan Noblesmith and there currently is a dsa branch in &g

[Mesa-dev] The ARB_shader_subroutine extension

2014-11-16 Thread Gustaw Smolarczyk
Hello once again, This time, I would like to ask about the shader subroutine extension. I believe this extension is not very popular, but is still needed for GL4 compliance. What is the reason for its unpopularity? Is it because one needs to reset subroutine uniform values after any glUse*? Or it

Re: [Mesa-dev] The ARB_shader_subroutine extension

2014-11-18 Thread Gustaw Smolarczyk
given draw, so that renderings with simple shaders wouldn't be penalized by the artificial register pressure caused by the dynamically unused paths. But I guess, the hardware is unable to implement such a feature. 2014-11-18 19:51 GMT+01:00 Ian Romanick : > On 11/16/2014 08:31 AM, Gustaw Smo

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-03 Thread Gustaw Smolarczyk
2016-06-03 12:52 GMT+02:00 Marek Olšák : > From: Marek Olšák > > Simply ignore the "scanout" flag if the surface dimensions are unlikely > to be used by DCE. > > This enables DCC for all X pixmaps that are not on the list of displayable > dimensions. > > Also ignore the "scanout" flag for non-2D,

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

2017-05-19 Thread Gustaw Smolarczyk
2017-05-18 23:01 GMT+02:00 Jason Ekstrand : > --- > src/intel/vulkan/anv_device.c | 42 -- > 1 file changed, 36 insertions(+), 6 deletions(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 6ea8dfe..8eed7f3 100644 > ---

Re: [Mesa-dev] [PATCH 09/21] mesa: add validate_stencil_buffer() helper

2017-06-01 Thread Gustaw Smolarczyk
This time, send it to the list too. Gustaw 1 cze 2017 15:45 "Gustaw Smolarczyk" napisał(a): 1 cze 2017 15:07 "Samuel Pitoiset" napisał(a): Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 111 +++--- - 1 file ch

Re: [Mesa-dev] [PATCH 10/21] mesa: add validate_depth_buffer() helper

2017-06-01 Thread Gustaw Smolarczyk
Same problem as in the previous patch. Regards, Gustaw 1 cze 2017 15:07 "Samuel Pitoiset" napisał(a): Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 105 +++--- - 1 file changed, 56 insertions(+), 49 deletions(-) diff --git a/src/mesa/m

Re: [Mesa-dev] [PATCH] gallium/util: Allow pipe_resource_reference to be inlined again

2017-06-13 Thread Gustaw Smolarczyk
2017-06-13 12:07 GMT+02:00 Michel Dänzer : > On 13/06/17 06:51 PM, Timothy Arceri wrote: >> On 13/06/17 19:22, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> It calling itself recursively prevented it from being inlined, resulting >>> in a copy being generated in every compilation unit refer

[Mesa-dev] AMD Tahiti: A question about PFP firmware

2017-07-22 Thread Gustaw Smolarczyk
Hello, While looking at the extension list on my Tahiti GPU (SI) I have found that ARB_draw_parameters is missing. Looking at the code, it requires ME firmware version >= 87 and PFP firmware version >= 121. While the first is satisfied, the second is not [1]. I believe I use the newest TAHITI firm

Re: [Mesa-dev] AMD Tahiti: A question about PFP firmware

2017-07-24 Thread Gustaw Smolarczyk
$ ./piglit run gpu -t arb_draw_indirect results/indirect --dmesg [12/12] pass: 11, fail: 1 Thank you for running Piglit! Results have been written to /home/bigos/src/piglit/results/indirect The only one failing is spec/arb_draw_indirect/arb_draw_indirect-draw-arrays-prim-restart. However, it is al

Re: [Mesa-dev] [PATCH v2] glsl: update the extensions that are enabled for 460

2017-08-02 Thread Gustaw Smolarczyk
2017-08-02 20:57 GMT+02:00 Samuel Pitoiset : > Other ones are either unsupported or don't have any helper > function checks. > > v2: - fix ARB_shader_draw_parameters system value names > > Signed-off-by: Samuel Pitoiset > --- > src/compiler/glsl/builtin_functions.cpp | 6 -- > src/compiler/g

Re: [Mesa-dev] [PATCH 00/14] Better Travis-CI integration, take 2

2017-04-21 Thread Gustaw Smolarczyk
2017-04-21 14:08 GMT+02:00 Emil Velikov : > Note: GCC 5/6 crashes with internal compiler error at seemingly random > stages of the build. Unless any of the SWR devs sort it out, we might > want to disable it for now. > > A sample report can be seen at > https://travis-ci.org/evelikov/Mesa/builds/22

Re: [Mesa-dev] [RFC PATCH 3/4] ff_fragment_shader: mark impossible switch values with unreachable

2017-04-22 Thread Gustaw Smolarczyk
olai > > >>} >> } >> >> @@ -579,9 +576,8 @@ emit_combine(texenv_fragment_program *p, >> case TEXENV_MODE_ADD_PRODUCTS_SIGNED_NV: >>return add(add(mul(src[0], src[1]), mul(src[2], src[3])), >> new(p->mem_ctx) ir_constant(-0.5f)); >> - default: >> - assert(0); >> - return src[0]; >> + default: >> + unreachable("Invalid TexEnv Combine mode"); >> } >> } With Nicolai's suggestion or not: Reviewed-by: Gustaw Smolarczyk Regards, Gustaw ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 06/17] st/mesa: unify TCS, TES, GS st_*_program structures

2017-05-02 Thread Gustaw Smolarczyk
2017-05-01 14:52 GMT+02:00 Marek Olšák : > From: Marek Olšák SNIP > > /** > * Derived from Mesa gl_program: > */ > -struct st_geometry_program > +struct st_common_program > { > struct gl_program Base; /**< The Mesa geometry program */ I think you should remove the word "geometry" fro

Re: [Mesa-dev] [PATCH 05/14] mesa/main/ff_frag: Don't bother with VARYING_BIT_FOGC.

2017-05-15 Thread Gustaw Smolarczyk
2017-05-15 20:28 GMT+02:00 Ian Romanick : > With this patch I applied, I still see this bit used in several > places, including the i915 driver. Did you test that? > > rc/compiler/shader_enums.h:#define VARYING_BIT_FOGC > BITFIELD64_BIT(VARYING_SLOT_FOGC) > src/mesa/swrast/s_context.c:

Re: [Mesa-dev] [PATCH 05/14] mesa/main/ff_frag: Don't bother with VARYING_BIT_FOGC.

2017-05-16 Thread Gustaw Smolarczyk
2017-05-16 18:48 GMT+02:00 Ian Romanick : > On 05/15/2017 11:38 AM, Gustaw Smolarczyk wrote: >> 2017-05-15 20:28 GMT+02:00 Ian Romanick : >>> With this patch I applied, I still see this bit used in several >>> places, including the i915 driver. Did you tes

Re: [Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures

2017-11-14 Thread Gustaw Smolarczyk
2017-11-14 15:04 GMT+01:00 Marek Olšák : > On Mon, Nov 13, 2017 at 10:19 PM, Ian Romanick wrote: >> On 11/08/2017 07:16 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> For lower CPU cache usage. All enums fit within 2 bytes. >> >> Have you benchmarked this on anything? My recollection is th

Re: [Mesa-dev] [PATCH] ac: change legacy_surf_level::slice_size to dword units

2017-11-27 Thread Gustaw Smolarczyk
2017-11-27 14:43 GMT+01:00 Marek Olšák : > On Mon, Nov 27, 2017 at 12:54 PM, Nicolai Hähnle > wrote: > > On 23.11.2017 20:35, Marek Olšák wrote: > >> > >> From: Marek Olšák > >> > >> The next commit will reduce the size even more. > >> > >> v2: typecast to uint64_t manually > >> --- > >> src/a

Re: [Mesa-dev] [PATCH v1 3/3] gallium/hud: Prevent buffer overflow in hud_thread_busy_install

2017-06-29 Thread Gustaw Smolarczyk
2017-06-29 4:41 GMT+02:00 Robert Foss : > Switch to using strncopy to avoid potential overflow of > name array in struct hud_graph. > > Coverity-id: 1413760 > > Signed-off-by: Robert Foss > --- > src/gallium/auxiliary/hud/hud_cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

2017-07-03 Thread Gustaw Smolarczyk
2017-07-03 6:10 GMT+02:00 Robert Foss : > On Sun, 2017-07-02 at 21:06 -0700, Matt Turner wrote: >> Otherwise known as strlcpy()? > > I didn't realize this, a wrapper would be needed for all platformsou > that don't support it natively. > > Do you know which platforms support strlcpy? > > > Rob. I

Re: [Mesa-dev] [PATCH v4 1/3] util: Add util_strlcpy

2017-07-04 Thread Gustaw Smolarczyk
4 lip 2017 14:25 "Robert Foss" napisał(a): Add local strlcpy implementation. Signed-off-by: Robert Foss --- Changes since v3: Matt Turner - Change name of util_strncpy to util_strlcpy Changes since v2: Brian Paul - Patch added src/util/u_string.h | 9 + 1 file changed, 9

Re: [Mesa-dev] [PATCH v6 1/3] util: Add util_strlcpy

2017-07-05 Thread Gustaw Smolarczyk
2017-07-05 8:57 GMT+02:00 Robert Foss : > Add local strlcpy implementation. > > Signed-off-by: Robert Foss > --- > Changes since v5: > Actually include changes from v5 in patch > > Changes since v4: > Gustaw Smolarczyk >- Make util_strlcpy have the same be

Re: [Mesa-dev] [PATCH v6 1/3] util: Add util_strlcpy

2017-07-06 Thread Gustaw Smolarczyk
since v5: >> >Actually include changes from v5 in patch >> > >> > Changes since v4: >> >Gustaw Smolarczyk >> > - Make util_strlcpy have the same behaviour as strlcpy >> > >> > Changes since v3: >> >Matt Turner

Re: [Mesa-dev] DRI Configurator replacement announcement

2018-01-16 Thread Gustaw Smolarczyk
2018-01-16 8:33 GMT+01:00 Gert Wollny : > Hello Jean, > > Am Montag, den 15.01.2018, 20:15 + schrieb Jean Hertel: > > I have written a simply application like DRI Conf tool. > > It is written using GTKmm and C++. > Great! > > Unfortunately, it didn't link properly, so I send you a pull request

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix border color translation for integer textures

2017-09-26 Thread Gustaw Smolarczyk
t (whether 0.0 and -0.0 should be indistinguishable), but is that ok? Regards, Gustaw Smolarczyk ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Gustaw Smolarczyk
2017-09-28 18:52 GMT+02:00 Marek Olšák : > A clearer comment would be: "Don't destroy the fence when it's in the > middle of util_queue_fence_signal (signalled but not unlocked yet > because util_queue_fence_is_signalled doesn't lock). Instead, wait > until util_queue_fence_signal returns and then

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Gustaw Smolarczyk
2017-09-28 20:21 GMT+02:00 Nicolai Hähnle : > On 28.09.2017 19:18, Gustaw Smolarczyk wrote: >> >> 2017-09-28 18:52 GMT+02:00 Marek Olšák : >>> >>> A clearer comment would be: "Don't destroy the fence when it's in the >>> middle of util_queue

Re: [Mesa-dev] [PATCH 4/7] gallium: add PIPE_CAP_TGSI_FS_FBFETCH

2017-01-02 Thread Gustaw Smolarczyk
2017-01-02 7:01 GMT+01:00 Ilia Mirkin : > Signed-off-by: Ilia Mirkin > --- > src/gallium/docs/source/screen.rst | 2 ++ > src/gallium/drivers/freedreno/freedreno_screen.c | 1 + > src/gallium/drivers/i915/i915_screen.c | 1 + > src/gallium/drivers/ilo/ilo_screen.c

Re: [Mesa-dev] [PATCH 08/12] glcpp: Use strpbrk in the line continuations pass

2017-01-07 Thread Gustaw Smolarczyk
7 sty 2017 20:04 "Vladislav Egorov" napisał(a): To find newlines the line continuations removal pass uses strchr() twice -- first time to find '\n', second time to find '\r'. Now, if the shader uses Unix line separators '\n', the file could contain no '\r' at all, so each time it will scan to the

Re: [Mesa-dev] [PATCH 15/17] gallium/radeon: remove r600_common_context::max_db

2017-01-26 Thread Gustaw Smolarczyk
2017-01-26 17:04 GMT+01:00 Marek Olšák : > From: Marek Olšák > > this cleanup is based on the vulkan driver, which seems to do the same thing Is this also ok for r600g? If I'm right, the amdgpu-pro Vulkan driver doesn't have any support for pre-GCN hardware. Regards, Gustaw _

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

2017-03-27 Thread Gustaw Smolarczyk
27 mar 2017 08:47 "Alejandro Piñeiro" napisał(a): On 27/03/17 01:51, Edward O'Callaghan wrote: > V.1: > We memset number of elements without multiplication by the > element size. It is not usual to summarize v1. The idea is explain just the changes. > > V.2: > We explicitly set each member to -1

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

2017-03-27 Thread Gustaw Smolarczyk
26 mar 2017 22:32 "Edmondo Tommasina" napisał(a): Define a new MESA_USER_DRIRC environment variable to load a customized drirc file. When the variable is not defined, nothing changes and the ${HOME}/.drirc file will be loaded. If the variable is set to a file, this file will be loaded instead o

[Mesa-dev] [PATCH 0/3] Minor fixed-function fragment shader cache key optimizations.

2017-03-27 Thread Gustaw Smolarczyk
nside the gl context be more similar to ff cache key. This way make_state_key would be more about copying stuff around than translating it from one representation to another. As I don't have commit access, please push the changes after you deem them ready for that. Regards, Gustaw Gustaw Smo

[Mesa-dev] [PATCH 2/3] mesa/main: Remove enabled_units from ff cache key.

2017-03-27 Thread Gustaw Smolarczyk
Its only usage is easily replaced by nr_enabled_units. As for cache key part, unit[i].enabled should be enough. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp

[Mesa-dev] [PATCH 1/3] mesa/main: Use correct constant in ff cache key.

2017-03-27 Thread Gustaw Smolarczyk
Since fixed-function shaders are restricted to MAX_TEXTURE_COORD_UNITS texture units, use this constant instead of MAX_TEXTURE_UNITS. This reduces the array size from 32 to 8. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH 3/3] mesa/main: Reduce the size of nr_enabled_units in ff cache key.

2017-03-27 Thread Gustaw Smolarczyk
Since it holds values from 0 to 8, 4 bits will suffice. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 75189733ba

Re: [Mesa-dev] [PATCH 0/3] Minor fixed-function fragment shader cache key optimizations.

2017-03-27 Thread Gustaw Smolarczyk
2017-03-27 21:10 GMT+02:00 Jason Ekstrand : > On March 27, 2017 10:24:47 AM Gustaw Smolarczyk > wrote: > >> Hello, >> >> I was playing with profiling Minecraft on radeonsi in perf and found that >> _mesa_get_fixed_func_fragment_program was a little bit too high

Re: [Mesa-dev] [PATCH v2 2/2] mesa: load a user defined drirc file specified via an environment variable

2017-03-27 Thread Gustaw Smolarczyk
2017-03-27 21:59 GMT+02:00 Edmondo Tommasina : > Introduce a new MESA_USER_DRIRC environment variable to load a customized > drirc file. > > This can be used mostly for two things: > 1. Force the load of a different user drirc configuration for an application >without touching/creating a user g

Re: [Mesa-dev] [PATCH 0/3] Minor fixed-function fragment shader cache key optimizations.

2017-03-27 Thread Gustaw Smolarczyk
2017-03-27 21:27 GMT+02:00 Gustaw Smolarczyk : > 2017-03-27 21:10 GMT+02:00 Jason Ekstrand : >> On March 27, 2017 10:24:47 AM Gustaw Smolarczyk >> wrote: >> >>> Hello, >>> >>> I was playing with profiling Minecraft on radeonsi in perf and found that

Re: [Mesa-dev] [RFC 2/3] mesa: always return GL_OUT_OF_MEMORY or GL_NO_ERROR when KHR_no_error enabled

2017-03-28 Thread Gustaw Smolarczyk
28 mar 2017 06:35 "Timothy Arceri" napisał(a): --- src/mesa/main/getstring.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 6e90511..50140cf 100644 --- a/src/mesa/main/getstring.c +++ b/src/mesa/main/getstring.c @@ -2

[Mesa-dev] [PATCH 00/14] More substantial ff_fragment_shader cache key optimizations.

2017-03-30 Thread Gustaw Smolarczyk
pped from ~0.78% to ~0.37%. Standard deviation here is ~0.025% so the performance gain is statistically significant. Regards, Gustaw Gustaw Smolarczyk (14): mesa/main/ff_frag: Use correct constant. mesa/main/ff_frag: Remove enabled_units. mesa/main/ff_frag: Reduce the size of nr_enabled_u

[Mesa-dev] [PATCH 02/14] mesa/main/ff_frag: Remove enabled_units.

2017-03-30 Thread Gustaw Smolarczyk
Its only usage is easily replaced by nr_enabled_units. As for cache key part, unit[i].enabled should be enough. Signed-off-by: Gustaw Smolarczyk Reviewed-by: Eric Anholt --- src/mesa/main/ff_fragment_shader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 03/14] mesa/main/ff_frag: Reduce the size of nr_enabled_units.

2017-03-30 Thread Gustaw Smolarczyk
Since it holds values from 0 to 8, 4 bits will suffice. Signed-off-by: Gustaw Smolarczyk Reviewed-by: Eric Anholt --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main

[Mesa-dev] [PATCH 06/14] mesa/main/ff_frag: Simplify get_fp_input_mask.

2017-03-30 Thread Gustaw Smolarczyk
Change it into filter_fp_input_mask transform function that instead of returning a mask, transforms input. Also, simplify the case of vertex program handling by assuming that fp_inputs is always a combination of VARYING_BIT_COL* and VARYING_BIT_TEX*. Signed-off-by: Gustaw Smolarczyk --- src

[Mesa-dev] [PATCH 01/14] mesa/main/ff_frag: Use correct constant.

2017-03-30 Thread Gustaw Smolarczyk
Since fixed-function shaders are restricted to MAX_TEXTURE_COORD_UNITS texture units, use this constant instead of MAX_TEXTURE_UNITS. This reduces the array size from 32 to 8. Signed-off-by: Gustaw Smolarczyk Reviewed-by: Eric Anholt --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file

[Mesa-dev] [PATCH 04/14] mesa/main/ff_frag: Remove unused struct.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 9b00c36534..95c74e2b92 100644 --- a/src/mesa/main/ff_fragment_shader.cpp +++ b

[Mesa-dev] [PATCH 08/14] mesa/main/ff_frag: Use gl_texture_object::TargetIndex.

2017-03-30 Thread Gustaw Smolarczyk
Instead of computing it once again using _mesa_tex_target_to_index. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index

[Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/enable.c | 1 + src/mesa/main/fog.c| 9 + src/mesa/main/mtypes.h | 14 ++ 3 files changed, 24 insertions(+) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index d9d63a6b4b..ef278a318a 100644 --- a/src

[Mesa-dev] [PATCH 07/14] mesa/main/ff_frag: Store nr_enabled_units only once.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 1b76f40e9a..717f39e9d3 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 12/14] mesa/main/ff_frag: Use compressed fog mode.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index e1fe9b58c0..bdbefc7880 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 09/14] mesa/main/ff_frag: Don't retrieve format if not necessary.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 2b4d99c879..e1fe9b58c0 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 05/14] mesa/main/ff_frag: Don't bother with VARYING_BIT_FOGC.

2017-03-30 Thread Gustaw Smolarczyk
It's not used. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 95c74e2b92..05641997de 100644 --- a/src/mesa

[Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/mtypes.h | 83 ++ src/mesa/main/texstate.c | 103 +++ 2 files changed, 186 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

[Mesa-dev] [PATCH 13/14] mesa/main/ff_frag: Use compressed TexEnv Combine state.

2017-03-30 Thread Gustaw Smolarczyk
Along the way, add missing GL_ONE source support and drop non-existing GL_ZERO and GL_ONE operand support. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 335 +++ 1 file changed, 104 insertions(+), 231 deletions(-) diff --git a/src

  1   2   >