Yes, but it seems suboptimal, incurring overhead on every rendered pixel.
Another way that I just realized would be to convert a texture to BGRA the
first time it's rendered to.
In contrast to the shader solution that has only a one-time overhead. Is
this a stupid idea for any reason?
Wla
Sorry for getting the list wrong again. Please reply to mesa-dev not
dri-dev .
-- Forwarded message --
From: "Wladimir J. van der Laan"
Date: Feb 3, 2017 10:56
Subject: Question about handling RGBA/BGRA in etnaviv driver
To: ,
Cc: "Chris Healy"
Hello,
Wit
S_required_internalformat which does give the
application more control, but I'm describing behavior without this extension
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
nd. See the attached
> patch.
>
Thanks, tested this, it works,
Reviewed-by: Wladimir J. van der Laan
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>From 1b3d69d7749e3b82f529d2a41b80f5cd64447d92 Mon Sep 17 00:00:00 2001
From: "Wladimir J. van der Laan"
Date: Fri, 5 Apr 2013 18:58:32 +0200
Subject: [PATCH] gallium/auxiliary: Add ETC as compressed format
Add UTIL_FORMAT_LAYOUT_ETC to util_format_is_compressed. It was missing.
Hello Brian,
Reviewed-by: Brian Paul
>
> Do you need someone to commit this for you?
>
Yes, I'm new here,
Regards,
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
from the second plane to g and a.
How does this work? EGL_TEXTURE_Y_U_V_WL puts all planes in r;
EGL_TEXTURE_Y_UV_WL puts a plane in r and one in rg (thus overlapping).
Regards,
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http
On Thu, Oct 26, 2017 at 9:45 AM, Lucas Stach wrote:
> Am Donnerstag, den 26.10.2017, 03:17 +0200 schrieb Christian Gmeiner:
>> Signed-off-by: Christian Gmeiner
>
> Has this been tested on older GPU cores like the GC600?
To be fair, I doubt any of the recent changes have been tested on GC600.
Is
d pre-GC2000 support.
I don't think they've ever tried any recent versions, because they
don't have a DRM driver for the display out and mesa has no fbdev
support anymore :)
(would be doable to hack around, but I don't have the time right now)
Wladimir
ath. This isn't
>> allowed and the kernel will start to reject this in the near future.
>>
>
> Good to know that the kernel will reject this behauvior in the near future.
Seems a good idea nevertheless, and very welcome after rework, I've
seen some cases of ex
On Wed, Nov 1, 2017 at 11:35 AM, Eric Engestrom
wrote:
> On Wednesday, 2017-11-01 11:17:53 +0100, Wladimir J. van der Laan wrote:
>> GC3000 resolve-in-place assumes that the TS state is configured.
>> If it is not, this will result in MMU errors. This is especially
>>
On Sun, Nov 5, 2017 at 12:47 PM, Christian Gmeiner
wrote:
> 2017-10-30 17:16 GMT+01:00 Wladimir J. van der Laan :
>> When the BLT is involved as source or target, add an extra BLT
>> enable/disable sequence around the sync sequence.
>>
>
> Does this mean we are doing l
On Sun, Nov 5, 2017 at 1:09 PM, Christian Gmeiner
wrote:
> 2017-10-30 17:16 GMT+01:00 Wladimir J. van der Laan :
>> Prepare for BLT-based blitting path by moving RS-based
>> blitting to its own implementation file.
>>
>> Signed-off-by: Wladimir J. van der Laan
>
e) {
if (!ctx->specs.use_blt) {
...
}
} else {
if (!ctx->specs.use_blt)
..
}
My current working tree can be found at
https://github.com/laanwj/mesa/tree/gc7000. It contains these patches
(but also some temporary local scaffolding, so be warned).
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
valid_ts(&to->base)) {
I just realized - would it maybe make sense to roll the call to
etna_resource_has_valid_ts into etna_resource_needs_flush?
etna_resource_needs_flush is only called from two places - here, and
in resource_flush, where it also determines whether to do a
res
s its own feature bit
(ETC1_TEXTURE_COMPRESSION).
But yes that shortens the code at least, thanks.
> There's already a util_format_is_s3tc helper, I don't think it'd be
way out of line to add one for etc as well.
Ok, will add one.
Regards,
Wladimir
___
On Tue, Aug 8, 2017 at 12:58 AM, Rob Herring wrote:
> Use the common pipe_screen ref counting and fd hashing functions.
> The mutex can be dropped as the pipe loader serializes the
> create_screen() and destroy() calls.
>
> Signed-off-by: Rob Herring
> Cc: Christian Gmeiner
On Tue, Nov 7, 2017 at 5:43 PM, Wladimir J. van der Laan
wrote:
> Sampler TS introduces yet another format enumeration for renderable
> formats. Introduce it into etnaviv_format as unobtrusively as possible.
>
> Signed-off-by: Wladimir J. van der Laan
> ---
> src/galli
coordinate, e.g. to render solid points?
I thought about that, but I don't think it's general enough.
Could we make the blitter label texture coordinates properly?
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://
ld be reasonable to re-emit the shader state (or maybe
just the varyings) when the primitive type changes from points to
non-points. It virtually never happens that the same shader combo is
used for points and non-points.
Wladimir
___
mesa-dev mailing li
_vertex, currently we don't handle
pipe_rasterizer_state->point_size at all, we pretty much just assume
point_size_per_vertex.
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hello,
On Tue, Jun 27, 2017 at 5:47 PM, Christian Gmeiner
wrote:
> 2017-06-27 17:39 GMT+02:00 Wladimir J. van der Laan :
>> On Tue, Jun 27, 2017 at 05:31:52PM +0200, Wladimir J. van der Laan wrote:
>>
>>> > sure if we should advertise the broken formats (on gpus with
On Thu, Jul 6, 2017 at 4:01 PM, Wladimir wrote:
> That the SRGB formats fail is expected (they're simply using RGB, this
> is mentioned in the patch message), the discrepancy between
> gc2000/gc3000 on RGB(A) is interesting, though, I'll look into it.
I've not been able
On Oct 1, 2017 13:38, "Lucas Stach" wrote:
Am Sonntag, den 01.10.2017, 12:46 +0200 schrieb Christian Gmeiner:
> 2017-09-26 12:29 GMT+02:00 Wladimir J. van der Laan :
> > Set up new states that the blob started setting for GC3000 consistently.
> >
> > This makes
is at a higher level, maybe it should be solved
at the Mesa / GL ES level - applications using OpenGL ES API expect an
abstraction "GL_RGBA" which does not necessarily need to use RGBA layout in
memory.
(On the other hand for desktop GL the internal format is the internal format and
it
On Wed, Feb 08, 2017 at 12:10:24PM +0100, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner
Sure why not.
Reviewed-by: Wladimir J. van der Laan
> ---
> src/gallium/drivers/etnaviv/etnaviv_compiler.c | 6 ++
> src/gallium/drivers/etnaviv/etnaviv_compiler.h | 1
On Wed, Feb 08, 2017 at 12:10:25PM +0100, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner
Reviewed-By: Wladimir J. van der Laan
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/m
)
+- common.xml( 23473 bytes, from 2016-12-11 10:32:13)
Copyright (C) 2012-2016 by the following authors:
- Wladimir J. van der Laan
diff --git a/src/gallium/drivers/etnaviv/hw/common.xml.h
b/src/gallium/drivers/etnaviv/hw/common.xml.h
index 8d8ef7d..0f99db2 100644
--- a/src/gallium/drivers
- Use the same instruction area on GC3000 as the Vivante driver.
This allows the same number of instructions on GC3000 as GC2000
instead of half.
- Makes sure that the "PE to FE" stall before updating the shader code
or constants is hit (which is conditional on vs_offset > 0x4000). This
is
ay: just have whatever
parses the output do the counting based on what is printed first.
But I think it's fine as it is.
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
r object then add an id to the shader object. It's not like
that overhead is significant and if you're going to add it later anyway
we're pretty much wasting time here by removing it and adding it back...
Wladimir
___
mesa-dev mailing lis
> Thx - will send out updated patches the next days. I quite busy with
> lot of stuff atm but
> a long weekend is coming :)
Yeah np I could update my patches to that too and re-send them if that
is more convenient,
Wladimir
___
mesa-dev mai
art to do
> so at a later point in time. If there is a temporary resource the fini needs
> to happen before the RS uses this one as the source for the upload.
>
> Also remove an invalid comment about flushing CPU caches, cpu_fini takes
> care of everything involved in this.
Reviewed
ccount the case on GC2000, where there can be a texture
resource
that is out of date with the rendered-to resource?
If so:
Reviewed-By: Wladimir J. van der Laan
> ---
> src/gallium/drivers/etnaviv/etnaviv_resource.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --
On Fri, May 19, 2017 at 11:41:08AM +0200, Lucas Stach wrote:
> cpu_prep() already does all the required waiting, so the only thing that
> needs to be done is flushing the commandstream, if a GPU write is pending.
Looks good to me.
Reviewed-By: Wladimir J. van der Laan
> Signed-off-
the flag if there exists a temporary resource, as those ones are
> never busy.
OK.
Reviewed-By: Wladimir J. van der Laan
> Signed-off-by: Lucas Stach
> ---
> src/gallium/drivers/etnaviv/etnaviv_transfer.c | 22 ++
> 1 file changed, 10 insertions(+), 12
rce
don't matter if DISCARD_WHOLE_RESOURCE.
Reviewed-By: Wladimir J. van der Laan
> Signed-off-by: Lucas Stach
> ---
> src/gallium/drivers/etnaviv/etnaviv_transfer.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/etnaviv/etn
ood to me. Resource layout is explicit, and not dependent
on the compressed-ness of the texture format.
Reviewed-By: Wladimir J. van der Laan
> Signed-off-by: Lucas Stach
> ---
> src/gallium/drivers/etnaviv/etnaviv_transfer.c | 70
> +++---
> 1 file changed, 29 ins
Hello Lucas,
On Thu, Jun 08, 2017 at 10:26:04AM +0200, Lucas Stach wrote:
> Hi Wladimir,
>
> did you also review this patch? It's the last one of this series missing
> review.
Sorry, no, I missed it somehow.
Looks obviously correct to me, and matches the code from VC4 (apart f
Hello Fabio,
Can you get a traceback using gdb?
That'd be very useful to find out where in the driver this crash happens.
Regards,
Wladimir
On Tue, Jun 13, 2017 at 04:20:23PM -0300, Fabio Estevam wrote:
> Hi,
>
> I am running kernel 4.11.4 with Etnaviv 17.1.2 on a imx6qsabre
On Tue, Oct 17, 2017 at 10:38:13PM +0200, Christian Gmeiner wrote:
> Update to etna_viv commit 6c9c706.
>
> Signed-off-by: Christian Gmeiner
Reviewed-by: Wladimir J. van der Laan
> ---
> src/gallium/drivers/etnaviv/hw/cmdstream.xml.h | 36 ++-
> src/gallium/drivers/etnav
On Tue, Oct 17, 2017 at 10:38:14PM +0200, Christian Gmeiner wrote:
> No hardware query is supported yet.
>
> Signed-off-by: Christian Gmeiner
Reviewed-by: Wladimir J. van der Laan
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.
On Tue, Oct 17, 2017 at 10:38:16PM +0200, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner
Reviewed-by: Wladimir J. van der Laan
> ---
> src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/s
> +};
Is it intentional that this defines the same fields three times?
Why not return the same structure for all three cases? Is this expected to
change to
specific implementations soon in another patch?
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Oct 17, 2017 at 10:38:17PM +0200, Christian Gmeiner wrote:
> Galliums query_type used in APIs is unsigned.
Reviewed-by: Wladimir J. van der Laan
> Signed-off-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_query.h| 2 +-
> src/gallium/
> There is one difference - how the sum is interpreted - uint64_t vs. bool
> value. In general the code
Ok in that case it's ok like this, just looked like unnecessary/accidental
duplication.
Regards,
Wladimir
___
mesa-dev mailing li
On Thu, Oct 19, 2017 at 11:12:44PM +0200, Christian Gmeiner wrote:
> Update to etna_viv commit 6c9c706.
>
> Signed-off-by: Christian Gmeiner
> Reviewed-by: Wladimir J. van der Laan
For whole v2 series:
Reviewed-by: Wladimir J. van der Laan
Wladimir
> ---
> src/gallium/
NENTS=R=1,G=1,B=1,A=1,SUPER_TILED_NEW=1,COMPONENTS_MASK=0,OVERWRITE=1,OVERWRITE_MASK=0,SUPER_TILED=1,SUPER_TILED_MASK=0,FORMAT_EXT=A8R8G8B8,FORMAT_EXT_MASK=0
*/
(the blob even uses the FORMAT_EXT and masks FORMAT for every format - on GPUs
that support the EXT format bits, but there's som
mpatible_rs_format(enum pipe_format fmt)
>return PIPE_FORMAT_B4G4R4A4_UNORM;
> case 4:
>return PIPE_FORMAT_B8G8R8A8_UNORM;
> + case 8:
> + return PIPE_FORMAT_B8G8R8A8_UNORM;
That's the same as 4. How does the RS know it has to copy 8 bytes per pixel?
Wladimir
_
On Fri, Oct 20, 2017 at 10:21:22PM +0200, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner
Reviewed-by: Wladimir J. van der Laan
Verified that HALTI0 has PE TEXTURE_FORMAT_EXT by looking at GC2000 blob
replays.
> ---
> src/gallium/drivers/etnaviv/etnaviv_scre
On Fri, Oct 20, 2017 at 10:21:23PM +0200, Christian Gmeiner wrote:
> Also update RS_FORMAT_RB_SWAP.
>
> Signed-off-by: Christian Gmeiner
Reviewed-by: Wladimir J. van der Laan
> ---
> src/gallium/drivers/etnaviv/etnaviv_format.c | 4 ++--
> 1 file changed, 2 insertio
On Fri, Oct 20, 2017 at 10:21:25PM +0200, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner
Reviewed-by: Wladimir J. van der Laan
> ---
> src/gallium/drivers/etnaviv/etnaviv_tiling.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff -
On Fri, Oct 20, 2017 at 10:21:26PM +0200, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner
Reviewed-by: Wladimir J. van der Laan
> ---
> src/gallium/drivers/etnaviv/etnaviv_screen.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/galli
On Fri, Oct 20, 2017 at 10:21:27PM +0200, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner
Reviewed-by: Wladimir J. van der Laan
Optional suggestions inline.
> ---
> src/gallium/drivers/etnaviv/etnaviv_format.c | 22 +-
> 1 file changed, 17 inse
On Fri, Oct 20, 2017 at 10:21:21PM +0200, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner
> ---
> src/mesa/main/glformats.c | 19 +++
> 1 file changed, 19 insertions(+)
Reviewed-by: Wladimir J. van der Laan
(as far as I'm qualified to review this
On Fri, Oct 20, 2017 at 04:04:09PM -0700, Dylan Baker wrote:
> This is all pretty straight-forward, it builds on my system, but I don't have
> any actual hardware to test on.
>
> Christian and/or Wladimir, could one of you build this and do some kind of
> testing to ensure it
On Sat, Oct 21, 2017 at 10:22:09AM +0200, Christian Gmeiner wrote:
> Hi Wladimir
>
> 2017-10-21 7:28 GMT+02:00 Wladimir J. van der Laan :
> > On Fri, Oct 20, 2017 at 10:21:28PM +0200, Christian Gmeiner wrote:
> >> Fixes piglit/bin/oes_texture_float half
> >>
>
Prevents an assertion when using GALLIUM_HUD with ioquake3,
when cso_restore_constant_buffer_slot0 restores an empty
constant buffer in slot 0.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Structure code to only flush when we will potentially call cpu_prep. This
prevents spurious flushes in applications that heavily rely on u_uploader.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_transfer.c | 24
1 file changed, 12
Prevents an assertion when using GALLIUM_HUD with ioquake3,
when cso_restore_constant_buffer_slot0 restores an empty
constant buffer in slot 0.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Oops
mats-s3tc
>
> Btw. this enables GL 2.1 :-)
That's all?
Cool, I thought ext_texture_srgb needed rendering to srgb too,
but apparently not.
> Signed-off-by: Christian Gmeiner
Reviewed-by: Wladimir J. van der Laan
> ---
> src/gallium/drivers/etnaviv/etnaviv_format.c |
is able to test it on old hw can remove
the conditional if they've tested it.
Regards,
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ares
explicitly with NULL. But ok, I'll update it some time.
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Vivante kernel driver. If
you really want to see etnaviv_texture_desc.c in its current state, it's here:
https://github.com/laanwj/mesa/blob/gc7000/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c
Wladimir J. van der Laan (19):
etnaviv: Update from rnndb
etnaviv: Const-correctness etnav
The relocation structure is never changed by submitting it.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_emit.h
b/src/gallium/drivers/etnaviv
Updated as of etnav_viv commit 8255e4b.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 2 +-
src/gallium/drivers/etnaviv/etnaviv_format.c | 9 +-
src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +-
src/gallium/drivers/etnaviv
This is used by HALTI2+ (GC3000+) when drawing with DRAW_INSTANCED.
It is also necessary when switching between integer and floating point
vertex element formats.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 5 +
src/gallium/drivers/etnaviv
The blob does this, as DRAW_INSTANCED can replace fully all the other
draw commands - the other path is only there for compatibility and
will go away (or at least rot to become buggy due to dis-use) in newer
hardware.
Preparation for GC7000 support.
Signed-off-by: Wladimir J. van der Laan
Prepare for BLT-based blitting path by moving RS-based
blitting to its own implementation file.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/Makefile.sources | 1 +
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 553 +--
src/gallium
The HALTI level is an indication of the gross architecture of the GPU.
It determines for significant part what feature level the GPU has, what
state (especially frontend state) is there, and where it is located.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv
When the BLT is involved as source or target, add an extra BLT
enable/disable sequence around the sync sequence.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/src/gallium
Add a low-level library for using the BLT engine from the etnaviv
driver.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/Makefile.sources | 2 +
src/gallium/drivers/etnaviv/etnaviv_blt.c| 219 +++
src/gallium/drivers/etnaviv/etnaviv_blt.h
Add an implemenation of key clear_blit functions using the BLT engine
that replaced the RS on GC7000.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/Makefile.sources | 1 +
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 7 +-
src/gallium/drivers/etnaviv
RS align is not necessary and might even be harmful when using the BLT
engine for blitting.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 15 +
src/gallium/drivers/etnaviv/etnaviv_surface.c | 41 +
src/gallium
Update context reset for HALTI3..HALTI5, sorting states for the HALTI
version that has them.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_context.c | 37 +++
1 file changed, 32 insertions(+), 5 deletions(-)
diff --git a/src/gallium
- This core must load shaders from memory (AFAIK)
- Yet another new location for UNIFORMS
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/etnaviv
Track varying component offset of the point size output, as well as
provide the offset of the point coord input.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 7 ++-
src/gallium/drivers/etnaviv/etnaviv_compiler.h | 1 +
src/gallium/drivers
This needs to be shared between texture_plain and texture_desc.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c| 12
src/gallium/drivers/etnaviv/etnaviv_texture.c | 6 ++
src/gallium/drivers/etnaviv/etnaviv_texture.h | 11
Update state objects to add new state, and emit function to emit new
state.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 247 +++--
src/gallium/drivers/etnaviv/etnaviv_internal.h | 4 +
src/gallium/drivers/etnaviv
Need this to efficiently emit texture descriptor invalidations.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_context.c | 1 +
src/gallium/drivers/etnaviv/etnaviv_context.h | 1 +
src/gallium/drivers/etnaviv/etnaviv_emit.c| 1 +
src/gallium/drivers/etnaviv
Prepare for two texture handling paths, the descriptor-based
path will be added in a future commit. These are structured
so that the texture implementation handles its own state
emission.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/Makefile.sources | 2 +
src
Want to be able to emit state from the texture implementation.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 83 --
src/gallium/drivers/etnaviv/etnaviv_emit.h | 83 ++
2 files changed, 83
This will be shared with the texture descriptor path.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_texture.c | 40 +--
src/gallium/drivers/etnaviv/etnaviv_texture.h | 5
2 files changed, 30 insertions(+), 15 deletions(-)
diff
GC3000 resolve-in-place assumes that the TS state is configured.
If it is not, this will result in MMU errors. This is especially
apparent when using glGenMipmaps().
Fixes a problem introduced in 78ade659569ee6fe9bd244170956139f19dd8c6c.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium
On Wed, Nov 01, 2017 at 11:52:55AM +0100, Lucas Stach wrote:
> Am Mittwoch, den 01.11.2017, 11:17 +0100 schrieb Wladimir J. van der Laan:
> > GC3000 resolve-in-place assumes that the TS state is configured.
> > If it is not, this will result in MMU errors. This is especially
&g
On Wed, Nov 01, 2017 at 11:57:39AM +0100, Philipp Zabel wrote:
> On Mon, 2017-10-30 at 17:16 +0100, Wladimir J. van der Laan wrote:
> > The blob does this, as DRAW_INSTANCED can replace fully all the other
> > draw commands - the other path is only there for compatibility and
>
Add ASTC texture support for hardware that supports this
(currently only GC3000 on i.MX6qp is known to have this).
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 8 +++
src/gallium/drivers/etnaviv/etnaviv_format.c | 30
drs Block 4x4.
PIGLIT: {"subtest": {"sRGB decode full precision" : "fail"}}
PIGLIT: {"subtest": {"sRGB skip decode" : "pass"}}
This means all block sizes are working, and basic RGB/sRGB.
Not sure why "sRGB decode full precisi
Updated as of etnav_viv commit 3b4a8ec.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 2 +-
src/gallium/drivers/etnaviv/etnaviv_format.c | 9 +-
src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +-
src/gallium/drivers/etnaviv
rdware (programmed through a different register), so IMO it makes sense to
add a new format bit for it, just like for EXT_FORMAT.
Relying on mesa's judgement on whether something is astc seems brittle.
Regards,
Wladimir
___
mesa-dev mailing li
On Wed, Nov 01, 2017 at 02:27:40PM +0100, Lucas Stach wrote:
> Am Montag, den 30.10.2017, 17:14 +0100 schrieb Wladimir J. van der Laan:
> > On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote:
> > > I would prefer the shorter expression (!cb->buffer && !cb->
ay. Having a specs bit is easier
for that.
(also, vivante is doing away with feature bits on newer GPUs; we're
going to have our own model->specs mapping database like them at some point)
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed, Nov 01, 2017 at 01:27:30PM -0400, Ilia Mirkin wrote:
> On Wed, Nov 1, 2017 at 1:19 PM, Wladimir J. van der Laan
> wrote:
> > Add ASTC texture support for hardware that supports this
> > (currently only GC3000 on i.MX6qp is known to have this).
> >
> > Pi
HALIGN_FOUR/SIXTEEN has no meaning for compressed textures, and we can't
render to them anyway. So use the tightest possible packing. This
avoids bugs with non-power-of-two block sizes.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_resource.c
;
> > +
> > +#include "hw/state_3d.xml.h"
>
> Is this include needed?
Huh, no, I don't see why the states would need to be included in the header,
probably a leftover, I'll remove it.
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
when not using sampler TS, as
resolve-in-place will now be skipped if a resource has no (valid) TS.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c| 26
src/gallium/drivers/etnaviv/etnaviv_texture.c | 92 +--
src/gallium
Update rnndb to etna_viv 07c756a.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/hw/common.xml.h | 2 +-
src/gallium/drivers/etnaviv/hw/common_3d.xml.h | 2 +-
src/gallium/drivers/etnaviv/hw/state.xml.h | 4 ++--
src/gallium/drivers/etnaviv/hw
Sampler TS introduces yet another format enumeration for renderable
formats. Introduce it into etnaviv_format as unobtrusively as possible.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 19 +++
src/gallium/drivers/etnaviv
: 7.692 ms
after: [shadow] : FPS: 244 FrameTime: 4.098 ms
Wladimir J. van der Laan (3):
etnaviv: rnndb update
etnaviv: Add TS_SAMPLER formats to etnaviv_format
etnaviv: Add sampler TS support
src/gallium/drivers/etnaviv/etnaviv_emit.c | 26 +++
src/gallium/drivers/etnaviv/etnavi
A dangling bo object would result in memory corruption while
loading a level in ioquake3_opengl2.
Fixes a problem introduced in 330d0607ed60fd3edca192e54b4246310f06652f.
Fix suggested by Lucas Stach.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_context.c | 6
1 - 100 of 264 matches
Mail list logo
