Re: [Mesa-dev] [PATCH] radeonsi/nir: set TGSI_PROPERTY_FS_EARLY_DEPTH_STENCIL correctly

2018-02-15 Thread Marek Olšák
Reviewed-by: Marek Olšák 

Marek

On Thu, Feb 15, 2018 at 5:14 AM, Timothy Arceri  wrote:
> We set this for post_depth_coverage in addition to early_fragment_tests.
> ---
>
>  This doesn't fix any piglit tests but it's what the glsl->tgsi state
>  tracker does.
>
>  src/gallium/drivers/radeonsi/si_shader_nir.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c 
> b/src/gallium/drivers/radeonsi/si_shader_nir.c
> index 501e8bab03..8094f1f584 100644
> --- a/src/gallium/drivers/radeonsi/si_shader_nir.c
> +++ b/src/gallium/drivers/radeonsi/si_shader_nir.c
> @@ -292,7 +292,8 @@ void si_nir_scan_shader(const struct nir_shader *nir,
> }
>
> if (nir->info.stage == MESA_SHADER_FRAGMENT) {
> -   info->properties[TGSI_PROPERTY_FS_EARLY_DEPTH_STENCIL] = 
> nir->info.fs.early_fragment_tests;
> +   info->properties[TGSI_PROPERTY_FS_EARLY_DEPTH_STENCIL] =
> +   nir->info.fs.early_fragment_tests | 
> nir->info.fs.post_depth_coverage;
> info->properties[TGSI_PROPERTY_FS_POST_DEPTH_COVERAGE] = 
> nir->info.fs.post_depth_coverage;
>
> if (nir->info.fs.depth_layout != FRAG_DEPTH_LAYOUT_NONE) {
> --
> 2.14.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] radeonsi/nir: set TGSI_PROPERTY_FS_EARLY_DEPTH_STENCIL correctly

2018-02-14 Thread Timothy Arceri
We set this for post_depth_coverage in addition to early_fragment_tests.
---

 This doesn't fix any piglit tests but it's what the glsl->tgsi state
 tracker does.

 src/gallium/drivers/radeonsi/si_shader_nir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c 
b/src/gallium/drivers/radeonsi/si_shader_nir.c
index 501e8bab03..8094f1f584 100644
--- a/src/gallium/drivers/radeonsi/si_shader_nir.c
+++ b/src/gallium/drivers/radeonsi/si_shader_nir.c
@@ -292,7 +292,8 @@ void si_nir_scan_shader(const struct nir_shader *nir,
}
 
if (nir->info.stage == MESA_SHADER_FRAGMENT) {
-   info->properties[TGSI_PROPERTY_FS_EARLY_DEPTH_STENCIL] = 
nir->info.fs.early_fragment_tests;
+   info->properties[TGSI_PROPERTY_FS_EARLY_DEPTH_STENCIL] =
+   nir->info.fs.early_fragment_tests | 
nir->info.fs.post_depth_coverage;
info->properties[TGSI_PROPERTY_FS_POST_DEPTH_COVERAGE] = 
nir->info.fs.post_depth_coverage;
 
if (nir->info.fs.depth_layout != FRAG_DEPTH_LAYOUT_NONE) {
-- 
2.14.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev