Re: [Mesa-dev] [PATCH] radv: Don't emit a warning on VI-GFX9.
Congratulations! Tested-by: Edmondo Tommasina On Wed, Mar 7, 2018 at 4:42 PM, Bas Nieuwenhuizen wrote: > We are conformant: > > https://www.khronos.org/conformance/adopters/conformant-products#submission_308 > > v2: Actually not emit it on gfx9. > --- > src/amd/vulkan/radv_device.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > index 150cbdab2e..ffc00fa888 100644 > --- a/src/amd/vulkan/radv_device.c > +++ b/src/amd/vulkan/radv_device.c > @@ -280,7 +280,9 @@ radv_physical_device_init(struct radv_physical_device > *device, > disk_cache_format_hex_id(buf, device->cache_uuid, VK_UUID_SIZE * 2); > device->disk_cache = disk_cache_create(device->name, buf, > shader_env_flags); > > - fprintf(stderr, "WARNING: radv is not a conformant vulkan > implementation, testing use only.\n"); > + if (device->rad_info.chip_class < VI || > + device->rad_info.chip_class > GFX9) > + fprintf(stderr, "WARNING: radv is not a conformant vulkan > implementation, testing use only.\n"); > > radv_get_driver_uuid(&device->device_uuid); > radv_get_device_uuid(&device->rad_info, &device->device_uuid); > -- > 2.16.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radv: Don't emit a warning on VI-GFX9.
Yeah, without the '=' that's better :) Reviewed-by: Samuel Pitoiset On 03/07/2018 04:42 PM, Bas Nieuwenhuizen wrote: We are conformant: https://www.khronos.org/conformance/adopters/conformant-products#submission_308 v2: Actually not emit it on gfx9. --- src/amd/vulkan/radv_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 150cbdab2e..ffc00fa888 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -280,7 +280,9 @@ radv_physical_device_init(struct radv_physical_device *device, disk_cache_format_hex_id(buf, device->cache_uuid, VK_UUID_SIZE * 2); device->disk_cache = disk_cache_create(device->name, buf, shader_env_flags); - fprintf(stderr, "WARNING: radv is not a conformant vulkan implementation, testing use only.\n"); + if (device->rad_info.chip_class < VI || + device->rad_info.chip_class > GFX9) + fprintf(stderr, "WARNING: radv is not a conformant vulkan implementation, testing use only.\n"); radv_get_driver_uuid(&device->device_uuid); radv_get_device_uuid(&device->rad_info, &device->device_uuid); ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] radv: Don't emit a warning on VI-GFX9.
We are conformant: https://www.khronos.org/conformance/adopters/conformant-products#submission_308 v2: Actually not emit it on gfx9. --- src/amd/vulkan/radv_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 150cbdab2e..ffc00fa888 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -280,7 +280,9 @@ radv_physical_device_init(struct radv_physical_device *device, disk_cache_format_hex_id(buf, device->cache_uuid, VK_UUID_SIZE * 2); device->disk_cache = disk_cache_create(device->name, buf, shader_env_flags); - fprintf(stderr, "WARNING: radv is not a conformant vulkan implementation, testing use only.\n"); + if (device->rad_info.chip_class < VI || + device->rad_info.chip_class > GFX9) + fprintf(stderr, "WARNING: radv is not a conformant vulkan implementation, testing use only.\n"); radv_get_driver_uuid(&device->device_uuid); radv_get_device_uuid(&device->rad_info, &device->device_uuid); -- 2.16.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] radv: Don't emit a warning on VI-GFX9.
We are conformant: https://www.khronos.org/conformance/adopters/conformant-products#submission_308 --- src/amd/vulkan/radv_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 150cbdab2e..75af85fee0 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -280,7 +280,9 @@ radv_physical_device_init(struct radv_physical_device *device, disk_cache_format_hex_id(buf, device->cache_uuid, VK_UUID_SIZE * 2); device->disk_cache = disk_cache_create(device->name, buf, shader_env_flags); - fprintf(stderr, "WARNING: radv is not a conformant vulkan implementation, testing use only.\n"); + if (device->rad_info.chip_class < VI || + device->rad_info.chip_class >= GFX9) + fprintf(stderr, "WARNING: radv is not a conformant vulkan implementation, testing use only.\n"); radv_get_driver_uuid(&device->device_uuid); radv_get_device_uuid(&device->rad_info, &device->device_uuid); -- 2.16.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
