Re: [Mesa-dev] [PATCH 12/15] nir/types: Add a wrapper to access gl_type

2018-07-23 Thread Timothy Arceri
On 23/07/18 22:48, Alejandro Piñeiro wrote: On 21/07/18 05:15, Timothy Arceri wrote: On 21/07/18 13:09, Timothy Arceri wrote: Reviewed-by: Timothy Arceri Actually I take that back. This introduces a dependency on GL in NIR, Hmm, but that dependency is already there. nir.h includes

Re: [Mesa-dev] [PATCH 12/15] nir/types: Add a wrapper to access gl_type

2018-07-23 Thread Alejandro Piñeiro
On 21/07/18 05:15, Timothy Arceri wrote: > On 21/07/18 13:09, Timothy Arceri wrote: >> Reviewed-by: Timothy Arceri > > Actually I take that back. This introduces a dependency on GL in NIR, Hmm, but that dependency is already there. nir.h includes GL/gl.h, and in fact, there is a comment

Re: [Mesa-dev] [PATCH 12/15] nir/types: Add a wrapper to access gl_type

2018-07-20 Thread Timothy Arceri
On 21/07/18 13:09, Timothy Arceri wrote: Reviewed-by: Timothy Arceri Actually I take that back. This introduces a dependency on GL in NIR, maybe better to put this one in gl_nir_linker.h? If you agree that change would be: Reviewed-by: Timothy Arceri On 21/07/18 01:08, Alejandro

Re: [Mesa-dev] [PATCH 12/15] nir/types: Add a wrapper to access gl_type

2018-07-20 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 21/07/18 01:08, Alejandro Piñeiro wrote: From: Neil Roberts --- src/compiler/nir_types.cpp | 6 ++ src/compiler/nir_types.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index

[Mesa-dev] [PATCH 12/15] nir/types: Add a wrapper to access gl_type

2018-07-20 Thread Alejandro Piñeiro
From: Neil Roberts --- src/compiler/nir_types.cpp | 6 ++ src/compiler/nir_types.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 6f1182b742c..2085138c407 100644 --- a/src/compiler/nir_types.cpp +++