Re: [Mesa-dev] [PATCH 1/2] radv/nir: call opt_remove_phis after trivial continues.

2017-09-12 Thread Timothy Arceri
On 13/09/17 13:52, Timothy Arceri wrote: On 13/09/17 13:48, Dave Airlie wrote: On 13 September 2017 at 13:42, Timothy Arceri wrote: On 13/09/17 12:57, Dave Airlie wrote: From: Dave Airlie With the shaders in the ssao demo, the nir_opt_if

Re: [Mesa-dev] [PATCH 1/2] radv/nir: call opt_remove_phis after trivial continues.

2017-09-12 Thread Timothy Arceri
On 13/09/17 13:48, Dave Airlie wrote: On 13 September 2017 at 13:42, Timothy Arceri wrote: On 13/09/17 12:57, Dave Airlie wrote: From: Dave Airlie With the shaders in the ssao demo, the nir_opt_if wasn't working properly without this, after

Re: [Mesa-dev] [PATCH 1/2] radv/nir: call opt_remove_phis after trivial continues.

2017-09-12 Thread Dave Airlie
On 13 September 2017 at 13:42, Timothy Arceri wrote: > > On 13/09/17 12:57, Dave Airlie wrote: >> >> From: Dave Airlie >> >> With the shaders in the ssao demo, the nir_opt_if wasn't >> working properly without this, after this the if gets optimised >>

Re: [Mesa-dev] [PATCH 1/2] radv/nir: call opt_remove_phis after trivial continues.

2017-09-12 Thread Timothy Arceri
On 13/09/17 12:57, Dave Airlie wrote: From: Dave Airlie With the shaders in the ssao demo, the nir_opt_if wasn't working properly without this, after this the if gets optimised so that loop unrolling gets called. (loop unrolling fails due to instruction count, but at