Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Chris Wilson
Quoting Sergii Romantsov (2018-07-25 10:37:29) > Hello, Chris. > Your variant also works. > But i wonder about comment: >    /* If we don't have caching at this size, don't actually round the >     * allocation up. >     */ >    if (bucket == NULL) { > > Has it any sense now? If 'no' - will

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
Hello, Chris. Your variant also works. But i wonder about comment: /* If we don't have caching at this size, don't actually round the * allocation up. */ if (bucket == NULL) { Has it any sense now? If 'no' - will delete it in next patch update. Was trying to get commit where and

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Chris Wilson
Quoting Sergii Romantsov (2018-07-25 08:42:55) > Hello, > here is a backtrace: ... Please try: diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 09d45e30ecc..8274c2e0b2f 100644 --- a/src/mesa/drivers/dri/i965/brw_bufmgr.c +++

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
Hello, here is a backtrace: Core was generated by `glretrace ./DyingLightGame.trace'. Program terminated with signal SIGABRT, Aborted. #0 0x7f2852895428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 54 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-24 Thread Lionel Landwerlin
On 24/07/18 18:34, Kenneth Graunke wrote: On Tuesday, July 24, 2018 5:34:57 AM PDT Lionel Landwerlin wrote: That looks correct to me (and we do the same in Anv). Also a bit baffled that we haven't run into issues earlier :( But would be good to have Ken's Rb too. Thanks a lot! Reviewed-by:

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-24 Thread Kenneth Graunke
On Tuesday, July 24, 2018 5:34:57 AM PDT Lionel Landwerlin wrote: > That looks correct to me (and we do the same in Anv). > Also a bit baffled that we haven't run into issues earlier :( > > But would be good to have Ken's Rb too. > > Thanks a lot! > > Reviewed-by: Lionel Landwerlin Yeah, this

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-24 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-07-24 13:45:18) > On 24/07/18 13:42, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2018-07-24 13:34:57) > >> That looks correct to me (and we do the same in Anv). > >> Also a bit baffled that we haven't run into issues earlier :( > > All the allocations should

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-24 Thread Lionel Landwerlin
On 24/07/18 13:42, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-07-24 13:34:57) That looks correct to me (and we do the same in Anv). Also a bit baffled that we haven't run into issues earlier :( All the allocations should be in multiples of page size, alignment less than a page size

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-24 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-07-24 13:34:57) > That looks correct to me (and we do the same in Anv). > Also a bit baffled that we haven't run into issues earlier :( All the allocations should be in multiples of page size, alignment less than a page size should be a no-op. Tracking down who

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-24 Thread Lionel Landwerlin
That looks correct to me (and we do the same in Anv). Also a bit baffled that we haven't run into issues earlier :( But would be good to have Ken's Rb too. Thanks a lot! Reviewed-by: Lionel Landwerlin On 24/07/18 12:50, Sergii Romantsov wrote: Kernel (for ppgtt) requires memory address to

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-24 Thread Sergii Romantsov
Hello, Kenneth. Looks like you are expert in memory management for i965. Could you, please, point me if that idea of patch is correct and what could i improve? Seems its better somehow to bind it to I915_GTT_PAGE_SIZE... right? On Tue, Jul 24, 2018 at 2:50 PM, Sergii Romantsov <