Re: [Mesa-dev] [PATCH v3 24/25] configure.ac: Only add default LLVM components if needed

[Tobias Droste]

Am Mittwoch, 12. Oktober 2016, 12:03:38 CEST schrieb Emil Velikov:
> > Does this mean that the "default" components are required only by the
> > gallivm module ? Please rename the function to reflect that.
> > 
> > Don't recall if swr driver is/was using any of it, but the nv30 path
> > of nouveau does use it, iirc. In the latter you want to call the
> > function if --enable-gallium-llvm is set. Alternatively keep
> > llvm_add_default_components within the "test enable_gallium_llvm !=
> > xno" block.
> 
> In case you're wondering how the above might happen:
> 
> Some drivers (i915g, softpipe/llvmpipe, nv30, r300, svga?... ) use the
> aux/draw module. The latter of which has LLVM codepaths which get
> build if --enable-gallium-llvm is set.
> 
> Search "\ Emil

I didn't know that. Then I have to change this a little bit.
I need to think about that.
So don't bother with patch 24 right now until I came up with a better way.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 24/25] configure.ac: Only add default LLVM components if needed

[Tobias Droste]

Am Mittwoch, 12. Oktober 2016, 10:57:14 CEST schrieb Emil Velikov:
> On 12 October 2016 at 00:02, Tobias Droste  wrote:
> > Each driver has to expllicitly call llvm_add_default_components to
> > add the shared components.
> > This way we can fail the build if a component is not found and avoid
> > the recursive solution from a previous version of the pach series.
> 
> s/pach/patch/
> 
> Does this mean that the "default" components are required only by the
> gallivm module ? Please rename the function to reflect that.

No, there's probably some of them that are only used by gallivm, but not all 
of them. That's something I wanted to do on a follow up to explicitly add all 
llvm components for each driver. But this needs some forensics, to actually 
find out what's really needed ;-)

> 
> Don't recall if swr driver is/was using any of it, but the nv30 path
> of nouveau does use it, iirc. In the latter you want to call the
> function if --enable-gallium-llvm is set. Alternatively keep
> llvm_add_default_components within the "test enable_gallium_llvm !=
> xno" block.

I'm going to add it to nv30.
swr was calling that function before my changes too. So it probably uses it.

> 
> -Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 24/25] configure.ac: Only add default LLVM components if needed

[Emil Velikov]

On 12 October 2016 at 10:57, Emil Velikov  wrote:
> On 12 October 2016 at 00:02, Tobias Droste  wrote:
>> Each driver has to expllicitly call llvm_add_default_components to
>> add the shared components.
>> This way we can fail the build if a component is not found and avoid
>> the recursive solution from a previous version of the pach series.
>>
> s/pach/patch/
>
> Does this mean that the "default" components are required only by the
> gallivm module ? Please rename the function to reflect that.
>
> Don't recall if swr driver is/was using any of it, but the nv30 path
> of nouveau does use it, iirc. In the latter you want to call the
> function if --enable-gallium-llvm is set. Alternatively keep
> llvm_add_default_components within the "test enable_gallium_llvm !=
> xno" block.
>
In case you're wondering how the above might happen:

Some drivers (i915g, softpipe/llvmpipe, nv30, r300, svga?... ) use the
aux/draw module. The latter of which has LLVM codepaths which get
build if --enable-gallium-llvm is set.

Search "\

Re: [Mesa-dev] [PATCH v3 24/25] configure.ac: Only add default LLVM components if needed

[Emil Velikov]

On 12 October 2016 at 00:02, Tobias Droste  wrote:
> Each driver has to expllicitly call llvm_add_default_components to
> add the shared components.
> This way we can fail the build if a component is not found and avoid
> the recursive solution from a previous version of the pach series.
>
s/pach/patch/

Does this mean that the "default" components are required only by the
gallivm module ? Please rename the function to reflect that.

Don't recall if swr driver is/was using any of it, but the nv30 path
of nouveau does use it, iirc. In the latter you want to call the
function if --enable-gallium-llvm is set. Alternatively keep
llvm_add_default_components within the "test enable_gallium_llvm !=
xno" block.

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev