Re: [Mesa-dev] [RFC PATCH 4/4] radv: add support for push constants inlining when possible

2019-02-05 Thread Samuel Pitoiset
On 2/5/19 11:29 AM, Bas Nieuwenhuizen wrote: On Tue, Feb 5, 2019 at 11:07 AM Samuel Pitoiset wrote: On 2/5/19 10:58 AM, Bas Nieuwenhuizen wrote: On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset wrote: This removes some scalar loads from shaders, but it increases the number of SET_SH_REG

Re: [Mesa-dev] [RFC PATCH 4/4] radv: add support for push constants inlining when possible

2019-02-05 Thread Bas Nieuwenhuizen
On Tue, Feb 5, 2019 at 11:07 AM Samuel Pitoiset wrote: > > > On 2/5/19 10:58 AM, Bas Nieuwenhuizen wrote: > > On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset > > wrote: > >> This removes some scalar loads from shaders, but it increases > >> the number of SET_SH_REG packets. This is currently

Re: [Mesa-dev] [RFC PATCH 4/4] radv: add support for push constants inlining when possible

2019-02-05 Thread Samuel Pitoiset
On 2/5/19 10:58 AM, Bas Nieuwenhuizen wrote: On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset wrote: This removes some scalar loads from shaders, but it increases the number of SET_SH_REG packets. This is currently basic but it could be improved if needed. Inlining dynamic offsets might also

Re: [Mesa-dev] [RFC PATCH 4/4] radv: add support for push constants inlining when possible

2019-02-05 Thread Bas Nieuwenhuizen
On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset wrote: > > This removes some scalar loads from shaders, but it increases > the number of SET_SH_REG packets. This is currently basic but > it could be improved if needed. Inlining dynamic offsets might > also help. > > Original idea from Dave