Re: [Mesa3d-dev] DO_DEBUG defines in dri-drivers

2006-07-13 Thread Brian Paul
Hanno Böck wrote: In various dri-drivers, DO_DEBUG is defined to 1. Shouldn't this be defaulted off and only enabled via -DDO_DEBUG on CFLAGS? (suggested Patch attached) diff -Naur

Re: [Mesa3d-dev] DO_DEBUG defines in dri-drivers

2006-07-13 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hanno Böck wrote: In various dri-drivers, DO_DEBUG is defined to 1. Shouldn't this be defaulted off and only enabled via -DDO_DEBUG on CFLAGS? (suggested Patch attached) It defaults to 1 because it doesn't actually enable debugging. It enables

Re: [Mesa3d-dev] DO_DEBUG defines in dri-drivers

2006-07-13 Thread Hanno Böck
Am Donnerstag, 13. Juli 2006 17:46 schrieb Ian Romanick: It defaults to 1 because it doesn't actually enable debugging. It enables a variable that allows the user to enable debugging at run-time. By default the driver_DEBUG variables are set to zero, but environment variables (or GDB!) can