[Mesa3d-dev] [PATCH] Make sure we use only signed/unsigned ints with bitfields.

2010-01-06 Thread michal
Attached. From c91abe0b58abc69743c162fd55f7461a716b9141 Mon Sep 17 00:00:00 2001 From: Michal Krol mic...@vmware.com Date: Wed, 6 Jan 2010 09:48:41 +0100 Subject: [PATCH] Make sure we use only signed/unsigned ints with bitfields. Seems to be the only way to stay fully portable. ---

Re: [Mesa3d-dev] [PATCH] Make sure we use only signed/unsigned ints with bitfields.

2010-01-06 Thread Keith Whitwell
On Wed, 2010-01-06 at 00:50 -0800, michal wrote: diff --git a/src/gallium/drivers/svga/svga_tgsi.h b/src/gallium/drivers/svga/svga_tgsi.h index 896c90a..d132525 100644 --- a/src/gallium/drivers/svga/svga_tgsi.h +++ b/src/gallium/drivers/svga/svga_tgsi.h @@ -39,24 +39,24 @@ struct tgsi_token;

Re: [Mesa3d-dev] [PATCH] Make sure we use only signed/unsigned ints with bitfields.

2010-01-06 Thread michal
Keith Whitwell wrote on 2010-01-06 10:43: On Wed, 2010-01-06 at 00:50 -0800, michal wrote: diff --git a/src/gallium/drivers/svga/svga_tgsi.h b/src/gallium/drivers/svga/svga_tgsi.h index 896c90a..d132525 100644 --- a/src/gallium/drivers/svga/svga_tgsi.h +++

Re: [Mesa3d-dev] [PATCH] Make sure we use only signed/unsigned ints with bitfields.

2010-01-06 Thread Keith Whitwell
Looks good to me Michal. Keith On Wed, 2010-01-06 at 02:26 -0800, michal wrote: Keith Whitwell wrote on 2010-01-06 10:43: On Wed, 2010-01-06 at 00:50 -0800, michal wrote: diff --git a/src/gallium/drivers/svga/svga_tgsi.h b/src/gallium/drivers/svga/svga_tgsi.h index 896c90a..d132525

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread Christoph Bumiller
On 06.01.2010 08:36, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22 10:00: Marek Olšák wrote on 2009-12-22 08:40: Hi, I noticed that gallium/auxiliary/util/u_format.csv contains some weird swizzling, for example see this: $ grep zyxw u_format.csv

Re: [Mesa3d-dev] [PATCH] condition always evaluates to false

2010-01-06 Thread roel kluin
On Tue, Jan 5, 2010 at 11:51 PM, Brian Paul bri...@vmware.com wrote: Roel Kluin wrote: These can never be true. Signed-off-by: Roel Kluin roel.kl...@gmail.com ---  src/gallium/drivers/i965/brw_wm_emit.c  |    2 +-  src/mesa/drivers/dri/i915/intel_tris.c  |    2 +-  

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread José Fonseca
On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22 10:00: Marek Olšák wrote on 2009-12-22 08:40: Hi, I noticed that gallium/auxiliary/util/u_format.csv contains some weird swizzling, for example see this:

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread michal
José Fonseca wrote on 2010-01-06 15:03: On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22 10:00: Marek Olšák wrote on 2009-12-22 08:40: Hi, I noticed that

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread michal
Christoph Bumiller wrote on 2010-01-06 12:08: On 06.01.2010 08:36, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22 10:00: Marek Olšák wrote on 2009-12-22 08:40: Hi, I noticed that gallium/auxiliary/util/u_format.csv contains some weird swizzling, for

Re: [Mesa3d-dev] [PATCH] condition always evaluates to false

2010-01-06 Thread Brian Paul
On Wed, Jan 6, 2010 at 5:54 AM, roel kluin roel.kl...@gmail.com wrote: On Tue, Jan 5, 2010 at 11:51 PM, Brian Paul bri...@vmware.com wrote: Roel Kluin wrote: These can never be true. Signed-off-by: Roel Kluin roel.kl...@gmail.com ---  src/gallium/drivers/i965/brw_wm_emit.c  |    2 +-  

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread Michel Dänzer
On Wed, 2010-01-06 at 14:03 +, José Fonseca wrote: On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22 10:00: Marek Olšák wrote on 2009-12-22 08:40: Hi, I noticed that

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread José Fonseca
On Wed, 2010-01-06 at 06:11 -0800, michal wrote: José Fonseca wrote on 2010-01-06 15:03: On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22 10:00: Marek Olšák wrote on 2009-12-22 08:40:

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread michal
José Fonseca wrote on 2010-01-06 15:26: On Wed, 2010-01-06 at 06:11 -0800, michal wrote: José Fonseca wrote on 2010-01-06 15:03: On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22 10:00:

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread michal
Michel Dänzer wrote on 2010-01-06 15:23: On Wed, 2010-01-06 at 14:03 +, José Fonseca wrote: On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22 10:00: Marek Olšák wrote on 2009-12-22 08:40:

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread José Fonseca
On Wed, 2010-01-06 at 06:32 -0800, michal wrote: Michel Dänzer wrote on 2010-01-06 15:23: On Wed, 2010-01-06 at 14:03 +, José Fonseca wrote: On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22 10:00:

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread Michel Dänzer
On Wed, 2010-01-06 at 14:32 +, José Fonseca wrote: On Wed, 2010-01-06 at 06:23 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:03 +, José Fonseca wrote: On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal wrote on 2010-01-06 07:58: michal wrote on 2009-12-22

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread Michel Dänzer
On Wed, 2010-01-06 at 15:51 +0100, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:32 +, José Fonseca wrote: On Wed, 2010-01-06 at 06:23 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:03 +, José Fonseca wrote: On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread José Fonseca
On Wed, 2010-01-06 at 06:51 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:32 +, José Fonseca wrote: On Wed, 2010-01-06 at 06:23 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:03 +, José Fonseca wrote: On Tue, 2010-01-05 at 23:36 -0800, michal wrote: michal

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread José Fonseca
On Wed, 2010-01-06 at 07:03 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 15:51 +0100, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:32 +, José Fonseca wrote: On Wed, 2010-01-06 at 06:23 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:03 +, José Fonseca wrote: On

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread Keith Whitwell
On Wed, 2010-01-06 at 07:13 -0800, José Fonseca wrote: On Wed, 2010-01-06 at 06:51 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:32 +, José Fonseca wrote: On Wed, 2010-01-06 at 06:23 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:03 +, José Fonseca wrote: On

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread Michel Dänzer
On Wed, 2010-01-06 at 15:13 +, José Fonseca wrote: On Wed, 2010-01-06 at 06:51 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:32 +, José Fonseca wrote: On Wed, 2010-01-06 at 06:23 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:03 +, José Fonseca wrote: On

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread Michel Dänzer
On Wed, 2010-01-06 at 15:18 +, Keith Whitwell wrote: On Wed, 2010-01-06 at 07:13 -0800, José Fonseca wrote: On Wed, 2010-01-06 at 06:51 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:32 +, José Fonseca wrote: On Wed, 2010-01-06 at 06:23 -0800, Michel Dänzer wrote: On

[Mesa3d-dev] [PATCH] nv50: add missing parentheses in nv50_query_result()

2010-01-06 Thread Roel Kluin
NOUVEAU_BO_RD is defined (1 2), and `|' has higher precedence than `?' so the second argument of nouveau_bo_map was always 0. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- src/gallium/drivers/nv50/nv50_query.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Mesa3d-dev] Mystery of u_format.csv

2010-01-06 Thread Alex Deucher
2010/1/6 Michel Dänzer mic...@daenzer.net: On Wed, 2010-01-06 at 15:18 +, Keith Whitwell wrote: On Wed, 2010-01-06 at 07:13 -0800, José Fonseca wrote: On Wed, 2010-01-06 at 06:51 -0800, Michel Dänzer wrote: On Wed, 2010-01-06 at 14:32 +, José Fonseca wrote: On Wed, 2010-01-06 at

Re: [Mesa3d-dev] [PATCH] Make sure we use only signed/unsigned ints with bitfields.

2010-01-06 Thread michal
Keith Whitwell wrote on 2010-01-06 11:31: Looks good to me Michal. Thanks, commited. -- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development

[Mesa3d-dev] [PATCH] win32_menu: add missing parentheses in mapMenu()

2010-01-06 Thread Roel Kluin
`|' has higher precedence than `?'. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- src/glut/glx/win32_menu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/glut/glx/win32_menu.c b/src/glut/glx/win32_menu.c index 5ce264d..d8e336c 100644 ---

[Mesa3d-dev] [PATCH] test index bounds before array element

2010-01-06 Thread Roel Kluin
Check whether the index is within bounds before accessing the array. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- src/mesa/drivers/dri/tdfx/tdfx_dd.c |2 +- src/mesa/shader/nvfragparse.c |2 +- src/mesa/shader/prog_optimize.c |2 +- 3 files changed, 3 insertions(+), 3

Re: [Mesa3d-dev] [PATCH] nv50: add missing parentheses in nv50_query_result()

2010-01-06 Thread Brian Paul
Roel Kluin wrote: NOUVEAU_BO_RD is defined (1 2), and `|' has higher precedence than `?' so the second argument of nouveau_bo_map was always 0. Applied to 7.7 branch. Thanks. -Brian -- This SF.Net email is

Re: [Mesa3d-dev] [PATCH] win32_menu: add missing parentheses in mapMenu()

2010-01-06 Thread Brian Paul
Roel Kluin wrote: `|' has higher precedence than `?'. Signed-off-by: Roel Kluin roel.kl...@gmail.com Applied to 7.7 branch. Thanks. -Brian -- This SF.Net email is sponsored by the Verizon Developer Community Take

Re: [Mesa3d-dev] [PATCH] test index bounds before array element

2010-01-06 Thread Brian Paul
Roel Kluin wrote: Check whether the index is within bounds before accessing the array. Applied to 7.7 branch. -Brian -- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's

Re: [Mesa3d-dev] [PATCH] test index bounds before array element

2010-01-06 Thread roel kluin
On Wed, Jan 6, 2010 at 5:49 PM, Brian Paul bri...@vmware.com wrote: Roel Kluin wrote: Check whether the index is within bounds before accessing the array. Applied to 7.7 branch. -Brian I just realized the last one (affecting src/mesa/shader/prog_optimize.c) is wrong. Should I resend it

[Mesa3d-dev] [mesa] svga: Fix error: cannot take address of bit-field 'texture_target' in svga_tgsi.h

2010-01-06 Thread Sedat Dilek
Hi, this patch fixes a build-error in mesa GIT master after... commit 251363e8f1287b54dc7734e690daf2ae96728faf (patch) configs: set INTEL_LIBS, INTEL_CFLAGS, etcmaster From my build-log: ... In file included from svga_pipe_fs.c:37: svga_tgsi.h: In function 'svga_fs_key_size': svga_tgsi.h:122:

Re: [Mesa3d-dev] [mesa] svga: Fix error: cannot take address of bit-field 'texture_target' in svga_tgsi.h

2010-01-06 Thread Brian Paul
Sedat Dilek wrote: Hi, this patch fixes a build-error in mesa GIT master after... commit251363e8f1287b54dc7734e690daf2ae96728faf (patch) configs: set INTEL_LIBS, INTEL_CFLAGS, etcmaster From my build-log: ... In file included from svga_pipe_fs.c:37: svga_tgsi.h: In function

Re: [Mesa3d-dev] [mesa] svga: Fix error: cannot take address of bit-field 'texture_target' in svga_tgsi.h

2010-01-06 Thread Sedat Dilek
OK. That's the next one :-) ... In file included from r300_emit.c:36: r300_state_inlines.h: In function ‘r300_translate_tex_filters’: r300_state_inlines.h:263: error: ‘is_anisotropic’ undeclared (first use in this function) r300_state_inlines.h:263: error: (Each undeclared identifier is reported

Re: [Mesa3d-dev] [mesa] svga: Fix error: cannot take address of bit-field 'texture_target' in svga_tgsi.h

2010-01-06 Thread Keith Whitwell
This looks like my fault. It would be nice to have the r300 and nvidia drivers building by default (eg on linux-debug builds), even if they don't create full drivers, so that a single build can get greater coverage. Keith On Wed, 2010-01-06 at 09:09 -0800, Sedat Dilek wrote: OK. That's the

Re: [Mesa3d-dev] [mesa] svga: Fix error: cannot take address of bit-field 'texture_target' in svga_tgsi.h

2010-01-06 Thread Brian Paul
r300_translate_tex_filters() was missing the is_anisotropic parameter. I fixed that, but there may be other issues. Looks like some of the r300 code isn't c99. -Brian Sedat Dilek wrote: OK. That's the next one :-) ... In file included from r300_emit.c:36: r300_state_inlines.h: In

Re: [Mesa3d-dev] [mesa] svga: Fix error: cannot take address of bit-field 'texture_target' in svga_tgsi.h

2010-01-06 Thread michal
Brian Paul wrote on 2010-01-06 18:07: Sedat Dilek wrote: Hi, this patch fixes a build-error in mesa GIT master after... commit 251363e8f1287b54dc7734e690daf2ae96728faf (patch) configs: set INTEL_LIBS, INTEL_CFLAGS, etcmaster From my build-log: ... In file included from svga_pipe_fs.c:37:

Re: [Mesa3d-dev] [mesa] svga: Fix error: cannot take address of bit-field 'texture_target' in svga_tgsi.h

2010-01-06 Thread Sedat Dilek
Compile-tested OK. - Sedat - On Wed, Jan 6, 2010 at 6:39 PM, michal mic...@vmware.com wrote: Brian Paul wrote on 2010-01-06 18:07: Sedat Dilek wrote: Hi, this patch fixes a build-error in mesa GIT master after... commit  251363e8f1287b54dc7734e690daf2ae96728faf (patch) configs: set

[Mesa3d-dev] Redundant assertions: unsigned = 0, remove?

2010-01-06 Thread Roel Kluin
I also found several tests on unsigned variables which do nothing. should they be removed or changed otherwise? Roel backref 3: src_x ---[ vi src/gallium/auxiliary/util/u_rect.c +30 ]--- void util_copy_rect(ubyte * dst, enum pipe_format format, unsigned dst_stride,

[Mesa3d-dev] [RFC] add support to double opcodes

2010-01-06 Thread Igor Oliveira
Hi, the patches add support to double opcodes in gallium/tgsi. It just implement some opcodes i like to know if someone has suggestion about the patches. Igor From e856e2aa3b801fc6f386a88df646a396c27d8ee8 Mon Sep 17 00:00:00 2001 From: Igor Oliveira igor.olive...@openbossa.org Date: Wed, 6 Jan

Re: [Mesa3d-dev] [PATCH] condition always evaluates to false

2010-01-06 Thread Eric Anholt
On Tue, 05 Jan 2010 23:13:54 +0100, Roel Kluin roel.kl...@gmail.com wrote: These can never be true. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- src/gallium/drivers/i965/brw_wm_emit.c |2 +- src/mesa/drivers/dri/i915/intel_tris.c |2 +-

[Mesa3d-dev] [PATCH] Fix Viewport in _mesa_meta_GenerateMipmap

2010-01-06 Thread Pierre Willenbrock
Hi list, the first of these two patches fixes _mesa_meta_GenerateMipmap to update the viewport and projection matrix after changing the destination mipmap level. Before, pixels would get clipped to the boundaries of the original DrawBuffer, which may be smaller than the second mipmap level. The

Re: [Mesa3d-dev] [RFC] add support to double opcodes

2010-01-06 Thread Zack Rusin
On Wednesday 06 January 2010 14:56:35 Igor Oliveira wrote: Hi, the patches add support to double opcodes in gallium/tgsi. It just implement some opcodes i like to know if someone has suggestion about the patches. Hi Igor, first of all this should probably go into a feature branch because

Re: [Mesa3d-dev] [PATCH] Fix Viewport in _mesa_meta_GenerateMipmap

2010-01-06 Thread Eric Anholt
On Wed, 06 Jan 2010 23:30:46 +0100, Pierre Willenbrock pie...@pirsoft.de wrote: Hi list, the first of these two patches fixes _mesa_meta_GenerateMipmap to update the viewport and projection matrix after changing the destination mipmap level. Before, pixels would get clipped to the

Re: [Mesa3d-dev] [PATCH] Fix Viewport in _mesa_meta_GenerateMipmap

2010-01-06 Thread Brian Paul
Pierre Willenbrock wrote: Hi list, the first of these two patches fixes _mesa_meta_GenerateMipmap to update the viewport and projection matrix after changing the destination mipmap level. Before, pixels would get clipped to the boundaries of the original DrawBuffer, which may be smaller

[Mesa3d-dev] A patch to get rbug-gui working with recent util_format and libgallium.a

2010-01-06 Thread Mike Stroyan
Hello folks. I started at LunarG this week and have been getting more familiar with the gallium code. I noticed that rbug-gui has not been updated to match the recent changes to the util_format. Here is a patch that switches from the pr_* functions to util_format functions. (It also adds

[Mesa3d-dev] gallium: add overlapping blit support to u_blitter

2010-01-06 Thread Dave Airlie
This makes the r300g + X.org state tracker work a bit better, I can start X + xterm + metacity and drag a window around now at least. A full gnome session seems to have other issuess. Dave.From b8f1d1cf45aa23c74b2d150058506a6a27737d25 Mon Sep 17 00:00:00 2001 From: Dave Airlie

Re: [Mesa3d-dev] Redundant assertions: unsigned = 0, remove?

2010-01-06 Thread Brian Paul
Roel Kluin wrote: I also found several tests on unsigned variables which do nothing. should they be removed or changed otherwise? I think they could be removed. However, note that src/glx/x11/indirect.c is generated by a python script. The generator would have to be changed. I'd rather not

Re: [Mesa3d-dev] [PATCH] test index bounds before array element

2010-01-06 Thread Brian Paul
roel kluin wrote: On Wed, Jan 6, 2010 at 5:49 PM, Brian Paul bri...@vmware.com wrote: Roel Kluin wrote: Check whether the index is within bounds before accessing the array. Applied to 7.7 branch. -Brian I just realized the last one (affecting src/mesa/shader/prog_optimize.c) is wrong.

Re: [Mesa3d-dev] gallium: add overlapping blit support to u_blitter

2010-01-06 Thread Brian Paul
On Wed, Jan 6, 2010 at 6:50 PM, Dave Airlie airl...@linux.ie wrote: This makes the r300g + X.org state tracker work a bit better, I can start X + xterm + metacity and drag a window around now at least. A full gnome session seems to have other issuess. Hi Dave, a couple comments on your

[Mesa3d-dev] Build failure on AIX/xlc with current master

2010-01-06 Thread tom fogal
I'm getting a build failure on AIX --with-driver=xlib via the autoconf build system. It appears as if creating libglslpp.a libglslcl.a and then merging them into the single libmesa.a is not supported. Is there a compelling reason for the build to be this way (other than convenience)? Would

Re: [Mesa3d-dev] [mesa] svga: Fix error: cannot take address of bit-field 'texture_target' in svga_tgsi.h

2010-01-06 Thread Sedat Dilek
Thanks, your patch fixed the problem. - Sedat - On Wed, Jan 6, 2010 at 6:38 PM, Brian Paul bri...@vmware.com wrote: r300_translate_tex_filters() was missing the is_anisotropic parameter.  I fixed that, but there may be other issues.  Looks like some of the r300 code isn't c99. -Brian