This lets user have a small window of the context of
the current message relative to other threads.
---
lib/PublicInbox/Feed.pm | 3 +-
lib/PublicInbox/SearchView.pm | 2 +-
lib/PublicInbox/View.pm | 160 +-
3 files changed, 100
Oops, these were only introduced during the hybrid flat thread
view reworking and never deployed.
---
lib/PublicInbox/View.pm | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 17d6de5..44130b9 100644
---
uce server/caching overheads
but I still find it more usable in some situations.
What I still enjoy is being able to toggle between
[flat|threaded] views.
Eric Wong (13):
www: implement hybrid flat+thread conversation view
www: use WwwStream for dumping thread and search views
v
This should make formatting more apparent since we can rely
on semantics.
---
lib/PublicInbox/View.pm | 36 ++--
1 file changed, 22 insertions(+), 14 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 27dd155..9d48dfc 100644
---
It may be 2016, but top-posting still makes me cringe :<
Eric Wong (2):
view: improve readability of msg_reply with here-doc
view: reference posting style article on Wikipedia
lib/PublicInbox/View.pm | 42 --
1 file changed, 28 inserti
I'm not sure what to show here, actually; but it's better
than triggering an uninitialized variable warning.
---
lib/PublicInbox/SearchView.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 30a310c..d019a0f 100644
---
Oops, this endpoint needs testing :x
---
lib/PublicInbox/View.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index db2bd20..b4f80d1 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -129,7 +129,7 @@ sub
This acts like the Atom feed; but should be viewable directly
from browsers.
---
lib/PublicInbox/Feed.pm | 27 +++
lib/PublicInbox/WWW.pm | 10 +-
2 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
This should be more accessible to readers on narrow terminals
(or giant fonts) while providing a chronological view which
is also aware of message threading relationships.
---
TODO | 2 -
lib/PublicInbox/SearchView.pm | 42 +++
lib/PublicInbox/View.pm | 248
This reduces the level of indirection to reach certain objects
within the hash and there are no namespace or lifetime conflicts
anyways.
---
lib/PublicInbox/Feed.pm | 25 +++
lib/PublicInbox/SearchView.pm | 25 +++
lib/PublicInbox/View.pm | 149
This makes the top permalink/raw as well as the In-Reply-To
show up without search. While we're at it, try to make
the links on the thread index from the "X siblings, Y replies"
more obvious.
---
lib/PublicInbox/View.pm | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff
This is friendlier for people on small screens and usually
eliminates the need to scroll horizontally.
---
lib/PublicInbox/View.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 44130b9..22d7250 100644
---
This encapsulates an entire PSGI response array, hopefully
making it easier to generate responses and avoid typos when
setting the Content-Type.
---
lib/PublicInbox/Feed.pm | 3 +--
lib/PublicInbox/SearchView.pm | 4 +---
lib/PublicInbox/View.pm | 8 +++-
lib/PublicInbox/WWW.pm
This should give readers a better idea of what to expect.
---
lib/PublicInbox/View.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 22d7250..fac53eb 100644
--- a/lib/PublicInbox/View.pm
+++
Oops :x I really need to whip check-inbox.perl into
shape or at least start running it, again.
Fixes: e29518088b3f ("view: fix up some HTML injection via Message-ID vectors")
---
lib/PublicInbox/View.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This fixes the '^' (up) link in the $INBOX/new.html endpoint
for search-less displays.
---
lib/PublicInbox/View.pm | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 8487c2a..11d8dd5 100644
---
Eating our own dogfood, git://80x24.org/public-inbox remains
available for those without curl or up-to-date TLS stack/certs.
Eric Wong (2):
githttpbackend: allow git to be a regular scalar string
update git repo location to https:// using GitHTTPBackend.pm
Documentation/dc-dlvr-spam
No point in forcing users to pass a hashref/object to
get a single git directory.
---
lib/PublicInbox/GitHTTPBackend.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm
b/lib/PublicInbox/GitHTTPBackend.pm
index 7267a1d..4f58c6b 100644
---
We want to avoid the bare './' wherever possible, but it
doesn't seem possible here.
---
lib/PublicInbox/WwwStream.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index 6de1b31..d9abb5a 100644
---
Hrm... is there a more obvious way to do an internal API for
this while still being streamable?
---
lib/PublicInbox/SearchView.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index d019a0f..ce1eff1 100644
---
This means we can still show non-git users a somewhat browseable
URL with a link to the README.html file while allowing git users
to type less when cloning.
All of the following are supported:
git clone https://public-inbox.org/ public-inbox
git clone https://public-inbox.org/public-inbox
git
Note to self: remember to run tests
Fixes: 52052329aced ("git: allow cloning from the URL root, too")
---
lib/PublicInbox/WwwStream.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index 87a461e..fdab4da 100644
---
Probably better than bloating our own API with configurable
warning streams and such...
---
t/watch_maildir.t | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/watch_maildir.t b/t/watch_maildir.t
index 2138963..3969c80 100644
--- a/t/watch_maildir.t
+++ b/t/watch_maildir.t
Well, I'm fumbling along with this config. Might as well
fumble along with it publically :)
---
examples/varnish-4.vcl | 74 ++
1 file changed, 74 insertions(+)
create mode 100644 examples/varnish-4.vcl
diff --git a/examples/varnish-4.vcl
Opposing goals here, yes, I'm hell bent on sticking to a
scripting language for hackability and eliminating the need to
provide reproducible builds. On the other hand, this should
be able to scale to handle LKML.
Eric Wong (2):
TODO: update documentation for performance items
More work on on the Plack::Request/CGI.pm removal front,
No need to access the PSGI env through an extra hash lookup.
---
lib/PublicInbox/SearchView.pm | 2 +-
lib/PublicInbox/WWW.pm| 9 -
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/SearchView.pm
Plack::Request will check the request body by merely
calling "param", totally unnecessary and sneaky.
---
lib/PublicInbox/View.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index fd882aa..1527959 100644
---
This is less code and hopefully easier-to-understand.
---
lib/PublicInbox/ExtMsg.pm | 102 --
lib/PublicInbox/Inbox.pm | 5 +++
2 files changed, 49 insertions(+), 58 deletions(-)
diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
This is lighter and we can work further towards eliminating
our Plack::Request dependency entirely.
---
lib/PublicInbox/Feed.pm | 4 +---
lib/PublicInbox/Inbox.pm | 12
lib/PublicInbox/Mbox.pm | 2 +-
lib/PublicInbox/WWW.pm | 2 +-
lib/PublicInbox/WwwStream.pm
Should be pretty obvious, and the iffstat looks good :)
Eric Wong (6):
TODO: clarify streaming Email::MIME replacement
inbox: base_url method takes PSGI env hashref instead
extmsg: rework to use Inbox objects
www: use PSGI env directly
view: rely on internal query
I bet there's a billion other improvements to be made elsewhere.
---
TODO | 1 +
1 file changed, 1 insertion(+)
diff --git a/TODO b/TODO
index 30ba38b..644fa03 100644
--- a/TODO
+++ b/TODO
@@ -53,6 +53,7 @@ all need to be considered for everything we introduce)
* streaming Email::MIME
Lighter and ever-so-slightly faster!
Most importantly, this won't do non-obvious stuff behind our
backs like trying to parse a POST request body for a query
string param.
---
lib/PublicInbox/Feed.pm | 9 +
lib/PublicInbox/WWW.pm| 13 +
script/public-inbox-httpd | 1 -
GoogleGroups URLs often contain '!' in them
---
lib/PublicInbox/Linkify.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Linkify.pm b/lib/PublicInbox/Linkify.pm
index 25f0b48..d4df689 100644
--- a/lib/PublicInbox/Linkify.pm
+++
A couple of minor cleanups and shutdown improvement for NNTP.
Eric Wong (3):
config: introduce each_inbox for iteration
nntp: simplify update_idle_time
nntp: respect 3 minute idle time for shutdown
lib/PublicInbox/Config.pm | 18 ++
lib/PublicInbox/ExtMsg.pm
This ought to make things easier when we add TLS support.
---
lib/PublicInbox/NNTP.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 4b116a7..b07e184 100644
--- a/lib/PublicInbox/NNTP.pm
+++
This avoids breaking clients on graceful shutdown since
NNTP responses should usually be quick.
---
lib/PublicInbox/NNTP.pm | 15 ---
t/nntpd.t | 1 +
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index
There is no point for diverting readers' attention with
an unnecessary link, here.
---
lib/PublicInbox/View.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 1527959..e8395ae 100644
--- a/lib/PublicInbox/View.pm
+++
Less configuration and more explanation is better :)
Eric Wong (2):
examples: remove X-Forwarded-For mentions
examples/varnish-4.vcl: comments and tweaks
examples/public-inbox.psgi | 2 +-
examples/varnish-4.vcl | 34 ++
script/public-inbox.cgi
This will allow cache proxies such as Varnish to avoid
caching data sent by us.
---
lib/PublicInbox/GitHTTPBackend.pm | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm
b/lib/PublicInbox/GitHTTPBackend.pm
index
git.git documentation uses "clonable" so that's probably
a better term than "clone-able". Also, shorten the section
for retrieving our code and remove an obvious typo.
---
lib/PublicInbox/WwwStream.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Document and simplify things a bit. The major functional change
is we no longer waste space caching objects from dumb HTTP
clones.
---
examples/varnish-4.vcl | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/examples/varnish-4.vcl
They're needless for actual display once outside of email
headers. But we will still show them when displaying mock
headers in the permalink view.
---
lib/PublicInbox/Address.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Address.pm
We overuse streaming, here. Allow Content-Length to be
calculated in this case.
---
lib/PublicInbox/Feed.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 045e495..d88421b 100644
--- a/lib/PublicInbox/Feed.pm
+++
Not deployed to clear-net sites, yet, I'm reindexing the
http://czquwvybam4bgbro.onion/git/ onion right now.
Eric Wong (2):
search: drop pointless range processors for Unix timestamp
search: add MMDD search range via "d:" prefix
lib/PublicInbox/Search.
Josh Triplett <j...@joshtriplett.org> wrote:
> On Tue, Aug 16, 2016 at 09:30:27AM +0000, Eric Wong wrote:
> > Jakub Narębski <jna...@gmail.com> wrote:
> > > It's a great pity that https://public-inbox.org/ is just
> > > directory index, not a true home p
Also, at least add one of the Tor mirrors (the rest will
be discoverable through the mirrors themselves).
---
Documentation/include.mk | 3 ++-
HACKING | 19 +++
README | 5 +
3 files changed, 22 insertions(+), 5 deletions(-)
diff --git
Junio C Hamano wrote:
> Stefan Beller writes:
> > * Should the public-inbox offer another link to patches 1-n, without
> > the cover letter? Or should it add instructions:
> >
> > If this is a patch series you can apply it locally as:
> >
Always plenty to do while working on this...
---
TODO | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/TODO b/TODO
index b85887a..3163b8a 100644
--- a/TODO
+++ b/TODO
@@ -11,15 +11,28 @@ all need to be considered for everything we introduce)
* POP3 server,
There's no need to hold everything in memory, here,
since apparently "foreach" will read everything at
once in array context
(for some reason, I thought Perl5 was smart enough
to avoid creating a temporary array, here...)
---
lib/PublicInbox/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1
In some messages, these headers exist, but have empty values.
Do not let empty values throw off our search indexer to tie
threads together, as it can make non-sensical threads grouped
to a Message-Id of "" (empty string).
See
We cannot always reuse thread IDs since our threading
logic may change as bugs are fixed.
---
lib/PublicInbox/SearchIdx.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 1142ca7..bc003c6 100644
---
We cannot distinguish between legitimate ghosts and mis-threaded
messages before commit 83425ef12e4b65cdcecd11ddcb38175d4a91d5a0
("searchidx: deal with empty In-Reply-To and References headers")
so we must rebuild the index in parallel to fix it.
---
lib/PublicInbox/Search.pm | 4 +++-
1 file
We cannot rely on in-place --reindex to handle thread_id
changes when we fix threading bugs in the search indexer
like in commit 83425ef12e4b65cdcecd11ddcb38175d4a91d5a0
("searchidx: deal with empty In-Reply-To and References headers")
So, bump the schema version and pay the cost of requiring
Oops, that's broken, too. I guess the only way to reindex
after fixing the thread detection is to start from scratch.
This reverts commit 5d91adedf5f33ef1cb87df2a86306ddf370b4f8d.
---
lib/PublicInbox/SearchIdx.pm | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
Xapian can only give estimated results when a result limit is
given to it, so make clear it is an estimate to avoid showing
non-sensical ranges when no results are returned.
---
lib/PublicInbox/SearchView.pm | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git
Some mailing lists add annoying tags into the Subject line which
discourages readers from doing proper mail organization on the
client side. They also waste precious screen space and
attention span.
Remove them from our archives to reduce clutter.
---
MANIFEST | 2
We'll want to allow some degree of configuration for
various mailing lists.
---
lib/PublicInbox/WatchMaildir.pm | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/WatchMaildir.pm b/lib/PublicInbox/WatchMaildir.pm
index 0b284bd..1823c24 100644
---
lines to reduce clutter when mirroring those
archives.
Eric Wong (2):
watchmaildir: allow arguments for filters
add filter for Subject: tags
MANIFEST | 2 ++
lib/PublicInbox/Filter/SubjectTag.pm | 33 +
lib/PublicInbox
Eric Wong <e...@80x24.org> wrote:
> It seems possible for git-send-email(1) to generate repeated
> repeated instances of References and In-Reply-To headers,
> as evidenced in:
>
> https://public-inbox.org/git/2016124541.8216-17-vascomalme...@sapo.pt/raw
RFC to fi
This is fixed in the newest versions of Email::Simple,
but not the version in Debian jessie (2.203)
---
v1 actually broke the intent of the test :x
t/mime.t | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/mime.t b/t/mime.t
index c4bdcf0..b0e2290 100644
--- a/t/mime.t
+++ b/t/mime.t
@@
It seems possible for git-send-email(1) to generate repeated
repeated instances of References and In-Reply-To headers,
as evidenced in:
https://public-inbox.org/git/2016124541.8216-17-vascomalme...@sapo.pt/raw
This causes a mismatch between how our search indexer threads
and how our HTML
This is fixed in the newest versions of Email::Simple,
but not the version in Debian jessie (2.203)
---
t/mime.t | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/mime.t b/t/mime.t
index c4bdcf0..3e29dbc 100644
--- a/t/mime.t
+++ b/t/mime.t
@@ -20,6 +20,7 @@ Content-Type: multipart/signed;
Arif Khokar wrote:
> On 02/13/2017 09:37 AM, Johannes Schindelin wrote:
> >I actually had expected *you* to put in a little bit of an effort, too. In
> >fact, I was very disappointed that you did not even look into porting that
> >script to use public-inbox instead of
PSGI specs already require PATH_INFO to be unescaped;
so our tests were wrong, too.
---
lib/PublicInbox/WWW.pm | 2 +-
t/cgi.t| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 430e6b1..62e4ca4 100644
---
We don't want to be triggering OOM or swapping on weaker
systems when we have dozens of inboxes as potential targets.
---
lib/PublicInbox/WatchMaildir.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/WatchMaildir.pm b/lib/PublicInbox/WatchMaildir.pm
We must call Email::Simple methods directly in our monkey patch
for Email::MIME to call the intended method. Using SUPER in our
subclass would instead hit a different, unintended method in
Email::MIME.
Reported-by: Junio C Hamano
Do not consider this interface stable, but I just needed a
way to remove mis-imported multipart messages so
public-inbox-watch could pick them up again from my Maildir.
---
script/public-inbox-learn | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git
Junio C Hamano wrote:
> Santiago Torres writes:
>
> <>???
>
> Eric, I've noticed that this message
>
>
> http://public-inbox.org/git/20170118182831.pkhqu2np3bh2puei@LykOS.localdomain/
>
> and all messages from Santiago appear empty when they come via
>
"W. Trevor King" <wk...@tremily.us> wrote:
> On Sun, Aug 21, 2016 at 06:37:04PM +, Eric Wong wrote:
> > Btw, for public-inbox, I'm using git-fast-import now, so imports are
> > a bit faster and $GIT_DIR/ssoma.index is no longer used. This was
> > crucial f
"W. Trevor King" <wk...@tremily.us> wrote:
> On Sun, Aug 21, 2016 at 12:08:52PM +, Eric Wong wrote:
> > "W. Trevor King" <wk...@tremily.us> wrote:
> > > This is the ssoma archive (with the data in it). I just set up a
> > > ba
Johannes Schindelin <johannes.schinde...@gmx.de> wrote:
> On Thu, 18 Aug 2016, Eric Wong wrote:
> > Johannes Schindelin <johannes.schinde...@gmx.de> wrote:
> >
> > > Old dogs claim the mail list-approach works for them. Nope. Doesn't.
> > > Else you wo
Stefan Beller wrote:
> Maybe we should invent a patch format that copes with broken whitespace?
No redundant new formats, please. MIME attachments are already
widely-supported and fine by me. But it's not my call for git.
--
unsubscribe: meta+unsubscr...@public-inbox.org
We want the pod2man(1) executable for handling certain
options. Also, use the correct year while we're at it :P
---
Documentation/include.mk | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/include.mk b/Documentation/include.mk
index
Centralization sucks, so we mirror everything.
---
README | 3 +++
1 file changed, 3 insertions(+)
diff --git a/README b/README
index 7618727..3235275 100644
--- a/README
+++ b/README
@@ -88,6 +88,8 @@ Hacking
Source code is available via git:
git clone https://public-inbox.org/
This makes us closer to git.git style (though I'm not quite sure
why we do this...)
---
Documentation/include.mk | 4 ++--
Documentation/public-inbox-mda.pod | 2 +-
scripts/dc-dlvr| 4 ++--
scripts/dc-dlvr.pre| 6 +++---
scripts/report-spam
+Cc meta@public-inbox.org
"W. Trevor King" wrote:
> On Sat, Aug 20, 2016 at 09:36:31PM -0700, W. Trevor King wrote:
> > [2]: git://tremily.us/notmuch-archives.git
Cool!
> This is the ssoma archive (with the data in it). I just set up a
> basic HTTP archive (following [1])
Johannes Schindelin <johannes.schinde...@gmx.de> wrote:
> On Fri, 19 Aug 2016, Eric Wong wrote:
> > Johannes Schindelin <johannes.schinde...@gmx.de> wrote:
> > > On Thu, 18 Aug 2016, Eric Wong wrote:
> > > > Johannes Schindelin <johannes.schinde...@gm
Just having "limiter" in the prefix may confuse
it with something else. Use the full prefix to
avoid this confusion.
---
lib/PublicInbox/Config.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index
Hopefully more folks can download and run public-inbox,
nowadays.
---
.gitignore | 1 +
Documentation/.gitignore| 2 +-
Documentation/include.mk| 25 -
Documentation/public-inbox-config.pod | 151
Josh Triplett <j...@joshtriplett.org> wrote:
> On Tue, Aug 16, 2016 at 09:27:04PM +0000, Eric Wong wrote:
> > As for other projects, I'm not aware of anybody else using it,
> > yet. I have some small projects using it, but most of those are
> > one-off throwaways and I'
This will be important as we will have more of them.
---
Documentation/include.mk | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/include.mk b/Documentation/include.mk
index 4583f95..9d2c3b0 100644
--- a/Documentation/include.mk
+++
Since this is bundled with the source, we might as well use
internal APIs to avoid having duplicate code (and bugs :P)
---
Documentation/include.mk | 3 ++-
Documentation/txt2pre| 30 ++
2 files changed, 12 insertions(+), 21 deletions(-)
diff --git
This will allow reasonable titles to be generated for
manpages.
---
Documentation/include.mk | 2 +-
Documentation/txt2pre| 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/include.mk b/Documentation/include.mk
index 51a914b..4583f95 100644
---
We'll keep supporting "publicinboxlearn" indefinitely,
but "publicinboxwatch" is probably more appropriate
at the moment.
Noticed while writing documentation.
---
lib/PublicInbox/WatchMaildir.pm | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git
in [PATCH 7/10] to maintain
compatibility with Debian 7.x wheezy installs. The in-place
reindexing would've been expensive anyways, so perhaps the
schema bump is a good idea, anyways, as creating a fresh index
should be faster than --reindex.
Eric Wong (10):
search: allow searching user
We only document the "s:" anyways. While the long name is more
descriptive, the ambiguity makes agnostic caching (by Varnish or
similar) slightly harder and longer URLs are more likely to be
accidentally truncated when shared.
---
lib/PublicInbox/Search.pm | 1 -
t/search.t| 14
Email::MIME internally assumes "text/plain" for messages
missing a Content-Type, but does not expose that in the
Email::MIME::content_type API method. We must assume it
ourselves to avoid uninitialized value warnings for the
rare (nowadays) MUAs which do not set it.
---
lib/PublicInbox/View.pm |
This reduces duplication, slightly. We may be using it
yet again in a to-be-introduced function (or we may not
introduce it).
---
lib/PublicInbox/Import.pm | 37 ++---
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/lib/PublicInbox/Import.pm
For now, we will document this since it allows better
performance without the burden of extensions. Perhaps one day
far in the future Perl can natively support vfork(2) AND that
version of Perl will be widely available, but I suspect that day
is at least a decade away, if not two:
The existing string -> number date range Xapian query is good
enough, and having too much flexibility is probably bad for
caching (as well as increasing our attack surface, because
parsing queries is tricky).
Tags-as-skiplists are probably not worth the effort given
Xapian, and we may have to
This clarifies the code somewhat, and we don't care to lazy-load
in NNTP.pm anyways since this is only used for a long-lived
daemon.
---
lib/PublicInbox/NNTP.pm | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index
Copying large arrays is expensive, so avoid it.
This reduces /$INBOX/ time by around 1%.
---
lib/PublicInbox/SearchThread.pm | 25 +
lib/PublicInbox/SearchView.pm | 4 ++--
lib/PublicInbox/View.pm | 4 ++--
3 files changed, 17 insertions(+), 16 deletions(-)
smsg will be undef for ghost messages in a subsequent commit
---
lib/PublicInbox/Inbox.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 414973c..8c63908 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -211,6
It is pointless to increment when setting a true value is
simpler as there is no need to read before writing.
---
lib/PublicInbox/SearchThread.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SearchThread.pm b/lib/PublicInbox/SearchThread.pm
index
This starts to show noticeable performance improvements when
attempting to thread over 400 messages; but the improvement
may not be measurable with less.
However, the resulting code is much shorter and (IMHO)
much easier to understand.
---
MANIFEST| 1 +
This bug was hidden, and we may not be able to efficiently
implement a topmost subroutine with the hash-based (vs
linked-list) based container for threading in the next
commit.
---
lib/PublicInbox/SearchView.pm | 5 ++---
lib/PublicInbox/View.pm | 4 ++--
2 files changed, 4 insertions(+), 5
Some broken (or malicious) mailers may include a generated
Message-ID in its References header, so be prepared for it.
---
t/thread-cycle.t | 39 +--
1 file changed, 25 insertions(+), 14 deletions(-)
diff --git a/t/thread-cycle.t b/t/thread-cycle.t
index
Each node has an entire arrayref of its children nowadays, so
there's no need to waste time and memory creating another one.
---
lib/PublicInbox/View.pm | 63 -
1 file changed, 26 insertions(+), 37 deletions(-)
diff --git a/lib/PublicInbox/View.pm
We have to walk through all the messages after threading
anyways to build the rootset, so we can just delete all
the parent references at that point.
---
lib/PublicInbox/SearchThread.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/SearchThread.pm
We will not care for inexact threading by subject or pruning.
---
lib/PublicInbox/View.pm | 8
1 file changed, 8 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 9359209..a3b2681 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@
501 - 600 of 7360 matches
Mail list logo