Re: [Mimedefang] Seeing weird SMFI errors

2015-08-13 Thread Philip Prindeville
On Aug 11, 2015, at 9:06 PM, Dianne Skoll d...@roaringpenguin.com wrote: On Tue, 11 Aug 2015 16:24:25 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: You'll take a patch? Possibly, but I think I've made my feelings pretty clear, that filter_helo is not really

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-11 Thread Dianne Skoll
On Tue, 11 Aug 2015 14:00:44 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: What about adding ${tls_version} to the list of parameters to filter_helo? Feel free. Regards, Dianne. ___ NOTE: If there is a disclaimer or other legal

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-11 Thread Philip Prindeville
On 08/11/2015 03:25 PM, Dianne Skoll wrote: On Tue, 11 Aug 2015 14:00:44 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: What about adding ${tls_version} to the list of parameters to filter_helo? Feel free. Regards, Dianne. You'll take a patch?

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-11 Thread Philip Prindeville
On 08/04/2015 02:11 PM, Dianne Skoll wrote: On Tue, 4 Aug 2015 14:45:42 -0400 Kevin A. McGrail kmcgr...@pccc.com wrote: On 8/4/2015 2:02 PM, Philip Prindeville wrote: Is there any other way to figure out if this is HELO that follows a STARTTLS? Save state and re-call the helo check again

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-11 Thread Dianne Skoll
On Tue, 11 Aug 2015 16:24:25 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: You'll take a patch? Possibly, but I think I've made my feelings pretty clear, that filter_helo is not really something I like in MIMEDefang. I'd prefer to remove it, to be honest. But yes, if you

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-04 Thread John Nemeth
On Aug 4, 6:04pm, Philip Prindeville wrote: } On 08/04/2015 02:11 PM, Dianne Skoll wrote: } } This is why I resisted even adding a filter_helo callback. It's } basically useless. Anything you can do in filter_helo might as well } be deferred to filter_sender. } } If an SMTP client

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-04 Thread Dianne Skoll
On Tue, 04 Aug 2015 18:04:32 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: [...] Potentially, yes... If it's doing a denial of service attack I might want to notice the rate of incoming connections, save them into a .db file, and start blocking them in filter_relay()

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-04 Thread Philip Prindeville
On 08/04/2015 02:11 PM, Dianne Skoll wrote: On Tue, 4 Aug 2015 14:45:42 -0400 Kevin A. McGrail kmcgr...@pccc.com wrote: On 8/4/2015 2:02 PM, Philip Prindeville wrote: Is there any other way to figure out if this is HELO that follows a STARTTLS? Save state and re-call the helo check again

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-04 Thread Philip Prindeville
On Jul 29, 2015, at 7:22 PM, Philip Prindeville philipp_s...@redfish-solutions.com wrote: On 07/28/2015 08:17 PM, Dianne Skoll wrote: On Tue, 28 Jul 2015 14:27:45 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Am I correctly seeing that filter_helo() is being

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-04 Thread Dianne Skoll
On Tue, 4 Aug 2015 14:45:42 -0400 Kevin A. McGrail kmcgr...@pccc.com wrote: On 8/4/2015 2:02 PM, Philip Prindeville wrote: Is there any other way to figure out if this is HELO that follows a STARTTLS? Save state and re-call the helo check again in filter_sender, perhaps? This is why I

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-04 Thread Dave Osbourne
On 04/08/15 21:20, Kevin A. McGrail wrote: On 8/4/2015 4:11 PM, Dianne Skoll wrote: This is why I resisted even adding a filter_helo callback. It's basically useless. Anything you can do in filter_helo might as well be deferred to filter_sender. +1 If an SMTP client connects, says EHLO

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-04 Thread Kevin A. McGrail
On 8/4/2015 4:11 PM, Dianne Skoll wrote: This is why I resisted even adding a filter_helo callback. It's basically useless. Anything you can do in filter_helo might as well be deferred to filter_sender. +1 If an SMTP client connects, says EHLO and then closes the connection... do we really

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-04 Thread Dianne Skoll
On Tue, 4 Aug 2015 12:02:16 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Err, cipher_bits… or tls_version… except that, if I remember correctly, these can’t be accessed until after filter_sender(), right? True, in MIMEDefang. The symbols are available via the milter API,

Re: [Mimedefang] Seeing weird SMFI errors

2015-08-04 Thread Kevin A. McGrail
On 8/4/2015 2:02 PM, Philip Prindeville wrote: Err, cipher_bits… or tls_version… except that, if I remember correctly, these can’t be accessed until after filter_sender(), right? Is there any other way to figure out if this is HELO that follows a STARTTLS? Save state and re-call the helo

Re: [Mimedefang] Seeing weird SMFI errors

2015-07-29 Thread Philip Prindeville
On 07/28/2015 08:17 PM, Dianne Skoll wrote: On Tue, 28 Jul 2015 14:27:45 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Am I correctly seeing that filter_helo() is being called twice for the same connection? Looks that way. I bet the sequence was: EHLO STARTTLS EHLO

Re: [Mimedefang] Seeing weird SMFI errors

2015-07-28 Thread Dianne Skoll
On Tue, 28 Jul 2015 14:27:45 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Am I correctly seeing that filter_helo() is being called twice for the same connection? Looks that way. I bet the sequence was: EHLO STARTTLS EHLO (this time over the encrypted connection)

Re: [Mimedefang] Seeing weird SMFI errors

2015-07-28 Thread Philip Prindeville
On Jul 27, 2015, at 10:12 AM, Philip Prindeville philipp_s...@redfish-solutions.com wrote: On Jul 27, 2015, at 8:07 AM, Dianne Skoll d...@roaringpenguin.com wrote: On Mon, 27 Jul 2015 00:11:09 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Update: I changed the

Re: [Mimedefang] Seeing weird SMFI errors

2015-07-27 Thread Dianne Skoll
On Mon, 27 Jul 2015 00:11:09 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Update: I changed the timeout argument to T=S:2m;R:2m;E:10m and rebuilt sendmail.cf, then restarted the service. The problem seems to have gone away, but I’m not sure why. Obviously, your filter

Re: [Mimedefang] Seeing weird SMFI errors

2015-07-27 Thread Philip Prindeville
On Jul 27, 2015, at 8:07 AM, Dianne Skoll d...@roaringpenguin.com wrote: On Mon, 27 Jul 2015 00:11:09 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Update: I changed the timeout argument to T=S:2m;R:2m;E:10m and rebuilt sendmail.cf, then restarted the service. The

Re: [Mimedefang] Seeing weird SMFI errors

2015-07-27 Thread Philip Prindeville
On Jul 26, 2015, at 11:26 PM, Philip Prindeville philipp_s...@redfish-solutions.com wrote: On Jul 26, 2015, at 7:42 PM, Dianne Skoll d...@roaringpenguin.com wrote: On Sun, 26 Jul 2015 18:03:38 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Jul 26 17:44:31 mail

[Mimedefang] Seeing weird SMFI errors

2015-07-26 Thread Philip Prindeville
I’m running mimedefang-2.78-2 on Fedora 21, along with sendmail-8.14.9-5. I’m seeing errors when getting email from vger.kernel.org (I get several kernel hacking mailing lists), and getting sporadic delivery. It seems to start when vger connects every 20 minutes or so and attempts to deliver a

Re: [Mimedefang] Seeing weird SMFI errors

2015-07-26 Thread Dianne Skoll
On Sun, 26 Jul 2015 18:03:38 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Jul 26 17:44:31 mail mimedefang[31780]: t6QNhOYb027848: smfi_addheader returned MI_FAILURE Sendmail timed out (that's in the Milter (mimedefang): timeout before data read log line) so it tempfailed

Re: [Mimedefang] Seeing weird SMFI errors

2015-07-26 Thread Philip Prindeville
On Jul 26, 2015, at 7:42 PM, Dianne Skoll d...@roaringpenguin.com wrote: On Sun, 26 Jul 2015 18:03:38 -0600 Philip Prindeville philipp_s...@redfish-solutions.com wrote: Jul 26 17:44:31 mail mimedefang[31780]: t6QNhOYb027848: smfi_addheader returned MI_FAILURE Sendmail timed out (that's