Re: [Mingw-w64-public] [PATCH 1/2] winstorecompat: Fix EnumProcessModule

2018-07-11 Thread Martin Storsjö
On Wed, 11 Jul 2018, Martin Storsjö wrote: On Wed, 11 Jul 2018, Hugo Beauzée-Luyssen wrote: Return the correct size if the buffer isn't big enough, Ah, I had misread the msdn docs; this behaviour makes much more sense. After rereading the docs, I now see how it should be interpteted.

Re: [Mingw-w64-public] [PATCH 1/2] winstorecompat: Fix EnumProcessModule

2018-07-11 Thread Martin Storsjö
On Wed, 11 Jul 2018, Hugo Beauzée-Luyssen wrote: Return the correct size if the buffer isn't big enough, Ah, I had misread the msdn docs; this behaviour makes much more sense. After rereading the docs, I now see how it should be interpteted. and don't reference mods as it is undeclared

Re: [Mingw-w64-public] [PATCH 2/2] winstorecompat: Provide RtlAddFunctionTable on 64bits platforms only

2018-07-11 Thread Hugo Beauzée-Luyssen
On Wed, Jul 11, 2018, at 7:12 PM, Martin Storsjö wrote: > On Wed, 11 Jul 2018, Hugo Beauzée-Luyssen wrote: > > > RtlAddFunctionTable is only available on those. Moreover, so are the > > (P)RUNTIME_FUNCTION types > > No, it's available for armv7 as well (I just checked the msvc import > libs).

Re: [Mingw-w64-public] [PATCH 2/2] winstorecompat: Provide RtlAddFunctionTable on 64bits platforms only

2018-07-11 Thread Martin Storsjö
On Wed, 11 Jul 2018, Hugo Beauzée-Luyssen wrote: RtlAddFunctionTable is only available on those. Moreover, so are the (P)RUNTIME_FUNCTION types No, it's available for armv7 as well (I just checked the msvc import libs). So the correct logic probably is "HAVE_NON_I386" or something like

Re: [Mingw-w64-public] [PATCH 2/2] winstorecompat: Provide RtlAddFunctionTable on 64bits platforms only

2018-07-11 Thread JonY via Mingw-w64-public
On 07/11/2018 12:06 PM, Hugo Beauzée-Luyssen wrote: > RtlAddFunctionTable is only available on those. Moreover, so are the > (P)RUNTIME_FUNCTION types Patches OK. signature.asc Description: OpenPGP digital signature --

[Mingw-w64-public] [PATCH 2/2] winstorecompat: Provide RtlAddFunctionTable on 64bits platforms only

2018-07-11 Thread Hugo Beauzée-Luyssen
RtlAddFunctionTable is only available on those. Moreover, so are the (P)RUNTIME_FUNCTION types --- mingw-w64-libraries/winstorecompat/Makefile.am | 5 - mingw-w64-libraries/winstorecompat/configure.ac| 10 ++ .../winstorecompat/src/RtlAddFunctionTable.c | 8