Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-10 Thread Martin Storsjö
On Thu, 9 Sep 2021, Patrick Northon wrote: On jeudi 9 septembre 2021 17 h 13 min 17 s EDT Martin Storsjö wrote: On Tue, 7 Sep 2021, Patrick Northon wrote: Take number 2. I moved the adjustment to the exponent into __pformat_xldouble. Thanks for this attempt. Now I've poked the

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-09 Thread Patrick Northon via Mingw-w64-public
On jeudi 9 septembre 2021 17 h 13 min 17 s EDT Martin Storsjö wrote: > On Tue, 7 Sep 2021, Patrick Northon wrote: > > Take number 2. I moved the adjustment to the exponent into > > __pformat_xldouble. > > Thanks for this attempt. Now I've poked the implementation to follow it a > bit better to

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-09 Thread Martin Storsjö
On Tue, 7 Sep 2021, Patrick Northon wrote: Take number 2. I moved the adjustment to the exponent into __pformat_xldouble. Thanks for this attempt. Now I've poked the implementation to follow it a bit better to see what happens, and now I see the point in your original form of the patch -

[Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-07 Thread Patrick Northon via Mingw-w64-public
Take number 2. I moved the adjustment to the exponent into __pformat_xldouble.>From b5a399f21cb15f5d3a38b312c7889adede225ff6 Mon Sep 17 00:00:00 2001 From: Patrick Northon Date: Tue, 7 Sep 2021 12:11:20 -0400 Subject: [PATCH] Fix exponent when formatting long double in hexadecimal. Some

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-07 Thread Patrick Northon via Mingw-w64-public
Actually, nevermind, I got confused when I pulled changes but part of my patch was overwritten. I'll make another patch with the new proper indentation. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-07 Thread Patrick Northon via Mingw-w64-public
On lundi 6 septembre 2021 16 h 15 min 57 s EDT Martin Storsj? wrote: > Yes - hopefully someone will approve it soon, and I'd land it, then you > can reapply your changes on top of that. As for why git didn't manage to > apply your patch from the attachment, I don't quite know though. I think you

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-06 Thread Martin Storsjö
On Mon, 6 Sep 2021, Patrick Northon wrote: Yes the indentation is funky because the original has one level with a tab character and spaces for the rest in some parts. I see you have submitted a patch to fix this. Yes - hopefully someone will approve it soon, and I'd land it, then you can

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-06 Thread Patrick Northon via Mingw-w64-public
On lundi 6 septembre 2021 06 h 59 min 40 s EDT Martin Storsj? wrote: > But I feel a little uneasy about the patch - why would we unconditionally > do a "value.__pformat_fpreg_exponent -= 3;" at the start of > __pformat_emit_xfloat? I don't see the corresponding adjustment in > __pformat_xldouble

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-06 Thread Patrick Northon via Mingw-w64-public
On lundi 6 septembre 2021 06 h 59 min 40 s EDT Martin Storsj? wrote: > On Sun, 5 Sep 2021, Patrick Northon via Mingw-w64-public wrote: > > Hi, here's a patch to fix another problem with formatting long doubles in > > > hexadecimal. I found a failing case with a denormalized value: > Thanks for

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-06 Thread Martin Storsjö
On Sun, 5 Sep 2021, Patrick Northon via Mingw-w64-public wrote: Hi, here's a patch to fix another problem with formatting long doubles in hexadecimal. I found a failing case with a denormalized value: Thanks for the patch and testcase! Git didn't manage to automatically apply your patch and

[Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-05 Thread Patrick Northon via Mingw-w64-public
Hi, here's a patch to fix another problem with formatting long doubles in hexadecimal. I found a failing case with a denormalized value: printf("0x2.0p-16385l : %La\n", 0x2.0p-16385l); Complete tests: #include #include #include int main(int argc, char **argv) { puts( " ---