Re: [Mingw-w64-public] [PATCH] Revert "Avoid declaring something extern AND initializing it

2016-09-27 Thread Kai Tietz
Hello dw, please go ahead and apply your patch. Thanks for your work, Kai 2016-09-20 21:35 GMT+02:00 Mario Emmenlauer : > > I can confirm that the patch works for me with gcc-6.1.0 to build qt5. > > Thanks! Mario > > > On 17.09.2016 23:56, David Wohlferd wrote: >> It took

Re: [Mingw-w64-public] [PATCH] Revert "Avoid declaring something extern AND initializing it

2016-09-20 Thread Mario Emmenlauer
I can confirm that the patch works for me with gcc-6.1.0 to build qt5. Thanks! Mario On 17.09.2016 23:56, David Wohlferd wrote: > It took me a bit to figure out the difference between my test code (which > requires the patch) and yours (which can't have it). It was subtle. > > Try this patch

Re: [Mingw-w64-public] [PATCH] Revert \"Avoid declaring something extern AND initializing it

2016-09-19 Thread Kai Tietz
Patch is ok. Please go aheah. Thanks, Kai 2016-09-19 7:09 GMT+02:00 David Wohlferd : > I assume someone still needs to approve this before I push? > > dw > > On 9/18/2016 6:10 AM, Mateusz wrote: >> Hello, >> While I'm not able to reply to the mailing list directly

Re: [Mingw-w64-public] [PATCH] Revert \"Avoid declaring something extern AND initializing it

2016-09-18 Thread David Wohlferd
I assume someone still needs to approve this before I push? dw On 9/18/2016 6:10 AM, Mateusz wrote: > Hello, > While I'm not able to reply to the mailing list directly (forgot to > subscribe). Please discard my patch and commit your new patch. > Thank you for your help! > Best regards, >

Re: [Mingw-w64-public] [PATCH] Revert "Avoid declaring something extern AND initializing it

2016-09-17 Thread David Wohlferd
It took me a bit to figure out the difference between my test code (which requires the patch) and yours (which can't have it). It was subtle. Try this patch (attached). dw On 9/16/2016 1:39 AM, Mateusz wrote: Hello, Since this commit I'm not able to compile Qt5 with GCC 6.1.0 and 6.2.0

[Mingw-w64-public] [PATCH] Revert "Avoid declaring something extern AND initializing it

2016-09-17 Thread Mateusz
Hello, Since this commit I'm not able to compile Qt5 with GCC 6.1.0 and 6.2.0 errors: In file included from D:/msys64/mingw64/x86_64-w64-mingw32/include/mfidl.h:73:0, from example.cc:1: D:/msys64/mingw64/x86_64-w64-mingw32/include/mftransform.h:709:47: error: 'selectany'