Re: [Mingw-w64-public] [PATCH] crt: Allow sleeping for over a second with usleep

2018-02-23 Thread Kai Tietz via Mingw-w64-public
2018-02-23 10:56 GMT+01:00 Martin Storsjö : > On Fri, 23 Feb 2018, Kai Tietz via Mingw-w64-public wrote: > >> Patch looks fine beside one nit. The behavior above 4294967 seconds >> seems to be pretty unexpected, isn't it? > > > Well since the useconds_t parameter is a typedef

Re: [Mingw-w64-public] [PATCH] crt: Allow sleeping for over a second with usleep

2018-02-23 Thread Martin Storsjö
On Fri, 23 Feb 2018, Kai Tietz via Mingw-w64-public wrote: Patch looks fine beside one nit. The behavior above 4294967 seconds seems to be pretty unexpected, isn't it? Well since the useconds_t parameter is a typedef for unsigned int, I wouldn't think that callers expect to be able to sleep

Re: [Mingw-w64-public] [PATCH] crt: Allow sleeping for over a second with usleep

2018-02-23 Thread Kai Tietz via Mingw-w64-public
Patch looks fine beside one nit. The behavior above 4294967 seconds seems to be pretty unexpected, isn't it? Cheers, Kai 2018-02-22 22:17 GMT+01:00 Martin Storsjö : > Even though the POSIX spec of usleep says that the argument shall > be less than one million. Most unixes

[Mingw-w64-public] [PATCH] crt: Allow sleeping for over a second with usleep

2018-02-22 Thread Martin Storsjö
Even though the POSIX spec of usleep says that the argument shall be less than one million. Most unixes allow it and sleeps for over a second if requested (in practice, at least on Linux/glibc and macOS). Prefer matching other actual implementations (which ignore this aspect of the POSIX spec)