Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-04 Thread Biswapriyo Nath
> Could you please elaborate on that? "copy" may mean different things in this > context. Your previous statement answered it: "You're free to read it all you want, APIs are not copyrightable." ___ Mingw-w64-public mailing list

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-04 Thread Jacek Caban
On 02/11/2019 15:46, Biswapriyo Nath wrote: Thank you for the help. I've sent the patch in Wine devel mailing list. Two questions: 1. If I want to improve a file which is in wine-import.sh shell script, should I send patch twice -- one for mingw-w64 and one for wine-devel? Sending to

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-03 Thread Jacek Caban
On 03/11/2019 02:01, Liu Hao wrote: 在 2019/11/3 2:06, Jacek Caban 写道: No, only if you touch files imported from Wine. See wine-import.sh script if you're unsure if it's from Wine. How do we know whether a specific header is imported from Wine or not? By checking Git logs I presume? Yes,

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-03 Thread Liu Hao
在 2019/11/3 2:06, Jacek Caban 写道: > > No, only if you touch files imported from Wine. See wine-import.sh > script if you're unsure if it's from Wine. > > How do we know whether a specific header is imported from Wine or not? By checking Git logs I presume? -- Best regards, LH_Mouse

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-02 Thread Biswapriyo Nath
Thank you for the help. I've sent the patch in Wine devel mailing list. Two questions: 1. If I want to improve a file which is in wine-import.sh shell script, should I send patch twice -- one for mingw-w64 and one for wine-devel? 2. Why doesn't that wine-import.sh shell script conatin all header

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-02 Thread Jacek Caban
On 02/11/2019 10:08, Biswapriyo Nath wrote: Apology for any mistake. I didn't know any upstream-downstream relationship between wine and mingw-w64 repository. Some points: * If there any improvement need for mingw-w64 should I **always** send a patch to wine then mingw-w64? No, only if you

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-02 Thread Biswapriyo Nath
Apology for any mistake. I didn't know any upstream-downstream relationship between wine and mingw-w64 repository. Some points: * If there any improvement need for mingw-w64 should I **always** send a patch to wine then mingw-w64? * Why don't wine or mingw-w64, one of them make other repsitory

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-11-02 Thread Jacek Caban
Hi Biswapriyo, This patch is for a file imported from Wine. We have a script importing things from Wine and such changes would ideally go to Wine and be imported back to mingw-w64. Please consider upstreaming your changes to Wine. This was already committed to mingw-w64, so until they are in

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-10-28 Thread Liu Hao
在 2019/10/28 13:13, Biswapriyo Nath 写道: > Update 1. > > > > Thanks. I pushed this one. -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-10-27 Thread Biswapriyo Nath
Update 1. From bc5513d7b725afe9be405cefacb7c1e63031af01 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Mon, 28 Oct 2019 10:39:23 +0530 Subject: [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/netfw.idl | 58

Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-10-27 Thread Liu Hao
在 2019/10/28 3:25, Biswapriyo Nath 写道: > ... > > > > +interface INetFwProduct; > +interface INetFwProducts; > + > +[ > +uuid(2C5BC43E-3369-4C33-AB0C-BE9469677AF4) > +] > +coclass NetFwRule > +{ > +[default] interface INetFwRule; > +} Seems this

[Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces

2019-10-27 Thread Biswapriyo Nath
... From f460ea9ffec270e63b4fdcf6d12b3d400f756309 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Mon, 28 Oct 2019 00:50:45 +0530 Subject: [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/netfw.idl | 66