date:20170320

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread NightStrike

On Mon, Mar 20, 2017 at 9:42 PM, David Wohlferd  wrote:
>
>> I don't think application/octet-stream is something we would want to
>> enable.  Doesn't that sound like something that would be abused?
>
> I suppose application/octet-stream might be useful if we commonly worked
> with binary files for patches.  But I agree with you, don't do it.
>
> A google search turned up a few other hits:
>
>   * text/x-diff
>   * application/x-patch

text/x-diff is there as of 36 minutes ago.

We have text/x-patch, not application/x-patch.  I don't understand the
difference.  Do you?

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread David Wohlferd


> I don't think application/octet-stream is something we would want to
> enable.  Doesn't that sound like something that would be abused?

I suppose application/octet-stream might be useful if we commonly worked 
with binary files for patches.  But I agree with you, don't do it.

A google search turned up a few other hits:

  * text/x-diff
  * application/x-patch

These aren't a problem for me, but while we're thinking about it.

dw

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread NightStrike

On Mon, Mar 20, 2017 at 9:34 AM, Mateusz Mikuła  wrote:
>  It explains why my patches created with `git format-patch` couldn't
> make it.
>
> Their mime type is `text/x-diff`.

I added text/x-diff to the list.  Give it a shot.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread NightStrike

On Mon, Mar 20, 2017 at 9:23 AM, David Grayson  wrote:
> Oops, that was the problem then.  It was "application/octet-stream" because
> I was constructing the email with the Ruby "mail" gem that doesn't
> recognize ".patch" files as being text.  I'll use better methods in the
> future.

I don't think application/octet-stream is something we would want to
enable.  Doesn't that sound like something that would be abused?

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread Mateusz Mikuła

 I checked it with `file --mime-type something.patch` in MSYS2 shell;
something.patch was generated by git.



-- Original Message --
Subject: Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const
LPVOID' for VerQueryValue
Date: Mon, 20 Mar 2017 23:15:21 +0800
To: Mingw-w64-public
From: Liu Hao
> On 2017/3/20 22:34, Mateusz Mikuła wrote:
>>  It explains why my patches created with `git format-patch` couldn't
>> make it.
>>
>> Their mime type is `text/x-diff`.
> Isn't it our mail clients that guess MIME types of attachments? The diff 
> file doesn't have any MIME type information stored with it.
>



signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread Liu Hao

On 2017/3/20 22:34, Mateusz Mikuła wrote:
>  It explains why my patches created with `git format-patch` couldn't
> make it.
>
> Their mime type is `text/x-diff`.
Isn't it our mail clients that guess MIME types of attachments? The diff 
file doesn't have any MIME type information stored with it.

-- 
Best regards,
LH_Mouse


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread Mateusz Mikuła

 It explains why my patches created with `git format-patch` couldn't
make it.

Their mime type is `text/x-diff`.


-- Original Message --
Subject: Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const
LPVOID' for VerQueryValue
Date: Mon, 20 Mar 2017 00:13:44 -0500
To: Mingw-w64-public
From: Nightstrike
> Do you know what content type you attached as?  We have to explicitly
> allow each type.  The current list is:
>
> application/pgp-signature
> multipart/mixed
> multipart/alternative
> multipart/signed
> text/plain
> text/x-patch
>
> If the content type is left unspecified, then the attachment is
> deleted.  I can add anything you like.
>
> On Sun, Mar 19, 2017 at 10:30 PM, David Grayson  
> wrote:
>> NightStrike,
>>
>> The mailing list swallowed the patch in the message I sent on March 16th.
>> I can see in GMail that I did have a patch attached to my message, but no
>> attachment is visible in the archive here:
>>
>> https://sourceforge.net/p/mingw-w64/mailman/message/35729302/
>>
>> --David Grayson
>>
>> On Sun, Mar 19, 2017 at 7:03 PM, NightStrike  wrote:
>>
>>> On Mar 16, 2017 1:40 PM, "Liu Hao"  wrote:
>>>
>>> On 2017/3/17 0:51, David Grayson wrote:
 I was trying to compile Qt and I ran into an error because Qt is
 passing a const pointer to the first argument of VerQueryValue, which
 is not properly marked as const in the mingw-w64 header files.  This
 patch fixes that.
>>> Please send the patch both inline and as an attachment, since SF mailing
>>> lists swallow attachments frequently.
>>>
>>>
>>> It shouldn't. If it does, tell me and I'll address it. I believe I already
>>> fixed one issue you brought up a while ago. I haven't seen any since.
>>> 
>>> --
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> ___
>>> Mingw-w64-public mailing list
>>> Mingw-w64-public@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>>
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> Mingw-w64-public mailing list
>> Mingw-w64-public@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread David Grayson

Oops, that was the problem then.  It was "application/octet-stream" because
I was constructing the email with the Ruby "mail" gem that doesn't
recognize ".patch" files as being text.  I'll use better methods in the
future.

--David

On Sun, Mar 19, 2017 at 10:13 PM, NightStrike  wrote:

> Do you know what content type you attached as?  We have to explicitly
> allow each type.  The current list is:
>
> application/pgp-signature
> multipart/mixed
> multipart/alternative
> multipart/signed
> text/plain
> text/x-patch
>
> If the content type is left unspecified, then the attachment is
> deleted.  I can add anything you like.
>
> On Sun, Mar 19, 2017 at 10:30 PM, David Grayson 
> wrote:
> > NightStrike,
> >
> > The mailing list swallowed the patch in the message I sent on March 16th.
> > I can see in GMail that I did have a patch attached to my message, but no
> > attachment is visible in the archive here:
> >
> > https://sourceforge.net/p/mingw-w64/mailman/message/35729302/
> >
> > --David Grayson
> >
> > On Sun, Mar 19, 2017 at 7:03 PM, NightStrike 
> wrote:
> >
> >> On Mar 16, 2017 1:40 PM, "Liu Hao"  wrote:
> >>
> >> On 2017/3/17 0:51, David Grayson wrote:
> >> > I was trying to compile Qt and I ran into an error because Qt is
> >> > passing a const pointer to the first argument of VerQueryValue, which
> >> > is not properly marked as const in the mingw-w64 header files.  This
> >> > patch fixes that.
> >> Please send the patch both inline and as an attachment, since SF mailing
> >> lists swallow attachments frequently.
> >>
> >>
> >> It shouldn't. If it does, tell me and I'll address it. I believe I
> already
> >> fixed one issue you brought up a while ago. I haven't seen any since.
> >> 
> >> --
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> ___
> >> Mingw-w64-public mailing list
> >> Mingw-w64-public@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
> >>
> > 
> --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > Mingw-w64-public mailing list
> > Mingw-w64-public@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] Add DBG_PRINTEXCEPTION_WIDE_C exception

2017-03-20 Thread Jon Turney

Windows 10 now has a separate exception for OutputDebugStringW, rather than
converting the string to ANSI and raising DBG_PRINTEXCEPTION_C.

(See 
https://ntquery.wordpress.com/2015/09/07/windows-10-new-anti-debug-outputdebugstringw/)

Signed-off-by: Jon Turney 
---
 mingw-w64-headers/include/ntstatus.h | 1 +
 mingw-w64-headers/include/winnt.h| 1 +
 2 files changed, 2 insertions(+)

diff --git a/mingw-w64-headers/include/ntstatus.h 
b/mingw-w64-headers/include/ntstatus.h
index 6e95af7..49298ee 100644
--- a/mingw-w64-headers/include/ntstatus.h
+++ b/mingw-w64-headers/include/ntstatus.h
@@ -161,6 +161,7 @@
 #define DBG_RIPEXCEPTION ((NTSTATUS)0x40010007)
 #define DBG_CONTROL_BREAK ((NTSTATUS)0x40010008)
 #define DBG_COMMAND_EXCEPTION ((NTSTATUS)0x40010009)
+#define DBG_PRINTEXCEPTION_WIDE_C ((NTSTATUS)(0x4001000A)
 #define RPC_NT_UUID_LOCAL_ONLY ((NTSTATUS)0x40020056)
 #define RPC_NT_SEND_INCOMPLETE ((NTSTATUS)0x400200AF)
 #define STATUS_CTX_CDM_CONNECT ((NTSTATUS)0x400A0004)
diff --git a/mingw-w64-headers/include/winnt.h 
b/mingw-w64-headers/include/winnt.h
index a855801..6ac9f3e 100644
--- a/mingw-w64-headers/include/winnt.h
+++ b/mingw-w64-headers/include/winnt.h
@@ -1299,6 +1299,7 @@ inline ENUMTYPE  ^= (ENUMTYPE , ENUMTYPE b) { 
return (ENUMTYPE &)(((i
 #define DBG_RIPEXCEPTION ((DWORD)0x40010007)
 #define DBG_CONTROL_BREAK ((DWORD)0x40010008)
 #define DBG_COMMAND_EXCEPTION ((DWORD)0x40010009)
+#define DBG_PRINTEXCEPTION_WIDE_C ((DWORD)(0x4001000A)
 #define STATUS_GUARD_PAGE_VIOLATION ((DWORD)0x8001)
 #define STATUS_DATATYPE_MISALIGNMENT ((DWORD)0x8002)
 #define STATUS_BREAKPOINT ((DWORD)0x8003)
-- 
2.8.3


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

[Mingw-w64-public] [PATCH] Add DBG_PRINTEXCEPTION_WIDE_C exception

9 matches

Site Navigation

Mail list logo

Footer information