Re: [Mingw-w64-public] [PATCH] headers: Fix member variable in SYSTEM_POWER_STATUS

/include/winbase.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] inttypes.h section (__CRTDLL__ || __MSVCRT_VERSION__ < 0x200) is always disabled

hecked like `(defined(__USE_MINGW_ANSI_STDIO) && ((__USE_MINGW_ANSI_STDIO + 0) != 0))` but that was changed in a84fc015351e664519359214cbb08d6e21f42814 (which also contained a hunk against 'inttypes.h'). -- Best regards, LIU Hao OpenPGP_signature Description: OpenPG

Re: [Mingw-w64-public] [PATCH] headers: Always warn if gets() is used

now. Thanks. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Implement __gets_chk

insertions(+), 1 deletion(-) create mode 100644 mingw-w64-crt/ssp/gets_chk.c LGTM. Thanks. Side note: I am a bit curious how this function is supposed to be useful. Generally speaking `get()` should never be used. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH] headers: Fix ambigous declaration of the LeaseObtained and LeaseExpires fields of the IP_ADAPTER_INFO structure in iptypes.h

. Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64

Re: [Mingw-w64-public] [PATCH] headers: Add missing FSCTL macros in winioctl.h

--- mingw-w64-headers/include/winioctl.h | 161 ++- 1 file changed, 157 insertions(+), 4 deletions(-) Thanks. This patch looks good to me. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] string_s.h is missing a C++ overload

/string_s.h | 1 + 1 file changed, 1 insertion(+) Thanks. This patch looks good to me. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] headers: Add support for _FORTIFY_SOURCE=3

on the indention before `#define`? Pre-processor directives should not be indented. I have heard that some ancient compilers did not accept such indention, although all modern compilers seem fine about it. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt: Fix misleading indentation warning with gcc

: warning: this 'if' clause does not guard... [-Wmisleading-indentation] Signed-off-by: Biswapriyo Nath --- mingw-w64-crt/secapi/strerror_s.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description

Re: [Mingw-w64-public] [PATCH] headers: _FORTIFY_SOURCE: Enhance missing open() argument warning

atch looks good to me. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Internal compiler error specific to MinGW when using -fstack-clash-protection and __attribute__((noreturn))

在 2023-02-04 20:51, Théo Cavignac 写道: Sorry, I misclicked and sent an half written mail. So as I tried to expose, I am using MinGW with following configuration: This looks like a GCC issue. Reported here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108673 -- Best regards, LIU Hao

Re: [Mingw-w64-public] [PATCH] headers: Generate header from ivectorchangedeventargs.idl

by windows.foundation.collections.h. Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/Makefile.am | 1 + 1 file changed, 1 insertion(+) Thanks for the patch. Pushed now. Really, I thought I must have missed something... -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] headers: Add missing DXGI_COLOR_SPACE_TYPE enumeration values

? Done now. Thanks. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] headers: Add support for _FORTIFY_SOURCE=3

在 2023/2/2 06:41, Christian Franke 写道: This patch allows to use _FORTIFY_SOURCE=3 which is also supported by GLIBC headers. Thanks. This patch looks good to me. Pushed now. BTW does clang support this as well? I suspect we should add a check for clang too. -- Best regards, LIU Hao

Re: [Mingw-w64-public] Undefined reference to _set_doserrno w/ msvcrt

在 2023-01-31 22:05, Luca Bacci 写道: Hi LIU, very sorry for the delay! I have now attached a patch with a proper sign-off Thanks for the patch. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] Undefined reference to _set_doserrno w/ msvcrt

在 2023/1/24 00:07, Luca Bacci 写道: Ok, first tentative here. Let me know if anything needs to be changed! Thank you, Luca Hi Luca. If you are not willing to sign off this patch I will check it in without the 'Signed-off-by:' line. -- Best regards, LIU Hao OpenPGP_signature Description

Re: [Mingw-w64-public] [PATCH] headers: Add __CRT_UUID_DECL declarations in dbgeng.h

in dbgeng.h Required for JDK Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/dbgeng.h | 66 ++ 1 file changed, 66 insertions(+) Thanks. This patch looks good to me. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description

Re: [Mingw-w64-public] Undefined reference to _set_doserrno w/ msvcrt

在 2023-01-24 00:07, Luca Bacci 写道: Ok, first tentative here. Let me know if anything needs to be changed! This patch looks good to me, but would you like to sign off your commit? You can do this with `git commit -s`. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP

Re: [Mingw-w64-public] Undefined reference to _set_doserrno w/ msvcrt

在 2023-01-23 22:19, Luca Bacci 写道: Awesome! Thank you very much, LIU Hao and Martin Storsjö! Yes, making both _set_controlfp, _set_doserrno available in MSVCRT toolchains would be great! Should I prepare a patch? Yes if you can, and we'll be happy to check it in. -- Best regards, LIU

Re: [Mingw-w64-public] [PATCH] crt: Fix builtin declaration mismatch warning with ssp functions

(+), 6 deletions(-) Thanks for catching this. Pushed now, too. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists

Re: [Mingw-w64-public] [PATCH 2/2] headers: Fix declaration of _wcsset_s_l and _wcsnset_s_l

-w64-headers/crt/sec_api/string_s.h | 4 ++-- mingw-w64-headers/crt/sec_api/wchar_s.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) These patches look good to me. Pushed now. Thanks for the work. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] Undefined reference to _set_doserrno w/ msvcrt

of these functions? -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Add more WTS APIs in

在 2023-01-15 13:23, Li Carter 写道: I’m sorry, but I missed `WINAPI` specifier for WTSFreeMemoryEx*, which breaks x86 build Ah, yes. I was distracted by the `BOOL` thing. Fixed in a57cacad31f5766d45959b6c0f9b122918d545fa. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP

Re: [Mingw-w64-public] [PATCH] headers: Add missing const qualifier in rpcdce.h

Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/rpcdce.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] headers: Fix macros in except.h

/crt/excpt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Thanks for the patch. Looks good to me. pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list

Re: [Mingw-w64-public] [PATCH] Add more WTS APIs in

); These should be `WINBOOL` instead of `BOOL`, as the latter denotes something different in Objective-C. Other parts look good to me. Amended and pushed. Thanks for the work. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] Add more WTS APIs in

that they work. Looks like the patch didn't arrive. Please send it as a TXT file instead. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH] crt: Add msxml GUID library

, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Use only __ImageBase symbol in mingw-w64 code

在 2022-12-28 21:38, Pali Rohár 写道: Hello! I'm really really sorry :-( but I totally messed up my devel env during testing this change and this change in v2 does not work :-( OK I reverted these patches on master. New ideas will always be welcome. -- Best regards, LIU Hao

Re: [Mingw-w64-public] [PATCH] crt: Use only __ImageBase symbol in mingw-w64 code

ly, we should always use `__MINGW_LSYMBOL(_image_base__)` and get rid of that `__ImageBase` thing. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.s

Re: [Mingw-w64-public] [PATCH] headers: Import msxml IDL files from wine

在 2022-12-28 21:16, Biswapriyo Nath 写道: xmldom and and xmldso do not have their corresponding headers. So, those are not added in Makefile.am. Also make sure to match widl version. Thanks for the patch. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH v2] headers: Add shcore.h

Thanks for the update. Looks good to me now. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists

Re: [Mingw-w64-public] [PATCH] crt: Preserve special variables when LTO is in effect

assert in LLVM's LTO, but this assert isn't enabled in release builds of LLBM.) So this patch is ok, and for LLVM LTO of the crt startup files, more work is needed. Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

[Mingw-w64-public] [PATCH] crt: Preserve special variables when LTO is in effect

-- Best regards, LIU Hao From 1288ab9f2a965bcca5513b36bd29e906c4b7ee2f Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Tue, 27 Dec 2022 14:32:37 +0800 Subject: [PATCH] crt: Preserve special variables when LTO is in effect Variables that are required to be placed in explicit sections probably have

Re: [Mingw-w64-public] [RFC PATCH] headers: Add robuffer.idl to generate robuffer.h

This patch looks good to me. Pushed to master. Thanks. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists

Re: [Mingw-w64-public] [PATCH] headers: Add shcore.h

there. The only issue I see in this patch is that there is a trailing comma on the line `BSOS_PREFERDESTINATIONSTREAM,` which we don't allow, so please remove that. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt: Fix building LTO version of mingw-w64 crt libraries

在 2022-12-25 02:19, Pali Rohár 写道: This patch fixes it! And also in LTO mode it prints "test thread atexit". Mostly good. Should `__xl_d` be given an attribute as well? -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH] crt: Fix building LTO version of mingw-w64 crt libraries

} ``` And with LTO it prints nothing. When I added __attribute__((used)) for those 3 symbols then it started printing "ő<". So the attribute seems necessary. Patches are welcome. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] headers: Use Windows 10 as default _WIN32_WINNT value.

. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Fix building LTO version of mingw-w64 crt libraries

ut. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Fix building LTO version of mingw-w64 crt libraries

to be tested carefully. At the moment, these are `__xl_b`, `__xl_c` and `_tls_used`, but there might be more. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Fix building LTO version of mingw-w64 crt libraries

`... This patch shouldn't affect non-LTO builds, so pushed for now. If there are any issues, please let me know. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH 1/3] crt: Add non-inline variant of UCRT _scprintf, _snprintf and _snscanf functions

to provide unified non-inline *printf functions. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw

Re: [Mingw-w64-public] [PATCH] genstubdll: Remove

在 2022-12-22 02:04, Jacek Caban 写道: Removal seems good to me. Thanks. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

[Mingw-w64-public] [PATCH] genstubdll: Remove

在 2022-12-20 02:49, Pali Rohár 写道: And I think that this decision is independent of tool itself if should be removed too or not. My point is that if this should be removed then we shouldn't behave as if it was being actively maintained. Patch attached. Thoughts? -- Best regards, LIU Hao

Re: [Mingw-w64-public] interface macro conflicts with interface variable

that does not use COM will not get that unwanted macro; and when COM stuff is needed, COM headers can be included explicitly after . -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw

Re: [Mingw-w64-public] interface macro conflicts with interface variable

在 2022/12/21 17:06, Alvin Wong via Mingw-w64-public 写道: On 21/12/2022 16:45, LIU Hao wrote: If you define `WIN32_LEAN_AND_MEAN` (either `#define` it or pass `-DWIN32_LEAN_AND_MEAN` to GCC) before inclusion of , then the error will go away. This seems to be yet another reason why

Re: [Mingw-w64-public] interface macro conflicts with interface variable

EAN` (either `#define` it or pass `-DWIN32_LEAN_AND_MEAN` to GCC) before inclusion of , then the error will go away. This seems to be yet another reason why `WIN32_LEAN_AND_MEAN` should be preferred. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signat

Re: [Mingw-w64-public] [PATCH 2/2] crt: Include moldname content for crtdll and msvcrt10, 20, 40, 70, 71

you to acknowledge the status of this patch - see https://sourceforge.net/p/mingw-w64/mailman/message/37748083/. I can apply it when I get a chance - I'm quite swamped at the moment but trying to catch up - or then maybe someone else can push it. Okay, pushed now. -- Best regards, LIU Hao

Re: [Mingw-w64-public] [PATCH] headers: Add systemmediatransportcontrolsinterop.idl

/include/systemmediatransportcontrolsinterop.idl Thanks for the patch. Looks good to me. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH 1/3] headers: Fix noreturn compile warning for __fastfail()

for these patches (except the one for removal of 'ms.def'). Pushed to master now. I am a bit unsure about 'ms.def': If genstubdll is no longer useful nowadays, I think it had better be removed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] Remove old and unused msvcrt def file ms.def

/sample/ms.def deleted file mode 100644 index 1cb08ef3e04d.. Hmm what does 'genstubdll' do? Looks like neither MSYS2 nor Debian builds it; maybe it can be removed completely? -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt: Fix building LTO version of mingw-w64 crt libraries

I think should be avoided? -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Fix type of daylight, timezone and tzname symbols in msvcrt-common.def.in

/msvcrt-common.def.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Thanks for catching this. This patch looks good to me. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64

Re: [Mingw-w64-public] #ifdef _MSVCRT_

are always `DECLSPEC_IMPORT`. So, when is `WINUSERAPI` defined empty? I suspect it's only effective when building USER32.DLL itself by Microsoft. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing

Re: [Mingw-w64-public] [PATCH] crt: Remove unused lib64/moldname-msvcrt.def file

-crt/lib64/moldname-msvcrt.def diff --git a/mingw-w64-crt/lib64/moldname-msvcrt.def b/mingw-w64-crt/lib64/moldname-msvcrt.def deleted file mode 100644 index 6f31518d5c82.. Thanks for the patch. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH] headers: Include typeinfo in eh.h for std::type_info

Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/crt/eh.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) Thanks for the patch. Looks good to me. Pushed. The Microsoft header doesn't contain , but it is required by the C++ standard anyway. -- Best regards, LIU Hao

Re: [Mingw-w64-public] [PATCHv2] headers/shlwapi: Change `QITAB.dwOffset` to `DWORD` for, Windows 10 RS2+

在 2022-12-07 20:33, Martin Storsjö 写道: LGTM, thanks! Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

[Mingw-w64-public] [PATCHv2] headers/shlwapi: Change `QITAB.dwOffset` to `DWORD` for, Windows 10 RS2+

在 2022/12/6 18:28, Cao GH 写道: > > I checked all SDKs from 10240-16299 in the archive, it is changed in the > 15063 SDK. > That would be _WIN32_WINNT_WIN10_RS2 I belleve. > Yeah that's right. Updated patch attached. -- Best regards, LIU Hao From 1294d9bc93400209aa6262f8f5fc7

[Mingw-w64-public] [PATCH] headers/shlwapi: Change `QITAB.dwOffset` to `DWORD` since Windows 10

This field seems to have changed since an unknown revision. It was a signed type, up to Windows 8.1 SDK (https://developer.microsoft.com/en-us/windows/downloads/sdk-archive/). -- Best regards, LIU Hao From 007e97fa632fd841bb4ecff393ed320ba9e7398f Mon Sep 17 00:00:00 2001 From: LIU Hao Date

Re: [Mingw-w64-public] [PATCH] crt: Fix exports of crtdll.dll library

confirms it. --- mingw-w64-crt/lib32/crtdll.def | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) Thanks for the patches. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw

Re: [Mingw-w64-public] gcc parameter -mcrtdll= for choosing Windows C RunTime DLL library

that this parameter is useful for more people. I vote +1 for this in GCC 14. GCC 13 (i.e. current master branch) is at stage3 so it's not an option at this moment. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] headers/shlwapi.h: Update dwOffset of QITAB to be a DWORD

for that, such as: ``` #if _WIN32_WINNT >= _WIN32_WINNT_WIN10 DWORD dwOffset; #else int dwOffset; #endif ``` -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-

Re: [Mingw-w64-public] [PATCH] headers/shlwapi.h: Update dwOffset of QITAB to be a DWORD

, but it apparently deserves an `#if` check. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] compile on latest MSVC

insertions(+), 4 deletions(-) Thanks for the patch. Pushed now. The issue here is that `__stdcall` applies to the function, instead of the return value. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] headers/shlobj.h: Add missing KNOWN_FOLDER_FLAG constants

/shlobj.h | 11 +++ 1 file changed, 11 insertions(+) Thanks for the patch. Looks good to me, too. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Move pdh to lib-common

e mode 100644 mingw-w64-crt/lib64/pdh.def Thanks for the patch. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourcefor

Re: [Mingw-w64-public] [PATCH] headers: Add mapiaux.h

Nath --- mingw-w64-headers/include/mapiaux.h | 128 1 file changed, 128 insertions(+) create mode 100644 mingw-w64-headers/include/mapiaux.h This patch looks good to me. Pushed to master. Thanks. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP

Re: [Mingw-w64-public] [PATCH] headers: Implement quaternion functions in windowsnumerics.h

, it might be good to check these functions in and see how people respond. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] gcc parameter -mcrtdll= for choosing Windows C RunTime DLL library

desired libraries explicitly. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Manually do the linker test for __ImageBase

. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] gcc parameter -mcrtdll= for choosing Windows C RunTime DLL library

vcrt=`, so they always match. [1] https://sourceforge.net/p/mingw-w64/mailman/message/36030072/ -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge

Re: [Mingw-w64-public] [PATCH v2] crt: Use only __ImageBase symbol in mingw-w64 code

- mingw-w64-crt/misc/delayimp.c | 1 - 9 files changed, 29 insertions(+), 24 deletions(-) create mode 100644 mingw-w64-crt/crt/__imagebase.c Thanks for the patched. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt: Use only __ImageBase symbol in mingw-w64 code

these two patches? -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Use only __ImageBase symbol in mingw-w64 code

addresses. Thus, weak symbols are unacceptable; but removal of references to `__image_base__` seems fine, if dropping support for binutils 2.18 is acceptable. BTW 2.19 was released in 2008 [1]. [1] https://lists.gnu.org/archive/html/info-gnu/2008-10/msg00014.html -- Best regards, LIU Hao

Re: [Mingw-w64-public] [PATCH] headers: Add missing marco in synchapi.h

. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Remove unused __ImageBase from crt_handler.c

在 2022-11-18 23:38, Pali Rohár 写道: --- mingw-w64-crt/crt/crt_handler.c | 10 -- 1 file changed, 10 deletions(-) Thanks for the patch. Looks good to me. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt: Use _TCHAR/_tmain/_tcslen in crtexe.c

| 55 +++--- 1 file changed, 9 insertions(+), 46 deletions(-) These patches good to me. Pushed to master now. Thanks for the work. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] headers: Add missing marco in synchapi.h

you agree with this change: #if NTDDI_VERSION >= NTDDI_WIN10_RS4 #define CREATE_WAITABLE_TIMER_HIGH_RESOLUTION 0x2 #endif or do you prefer `_WIN32_WINNT` to `NTDDI_VERSION` there? -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signat

Re: [Mingw-w64-public] [PATCH] crt: Move WinMain/wWinMain specific code outside of crtexe.c file

, and an additional link to your reply in the mailing list archive. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] Adding a new thread model to GCC

(admittedly important) implementation details are the best way to fix them. Thanks for your understanding. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Move WinMain/wWinMain specific code outside of crtexe.c file

[2] https://en.wikipedia.org/wiki/Big5 [3] https://en.wikipedia.org/wiki/Shift_JIS -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge

Re: [Mingw-w64-public] Adding a new thread model to GCC

compatibility, letting users to solve such issues themselves? -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists

Re: [Mingw-w64-public] [PATCH] crt: Move WinMain/wWinMain specific code outside of crtexe.c file

, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] localtime() does not respect TZ if set via char **environ (CLANG*, UCRT64)

the `_environ` symbol; UCRT doesn't have it. See our 'stdlib.h' and 'msvcrt.def.in' for details. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH] headers/_mingw: Remove the obsolete `__stdcall` macro

在 2022-11-06 04:10, Martin Storsjö 写道: On Sun, 6 Nov 2022, LIU Hao wrote: I think this `__stdcall` macro should be removed. LGTM, thanks! Thanks. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

[Mingw-w64-public] [PATCH] headers/_mingw: Remove the obsolete `__stdcall` macro

I think this `__stdcall` macro should be removed. -- Best regards, LIU Hao From 16ad382685cb899e9369a28ab8c37c8afb3def59 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Sun, 6 Nov 2022 03:12:49 +0800 Subject: [PATCH] headers/_mingw: Remove the obsolete `__stdcall` macro This was introduced

Re: [Mingw-w64-public] [PATCH] headers: Clarify a few aspects relating to Clang wrt the fortification macros

deletions(-) These four patches look good to me. Thanks. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/list

Re: [Mingw-w64-public] [PATCH] headers/stdio: Don't attempt to perform buffer overflow checks when inlining is impossible

在 2022/11/4 15:47, Martin Storsjö 写道: Yes, this looks good to me - thanks! I've had this combination included in my nightly test builds for the last few days and haven't run into any issues with it. Thanks, pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description

Re: [Mingw-w64-public] [PATCH] headers/stdio: Don't attempt to perform buffer overflow checks when inlining is impossible

`#if __MINGW_FORTIFY_VA_ARG ... #endif` blocks. Does this look good to you? -- Best regards, LIU Hao From ed7221035897a7919bb0fe6f6bd36589f0cfbe23 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Fri, 28 Oct 2022 22:52:54 +0800 Subject: [PATCH] headers/stdio: Don't attempt to perform buffer overflow checks when inlining

Re: [Mingw-w64-public] [PATCH] headers/stdio: Don't attempt to perform buffer overflow checks when inlining is impossible

/llvm-project/issues/58724#issuecomment-1298505921 and (I think) will result in infinite recursion if compiled with clang. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64

Re: [Mingw-w64-public] [PATCH] crt/ssp: Use different __fastfail code in __chk_fail

在 2022/11/3 19:16, Martin Storsjö 写道: LGTM, this looks reasonable to me, thanks! I'll push this after leaving some time for others to comment. Looks good to me, too. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH v2 3/3] crt/stdlib: Add missing _wcstof_l function and redirections

(+) create mode 100644 mingw-w64-crt/stdio/_wcstof_l.c Thanks for the update. These patches look good to me. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64

Re: [Mingw-w64-public] [PATCH] headers/stdio: Don't attempt to perform buffer overflow checks when inlining is impossible

good to me. (However, I still think we had better remove `__mingw_bos_ovr` in the future.) -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH 1/1] crt/stdlib: Add missing _strtof_l function and redirections

for the former. You may take 'mingw-w64-crt/stdio/strtof.c' as an example. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH] headers/stdio: Don't attempt to perform buffer overflow checks when inlining is impossible

to keep `__mingw_bos_ovr` for it. (and it would be the only reference?) -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

[Mingw-w64-public] [PATCH] headers/stdio: Don't attempt to perform buffer overflow checks when inlining is impossible

This makes GDB build again in MSYS2. -- Best regards, LIU Hao From c7ecb4b7efd4a5c841ce62afaf66c2391b6615a4 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Fri, 28 Oct 2022 22:52:54 +0800 Subject: [PATCH] headers/stdio: Don't attempt to perform buffer overflow checks when inlining is impossible

Re: [Mingw-w64-public] Is that fine to add sys/mman.h support within mingw?

在 2022/10/27 16:34, 罗勇刚(Yonggang Luo) 写道: On Wed, Oct 26, 2022 at 10:22 PM LIU Hao wrote: I am a bit unsure about this. It may be something good to have, but will also bear the risk of bugs or limitation. So be careful; add those only if there is necessity. I have multiple projects

Re: [Mingw-w64-public] Is that fine to add sys/mman.h support within mingw?

I am a bit unsure about this. It may be something good to have, but will also bear the risk of bugs or limitation. So be careful; add those only if there is necessity. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] Adding a new thread model to GCC

[1] https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/nf-ntifs-zwwaitforsingleobject -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourcefor

<    1   2   3   4   5   6   7   8   9   10   >