Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
> I regenerated those files with latest (at that moment) MSYS2. That's what I figured, thanks! Also, about this patch in the first place: I was hacking on a project which uses Autoconf, but not Automake, which is why it needed to embed config.sub and config.guess manually. MinGW-w64 uses Automake which overwrites these files on update, and I hadn't figured that out, hence my confusion. Thank you for your understanding and the patches! :-) -- Antonin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
在 2023/11/23 22:16, Antonin Décimo 写道: May I ask on which system you regenerated the files? I need to regenerate some files after a little change, and I'm getting unrelated diffs in the files. I regenerated those files with latest (at that moment) MSYS2. The next day I also tried these on Linux Mint: ``` lh_mouse@lhmouse-xps ~ $ automake --version automake (GNU automake) 1.16.5 ... lh_mouse@lhmouse-xps ~ $ autoconf --version autoconf (GNU Autoconf) 2.71 ``` ... and there were indeed some differences about K vs. ISO prototypes and addition/removal of some target triplets, but I believed those should be safe. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
May I ask on which system you regenerated the files? I need to regenerate some files after a little change, and I'm getting unrelated diffs in the files. Best regards, -- Antonin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
在 2023/11/16 23:36, Antonin Décimo 写道: There are commits solely for updating generated files. Usually not all files get updated, however they can be forced regenerated with `autoreconf -f`. Updated now [1]. Thank you for having considered this. May I ask why you chose automake 1.15.1 rather than 1.16.5 to regenerate configure? Granted, I've looked at the diff, and it does seem minor. I don't know; that was just `autoreconf` selected. I will take a look later today. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
> There are commits solely for updating generated files. Usually not all files > get updated, however > they can be forced regenerated with `autoreconf -f`. Updated now [1]. Thank you for having considered this. May I ask why you chose automake 1.15.1 rather than 1.16.5 to regenerate configure? Granted, I've looked at the diff, and it does seem minor. Best regards, -- Antonin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
在 2023-11-16 18:10, Antonin Décimo 写道: I don't think that's entirely correct. The `configure.ac` scripts are specific to a project and require a minimum version of autoconf (see `AC_PREREQ` [1]). When updating to autoconf-2.71 I found just one deprecation warning in winpthreads/. These scripts never get updated automatically, they're written by project authors. Well, some of the may be safely removed, such as `AC_HEADER_TIME`. This is can be done with `autoupdate`. If the project already provides `configure`, it's unlikely anyone will regenerate it, which is why I think there's value in providing a regenerated `configure` from the latest autotools. A lot of work has been done between 2.69 and 2.71, see "Rejuvenating Autotools" [3]. There are also precedents in mingw-w64's history (which prompted me to submit these patches): There are commits solely for updating generated files. Usually not all files get updated, however they can be forced regenerated with `autoreconf -f`. Updated now [1]. [1] https://sourceforge.net/p/mingw-w64/mingw-w64/ci/b6de4ef -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
Thanks for the comment! > > For these two scripts, the thing is that autotools vendors them, and > > they can get stuck a bit behind in the past. They've had a handful of > > patches lately, improving Windows support. > > We don't stick to a specific version of autotools. Those products of > autotools are there for > convenience for others who don't have autotools installed; they can be > arbitrarily overwritten by > whatever happens to exist on a build machine. I don't think that's entirely correct. The `configure.ac` scripts are specific to a project and require a minimum version of autoconf (see `AC_PREREQ` [1]). When updating to autoconf-2.71 I found just one deprecation warning in winpthreads/. These scripts never get updated automatically, they're written by project authors. The `configure` scripts only get updated if the user runs `autogen` or `autoreconf`. Note that packagers typically don't regenerate configure if the project already provides it, see for instance the winpthreads package in Arch Linux [2]. If the project already provides `configure`, it's unlikely anyone will regenerate it, which is why I think there's value in providing a regenerated `configure` from the latest autotools. A lot of work has been done between 2.69 and 2.71, see "Rejuvenating Autotools" [3]. There are also precedents in mingw-w64's history (which prompted me to submit these patches): - https://sourceforge.net/p/mingw-w64/mingw-w64/ci/18dd4b31a2b89c9ffc2d4bf60585785cf73031bc/ - https://sourceforge.net/p/mingw-w64/mingw-w64/ci/e6921b2c26836f3788a4516c40e2bdd1b825a136/ > So, there is no need to send separate patches for them; they will get updated > sooner or later - for > example, when MSYS2 has the versions you've proposed. MSYS2 already has the latest automake/autoconf! [1]: https://www.gnu.org/software/autoconf/manual/autoconf-2.71/html_node/Versioning.html [2]: https://gitlab.archlinux.org/archlinux/packaging/packages/mingw-w64-winpthreads/-/blob/main/PKGBUILD?ref_type=heads [3]: https://lwn.net/Articles/834682/ Best regards, -- Antonin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
在 2023/11/16 00:24, Antonin Décimo 写道: For these two scripts, the thing is that autotools vendors them, and they can get stuck a bit behind in the past. They've had a handful of patches lately, improving Windows support. We don't stick to a specific version of autotools. Those products of autotools are there for convenience for others who don't have autotools installed; they can be arbitrarily overwritten by whatever happens to exist on a build machine. So, there is no need to send separate patches for them; they will get updated sooner or latter - for example, when MSYS2 has the versions you've proposed. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
(apologies for the duplicate, I responded privately) > Those files are generated by autotools automatically. Are there any reasons > why we should update > them by hand? I've sent a previous patch also updating autotools, but it's too big for the mailing list. Have you received it? If not, the patches can also be consulted at https://github.com/MisterDA/mingw-w64/tree/automake. For these two scripts, the thing is that autotools vendors them, and they can get stuck a bit behind in the past. They've had a handful of patches lately, improving Windows support. Best regards, -- Antonin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub
在 2023-11-15 20:49, Antonin Décimo 写道: Using commit 28ea239c53a2d5d8800c472bc2452eaa16e37af2 (latest as the time of writing) from https://git.savannah.gnu.org/cgit/config.git/. Signed-off-by: Antonin Décimo --- build-aux/config.guess| 107 +- build-aux/config.sub | 236 +- Those files are generated by autotools automatically. Are there any reasons why we should update them by hand? -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
