Re: [Mingw-w64-public] [PATCH 1/2] headers: Allow setting the default __MSVCRT_VERSION__

2017-11-11 Thread Jacek Caban
I would prefer to have the same names for headers and crt configure arguments. Other than that, it looks good to me. Thanks, Jacek On 11/10/17 10:07 PM, Kai Tietz via Mingw-w64-public wrote: Patch looks ok to me. Jacek any comments? Thanks Kai Am 10.11.2017 21:50 schrieb "Martin Storsjö"

Re: [Mingw-w64-public] [PATCH 2/2] crt: Provide __acrt_iob_func and __p___argv without the __imp_ prefix

2017-11-11 Thread Kai Tietz via Mingw-w64-public
Patch is Ok. Thanks Kai 2017-11-10 10:03 GMT+01:00 Martin Storsjö : > Some object files in the crt build were previously built with _CRTBLD, > but not all of them. This lead to these wrappers not defining the > unprefixed function (since that would cause warnings about

Re: [Mingw-w64-public] swscanf() crashes if __USE_MINGW_ANSI_STDIO is defined

2017-11-11 Thread Liu Hao
On 2017/11/11 21:47, Hannes Domani via Mingw-w64-public wrote: Am Samstag, 11. November 2017, 10:15:00 MEZ hat Liu Hao Folgendes geschrieben: Debugging in assembly exposes indirection through a null pointer in `mingw-w64-crt/stdio/mingw_wvfscanf.c` around or after line 906:

Re: [Mingw-w64-public] [PATCH 1/2] headers: Allow setting the default __MSVCRT_VERSION__

2017-11-11 Thread Martin Storsjö
On Sat, 11 Nov 2017, Jacek Caban wrote: I would prefer to have the same names for headers and crt configure arguments. Other than that, it looks good to me. Yes, that's probably good. I originally had some thought about why I made them different, because what they do is subtly different, but

Re: [Mingw-w64-public] swscanf() crashes if __USE_MINGW_ANSI_STDIO is defined

2017-11-11 Thread David Lee
On 11 November 2017 at 21:47, Hannes Domani via Mingw-w64-public wrote: > Am Samstag, 11. November 2017, 10:15:00 MEZ hat Liu Hao > Folgendes geschrieben: > >> Debugging in assembly exposes indirection through a null pointer in >>

Re: [Mingw-w64-public] swscanf() crashes if __USE_MINGW_ANSI_STDIO is defined

2017-11-11 Thread Hannes Domani via Mingw-w64-public
Am Samstag, 11. November 2017, 10:15:00 MEZ hat Liu Hao Folgendes geschrieben: > Debugging in assembly exposes indirection through a null pointer in > `mingw-w64-crt/stdio/mingw_wvfscanf.c` around or after line 906: > > ``` > optimize_alloc ((flags & IS_ALLOC_USED) != 0,

Re: [Mingw-w64-public] swscanf() crashes if __USE_MINGW_ANSI_STDIO is defined

2017-11-11 Thread Liu Hao
On 2017/11/11 12:41, David Lee wrote: Hello, Tried to compile and run the following C code on Windows (with gcc/mingw-w64), and it crashed at the swscanf() call: #define __USE_MINGW_ANSI_STDIO 1 #include int main(void) { wchar_t buf[] = L"1 2 3"; wchar_t field[10];