Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

[Jacek Caban]

On 03/15/2018 02:54 PM, Ebrahim Byagowi wrote:
> Oh, I see, done.

Looks good to me. I pushed that to Git.

Thanks,
Jacek

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

[Ebrahim Byagowi]

Oh, I see, done.

On Thu, Mar 15, 2018 at 2:09 PM, Jacek Caban  wrote:

> Hi Ebrahim,
>
>
> #ifndef __cplusplus inside IDWriteTextAnalyzer1 should be around all
> parent interfaces' methods (IDWriteTextAnalyzer in this case), not just
> IUnknown.
>
>
> Thanks,
>
> Jacek
>
>
> On 3/14/18 12:19 AM, Ebrahim Byagowi wrote:
>
>> Spotted one minor issue on the patch, here is another
>>
>> On Wed, Mar 14, 2018 at 12:29 AM, Ebrahim Byagowi 
>> wrote:
>>
>> Hi there. Following https://github.com/Alexpux/mingw-w64/pull/5 I am
>>> sending my work here, this patch allows harfbuzz's hb-directwrite
>>> 
>>> build on msys2, I hope this change can be applied to both
>>> "/msys2/usr/Include/win32api/dwrite_1.h" and
>>> "/mingw64/x86_64-w64-mingw32/include/dwrite_1.h".
>>> Let me know what else is needed in order to make this happen. Thanks!
>>>
>>> 
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> Mingw-w64-public mailing list
>> Mingw-w64-public@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>
>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

[Jacek Caban]

Hi Ebrahim,


#ifndef __cplusplus inside IDWriteTextAnalyzer1 should be around all 
parent interfaces' methods (IDWriteTextAnalyzer in this case), not just 
IUnknown.



Thanks,

Jacek


On 3/14/18 12:19 AM, Ebrahim Byagowi wrote:

Spotted one minor issue on the patch, here is another

On Wed, Mar 14, 2018 at 12:29 AM, Ebrahim Byagowi 
wrote:


Hi there. Following https://github.com/Alexpux/mingw-w64/pull/5 I am
sending my work here, this patch allows harfbuzz's hb-directwrite

build on msys2, I hope this change can be applied to both
"/msys2/usr/Include/win32api/dwrite_1.h" and 
"/mingw64/x86_64-w64-mingw32/include/dwrite_1.h".
Let me know what else is needed in order to make this happen. Thanks!


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

[Ebrahim Byagowi]

Spotted one minor issue on the patch, here is another

On Wed, Mar 14, 2018 at 12:29 AM, Ebrahim Byagowi 
wrote:

> Hi there. Following https://github.com/Alexpux/mingw-w64/pull/5 I am
> sending my work here, this patch allows harfbuzz's hb-directwrite
> 
> build on msys2, I hope this change can be applied to both
> "/msys2/usr/Include/win32api/dwrite_1.h" and 
> "/mingw64/x86_64-w64-mingw32/include/dwrite_1.h".
> Let me know what else is needed in order to make this happen. Thanks!
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] Add some more missing declaration of dwrite_1.h

[Ebrahim Byagowi]

Hi there. Following https://github.com/Alexpux/mingw-w64/pull/5 I am
sending my work here, this patch allows harfbuzz's hb-directwrite

build on msys2, I hope this change can be applied to both
"/msys2/usr/Include/win32api/dwrite_1.h" and
"/mingw64/x86_64-w64-mingw32/include/dwrite_1.h". Let me know what else is
needed in order to make this happen. Thanks!
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public